[jira] [Updated] (HADOOP-12254) test-patch.sh should run findbugs if only findbugs-exclude.xml has changed
[ https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12254: -- Resolution: Fixed Fix Version/s: HADOOP-12111 Status: Resolved (was: Patch Available) +1 committed. Thanks! > test-patch.sh should run findbugs if only findbugs-exclude.xml has changed > -- > > Key: HADOOP-12254 > URL: https://issues.apache.org/jira/browse/HADOOP-12254 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Varun Saxena >Assignee: Kengo Seki > Fix For: HADOOP-12111 > > Attachments: HADOOP-12254.HADOOP-12111.00.patch, > HADOOP-12254.HADOOP-12111.01.patch > > > Refer to Hadoop QA report for YARN-3952 > https://issues.apache.org/jira/browse/YARN-3952?focusedCommentId=14636455&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636455 > We can run findbugs for all the submodules if findbugs-exclude.xml has been > changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12254) test-patch.sh should run findbugs if only findbugs-exclude.xml has changed
[
https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12254:
Attachment: HADOOP-12254.HADOOP-12111.01.patch
Ah, thanks! Attaching a fixed patch. I confirmed the result is as expected.
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
b/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
index f1ef2b8..a6d4703 100644
--- a/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
+++ b/hadoop-mapreduce-project/dev-support/findbugs-exclude.xml
@@ -532,4 +532,4 @@
-
+
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../dev/hadoop
--project=hadoop /tmp/test.patch
(snip)
+1 overall
__
< Success! >
--
\ /\ ___ /\
\ // \/ \/ \\
((O O))
\\ / \ //
\/ | | \/
| | | |
| | | |
| o |
| | | |
|m| |m|
| Vote | Subsystem | Runtime | Comment
| +1 | @author | 0m 00s| The patch does not contain any @author
| ||| tags.
| +1 |asflicense | 0m 26s| Patch does not generate ASF License
| ||| warnings.
| +1 |whitespace | 0m 00s| Patch has no whitespace issues.
| +1 | xml | 0m 01s| The patch has no ill-formed XML file.
| +1 | findbugs | 0m 00s| the patch passed
| || 0m 28s|
{code}
> test-patch.sh should run findbugs if only findbugs-exclude.xml has changed
> --
>
> Key: HADOOP-12254
> URL: https://issues.apache.org/jira/browse/HADOOP-12254
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
>Affects Versions: HADOOP-12111
>Reporter: Varun Saxena
>Assignee: Kengo Seki
> Attachments: HADOOP-12254.HADOOP-12111.00.patch,
> HADOOP-12254.HADOOP-12111.01.patch
>
>
> Refer to Hadoop QA report for YARN-3952
> https://issues.apache.org/jira/browse/YARN-3952?focusedCommentId=14636455&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636455
> We can run findbugs for all the submodules if findbugs-exclude.xml has been
> changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-12254) test-patch.sh should run findbugs if only findbugs-exclude.xml has changed
[ https://issues.apache.org/jira/browse/HADOOP-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated HADOOP-12254: -- Summary: test-patch.sh should run findbugs if only findbugs-exclude.xml has changed (was: test-patch.sh should run findbugs if ony findbugs-exclude.xml has changed) > test-patch.sh should run findbugs if only findbugs-exclude.xml has changed > -- > > Key: HADOOP-12254 > URL: https://issues.apache.org/jira/browse/HADOOP-12254 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Varun Saxena >Assignee: Kengo Seki > Attachments: HADOOP-12254.HADOOP-12111.00.patch > > > Refer to Hadoop QA report for YARN-3952 > https://issues.apache.org/jira/browse/YARN-3952?focusedCommentId=14636455&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636455 > We can run findbugs for all the submodules if findbugs-exclude.xml has been > changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
