[
https://issues.apache.org/jira/browse/HADOOP-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated HADOOP-12315:
Attachment: HADOOP-12315.HADOOP-12111.00.patch
-00:
* replace $results with $result in hbaseprotoc_postapply
* fix hbaseprotoc_postapply failure caused by a missing maven parameter
I confirmed that hbaseprotoc_postapply is called if a .proto file is changed
and it works:
{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch
diff --git a/hbase-protocol/src/main/protobuf/AccessControl.proto
b/hbase-protocol/src/main/protobuf/AccessControl.proto
index e67540b..2d36568 100644
--- a/hbase-protocol/src/main/protobuf/AccessControl.proto
+++ b/hbase-protocol/src/main/protobuf/AccessControl.proto
@@ -121,3 +121,4 @@ service AccessControlService {
rpc CheckPermissions(CheckPermissionsRequest)
returns (CheckPermissionsResponse);
}
+
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=/Users/sekikn/hbase
--project=hbase /tmp/test.patch
(snip)
Patch HBase protoc plugin
cd /Users/sekikn/hbase/hbase-protocol
mvn --batch-mode compile -DskipTests -Pcompile-protobuf -X -DHBasePatchProcess
-DskipTests -DHBasePatchProcess -Ptest-patch >
/private/tmp/test-patch-hbase/1142/patch-hbaseprotoc-hbase-protocol.txt 2>&1
Elapsed: 0m 40s
(snip)
| Vote | Subsystem | Runtime | Comment
| +1 |@author | 0m 00s| The patch does not contain any @author
| | || tags.
| -1 | test4tests | 0m 00s| The patch doesn't appear to include any
| | || new or modified tests. Please justify
| | || why no new tests are needed for this
| | || patch. Also please list what manual
| | || steps were performed to verify this
| | || patch.
| +1 | asflicense | 0m 19s| Patch does not generate ASF License
| | || warnings.
| +1 | whitespace | 0m 00s| Patch has no whitespace issues.
| +1 |hadoopcheck | 10m 21s | Patch does not cause any errors with
| | || Hadoop 2.4.1 2.5.2 2.6.0.
| +1 |hbaseprotoc | 0m 40s| the patch passed
| | | 11m 21s |
{code}
> hbaseprotoc_postapply in the test-patch hbase personality can return a wrong
> status
> ---
>
> Key: HADOOP-12315
> URL: https://issues.apache.org/jira/browse/HADOOP-12315
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
>Affects Versions: HADOOP-12111
>Reporter: Kengo Seki
> Attachments: HADOOP-12315.HADOOP-12111.00.patch
>
>
> Similar to HADOOP-12314. hbaseprotoc_postapply returns the value of
> $\{results}, but if a module status is -1, $\{result} is incremented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
