[jira] [Updated] (HADOOP-14306) TestLocalFileSystem tests have very low timeouts

2017-05-02 Thread Jason Lowe (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated HADOOP-14306:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.8.2
   3.0.0-alpha3
   2.9.0
   Status: Resolved  (was: Patch Available)

Thanks to Eric for the contribution and to Steve and Allen for additional 
review!  I committed this to trunk, branch-2, and branch-2.8.

> TestLocalFileSystem tests have very low timeouts
> 
>
> Key: HADOOP-14306
> URL: https://issues.apache.org/jira/browse/HADOOP-14306
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Fix For: 2.9.0, 3.0.0-alpha3, 2.8.2
>
> Attachments: HADOOP-14306.001.patch, HADOOP-14306.002.patch, 
> HADOOP-14306.003.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-14306) TestLocalFileSystem tests have very low timeouts

2017-04-27 Thread Eric Badger (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated HADOOP-14306:
-
Attachment: HADOOP-14306.003.patch

Thanks, [~jlowe] for the review! That makes sense. Uploading a new patch where 
I got rid of the protected method and just created the timeout straight up

> TestLocalFileSystem tests have very low timeouts
> 
>
> Key: HADOOP-14306
> URL: https://issues.apache.org/jira/browse/HADOOP-14306
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: HADOOP-14306.001.patch, HADOOP-14306.002.patch, 
> HADOOP-14306.003.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-14306) TestLocalFileSystem tests have very low timeouts

2017-04-14 Thread Eric Badger (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated HADOOP-14306:
-
Attachment: HADOOP-14306.002.patch

[~aw], [~ste...@apache.org], thanks for the review/advice. My initial thinking 
was to get rid of the specific timeouts on the tests so that they would just 
use the maven-wide timeout. But I agree that a test suite timeout is a better 
solution. Uploading a new patch that gets rid of the specific timeouts on each 
test, but adds a test suite timeout of 60 seconds. This is a very conservative 
timeout as the largest timeout of the tests beforehand was 10 seconds. So let 
me know if you think that it should be more aggressive. 

> TestLocalFileSystem tests have very low timeouts
> 
>
> Key: HADOOP-14306
> URL: https://issues.apache.org/jira/browse/HADOOP-14306
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: HADOOP-14306.001.patch, HADOOP-14306.002.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-14306) TestLocalFileSystem tests have very low timeouts

2017-04-13 Thread Eric Badger (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated HADOOP-14306:
-
Attachment: HADOOP-14306.001.patch

Getting rid of timeouts for tests. They aren't really necessary since the code 
isn't doing anything but straight-line code. 

> TestLocalFileSystem tests have very low timeouts
> 
>
> Key: HADOOP-14306
> URL: https://issues.apache.org/jira/browse/HADOOP-14306
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: HADOOP-14306.001.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-14306) TestLocalFileSystem tests have very low timeouts

2017-04-13 Thread Eric Badger (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated HADOOP-14306:
-
Status: Patch Available  (was: Open)

> TestLocalFileSystem tests have very low timeouts
> 
>
> Key: HADOOP-14306
> URL: https://issues.apache.org/jira/browse/HADOOP-14306
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: HADOOP-14306.001.patch
>
>
> Most tests have a timeout of 1 second, which is much too low, especially if 
> there is a spinning disk involved. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org