[jira] [Updated] (HADOOP-6897) FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs failled

2018-03-22 Thread Andras Bokor (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Bokor updated HADOOP-6897:
-
Status: Patch Available  (was: Open)

> FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call 
> setPermission if mkdirs failled
> -
>
> Key: HADOOP-6897
> URL: https://issues.apache.org/jira/browse/HADOOP-6897
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 0.22.0
>Reporter: Hairong Kuang
>Assignee: Hairong Kuang
>Priority: Major
> Attachments: mkdirs.patch
>
>
> Here is the piece of code that has the bug. fs.setPermission should not be 
> called if result is false.
> {code}
>   public static boolean mkdirs(FileSystem fs, Path dir, FsPermission 
> permission)
>   throws IOException {
> // create the directory using the default permission
> boolean result = fs.mkdirs(dir);
> // set its permission to be the supplied one
> fs.setPermission(dir, permission);
> return result;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] Updated: (HADOOP-6897) FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs failled

2010-08-03 Thread Hairong Kuang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hairong Kuang updated HADOOP-6897:
--

Attachment: mkdirs.patch

The fix is trivial. So no unit test is included.

 FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call 
 setPermission if mkdirs failled
 -

 Key: HADOOP-6897
 URL: https://issues.apache.org/jira/browse/HADOOP-6897
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
 Fix For: 0.22.0

 Attachments: mkdirs.patch


 Here is the piece of code that has the bug. fs.setPermission should not be 
 called if result is false.
 {code}
   public static boolean mkdirs(FileSystem fs, Path dir, FsPermission 
 permission)
   throws IOException {
 // create the directory using the default permission
 boolean result = fs.mkdirs(dir);
 // set its permission to be the supplied one
 fs.setPermission(dir, permission);
 return result;
   }
 {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HADOOP-6897) FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs failled

2010-08-03 Thread Hairong Kuang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hairong Kuang updated HADOOP-6897:
--

Status: Patch Available  (was: Open)

 FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call 
 setPermission if mkdirs failled
 -

 Key: HADOOP-6897
 URL: https://issues.apache.org/jira/browse/HADOOP-6897
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
 Fix For: 0.22.0

 Attachments: mkdirs.patch


 Here is the piece of code that has the bug. fs.setPermission should not be 
 called if result is false.
 {code}
   public static boolean mkdirs(FileSystem fs, Path dir, FsPermission 
 permission)
   throws IOException {
 // create the directory using the default permission
 boolean result = fs.mkdirs(dir);
 // set its permission to be the supplied one
 fs.setPermission(dir, permission);
 return result;
   }
 {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.