[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom White updated HADOOP-9154:
--
Resolution: Fixed
Fix Version/s: 2.0.4-beta
1.2.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Karthik!
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 1.1.1, 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Fix For: 1.2.0, 2.0.4-beta
Attachments: HADOOP-9124.patch, hadoop-9154-branch1.patch,
hadoop-9154-draft.patch, hadoop-9154-draft.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Graves updated HADOOP-9154:
--
Fix Version/s: 0.23.7
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 1.1.1, 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Fix For: 1.2.0, 0.23.7, 2.0.4-beta
Attachments: HADOOP-9124.patch, hadoop-9154-branch1.patch,
hadoop-9154-draft.patch, hadoop-9154-draft.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154-branch1.patch
hadoop-9154.patch
Uploading fresh patches for trunk and branch-1, now that HADOOP-9124 is
committed to all branches.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 1.1.1, 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-branch1.patch,
hadoop-9154-draft.patch, hadoop-9154-draft.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Target Version/s: 1.2.0, 2.0.3-alpha
Affects Version/s: 1.1.1
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 1.1.1, 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154.patch
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 1.1.1, 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Status: Patch Available (was: Open)
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha, 1.1.1
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch,
hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154.patch
Uploading a patch that applies on top of the latest patch in HADOOP-9124. Will
submit the patch after HADOOP-9124 gets submitted.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch,
hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154-draft.patch
Thanks for your inputs, Tom. I am uploading a fresh patch by the approach you
suggested.
The added test doesn't pass yet due to its dependency on HADOOP-9124. I ll
upload another patch once we are done with HADOOP-9124.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Status: Open (was: Patch Available)
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154.patch
Suren, saw your comment slightly late. I ll keep it in mind the next time.
Here is a patch that cleans up Suren's earlier patch.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154.patch
Forgot to add a file to the previous patch. Here is the right patch.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Status: Patch Available (was: Open)
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch,
hadoop-9154.patch, hadoop-9154.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surenkumar Nihalani updated HADOOP-9154:
Attachment: HADOOP-9124.patch
Take a look at the merged tests.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Summary: SortedMapWritable#putAll() doesn't add key/value classes to the
map (was: SortedMap#putAll() doesn't add key/value classes to the map)
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
[
https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated HADOOP-9154:
-
Attachment: hadoop-9154-draft.patch
Uploading first draft of the patch. The patch moves all common map
functionality to AbstractMapWritable.
SortedMapWritable#putAll() doesn't add key/value classes to the map
---
Key: HADOOP-9154
URL: https://issues.apache.org/jira/browse/HADOOP-9154
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Attachments: hadoop-9154-draft.patch
In the following code from {{SortedMapWritable}}, #putAll() doesn't add
key/value classes to the class-id maps.
{code}
@Override
public Writable put(WritableComparable key, Writable value) {
addToMap(key.getClass());
addToMap(value.getClass());
return instance.put(key, value);
}
@Override
public void putAll(Map? extends WritableComparable, ? extends Writable t){
for (Map.Entry? extends WritableComparable, ? extends Writable e:
t.entrySet()) {
instance.put(e.getKey(), e.getValue());
}
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
