[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-9450: - Fix Version/s: (was: 3.0.0) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Improvement Components: scripts Reporter: Mitch Wyle Assignee: Harsh J Fix For: 1-win, 2.1.0-beta, 1.3.0 Attachments: HADOOP-9450-branch-1-win.patch, HADOOP-9450-branch-1.patch, HADOOP-9450-branch-2.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HADOOP-9450: Issue Type: Improvement (was: Bug) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Improvement Components: scripts Reporter: Mitch Wyle Assignee: Harsh J Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HADOOP-9450: Attachment: HADOOP-9450-branch-2.patch Attaching the committed branch-2 patch as no Windows changes are present there yet. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Improvement Components: scripts Reporter: Mitch Wyle Assignee: Harsh J Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450-branch-2.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HADOOP-9450: Resolution: Fixed Fix Version/s: 1.3.0 2.0.5-beta 1-win 3.0.0 Status: Resolved (was: Patch Available) Committed to branch-1, branch-1-win, branch-2, and trunk. Although usually not necessary, am noting 3.0.0 as a fix version here specifically to indicate that the fix on trunk carried Windows changes but branch-2 (2.0.5) does not, cause Windows support had not been merged to it. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Improvement Components: scripts Reporter: Mitch Wyle Assignee: Harsh J Fix For: 3.0.0, 1-win, 2.0.5-beta, 1.3.0 Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450-branch-2.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HADOOP-9450: --- Component/s: scripts Assignee: Harsh J Hadoop Flags: Reviewed +1 patch looks good. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Bug Components: scripts Reporter: Mitch Wyle Assignee: Harsh J Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-9450: -- Attachment: HADOOP-9450-branch-1.patch HADOOP-9450-branch-1-win.patch Hi, Harsh. I hope you don't mind, but I went ahead and back-ported your trunk patch to branch-1 and branch-1-win. I tested these on Mac and Windows. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Bug Reporter: Mitch Wyle Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-9450: -- Attachment: HADOOP-9450.patch Re-uploading Harsh's trunk patch, just so Jenkins sees it as the latest attachment. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Bug Reporter: Mitch Wyle Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-9450: -- Status: Patch Available (was: Open) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Bug Reporter: Mitch Wyle Attachments: HADOOP-9450-branch-1.patch, HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch, HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9450) HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended
[ https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated HADOOP-9450: Attachment: HADOOP-9450.patch Mitch is correct about all of this. The intention was to place first or regularly last, depending on the safety override. Relying on the position of where it is done in code today is not maintainable nor reliable in the long term (an example is trunk now, its got entries coming in before and after this manipulation). Note that the new Windows scripts already sorta do what Mitch points out rather than emulate the existing implementation. FWIW, Pig also does the same thing via PIG-3261. I've attached a trunk applicable patch from what Mitch has posted in his comments here. If this approach looks good to everyone, I can also supply a branch-1 (and branch-2/0.23, if doesn't apply from trunk) compat patch to backport. I cannot test the Windows changes as I lack an environment presently but I did manually inspect the CLASSPATH via a bash -x ./hadoop to see the precedence switching doing its work properly. HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of APpended -- Key: HADOOP-9450 URL: https://issues.apache.org/jira/browse/HADOOP-9450 Project: Hadoop Common Issue Type: Bug Reporter: Mitch Wyle Attachments: HADOOP-9450.patch On line 133 of the hadoop shell wrapper, CLASSPATH is set as: CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH} Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS are pre-pended BEFORE the user's HADOOP_CLASSPATH. Therefore there is no way to put your own JARs in front of those that the hadoop wrapper script sets. We propose a patch that reverses this order. Failing that, we would like to add a command line option to override this behavior and enable a user's JARs to be found before the wrong ones in the Hadoop library paths. We always welcome your opinions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira