[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-11 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510443
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 11/Nov/20 20:39
Start Date: 11/Nov/20 20:39
Worklog Time Spent: 10m 
  Work Description: jojochuang merged pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 510443)
Time Spent: 2h 20m  (was: 2h 10m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-11 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510444
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 11/Nov/20 20:39
Start Date: 11/Nov/20 20:39
Worklog Time Spent: 10m 
  Work Description: jojochuang commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-725649403


   Merged into trunk. I'll cherry pick the commit into lower branches later.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 510444)
Time Spent: 2.5h  (was: 2h 20m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510081
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 11/Nov/20 02:48
Start Date: 11/Nov/20 02:48
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-725094031


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 43s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  34m 41s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 59s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  compile  |  17m 16s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 31s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 59s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  4s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 39s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +0 :ok: |  spotbugs  |   2m 25s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 23s |  |  trunk passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 54s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  19m 17s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javac  |  19m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 17s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  javac  |  17m 17s |  |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 55s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no 
whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  15m 25s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  2s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  findbugs  |   2m 22s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 48s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 55s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 171m 28s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2436 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 689cb9dc303d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 375900049cc |
   | Default Java | Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/4/testReport/ |
   | Max. process+thread count | 1401 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/4/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.1.3 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT

[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510012
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 11/Nov/20 00:01
Start Date: 11/Nov/20 00:01
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-725040811


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 40s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  36m 21s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  21m 22s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  compile  |  18m 17s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  checkstyle  |   0m 50s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 27s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 48s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +0 :ok: |  spotbugs  |   2m 20s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 18s |  |  trunk passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 44s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javac  |  20m 44s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  18m 18s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  javac  |  18m 18s |  |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 24s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no 
whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  17m 16s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  findbugs  |   2m 24s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  10m  0s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 46s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 181m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2436 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 308c2b6e22bf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / fbd2220167f |
   | Default Java | Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/3/testReport/ |
   | Max. process+thread count | 2879 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/3/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.1.3 |
   | Powered by | Apache Yetus 0.13.0-SNAPSH

[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510010
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 10/Nov/20 23:56
Start Date: 10/Nov/20 23:56
Worklog Time Spent: 10m 
  Work Description: amahussein commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r520949563



##
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##
@@ -2876,12 +2876,28 @@ public Reader getConfResourceAsReader(String name) {
   protected synchronized Properties getProps() {
 if (properties == null) {
   properties = new Properties();
-  Map backup = updatingResource != null ?
-  new ConcurrentHashMap(updatingResource) : null;
-  loadResources(properties, resources, quietmode);
+  loadProps(properties, 0, true);
+}
+return properties;
+  }
 
+  /**
+   * Loads the resource at a given index into the properties.
+   * @param props the object containing the loaded properties.
+   * @param startIdx the index where the new resource has been added.
+   * @param fullReload flag whether we do complete reload of the conf instead
+   *   of just loading the new resource.
+   * @return the properties loaded from the resource.

Review comment:
   Sorry . I overlooked that.
   I added a new commit.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 510010)
Time Spent: 1h 50m  (was: 1h 40m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=510009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510009
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 10/Nov/20 23:50
Start Date: 10/Nov/20 23:50
Worklog Time Spent: 10m 
  Work Description: jojochuang commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r520947632



##
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##
@@ -2876,12 +2876,28 @@ public Reader getConfResourceAsReader(String name) {
   protected synchronized Properties getProps() {
 if (properties == null) {
   properties = new Properties();
-  Map backup = updatingResource != null ?
-  new ConcurrentHashMap(updatingResource) : null;
-  loadResources(properties, resources, quietmode);
+  loadProps(properties, 0, true);
+}
+return properties;
+  }
 
+  /**
+   * Loads the resource at a given index into the properties.
+   * @param props the object containing the loaded properties.
+   * @param startIdx the index where the new resource has been added.
+   * @param fullReload flag whether we do complete reload of the conf instead
+   *   of just loading the new resource.
+   * @return the properties loaded from the resource.

Review comment:
   Could you also remove this @return? I am +1 once this is updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 510009)
Time Spent: 1h 40m  (was: 1.5h)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=509829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509829
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 10/Nov/20 17:09
Start Date: 10/Nov/20 17:09
Worklog Time Spent: 10m 
  Work Description: jojochuang commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r520727890



##
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##
@@ -2893,7 +2909,7 @@ protected synchronized Properties getProps() {
 }
   }
 }
-return properties;
+return props;

Review comment:
   (I thought I posted a comment here, but somehow it got lost in github 
comments)
   returning this object isn't necessary, and obviously the callers don't use 
the return value.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 509829)
Time Spent: 1.5h  (was: 1h 20m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=508287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508287
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 22:24
Start Date: 05/Nov/20 22:24
Worklog Time Spent: 10m 
  Work Description: amahussein commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-722680657


   There is an open jira to fix `hadoop.security.TestLdapGroupsMapping`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 508287)
Time Spent: 1h 20m  (was: 1h 10m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=508285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508285
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 22:23
Start Date: 05/Nov/20 22:23
Worklog Time Spent: 10m 
  Work Description: amahussein commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-722680512


   Thanks @jojochuang . I updated the PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 508285)
Time Spent: 1h 10m  (was: 1h)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=508281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508281
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 22:20
Start Date: 05/Nov/20 22:20
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-722679292


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 14s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  34m 37s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  21m 30s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  compile  |  18m 13s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  checkstyle  |   0m 50s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 27s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 12s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +0 :ok: |  spotbugs  |   2m 21s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 19s |  |  trunk passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 58s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javac  |  20m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  18m 16s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  javac  |  18m 16s |  |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 46s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no 
whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  16m 41s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 29s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  findbugs  |   2m 22s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  |  10m  1s | 
[/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt)
 |  hadoop-common in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 47s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 178m 27s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.security.TestLdapGroupsMapping |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2436 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 8d8f8d5220fd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 638f1fc2b61 |
   | Default Java | Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/2/testReport/ |
   | Max. process+thread count | 2869 (vs. ulimit of 5500) |
   

[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=508218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508218
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 18:40
Start Date: 05/Nov/20 18:40
Worklog Time Spent: 10m 
  Work Description: amahussein commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r518278072



##
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##
@@ -2876,10 +2876,17 @@ public Reader getConfResourceAsReader(String name) {
   protected synchronized Properties getProps() {
 if (properties == null) {
   properties = new Properties();
+  loadProps(properties, -1);

Review comment:
   Good point @jojochuang .I will think about something. or maybe addd a 
comment.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 508218)
Time Spent: 50m  (was: 40m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=508216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508216
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 18:26
Start Date: 05/Nov/20 18:26
Worklog Time Spent: 10m 
  Work Description: jojochuang commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r518270081



##
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##
@@ -2876,10 +2876,17 @@ public Reader getConfResourceAsReader(String name) {
   protected synchronized Properties getProps() {
 if (properties == null) {
   properties = new Properties();
+  loadProps(properties, -1);

Review comment:
   I would really appreciate if you rewrite this so it doesn't use -1 as 
startIdx. A year from now I won't remember why we want to load from position -1.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 508216)
Time Spent: 40m  (was: 0.5h)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=507896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507896
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 01:16
Start Date: 05/Nov/20 01:16
Worklog Time Spent: 10m 
  Work Description: amahussein commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-722063542


   those two Junit test are broken 
   - https://issues.apache.org/jira/browse/HADOOP-17255
   - hadoop.security.TestLdapGroupsMapping is an existing bug HADOOP-17340



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 507896)
Time Spent: 0.5h  (was: 20m)

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=507887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507887
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 05/Nov/20 00:49
Start Date: 05/Nov/20 00:49
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#issuecomment-722055529


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 46s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  39m 52s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  27m 38s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  compile  |  22m 48s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  checkstyle  |   0m 58s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 46s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 19s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  7s |  |  trunk passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 33s |  |  trunk passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +0 :ok: |  spotbugs  |   2m 45s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 42s |  |  trunk passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  21m  7s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javac  |  21m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  18m 17s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  javac  |  18m 17s |  |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 49s | 
[/diff-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt)
 |  hadoop-common-project/hadoop-common: The patch generated 1 new + 148 
unchanged - 0 fixed = 149 total (was 148)  |
   | +1 :green_heart: |  mvnsite  |   1m 25s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no 
whitespace issues.  |
   | +1 :green_heart: |  shadedclient  |  16m 43s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  |  the patch passed with JDK 
Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 29s |  |  the patch passed with JDK 
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10  |
   | +1 :green_heart: |  findbugs  |   2m 24s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   9m 58s | 
[/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt)
 |  hadoop-common in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 46s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 199m 19s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.crypto.key.TestKeyProviderFactory |
   |   | hadoop.security.TestLdapGroupsMapping |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2436/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2436 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux c426c7b7e866 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 2cb9e8f66a3 |
   | Default Java | Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10 |
   | Multi-JDK versio

[jira] [Work logged] (HADOOP-17358) Improve excessive reloading of Configurations

2020-11-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-17358?focusedWorklogId=507791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507791
 ]

ASF GitHub Bot logged work on HADOOP-17358:
---

Author: ASF GitHub Bot
Created on: 04/Nov/20 21:28
Start Date: 04/Nov/20 21:28
Worklog Time Spent: 10m 
  Work Description: amahussein opened a new pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436


   ## NOTICE
   
   Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. HADOOP-X. Fix a typo in YYY.)
   For more details, please see 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 507791)
Remaining Estimate: 0h
Time Spent: 10m

> Improve excessive reloading of Configurations
> -
>
> Key: HADOOP-17358
> URL: https://issues.apache.org/jira/browse/HADOOP-17358
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: conf
>Reporter: Ahmed Hussein
>Assignee: Ahmed Hussein
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> [~daryn] reported that adding a new resource to a conf forces a complete 
> reload of the conf instead of just loading the new resource. Instantiating a 
> {{SSLFactory}} adds a new resource for the ssl client/server file. Formerly 
> only the KMS client used the SSLFactory but now TLS/RPC uses it too.
> The reload is so costly that RM token cancellation falls behind by hours or 
> days. The accumulation of uncancelled tokens in the KMS rose from a few 
> thousand to hundreds of thousands which risks ZK scalability issues causing a 
> KMS outage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org