[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=707664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707664 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 12/Jan/22 17:20 Start Date: 12/Jan/22 17:20 Worklog Time Spent: 10m Work Description: steveloughran commented on pull request #3076: URL: https://github.com/apache/hadoop/pull/3076#issuecomment-1011278336 @eric-maynard any chance to deal with the checkstyle complaints yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 707664) Time Spent: 2h 10m (was: 2h) > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=618106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618106
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 02/Jul/21 12:59
Start Date: 02/Jul/21 12:59
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-872978647
changes look good. This leaves checkstyle complaints to deal with.
Indentation and some lines need to be split.
+1 pending these changes
```
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:32:
@Test: 'method def modifier' has incorrect indentation level 4, expected
level should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:34:
InterruptedIOException inputException = new
InterruptedIOException("message");: 'method def' child has incorrect
indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:34:
InterruptedIOException inputException = new
InterruptedIOException("message");: Line is longer than 80 characters (found
86). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:35:
NullPointerException causeException = new
NullPointerException("cause");: 'method def' child has incorrect indentation
level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:36:
inputException.initCause(causeException);: 'method def' child has
incorrect indentation level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:37:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: 'method def' child has incorrect indentation level 8,
expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:37:
Exception outputException = IOUtils.wrapException("path", "methodName",
inputException);: Line is longer than 80 characters (found 96). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:40:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:40:
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);:
Line is longer than 80 characters (found 90). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:41:
Assertions.assertThat(outputException.getCause()).isInstanceOf(NullPointerException.class):
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:41:
Assertions.assertThat(outputException.getCause()).isInstanceOf(NullPointerException.class):
Line is longer than 80 characters (found 98). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:43:
assertEquals(outputException.getMessage(),
inputException.getMessage());: 'method def' child has incorrect indentation
level 8, expected level should be 4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:44:
assertEquals(outputException.getCause(), inputException.getCause());:
'method def' child has incorrect indentation level 8, expected level should be
4. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:45:
}: 'method def rcurly' has incorrect indentation level 4, expected level
should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:47:
@Test: 'method def modifier' has incorrect indentation level 4, expected
level should be 2. [Indentation]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java:48:
public void testWrap
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=618105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618105
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 02/Jul/21 12:57
Start Date: 02/Jul/21 12:57
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-854217501
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 58s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 33s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 55s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 4s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 40s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 2s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 34s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 26s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 21s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 58s | | the patch passed |
| +1 :green_heart: | compile | 22m 44s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 22m 44s | | the patch passed |
| +1 :green_heart: | compile | 19m 34s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 19m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 4s |
[/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt)
| hadoop-common-project/hadoop-common: The patch generated 25 new + 16
unchanged - 0 fixed = 41 total (was 16) |
| +1 :green_heart: | mvnsite | 1m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 6s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 36s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 37s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 1s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 188m 52s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3076 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a633afa4243f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / be7784f129795b478f8b0f5de60f71542367007c |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/testReport/ |
| Max. process+thread count | 3106 (vs. ulimit of 5500) |
| modules | C: hadoop-com
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=617357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617357
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 01/Jul/21 00:45
Start Date: 01/Jul/21 00:45
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-871822677
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 8s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 4s | | trunk passed |
| +1 :green_heart: | compile | 22m 33s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 19m 10s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 31s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 2s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 37s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 25s | | trunk passed |
| +1 :green_heart: | shadedclient | 18m 3s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 55s | | the patch passed |
| +1 :green_heart: | compile | 21m 44s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 21m 44s | | the patch passed |
| +1 :green_heart: | compile | 19m 3s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 19m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 1s |
[/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/3/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt)
| hadoop-common-project/hadoop-common: The patch generated 29 new + 16
unchanged - 0 fixed = 45 total (was 16) |
| +1 :green_heart: | mvnsite | 1m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 0s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 35s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 36s | | the patch passed |
| +1 :green_heart: | shadedclient | 18m 33s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 16m 57s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 187m 47s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3076 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 89c443ac23e8 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / efdfacb073f8f1af6ae330def5ee2c65337f433c |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/3/testReport/ |
| Max. process+thread count | 2235 (vs. ulimit of 5500) |
| modules | C: hadoop-common-pr
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=614214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614214 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 23/Jun/21 20:35 Start Date: 23/Jun/21 20:35 Worklog Time Spent: 10m Work Description: steveloughran commented on pull request #3076: URL: https://github.com/apache/hadoop/pull/3076#issuecomment-867139175 > Hi @steveloughran, what tests should I run in order to make this change? all the abfs tests in hadoop-azure. Ideally with as many auth options as you can. `hadoop-tools/hadoop-azure/dev-support/testrun-scripts/runtests.sh` helps there. At the very least: ``` mvn clean verify -Dparallel-tests=abfs -DtestsThreadCount=5 -Dscale ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 614214) Time Spent: 1.5h (was: 1h 20m) > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=614213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614213
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 23/Jun/21 20:32
Start Date: 23/Jun/21 20:32
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3076:
URL: https://github.com/apache/hadoop/pull/3076#discussion_r657439098
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.io;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+
+import static junit.framework.TestCase.assertEquals;
+import static junit.framework.TestCase.assertTrue;
+import org.apache.hadoop.test.AbstractHadoopTestBase;
+import org.assertj.core.api.Assertions;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestIOUtilsWrapExceptionSuite extends AbstractHadoopTestBase {
+@Test
+public void testWrapExceptionWithInterruptedException() throws Exception {
+InterruptedIOException inputException = new
InterruptedIOException("message");
+NullPointerException causeException = new
NullPointerException("cause");
+inputException.initCause(causeException);
+Exception outputException = IOUtils.wrapException("path",
"methodName", inputException);
+
+// The new exception should retain the input message, cause, and type
+
Assertions.assertThat(outputException).isInstanceOf(InterruptedIOException.class);
+
Assertions.assertThat(outputException.getCause()).isInstanceOf(NullPointerException.class);
Review comment:
can you add a .describedAs("inner cause")
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.io;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+
+import static junit.framework.TestCase.assertEquals;
Review comment:
nit: can you copy the import ordering of (most) of the hadoop code.
java*
non-org.apache. (though we are hadoop shaded guava is now in there too)
org.apache.*
static *
thanks
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=608761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608761
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 08/Jun/21 21:20
Start Date: 08/Jun/21 21:20
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3076:
URL: https://github.com/apache/hadoop/pull/3076#discussion_r647799533
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
##
@@ -482,6 +482,12 @@ public static IOException wrapException(final String path,
if (exception instanceof InterruptedIOException
|| exception instanceof PathIOException) {
return exception;
+} else if (exception.getCause() != null
+&& exception.getCause() instanceof InterruptedException) {
Review comment:
you can get rid of the !=null check, as L486 does that implicitly
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.io;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestIOUtilsWrapExceptionSuite extends Assert {
Review comment:
extends AbstractHadoopTestBase ; this sets up a timeout and names the
test thread
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtilsWrapExceptionSuite.java
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.io;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestIOUtilsWrapExceptionSuite extends Assert {
+@Test
+public void testWrapExceptionWithInterruptedException() throws Exception {
+InterruptedIOException inputException = new
InterruptedIOException("message");
+NullPointerException causeException = new
NullPointerException("cause");
+inputException.initCause(causeException);
+Exception outputException = IOUtils.wrapException("path",
"methodName", inputException);
+
+// The new exception should retain the input message, cause, and type
+assertTrue(outputException instanceof InterruptedIOException);
+assertTrue(outputException.getCause() instanceof NullPointerException);
+assertEquals(outputException.getMessage(),
inputException.getMessage());
+assertEquals(outputException.getCause(), inputException.getCause());
+}
+
+@Test
+public void testWrapExceptionWithInterruptedCauseException() throws
Exception {
+IOException inputException = new IOException("message");
+InterruptedException causeException = new
InterruptedException("cause");
+inputException.initCause(causeException);
+Exception outputException = IOUtils.wrapException("path",
"methodName", inputException);
+
+// The new exception should retain the input message and cause
+// but be an InterruptedIOException because the cause was an
InterruptedException
+
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=608757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608757 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 08/Jun/21 21:15 Start Date: 08/Jun/21 21:15 Worklog Time Spent: 10m Work Description: steveloughran commented on pull request #3076: URL: https://github.com/apache/hadoop/pull/3076#issuecomment-857157506 aah, you need to look at the [Testing Azure](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md) doc. I can see the code here doesn't directly go near the store, but as its called from abfs you are going to have to do a test run. Sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 608757) Time Spent: 1h (was: 50m) > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=607190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607190 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 04/Jun/21 16:34 Start Date: 04/Jun/21 16:34 Worklog Time Spent: 10m Work Description: eric-maynard commented on pull request #3076: URL: https://github.com/apache/hadoop/pull/3076#issuecomment-854861613 Hi @steveloughran, what tests should I run in order to make this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 607190) Time Spent: 50m (was: 40m) > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=606801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606801
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 04/Jun/21 08:25
Start Date: 04/Jun/21 08:25
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-854217501
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 58s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 33s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 55s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 4s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 40s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 2s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 34s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 26s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 21s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 58s | | the patch passed |
| +1 :green_heart: | compile | 22m 44s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 22m 44s | | the patch passed |
| +1 :green_heart: | compile | 19m 34s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 19m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 4s |
[/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt)
| hadoop-common-project/hadoop-common: The patch generated 25 new + 16
unchanged - 0 fixed = 41 total (was 16) |
| +1 :green_heart: | mvnsite | 1m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 6s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 36s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 37s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 1s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 188m 52s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3076 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a633afa4243f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / be7784f129795b478f8b0f5de60f71542367007c |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/testReport/ |
| Max. process+thread count | 3106 (vs. ulimit of 5500) |
| modules | C: hadoop-common-proj
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=606518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606518 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 04/Jun/21 07:52 Start Date: 04/Jun/21 07:52 Worklog Time Spent: 10m Work Description: eric-maynard opened a new pull request #3076: URL: https://github.com/apache/hadoop/pull/3076 The Azure client sometimes throws an IOException with an InterruptedException cause which can be converted to an InterruptedIOException. This is important for downstream consumers that rely on an InterruptedIOException to gracefully close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 606518) Time Spent: 0.5h (was: 20m) > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[
https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=606258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606258
]
ASF GitHub Bot logged work on HADOOP-17745:
---
Author: ASF GitHub Bot
Created on: 03/Jun/21 22:07
Start Date: 03/Jun/21 22:07
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3076:
URL: https://github.com/apache/hadoop/pull/3076#issuecomment-854217501
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 58s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 33s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 55s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | checkstyle | 1m 4s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 40s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 2s | | trunk passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 34s | | trunk passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 26s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 21s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 58s | | the patch passed |
| +1 :green_heart: | compile | 22m 44s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 22m 44s | | the patch passed |
| +1 :green_heart: | compile | 19m 34s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 19m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 4s |
[/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt)
| hadoop-common-project/hadoop-common: The patch generated 25 new + 16
unchanged - 0 fixed = 41 total (was 16) |
| +1 :green_heart: | mvnsite | 1m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 6s | | the patch passed with JDK
Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 36s | | the patch passed with JDK
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 37s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 1s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 188m 52s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3076 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a633afa4243f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / be7784f129795b478f8b0f5de60f71542367007c |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3076/1/testReport/ |
| Max. process+thread count | 3106 (vs. ulimit of 5500) |
| modules | C: hadoop-common-proj
[jira] [Work logged] (HADOOP-17745) ADLS client can throw an IOException when it should throw an InterruptedIOException
[ https://issues.apache.org/jira/browse/HADOOP-17745?focusedWorklogId=606130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606130 ] ASF GitHub Bot logged work on HADOOP-17745: --- Author: ASF GitHub Bot Created on: 03/Jun/21 18:57 Start Date: 03/Jun/21 18:57 Worklog Time Spent: 10m Work Description: eric-maynard opened a new pull request #3076: URL: https://github.com/apache/hadoop/pull/3076 The Azure client sometimes throws an IOException with an InterruptedException cause which can be converted to an InterruptedIOException. This is important for downstream consumers that rely on an InterruptedIOException to gracefully close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 606130) Remaining Estimate: 0h Time Spent: 10m > ADLS client can throw an IOException when it should throw an > InterruptedIOException > --- > > Key: HADOOP-17745 > URL: https://issues.apache.org/jira/browse/HADOOP-17745 > Project: Hadoop Common > Issue Type: Bug >Reporter: Eric Maynard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Azure client sometimes throws an IOException with an InterruptedException > cause which can be converted to an InterruptedIOException. This is important > for downstream consumers that rely on an InterruptedIOException to gracefully > close. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
