[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=628644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628644 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 27/Jul/21 17:51 Start Date: 27/Jul/21 17:51 Worklog Time Spent: 10m Work Description: steveloughran commented on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-887710637 merged into trunk. Can you cherrypick into branch-3.3 and retest there to make sure all is good. regarding the test failures, #3240 fixes the distcp issues. Please apply and verify that it works on your test setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 628644) Time Spent: 6h 20m (was: 6h 10m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 6h 20m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=628640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628640 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 27/Jul/21 17:49 Start Date: 27/Jul/21 17:49 Worklog Time Spent: 10m Work Description: steveloughran merged pull request #3153: URL: https://github.com/apache/hadoop/pull/3153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 628640) Time Spent: 6h 10m (was: 6h) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 6h 10m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=627844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627844
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 26/Jul/21 16:02
Start Date: 26/Jul/21 16:02
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-886829397
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 20s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 30 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 26s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 30s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 35s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 37s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 15m 57s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 34s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 34s | | the patch passed |
| +1 :green_heart: | compile | 0m 29s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 18s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 4s | | the patch passed |
| +1 :green_heart: | shadedclient | 15m 36s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 6s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not
generate ASF License warnings. |
| | | 78m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/9/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 0586a3d56972 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9004aeb7db040943f7a561d378c3d69e9289534e |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/9/testReport/ |
| Max. process+thread count | 720 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-mult
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=627801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627801 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 26/Jul/21 14:43 Start Date: 26/Jul/21 14:43 Worklog Time Spent: 10m Work Description: sumangala-patki commented on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-886765237 TEST RESULTS HNS Account Location: East US 2 NonHNS Account Location: East US 2, Central US ``` HNS OAuth [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 1 [ERROR] Errors: [WARNING] Tests run: 545, Failures: 0, Errors: 0, Skipped: 98 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut[ERROR] Tests run: 271, Failures: 0, Errors: 1, Skipped: 52 AppendBlob HNS OAuth [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 1 [ERROR] Failures: [ERROR] ITestAbfsStreamStatistics.testAbfsStreamOps:140->Assert.assertTrue:42->Assert.fail:89 The actual value of 99 was not equal to the expected value [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease:178->twoWriters:166 » IO [ERROR] Tests run: 558, Failures: 1, Errors: 1, Skipped: 98 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 1, Skipped: 76 HNS SharedKey [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 2 [WARNING] Tests run: 545, Failures: 0, Errors: 0, Skipped: 54 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 2, Skipped: 40 NonHNS SharedKey [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 2 [WARNING] Tests run: 545, Failures: 0, Errors: 0, Skipped: 276 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 2, Skipped: 40 ``` Existing JIRAs to track failures: [testDistCp](https://issues.apache.org/jira/browse/HADOOP-17628), [testAbfsStreamOps](https://issues.apache.org/jira/browse/HADOOP-17716), [Appendblob lease](https://issues.apache.org/jira/browse/HADOOP-17781) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627801) Time Spent: 5h 50m (was: 5h 40m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 5h 50m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=627563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627563
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 26/Jul/21 07:21
Start Date: 26/Jul/21 07:21
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-886445563
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 30 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 9s | | trunk passed |
| +1 :green_heart: | compile | 0m 41s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 33s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 31s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 6s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 5s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 23s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 33s | | the patch passed |
| +1 :green_heart: | compile | 0m 34s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 34s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/8/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 2 new + 7 unchanged - 0
fixed = 9 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 33s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 10s | | the patch passed |
| +1 :green_heart: | shadedclient | 17m 0s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 56s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 31s | | The patch does not
generate ASF License warnings. |
| | | 82m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/8/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 15d0464ef8f7 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 98882a01de71411e62d0108f9c02a184c2fa9f84 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apach
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=627538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627538
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 26/Jul/21 06:01
Start Date: 26/Jul/21 06:01
Worklog Time Spent: 10m
Work Description: sumangala-patki commented on a change in pull request
#3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r676312572
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -213,12 +213,12 @@ public void testOpenAppendRenameExists() throws
IOException {
assertAbfsStatistics(AbfsStatistic.CALL_RENAME, 1, metricMap);
//Testing if file exists at path.
-assertPathExists(fs,
-String.format("File with name %s should exist", destCreateFilePath),
-destCreateFilePath);
-assertPathDoesNotExist(fs,
-String.format("File with name %s should not exist", createFilePath),
-createFilePath);
+assertTrue(String.format("File with name %s should exist",
Review comment:
test verifies number of fs.exists() method calls based on its use in the
assertions
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -134,25 +140,25 @@ public void testBlobDataReader() throws Exception {
// TEST READ FS
Map properties =
abfsStore.getFilesystemProperties(tracingContext);
// TEST READ FOLDER
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+assertPathExists(fs, "This path should exist", existedFolderPath);
// TEST DELETE FOLDER
try {
- abfsStore.delete(EXISTED_FOLDER_PATH, true, tracingContext);
+ abfsStore.delete(existedFolderPath, true, tracingContext);
} catch (AbfsRestOperationException e) {
assertEquals(AzureServiceErrorCode.AUTHORIZATION_PERMISSION_MISS_MATCH,
e.getErrorCode());
}
// TEST READ FILE
-try (InputStream inputStream =
abfsStore.openFileForRead(EXISTED_FILE_PATH, null,
-tracingContext)) {
+try (InputStream inputStream = abfsStore
+.openFileForRead(existedFilePath, null, tracingContext)) {
assertTrue(inputStream.read() != 0);
}
// TEST WRITE FILE
try {
- abfsStore.openFileForWrite(EXISTED_FILE_PATH, fs.getFsStatistics(), true,
- tracingContext);
+ abfsStore.openFileForWrite(existedFilePath, fs.getFsStatistics(), true,
Review comment:
closed
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -161,14 +167,14 @@ public void testBlobDataReader() throws Exception {
}
- private void prepareFiles() throws IOException {
+ private void prepareFiles(Path existedFilePath, Path existedFolderPath)
throws IOException {
// create test files/folders to verify access control diff between
// Blob data contributor and Blob data reader
final AzureBlobFileSystem fs = this.getFileSystem();
-fs.create(EXISTED_FILE_PATH);
-assertTrue(fs.exists(EXISTED_FILE_PATH));
-fs.mkdirs(EXISTED_FOLDER_PATH);
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+fs.create(existedFilePath);
Review comment:
done
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsOutputStream.java
##
@@ -71,7 +70,7 @@ public void testMaxRequestsAndQueueCapacity() throws
Exception {
conf.set(ConfigurationKeys.AZURE_WRITE_MAX_REQUESTS_TO_QUEUE,
"" + maxRequestsToQueue);
final AzureBlobFileSystem fs = getFileSystem(conf);
-FSDataOutputStream out = fs.create(TEST_FILE_PATH);
+FSDataOutputStream out = fs.create(path(TEST_FILE_PATH));
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 627538)
Time Spent: 5.5h (was: 5h 20m)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
>Affects Versions: 3.3.1
>Reporter: Sumangala Patki
>Assignee: Sumangala Patki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Many of ABFS driver t
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=625557&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625557
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 20/Jul/21 12:25
Start Date: 20/Jul/21 12:25
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-874022678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 7s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 20s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 57s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2816e4e33139 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9977b30700db14e420c44d14deafda4530ce614 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/testReport/ |
| Max. process+thread count | 625 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/h
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=625486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625486
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 20/Jul/21 12:16
Start Date: 20/Jul/21 12:16
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r672590069
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsOutputStream.java
##
@@ -71,7 +70,7 @@ public void testMaxRequestsAndQueueCapacity() throws
Exception {
conf.set(ConfigurationKeys.AZURE_WRITE_MAX_REQUESTS_TO_QUEUE,
"" + maxRequestsToQueue);
final AzureBlobFileSystem fs = getFileSystem(conf);
-FSDataOutputStream out = fs.create(TEST_FILE_PATH);
+FSDataOutputStream out = fs.create(path(TEST_FILE_PATH));
Review comment:
this should be closed too in try-with-resources or try/finally
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -161,14 +167,14 @@ public void testBlobDataReader() throws Exception {
}
- private void prepareFiles() throws IOException {
+ private void prepareFiles(Path existedFilePath, Path existedFolderPath)
throws IOException {
// create test files/folders to verify access control diff between
// Blob data contributor and Blob data reader
final AzureBlobFileSystem fs = this.getFileSystem();
-fs.create(EXISTED_FILE_PATH);
-assertTrue(fs.exists(EXISTED_FILE_PATH));
-fs.mkdirs(EXISTED_FOLDER_PATH);
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+fs.create(existedFilePath);
Review comment:
should be `fs.create(existedFilePath).close()`. Not your change, but as
the line is changed, time to fix
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -134,25 +140,25 @@ public void testBlobDataReader() throws Exception {
// TEST READ FS
Map properties =
abfsStore.getFilesystemProperties(tracingContext);
// TEST READ FOLDER
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+assertPathExists(fs, "This path should exist", existedFolderPath);
// TEST DELETE FOLDER
try {
- abfsStore.delete(EXISTED_FOLDER_PATH, true, tracingContext);
+ abfsStore.delete(existedFolderPath, true, tracingContext);
} catch (AbfsRestOperationException e) {
assertEquals(AzureServiceErrorCode.AUTHORIZATION_PERMISSION_MISS_MATCH,
e.getErrorCode());
}
// TEST READ FILE
-try (InputStream inputStream =
abfsStore.openFileForRead(EXISTED_FILE_PATH, null,
-tracingContext)) {
+try (InputStream inputStream = abfsStore
+.openFileForRead(existedFilePath, null, tracingContext)) {
assertTrue(inputStream.read() != 0);
}
// TEST WRITE FILE
try {
- abfsStore.openFileForWrite(EXISTED_FILE_PATH, fs.getFsStatistics(), true,
- tracingContext);
+ abfsStore.openFileForWrite(existedFilePath, fs.getFsStatistics(), true,
Review comment:
Looking at this line (and it predates your patch): does the output
stream need to be closed?
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -213,12 +213,12 @@ public void testOpenAppendRenameExists() throws
IOException {
assertAbfsStatistics(AbfsStatistic.CALL_RENAME, 1, metricMap);
//Testing if file exists at path.
-assertPathExists(fs,
-String.format("File with name %s should exist", destCreateFilePath),
-destCreateFilePath);
-assertPathDoesNotExist(fs,
-String.format("File with name %s should not exist", createFilePath),
-createFilePath);
+assertTrue(String.format("File with name %s should exist",
Review comment:
why switch from AssertPathExists?
If you want to go to the simpler true/false, move to AssertJ whose assert
strings "describedAs()" as string formats only evaluated to assert failue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 625486)
Time Spent: 5h 10m (was: 5h)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
>
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=625096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625096
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 20/Jul/21 10:05
Start Date: 20/Jul/21 10:05
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r672590069
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsOutputStream.java
##
@@ -71,7 +70,7 @@ public void testMaxRequestsAndQueueCapacity() throws
Exception {
conf.set(ConfigurationKeys.AZURE_WRITE_MAX_REQUESTS_TO_QUEUE,
"" + maxRequestsToQueue);
final AzureBlobFileSystem fs = getFileSystem(conf);
-FSDataOutputStream out = fs.create(TEST_FILE_PATH);
+FSDataOutputStream out = fs.create(path(TEST_FILE_PATH));
Review comment:
this should be closed too in try-with-resources or try/finally
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -161,14 +167,14 @@ public void testBlobDataReader() throws Exception {
}
- private void prepareFiles() throws IOException {
+ private void prepareFiles(Path existedFilePath, Path existedFolderPath)
throws IOException {
// create test files/folders to verify access control diff between
// Blob data contributor and Blob data reader
final AzureBlobFileSystem fs = this.getFileSystem();
-fs.create(EXISTED_FILE_PATH);
-assertTrue(fs.exists(EXISTED_FILE_PATH));
-fs.mkdirs(EXISTED_FOLDER_PATH);
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+fs.create(existedFilePath);
Review comment:
should be `fs.create(existedFilePath).close()`. Not your change, but as
the line is changed, time to fix
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -134,25 +140,25 @@ public void testBlobDataReader() throws Exception {
// TEST READ FS
Map properties =
abfsStore.getFilesystemProperties(tracingContext);
// TEST READ FOLDER
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+assertPathExists(fs, "This path should exist", existedFolderPath);
// TEST DELETE FOLDER
try {
- abfsStore.delete(EXISTED_FOLDER_PATH, true, tracingContext);
+ abfsStore.delete(existedFolderPath, true, tracingContext);
} catch (AbfsRestOperationException e) {
assertEquals(AzureServiceErrorCode.AUTHORIZATION_PERMISSION_MISS_MATCH,
e.getErrorCode());
}
// TEST READ FILE
-try (InputStream inputStream =
abfsStore.openFileForRead(EXISTED_FILE_PATH, null,
-tracingContext)) {
+try (InputStream inputStream = abfsStore
+.openFileForRead(existedFilePath, null, tracingContext)) {
assertTrue(inputStream.read() != 0);
}
// TEST WRITE FILE
try {
- abfsStore.openFileForWrite(EXISTED_FILE_PATH, fs.getFsStatistics(), true,
- tracingContext);
+ abfsStore.openFileForWrite(existedFilePath, fs.getFsStatistics(), true,
Review comment:
Looking at this line (and it predates your patch): does the output
stream need to be closed?
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -213,12 +213,12 @@ public void testOpenAppendRenameExists() throws
IOException {
assertAbfsStatistics(AbfsStatistic.CALL_RENAME, 1, metricMap);
//Testing if file exists at path.
-assertPathExists(fs,
-String.format("File with name %s should exist", destCreateFilePath),
-destCreateFilePath);
-assertPathDoesNotExist(fs,
-String.format("File with name %s should not exist", createFilePath),
-createFilePath);
+assertTrue(String.format("File with name %s should exist",
Review comment:
why switch from AssertPathExists?
If you want to go to the simpler true/false, move to AssertJ whose assert
strings "describedAs()" as string formats only evaluated to assert failue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 625096)
Time Spent: 5h (was: 4h 50m)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
>
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624929
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 20/Jul/21 09:42
Start Date: 20/Jul/21 09:42
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-874022678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 7s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 20s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 57s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2816e4e33139 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9977b30700db14e420c44d14deafda4530ce614 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/testReport/ |
| Max. process+thread count | 625 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/h
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624604
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 19/Jul/21 20:00
Start Date: 19/Jul/21 20:00
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r672590069
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsOutputStream.java
##
@@ -71,7 +70,7 @@ public void testMaxRequestsAndQueueCapacity() throws
Exception {
conf.set(ConfigurationKeys.AZURE_WRITE_MAX_REQUESTS_TO_QUEUE,
"" + maxRequestsToQueue);
final AzureBlobFileSystem fs = getFileSystem(conf);
-FSDataOutputStream out = fs.create(TEST_FILE_PATH);
+FSDataOutputStream out = fs.create(path(TEST_FILE_PATH));
Review comment:
this should be closed too in try-with-resources or try/finally
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -161,14 +167,14 @@ public void testBlobDataReader() throws Exception {
}
- private void prepareFiles() throws IOException {
+ private void prepareFiles(Path existedFilePath, Path existedFolderPath)
throws IOException {
// create test files/folders to verify access control diff between
// Blob data contributor and Blob data reader
final AzureBlobFileSystem fs = this.getFileSystem();
-fs.create(EXISTED_FILE_PATH);
-assertTrue(fs.exists(EXISTED_FILE_PATH));
-fs.mkdirs(EXISTED_FOLDER_PATH);
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+fs.create(existedFilePath);
Review comment:
should be `fs.create(existedFilePath).close()`. Not your change, but as
the line is changed, time to fix
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -134,25 +140,25 @@ public void testBlobDataReader() throws Exception {
// TEST READ FS
Map properties =
abfsStore.getFilesystemProperties(tracingContext);
// TEST READ FOLDER
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+assertPathExists(fs, "This path should exist", existedFolderPath);
// TEST DELETE FOLDER
try {
- abfsStore.delete(EXISTED_FOLDER_PATH, true, tracingContext);
+ abfsStore.delete(existedFolderPath, true, tracingContext);
} catch (AbfsRestOperationException e) {
assertEquals(AzureServiceErrorCode.AUTHORIZATION_PERMISSION_MISS_MATCH,
e.getErrorCode());
}
// TEST READ FILE
-try (InputStream inputStream =
abfsStore.openFileForRead(EXISTED_FILE_PATH, null,
-tracingContext)) {
+try (InputStream inputStream = abfsStore
+.openFileForRead(existedFilePath, null, tracingContext)) {
assertTrue(inputStream.read() != 0);
}
// TEST WRITE FILE
try {
- abfsStore.openFileForWrite(EXISTED_FILE_PATH, fs.getFsStatistics(), true,
- tracingContext);
+ abfsStore.openFileForWrite(existedFilePath, fs.getFsStatistics(), true,
Review comment:
Looking at this line (and it predates your patch): does the output
stream need to be closed?
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStatistics.java
##
@@ -213,12 +213,12 @@ public void testOpenAppendRenameExists() throws
IOException {
assertAbfsStatistics(AbfsStatistic.CALL_RENAME, 1, metricMap);
//Testing if file exists at path.
-assertPathExists(fs,
-String.format("File with name %s should exist", destCreateFilePath),
-destCreateFilePath);
-assertPathDoesNotExist(fs,
-String.format("File with name %s should not exist", createFilePath),
-createFilePath);
+assertTrue(String.format("File with name %s should exist",
Review comment:
why switch from AssertPathExists?
If you want to go to the simpler true/false, move to AssertJ whose assert
strings "describedAs()" as string formats only evaluated to assert failue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 624604)
Time Spent: 4h 40m (was: 4.5h)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
>
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624600
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 19/Jul/21 19:52
Start Date: 19/Jul/21 19:52
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-874022678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 7s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 20s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 57s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2816e4e33139 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9977b30700db14e420c44d14deafda4530ce614 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/testReport/ |
| Max. process+thread count | 625 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/h
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624121
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 18/Jul/21 15:45
Start Date: 18/Jul/21 15:45
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-882076972
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 56s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 27 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 52s | | trunk passed |
| +1 :green_heart: | compile | 0m 40s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 28s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 33s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 2s |
[/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/7/artifact/out/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html)
| hadoop-tools/hadoop-azure in trunk has 1 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 14m 17s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 14m 36s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/7/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 2 new + 7 unchanged - 0
fixed = 9 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 31s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 13m 53s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 3s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 72m 39s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/7/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a4453a71ad5a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f306f8853f4ff7c5061405dda9f6118cab69f1f0 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624118&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624118 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 18/Jul/21 14:31 Start Date: 18/Jul/21 14:31 Worklog Time Spent: 10m Work Description: sumangala-patki commented on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-882065914 TEST RESULTS HNS Account Location: East US 2 NonHNS Account Location: East US 2, Central US ``` HNS OAuth [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 1 [WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 98 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 1, Skipped: 52 AppendBlob HNS OAuth [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 1 [ERROR] Failures: [ERROR] ITestAbfsStreamStatistics.testAbfsStreamOps:140->Assert.assertTrue:42->Assert.fail:89 The actual value of 99 was not equal to the expected value [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease:178->twoWriters:166 » IO [ERROR] Tests run: 558, Failures: 1, Errors: 1, Skipped: 98 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 1, Skipped: 76 SharedKey [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 2 [WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 54 [ERROR] Failures: [ERROR] ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:66->testReadWriteAndSeek:101 [Retry was required due to issue on server side] expected:<[0]> but was:<[1]> [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 1, Errors: 2, Skipped: 40 NonHNS-SharedKey [WARNING] Tests run: 102, Failures: 0, Errors: 0, Skipped: 2 [WARNING] Tests run: 558, Failures: 0, Errors: 0, Skipped: 276 [ERROR] Errors: [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 271, Failures: 0, Errors: 2, Skipped: 40 ``` Existing JIRAs to track failures: [ReadWriteandSeek](https://issues.apache.org/jira/browse/HADOOP-15702), [testDistCpWithIterator](https://issues.apache.org/jira/browse/HADOOP-17628), [testAbfsStreamOps](https://issues.apache.org/jira/browse/HADOOP-17716), [ITestAzureBlobFileSystemLease](https://issues.apache.org/jira/browse/HADOOP-17781) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 624118) Time Spent: 4h 10m (was: 4h) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 4h 10m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=624081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624081
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 18/Jul/21 05:12
Start Date: 18/Jul/21 05:12
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-881999817
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 27 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 52s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 0s |
[/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/6/artifact/out/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html)
| hadoop-tools/hadoop-azure in trunk has 1 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 16m 29s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 16m 46s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 28s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 79m 13s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/6/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 5816a82c52d3 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 8322a19842e07fb76dfcc7ab85e0e2a4bacfe719 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-m
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=622399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622399
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 14/Jul/21 07:52
Start Date: 14/Jul/21 07:52
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-879677511
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 21m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 27 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 29s | | trunk passed |
| +1 :green_heart: | compile | 0m 46s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 45s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 30s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 6s |
[/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/5/artifact/out/branch-spotbugs-hadoop-tools_hadoop-azure-warnings.html)
| hadoop-tools/hadoop-azure in trunk has 1 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 18m 50s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 19m 10s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 36s | | the patch passed |
| +1 :green_heart: | compile | 0m 43s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 43s | | the patch passed |
| +1 :green_heart: | compile | 0m 34s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 22s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/5/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 4 new + 7 unchanged - 0
fixed = 11 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 14s | | the patch passed |
| +1 :green_heart: | shadedclient | 18m 38s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 2s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 44s | | The patch does not
generate ASF License warnings. |
| | | 110m 15s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/5/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a15018e00e8b 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / d02c0cdd03d78f85079b716aa9b63e9879e989f0 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=621693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621693
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 12/Jul/21 20:07
Start Date: 12/Jul/21 20:07
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-869417214
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 43s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 44s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 16s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 1 new + 7 unchanged - 0
fixed = 8 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 39s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 79m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux f5bce17dec6f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0ad689edc99e9f25d17faf0df5896d7407ceb12a |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/testReport/ |
| Max. process+thread count | 518 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/h
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=620970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620970
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 09/Jul/21 13:05
Start Date: 09/Jul/21 13:05
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r666930271
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java
##
@@ -443,6 +445,16 @@ protected Path path(String filepath) throws IOException {
new Path(getTestPath(), filepath));
}
+ /**
+ * Generate a unique path using the given filepath
Review comment:
nit: add .
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##
@@ -90,29 +92,29 @@ public void testBlobDataContributor() throws Exception {
// Verify Blob Data Contributor has full access to existed folder, file
// READ FOLDER
-assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+assertTrue(fs.exists(existedFolderPath));
//DELETE FOLDER
-fs.delete(EXISTED_FOLDER_PATH, true);
-assertFalse(fs.exists(EXISTED_FOLDER_PATH));
+fs.delete(existedFolderPath, true);
+assertFalse(fs.exists(existedFolderPath));
Review comment:
good time to move to the ContractTestUtils assertions
assertPathExists/assertPathDoesNotExist as they provide meaningful
messages/diagnostics. I really don't like assertTrue/assertFalse without
messages, as they make debugging test failures much harder than they need to be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 620970)
Time Spent: 3.5h (was: 3h 20m)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
>Affects Versions: 3.3.1
>Reporter: Sumangala Patki
>Assignee: Sumangala Patki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Many of ABFS driver tests use common names for file paths (e.g.,
> "/testfile"). This poses a risk of errors during parallel test runs when
> static variables (such as those for monitoring stats) affected by file paths
> are introduced.
> Using unique test file names will avoid possible errors arising from shared
> resources during parallel runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=620966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620966
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 09/Jul/21 12:59
Start Date: 09/Jul/21 12:59
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-873783795
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 0s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 51s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 8s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 16s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/2/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 1 new + 7 unchanged - 0
fixed = 8 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 49s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 52s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 56s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 274f79894bd2 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9c382c2f48ee9dbb62f00540543eb14e4a54d8a6 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hado
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=620964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620964
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 09/Jul/21 12:58
Start Date: 09/Jul/21 12:58
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #3122:
URL: https://github.com/apache/hadoop/pull/3122#issuecomment-864399295
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 19 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 55s | | trunk passed |
| +1 :green_heart: | compile | 0m 43s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 42s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 35s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 3s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 11s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 2 new + 4 unchanged - 0
fixed = 6 total (was 4) |
| +1 :green_heart: | mvnsite | 0m 31s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 4s |
[/new-spotbugs-hadoop-tools_hadoop-azure.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/new-spotbugs-hadoop-tools_hadoop-azure.html)
| hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total
(was 0) |
| +1 :green_heart: | shadedclient | 13m 57s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 55s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not
generate ASF License warnings. |
| | | 72m 3s | | |
| Reason | Tests |
|---:|:--|
| SpotBugs | module:hadoop-tools/hadoop-azure |
| | Dead store to testUniqueForkId in
org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath() At
UriUtils.java:org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath()
At UriUtils.java:[line 73] |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3122 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ece91eed6fe3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=620847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620847 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 09/Jul/21 03:22 Start Date: 09/Jul/21 03:22 Worklog Time Spent: 10m Work Description: sumangala-patki closed pull request #3122: URL: https://github.com/apache/hadoop/pull/3122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 620847) Time Spent: 3h (was: 2h 50m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=620846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620846
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 09/Jul/21 03:22
Start Date: 09/Jul/21 03:22
Worklog Time Spent: 10m
Work Description: sumangala-patki commented on a change in pull request
#3122:
URL: https://github.com/apache/hadoop/pull/3122#discussion_r44759
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestCustomerProvidedKey.java
##
@@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception {
@Test
public void testReadWithCPK() throws Exception {
final AzureBlobFileSystem fs = getAbfs(true);
-String fileName = path("/" + methodName.getMethodName()).toString();
+String fileName = "/" + methodName.getMethodName();
Review comment:
This is an older PR, will be abandoning this. The current PR is at #3153
Could you please review that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 620846)
Time Spent: 2h 50m (was: 2h 40m)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
>Affects Versions: 3.3.1
>Reporter: Sumangala Patki
>Assignee: Sumangala Patki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Many of ABFS driver tests use common names for file paths (e.g.,
> "/testfile"). This poses a risk of errors during parallel test runs when
> static variables (such as those for monitoring stats) affected by file paths
> are introduced.
> Using unique test file names will avoid possible errors arising from shared
> resources during parallel runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=619236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-619236
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 06/Jul/21 11:35
Start Date: 06/Jul/21 11:35
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3122:
URL: https://github.com/apache/hadoop/pull/3122#discussion_r664106486
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemBackCompat.java
##
@@ -50,13 +52,17 @@ public void testBlobBackCompat() throws Exception {
CloudBlobContainer container =
blobClient.getContainerReference(this.getFileSystemName());
container.createIfNotExists();
-CloudBlockBlob blockBlob =
container.getBlockBlobReference("test/10/10/10");
+String testPath = "test" + UUID.randomUUID();
+CloudBlockBlob blockBlob = container
+.getBlockBlobReference(testPath + "/10/10/10");
blockBlob.uploadText("");
-blockBlob = container.getBlockBlobReference("test/10/123/3/2/1/3");
+blockBlob = container.getBlockBlobReference(testPath + "/10/123/3/2/1/3");
blockBlob.uploadText("");
-FileStatus[] fileStatuses = fs.listStatus(new Path("/test/10/"));
+System.out.println(new Path(String.format("%s/10/", testPath)));
Review comment:
use SLF4J logger
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestCustomerProvidedKey.java
##
@@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception {
@Test
public void testReadWithCPK() throws Exception {
final AzureBlobFileSystem fs = getAbfs(true);
-String fileName = path("/" + methodName.getMethodName()).toString();
+String fileName = "/" + methodName.getMethodName();
Review comment:
so this moves away from path(). why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 619236)
Time Spent: 2h 40m (was: 2.5h)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
>Affects Versions: 3.3.1
>Reporter: Sumangala Patki
>Assignee: Sumangala Patki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Many of ABFS driver tests use common names for file paths (e.g.,
> "/testfile"). This poses a risk of errors during parallel test runs when
> static variables (such as those for monitoring stats) affected by file paths
> are introduced.
> Using unique test file names will avoid possible errors arising from shared
> resources during parallel runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=619074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-619074
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 06/Jul/21 11:11
Start Date: 06/Jul/21 11:11
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-874022678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 7s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 20s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 57s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2816e4e33139 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9977b30700db14e420c44d14deafda4530ce614 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/testReport/ |
| Max. process+thread count | 625 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-mu
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618769
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 05/Jul/21 19:53
Start Date: 05/Jul/21 19:53
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3122:
URL: https://github.com/apache/hadoop/pull/3122#discussion_r664106486
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemBackCompat.java
##
@@ -50,13 +52,17 @@ public void testBlobBackCompat() throws Exception {
CloudBlobContainer container =
blobClient.getContainerReference(this.getFileSystemName());
container.createIfNotExists();
-CloudBlockBlob blockBlob =
container.getBlockBlobReference("test/10/10/10");
+String testPath = "test" + UUID.randomUUID();
+CloudBlockBlob blockBlob = container
+.getBlockBlobReference(testPath + "/10/10/10");
blockBlob.uploadText("");
-blockBlob = container.getBlockBlobReference("test/10/123/3/2/1/3");
+blockBlob = container.getBlockBlobReference(testPath + "/10/123/3/2/1/3");
blockBlob.uploadText("");
-FileStatus[] fileStatuses = fs.listStatus(new Path("/test/10/"));
+System.out.println(new Path(String.format("%s/10/", testPath)));
Review comment:
use SLF4J logger
##
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestCustomerProvidedKey.java
##
@@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception {
@Test
public void testReadWithCPK() throws Exception {
final AzureBlobFileSystem fs = getAbfs(true);
-String fileName = path("/" + methodName.getMethodName()).toString();
+String fileName = "/" + methodName.getMethodName();
Review comment:
so this moves away from path(). why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 618769)
Time Spent: 2h 20m (was: 2h 10m)
> ABFS: Use Unique File Paths in Tests
>
>
> Key: HADOOP-17765
> URL: https://issues.apache.org/jira/browse/HADOOP-17765
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
>Affects Versions: 3.3.1
>Reporter: Sumangala Patki
>Assignee: Sumangala Patki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Many of ABFS driver tests use common names for file paths (e.g.,
> "/testfile"). This poses a risk of errors during parallel test runs when
> static variables (such as those for monitoring stats) affected by file paths
> are introduced.
> Using unique test file names will avoid possible errors arising from shared
> resources during parallel runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618606
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 05/Jul/21 11:04
Start Date: 05/Jul/21 11:04
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-874022678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 7s | | trunk passed |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 20s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 57s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2816e4e33139 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9977b30700db14e420c44d14deafda4530ce614 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/3/testReport/ |
| Max. process+thread count | 625 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-mu
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618519
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 05/Jul/21 04:53
Start Date: 05/Jul/21 04:53
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-873783795
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 0s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 51s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 8s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 16s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/2/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 1 new + 7 unchanged - 0
fixed = 8 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 49s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 52s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 78m 56s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 274f79894bd2 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9c382c2f48ee9dbb62f00540543eb14e4a54d8a6 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apach
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=618496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618496 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 05/Jul/21 03:37 Start Date: 05/Jul/21 03:37 Worklog Time Spent: 10m Work Description: sumangala-patki commented on a change in pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#discussion_r663618585 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java ## @@ -25,6 +25,8 @@ import java.util.UUID; import java.util.concurrent.Callable; +import org.apache.commons.lang3.StringUtils; Review comment: Had assumed it's to be grouped with third-party imports; shifted to apache section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 618496) Time Spent: 1h 50m (was: 1h 40m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=617973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617973 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 02/Jul/21 04:33 Start Date: 02/Jul/21 04:33 Worklog Time Spent: 10m Work Description: bilaharith commented on a change in pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#discussion_r662729508 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java ## @@ -25,6 +25,8 @@ import java.util.UUID; import java.util.concurrent.Callable; +import org.apache.commons.lang3.StringUtils; Review comment: import order -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 617973) Time Spent: 1h 40m (was: 1.5h) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=616973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616973 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 30/Jun/21 09:05 Start Date: 30/Jun/21 09:05 Worklog Time Spent: 10m Work Description: sumangala-patki edited a comment on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-869613676 TEST RESULTS HNS Account Location: East US 2 NonHNS Account Location: East US 2, Central US ``` HNS OAuth [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures: [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendWithInfiniteLeaseEnabled:182->twoWriters:150 » TestTimedOut [ERROR] Tests run: 556, Failures: 1, Errors: 1, Skipped: 98 [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 1, Skipped: 52 AppendBlob HNS OAuth [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures: [ERROR] ITestAbfsStreamStatistics.testAbfsStreamOps:140->Assert.assertTrue:42->Assert.fail:89 The actual value of 99 was not equal to the expected value [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease:173->twoWriters:161 » IO [ERROR] Tests run: 556, Failures: 2, Errors: 1, Skipped: 98 [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 1, Skipped: 76 HNS SharedKey [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Tests run: 556, Failures: 1, Errors: 0, Skipped: 62 [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 2, Skipped: 40 NonHNS SharedKey [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Tests run: 556, Failures: 1, Errors: 0, Skipped: 276 [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 2, Skipped: 40 ``` Existing JIRAs to track failures: [AppendBlob StreamOps test](https://issues.apache.org/jira/browse/HADOOP-17716), [LMT](https://issues.apache.org/jira/browse/HADOOP-16752), [ReadWriteandSeek](https://issues.apache.org/jira/browse/HADOOP-15702), [testDistCpWithIterator](https://issues.apache.org/jira/browse/HADOOP-17628), [Lease IO error](https://issues.apache.org/jira/browse/HADOOP-17781) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 616973) Time Spent: 1.5h (was: 1h 20m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > ar
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615570 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 28/Jun/21 11:43 Start Date: 28/Jun/21 11:43 Worklog Time Spent: 10m Work Description: sumangala-patki commented on pull request #3153: URL: https://github.com/apache/hadoop/pull/3153#issuecomment-869613676 TEST RESULTS HNS Account Location: East US 2 NonHNS Account Location: East US 2, Central US ``` HNS OAuth [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures: [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendWithInfiniteLeaseEnabled:182->twoWriters:150 » TestTimedOut [ERROR] Tests run: 556, Failures: 1, Errors: 1, Skipped: 98 [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 1, Skipped: 52 AppendBlob HNS OAuth [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures: [ERROR] ITestAbfsStreamStatistics.testAbfsStreamOps:140->Assert.assertTrue:42->Assert.fail:89 The actual value of 99 was not equal to the expected value [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Errors: [ERROR] ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease:173->twoWriters:161 » IO [ERROR] Tests run: 556, Failures: 2, Errors: 1, Skipped: 98 [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 1, Skipped: 76 HNS SharedKey [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Tests run: 556, Failures: 1, Errors: 0, Skipped: 62 [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 2, Skipped: 40 NonHNS SharedKey [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [ERROR] ITestAzureBlobFileSystemFileStatus.testLastModifiedTime:143->Assert.assertTrue:42->Assert.fail:89 lastModifiedTime should be before createEndTime [ERROR] Tests run: 556, Failures: 1, Errors: 0, Skipped: 276 [ERROR] ITestAbfsFileSystemContractDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] ITestAbfsFileSystemContractSecureDistCp>AbstractContractDistCpTest.testDistCpWithIterator:635 » TestTimedOut [ERROR] Tests run: 265, Failures: 0, Errors: 2, Skipped: 40 ``` Existing JIRAs to track failures: [AppendBlob StreamOps test](https://issues.apache.org/jira/browse/HADOOP-17716), [LMT](https://issues.apache.org/jira/browse/HADOOP-16752), [ReadWriteandSeek](https://issues.apache.org/jira/browse/HADOOP-15702), [testDistCpWithIterator](https://issues.apache.org/jira/browse/HADOOP-17628) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 615570) Time Spent: 1h 20m (was: 1h 10m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors ar
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615470
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 28/Jun/21 07:06
Start Date: 28/Jun/21 07:06
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#issuecomment-869417214
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 25 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 43s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 16m 44s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 16s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 1 new + 7 unchanged - 0
fixed = 8 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 39s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not
generate ASF License warnings. |
| | | 79m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3153 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux f5bce17dec6f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0ad689edc99e9f25d17faf0df5896d7407ceb12a |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3153/1/testReport/ |
| Max. process+thread count | 518 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-az
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615462
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 28/Jun/21 05:52
Start Date: 28/Jun/21 05:52
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3122:
URL: https://github.com/apache/hadoop/pull/3122#issuecomment-869377529
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 34 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 15s | | trunk passed |
| +1 :green_heart: | compile | 0m 39s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 40s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 31s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 0s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 16s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/4/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 1 new + 12 unchanged - 0
fixed = 13 total (was 12) |
| +1 :green_heart: | mvnsite | 0m 30s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 13m 45s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 8s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 72m 25s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3122 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a8812f694e53 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 2320bc87ccec4cbfcc55e0f78d35494d622e93f2 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/4/testReport/ |
| Max. process+thread count | 693 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615460 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 28/Jun/21 05:45 Start Date: 28/Jun/21 05:45 Worklog Time Spent: 10m Work Description: sumangala-patki opened a new pull request #3153: URL: https://github.com/apache/hadoop/pull/3153 Many of ABFS driver tests use common names for file paths (e.g., "/testfile"). This poses a risk of errors during parallel test runs when static variables (such as those for monitoring stats) affected by file paths are introduced. Using unique test file names will avoid possible errors arising from shared resources during parallel runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 615460) Time Spent: 50m (was: 40m) > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615174
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 25/Jun/21 19:43
Start Date: 25/Jun/21 19:43
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3122:
URL: https://github.com/apache/hadoop/pull/3122#issuecomment-868794040
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 21 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 45s | | trunk passed |
| +1 :green_heart: | compile | 0m 39s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 40s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 31s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 1s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 15s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 18s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 30s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 0s | | the patch passed |
| +1 :green_heart: | shadedclient | 13m 48s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 9s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 72m 6s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3122 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 59e05e3e7509 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5dbb6f1d9c2fb508067560d595fc92ea336b7d89 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/3/testReport/ |
| Max. process+thread count | 543 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This messag
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=615048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615048
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 25/Jun/21 15:09
Start Date: 25/Jun/21 15:09
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3122:
URL: https://github.com/apache/hadoop/pull/3122#issuecomment-868567657
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 21 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 48s | | trunk passed |
| +1 :green_heart: | compile | 0m 40s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 28s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 42s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 3s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 3s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 19s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/2/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 2 new + 7 unchanged - 0
fixed = 9 total (was 7) |
| +1 :green_heart: | mvnsite | 0m 30s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 4s |
[/new-spotbugs-hadoop-tools_hadoop-azure.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/2/artifact/out/new-spotbugs-hadoop-tools_hadoop-azure.html)
| hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total
(was 0) |
| +1 :green_heart: | shadedclient | 2m 19s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 51s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 28s | | The patch does not
generate ASF License warnings. |
| | | 60m 14s | | |
| Reason | Tests |
|---:|:--|
| SpotBugs | module:hadoop-tools/hadoop-azure |
| | Dead store to testUniqueForkId in
org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath() At
UriUtils.java:org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath()
At UriUtils.java:[line 73] |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3122 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux c28d200f38fe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
|
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[
https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=612292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612292
]
ASF GitHub Bot logged work on HADOOP-17765:
---
Author: ASF GitHub Bot
Created on: 19/Jun/21 12:22
Start Date: 19/Jun/21 12:22
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3122:
URL: https://github.com/apache/hadoop/pull/3122#issuecomment-864399295
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 19 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 55s | | trunk passed |
| +1 :green_heart: | compile | 0m 43s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 42s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 35s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 1m 3s | | trunk passed |
| +1 :green_heart: | shadedclient | 14m 11s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 27s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt)
| hadoop-tools/hadoop-azure: The patch generated 2 new + 4 unchanged - 0
fixed = 6 total (was 4) |
| +1 :green_heart: | mvnsite | 0m 31s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| -1 :x: | spotbugs | 1m 4s |
[/new-spotbugs-hadoop-tools_hadoop-azure.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/new-spotbugs-hadoop-tools_hadoop-azure.html)
| hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total
(was 0) |
| +1 :green_heart: | shadedclient | 13m 57s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 55s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not
generate ASF License warnings. |
| | | 72m 3s | | |
| Reason | Tests |
|---:|:--|
| SpotBugs | module:hadoop-tools/hadoop-azure |
| | Dead store to testUniqueForkId in
org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath() At
UriUtils.java:org.apache.hadoop.fs.azurebfs.utils.UriUtils.generateUniqueTestPath()
At UriUtils.java:[line 73] |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3122/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3122 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ece91eed6fe3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
|
[jira] [Work logged] (HADOOP-17765) ABFS: Use Unique File Paths in Tests
[ https://issues.apache.org/jira/browse/HADOOP-17765?focusedWorklogId=612285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612285 ] ASF GitHub Bot logged work on HADOOP-17765: --- Author: ASF GitHub Bot Created on: 19/Jun/21 11:09 Start Date: 19/Jun/21 11:09 Worklog Time Spent: 10m Work Description: sumangala-patki opened a new pull request #3122: URL: https://github.com/apache/hadoop/pull/3122 Many of ABFS driver tests use common names for file paths (e.g., "/testfile"). This poses a risk of errors during parallel test runs when static variables (such as those for monitoring stats) affected by file paths are introduced. Using unique test file names will avoid possible errors arising from shared resources during parallel runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 612285) Remaining Estimate: 0h Time Spent: 10m > ABFS: Use Unique File Paths in Tests > > > Key: HADOOP-17765 > URL: https://issues.apache.org/jira/browse/HADOOP-17765 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.3.1 >Reporter: Sumangala Patki >Assignee: Sumangala Patki >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Many of ABFS driver tests use common names for file paths (e.g., > "/testfile"). This poses a risk of errors during parallel test runs when > static variables (such as those for monitoring stats) affected by file paths > are introduced. > Using unique test file names will avoid possible errors arising from shared > resources during parallel runs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
