[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated HADOOP-6536: Status: Open (was: Patch Available) Changes look good. bq. I would also add that fullyDelete should delete dangling links (it currently does but we should add a test). Can you add a test for deleting dangling links also? FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-6536: - Attachment: HADOOP-6536.v1.1.patch Attaching patch adding more testcases. FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.1.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated HADOOP-6536: Status: Patch Available (was: Open) Patch looks good. FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.1.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-6536: - Status: Open (was: Patch Available) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.1.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-6536: - Status: Patch Available (was: Open) The failed test TestTrash passes on my local machine. Allowing to go through Hudson again... FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.1.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated HADOOP-6536: Status: Resolved (was: Patch Available) Hadoop Flags: [Reviewed] Resolution: Fixed I just committed this. Thanks Ravi! FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.1.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-6536: - Attachment: HADOOP-6536.v1.patch Attaching new patch to apply to the latest trunk as HADOOP-6631 has gone in. FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch, HADOOP-6536.v1.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6536) FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument
[ https://issues.apache.org/jira/browse/HADOOP-6536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-6536: - Attachment: HADOOP-6536.patch Attaching patch for trunk. This patch is on top of HADOOP-6631. FileUtil.fullyDelete(dir) behavior is not defined when we pass a symlink as the argument Key: HADOOP-6536 URL: https://issues.apache.org/jira/browse/HADOOP-6536 Project: Hadoop Common Issue Type: Bug Components: fs Reporter: Amareshwari Sriramadasu Assignee: Ravi Gummadi Fix For: 0.22.0 Attachments: HADOOP-6536.patch FileUtil.fullyDelete(dir) deletes contents of sym-linked directory when we pass a symlink. If this is the behavior, it should be documented as so. Or it should be changed not to delete the contents of the sym-linked directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
