[DBCP] in JNDI (was: Problem setting properties in JNDI environment)
Hello Dutta! dctci I am trying to bound DBCP with a JNDI implementation. dctci I am not able to set properties of CPDS and Jdcb2PoolDataSource dctci by using jndi environment variables. dctci Is there any wrapper class is there that reads JNDI properties and dctci sets to the CPDS and Jdcb2PoolDataSource ?? Since nobody has taken this up I will probably try to do what I can :-) 1) I still own John Mc'Nally my reasonings (sorry, for my huge delays, I'll probably look at JCA and if both we and Tomcat could benefit from it with our pools, and also at the way Tomcat implements JNDI handling - still pending on my list) but I would say that it is at least * simpler (hope John will agree to this) * and safer (John won't agree I think :-) to use BasicDataSource, not Jdbc2PollDataSource 2) Dutta, probably if you did put [DBCP] in the Subject: line you would have received all the help you need right the next day you have posted (the traffic is huge and people do the filtering on subject) 3) My personal impression is that the JNDI handling for DBCP is written mostly for Tomcat. But we _all_ are interested in making it as widely usable as possible. I believe your use case can help us. What is your environment? JNDI impl. and so on? WBR, Anton - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build Failure - commons-net
This email is autogenerated from the output from: http://cvs.apache.org/builds/gump/2003-08-03/commons-net.html Buildfile: build.xml init: [mkdir] Created dir: /home/rubys/jakarta/jakarta-commons/net/target/lib get-deps: compile: [javac] Compiling 119 source files to /home/rubys/jakarta/jakarta-commons/net/target/classes compile-tests: [javac] Compiling 17 source files to /home/rubys/jakarta/jakarta-commons/net/target/test-classes internal-test: [mkdir] Created dir: /home/rubys/jakarta/jakarta-commons/net/target/test-reports [junit] Running org.apache.commons.net.ftp.parser.EnterpriseUnixFTPEntryParserTest [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.875 sec [junit] Testsuite: org.apache.commons.net.ftp.parser.EnterpriseUnixFTPEntryParserTest [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.875 sec [junit] Testcase: testParseFieldsOnDirectory took 0.096 sec [junit] Testcase: testParseFieldsOnFile took 0.043 sec [junit] FAILED [junit] expected:Mon Aug 12 13:56:00 2002 but was:Tue Aug 12 13:56:00 2003 [junit] junit.framework.ComparisonFailure: expected:Mon Aug 12 13:56:00 2002 but was:Tue Aug 12 13:56:00 2003 [junit] at org.apache.commons.net.ftp.parser.EnterpriseUnixFTPEntryParserTest.testParseFieldsOnFile(EnterpriseUnixFTPEntryParserTest.java:147) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] Testcase: testParseFieldsOnFileTestcase: testBadListing took 0.016 sec [junit] Testcase: testGoodListing took 0.003 sec [junit] TEST org.apache.commons.net.ftp.parser.EnterpriseUnixFTPEntryParserTest FAILED [junit] Running org.apache.commons.net.ftp.parser.NTFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.709 sec [junit] Testsuite: org.apache.commons.net.ftp.parser.NTFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.709 sec [junit] Testcase: testParseFieldsOnDirectory took 0.121 sec [junit] Testcase: testParseFieldsOnFile took 0.009 sec [junit] Testcase: testBadListing took 0.012 sec [junit] Testcase: testGoodListing took 0.003 sec [junit] Running org.apache.commons.net.ftp.parser.OS2FTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.851 sec [junit] Testsuite: org.apache.commons.net.ftp.parser.OS2FTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.851 sec [junit] Testcase: testParseFieldsOnDirectory took 0.222 sec [junit] Testcase: testParseFieldsOnFile took 0.011 sec [junit] Testcase: testBadListing took 0.052 sec [junit] Testcase: testGoodListing took 0.003 sec [junit] Running org.apache.commons.net.ftp.parser.UnixFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.907 sec [junit] Testsuite: org.apache.commons.net.ftp.parser.UnixFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.907 sec [junit] Testcase: testParseFieldsOnDirectory took 0.13 sec [junit] Testcase: testParseFieldsOnFile took 0.016 sec [junit] Testcase: testBadListing took 0.07 sec [junit] Testcase: testGoodListing took 0.027 sec [junit] Running org.apache.commons.net.ftp.parser.VMSFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.918 sec [junit] Testsuite: org.apache.commons.net.ftp.parser.VMSFTPEntryParserTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.918 sec [junit] - Standard Output --- [junit] 14 [junit] 1-JUN.LIS;1 [junit] 1-JUN.LIS;3 [junit] 1-JUN.LIS;2 [junit] DATA.DIR;1 [junit] 120196.TXT;1 [junit] 30CHARBAR.TXT;1 [junit] A.;2 [junit] AA.;2 [junit] UCX$REXECD_STARTUP.LOG;1098 [junit] UNARCHIVE.COM;1 [junit] UNXMERGE.COM;15 [junit] UNXTEMP.COM;7 [junit] UNZIP_AND_ATTACH_FILES.COM;12 [junit] UNZIP_AND_ATTACH_FILES.SAV;1 [junit] 12 [junit] UNZIP_AND_ATTACH_FILES.SAV [junit] UNZIP_AND_ATTACH_FILES.COM [junit] UCX$REXECD_STARTUP.LOG [junit] DATA.DIR [junit] 120196.TXT [junit] 30CHARBAR.TXT [junit] AA. [junit] A. [junit] UNARCHIVE.COM [junit] UNXTEMP.COM [junit] UNXMERGE.COM [junit] 1-JUN.LIS [junit] - --- [junit] Testcase: testParseFieldsOnDirectory took 0.167 sec [junit] Testcase: testParseFieldsOnFile took 0.047 sec [junit] Testcase: testBadListing took 0.06 sec [junit] Testcase: testGoodListing took 0.034 sec [junit] Running
[GUMP] Build Failure - commons-el
This email is autogenerated from the output from: http://cvs.apache.org/builds/gump/2003-08-03/commons-el.html Buildfile: build.xml init: [echo] el 1.1-dev prepare: [mkdir] Created dir: /home/rubys/jakarta/jakarta-commons/el/target/tests static: [copy] Copying 1 file to /home/rubys/jakarta/jakarta-commons/el/target/conf build-servletapi: [echo] == Building: ../../jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar prepare: static: compile: jar: [copy] Copying 1 file to /home/rubys/jakarta/jakarta-servletapi-5/jsr154/build build-jspapi: [echo] == Building: ../../jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar prepare: static: compile: jar: [copy] Copying 1 file to /home/rubys/jakarta/jakarta-servletapi-5/jsr152/build compile-only: [javac] Compiling 43 source files to /home/rubys/jakarta/jakarta-commons/el/target/classes [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/ArraySuffix.java:58: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.Log; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/ArraySuffix.java:59: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.LogFactory; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/ArraySuffix.java:120: cannot resolve symbol [javac] symbol : class Log [javac] location: class org.apache.commons.el.ArraySuffix [javac] private static Log log = LogFactory.getLog(ArraySuffix.class); [javac]^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/BeanInfoManager.java:58: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.Log; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/BeanInfoManager.java:59: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.LogFactory; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/BeanInfoManager.java:92: cannot resolve symbol [javac] symbol : class Log [javac] location: class org.apache.commons.el.BeanInfoManager [javac] private static Log log = LogFactory.getLog(BeanInfoManager.class); [javac]^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/Coercions.java:58: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.Log; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/Coercions.java:59: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.LogFactory; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/Coercions.java:324: cannot resolve symbol [javac] symbol : class Log [javac] location: class org.apache.commons.el.Coercions [javac] private static Log log = LogFactory.getLog(Coercions.class); [javac]^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/DivideOperator.java:58: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.Log; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/DivideOperator.java:59: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.LogFactory; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/DivideOperator.java:78: cannot resolve symbol [javac] symbol : class Log [javac] location: class org.apache.commons.el.DivideOperator [javac] private static Log log = LogFactory.getLog(DivideOperator.class); [javac]^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java:72: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.Log; [javac] ^ [javac] /home/rubys/jakarta/jakarta-commons/el/src/java/org/apache/commons/el/ExpressionEvaluatorImpl.java:73: package org.apache.commons.logging does not exist [javac] import org.apache.commons.logging.LogFactory; [javac] ^
Re: [lang] ArrayUtils.contains()
Hadn't thought of that one, but I guess it makes sense. If you want to supply a patch;-) Stephen - Original Message - From: Tim O'Brien [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, August 03, 2003 4:17 AM Subject: [lang] ArrayUtils.contains() Has anyone thought of adding a tolerance to ArrayUtils when trying to calls contains, indexOf, of lastIndexOf for a floating point number? boolean ArrayUtils.contains(double[] array, double valueToFind, double tolerance) The method would return true if array contained a double value in valueToFind +/- tolerance. Any thoughts? Tim - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[email] SimpleEmail
Hi, Ant has a MailMessage class that can be used like this: // % MailMessage msg = new MailMessage(mailhost, mailport); msg.from(Ant Mail Message [EMAIL PROTECTED]); msg.to([EMAIL PROTECTED]); msg.setSubject(Test subject); PrintStream out = msg.getPrintStream(); out.println( test message line 1 ); out.println( test message line 2 ); msg.sendAndClose(); // % The important bit here is the out.println(). Perhaps something could be added to SimpleEmail to allow the message body to be built up line by line. Either a getPrintStream() method or perhaps an addMsg() method? Also, I feel that there is scope within commons-email for a mail class that doesn't use JavaMail and performs a best-efforts mail delivery. Indeed, this is pretty much what Ant's MailMessage class does. -- Michael - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] Work outstanding
Stephen Colebourne wrote: Work todo for 2.0: - Enum tests on Linux Hard for me to look at as I don't have Linux the junit tests all work on linux :-) martin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2003/08/03]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 3893|Opn|Enh|2001-10-01|Multiple element body parts problem | | 6508|Ass|Enh|2002-02-17|HttpClient now supports proxyHost and proxyPort - | | 6826|Ass|Enh|2002-03-04|Need to have xml files validated against DTDs as p| | 6829|Ass|Enh|2002-03-04|Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|DTD and DOM Validators| | 7135|Opn|Enh|2002-03-14|Misleading error message when beaninfo class confl| | 7226|Opn|Enh|2002-03-19|Nested Bean Collection| | 7367|New|Nor|2002-03-22|[unspecified] ServiceManager not actually serializ| | 7465|New|Nor|2002-03-25|Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| | 8140|Ver|Nor|2002-04-16|Incorrect credentials loop infinitely | |10319|New|Enh|2002-06-28|Instantiate property if null in form bean | |10543|Ass|Enh|2002-07-08|generate ant task automatically from CLI | |10790|New|Enh|2002-07-15|Non-standards configuration and tracking | |10792|New|Enh|2002-07-15|Plug-in authentication modules| |10793|New|Enh|2002-07-15|User definable default headers support| |10794|New|Enh|2002-07-15|User interaction for authentication | |10810|New|Enh|2002-07-15|Response handlers | |10813|New|Enh|2002-07-15|RFC 2965 Support (Port sensitive cookies) | |10815|New|Enh|2002-07-15|Instrumentation for Timings | |10818|Opn|Enh|2002-07-15|Add method enter() and exit() methods to public Lo| |10930|New|Enh|2002-07-18|J2EE FORM authentication (also affects pluggable a| |10957|New|Nor|2002-07-18|Change Header/HeaderElement to handle a list as th| |12807|New|Nor|2002-09-19|[PATCH] x 2 Update build.xml to use commons-loggin| |12858|Ass|Nor|2002-09-20|Style variation in CVS $Header$ tag in embedded LI| |12916|New|Nor|2002-09-23|[PATCH] Fix javadoc in RequestImpl.java | |12997|Opn|Nor|2002-09-25|Call the method as soon as the last parameter is e| |13031|New|Enh|2002-09-26|Use regular expression (regex) pattern matching fo| |13098|Opn|Nor|2002-09-27|Digester Performance | |13370|New|Nor|2002-10-07|[sql] DDL for INTEGER data type incorrect | |13381|New|Enh|2002-10-07|[sql] commons-sql database.xml - OJB repository.x| |13390|New|Nor|2002-10-07|ResponseHeaderHandler and ResponseHeaderValidator | |13426|New|Enh|2002-10-08|[PATCH] xml-reference.xml responseHeader addition | |13743|Opn|Enh|2002-10-17|Need getPropertyType(Class theClass, String propNa| |14036|New|Enh|2002-10-29|MultipartPostMethod does not check for error messa| |14262|Opn|Maj|2002-11-05|SAXBeanWriter produces invalid XML| |14278|New|Enh|2002-11-05|add link/info for Struts Console to website | |14394|Ver|Nor|2002-11-08|Excessive exceptions log under security manager | |14409|New|Nor|2002-11-09|Add support for stuff like [target [target2 [targe| |14667|Ver|Maj|2002-11-19|PropertyUtils.copyProperties does not copy to Dyna| |15046|Opn|Nor|2002-12-04|MissingArgumentException: no argument for option| |15082|Ass|Enh|2002-12-04|[lang] elapsed time formatting utility method | |15127|New|Enh|2002-12-06|Tests should explicit about checking serialization| |15297|New|Enh|2002-12-12|[HttpClient] Authenticator() - ability to perform | |15435|New|Enh|2002-12-17|New Preferences Architecture | |15451|Opn|Enh|2002-12-17|Multiple mapped properties not possible / Direct m| |15519|Ver|Maj|2002-12-19|PropertyUtils.getPropertyType() for java.util.Coll| |15534|New|Nor|2002-12-19|Inadequate HTTP proxy server support in HttpClient| |15542|New|Nor|2002-12-19|No Javadoc for HelpFormatter! | |15744|New|Nor|2002-12-31|[unspecified] Scaffold ResultSet used after statem| |15773|Opn|Nor|2003-01-03|setProperty throws exception on null value|
DO NOT REPLY [Bug 22091] New: - Adding tolerance to double[] search methods in ArrayUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091 Adding tolerance to double[] search methods in ArrayUtils Summary: Adding tolerance to double[] search methods in ArrayUtils Product: Commons Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Lang AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] It is sometimes useful to for the presence of a double within a given tolerance. For example, does this double[] array contain 3.054 +/- 0.001? The patch attached adds new methods which use the DoubleRange test elements of an array: ArrayUtils.indexOf(double[] array, double valueToFind, double tolerance) ArrayUtils.indexOf(double[] array, double valueToFind, int startIndex, double tolerance); ArrayUtils.lastIndexOf(double[] array, double valueToFind, int startIndex, double tolerance); ArrayUtils.contains(double[] array, double valueToFind, double tolerance); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22091] - Adding tolerance to double[] search methods in ArrayUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091 Adding tolerance to double[] search methods in ArrayUtils --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 14:58 --- Created an attachment (id=7631) tolerance search and unit tests patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22094] New: - A small, but important javadoc fix for Fraction proper whole and numerator
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094 A small, but important javadoc fix for Fraction proper whole and numerator Summary: A small, but important javadoc fix for Fraction proper whole and numerator Product: Commons Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Lang AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] A small fix, for the javadoc on getProperWhole and getProperNumerator. Doc said that -7/8 was improper and could be resolved to -1 3/4. The original fraction should have been -7/4. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22094] - A small, but important javadoc fix for Fraction proper whole and numerator
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094 A small, but important javadoc fix for Fraction proper whole and numerator --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 16:48 --- Created an attachment (id=7632) Simple javadoc patch for Fraction - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22046] - field validation for a list of fields
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22046. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22046 field validation for a list of fields [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21043] - javascript mask validator fails when field is disabled
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21043. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21043 javascript mask validator fails when field is disabled [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |commons- ||[EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Arg.java
dgraham 2003/08/03 10:13:55
Modified:validator/src/share/org/apache/commons/validator Arg.java
Log:
Formatting changes only.
Revision ChangesPath
1.10 +54 -53
jakarta-commons/validator/src/share/org/apache/commons/validator/Arg.java
Index: Arg.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/share/org/apache/commons/validator/Arg.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- Arg.java 25 May 2003 18:00:23 - 1.9
+++ Arg.java 3 Aug 2003 17:13:55 - 1.10
@@ -85,41 +85,39 @@
public class Arg implements Cloneable, Serializable {
/**
- * The name dependency that this argument goes with (optional).
- */
-protected String name = null;
-
-/**
* The key or value of the argument.
*/
protected String key = null;
/**
- * Whether or not the key is a message resource (optional). Defaults to true.
- * If it is 'true', the value will try to be resolved as a message resource.
+ * The name dependency that this argument goes with (optional).
*/
-protected boolean resource = true;
+protected String name = null;
/**
- * This argument's position in the message (ie. you would set postion=0 to make
- * a replacement in this string some msg {0}).
+ * This argument's position in the message (ie. you would set postion=0 to
+ * make a replacement in this string some msg {0}).
*/
protected int position = 0;
/**
- * Gets the name of the dependency.
- * @return the name of the dependency.
+ * Whether or not the key is a message resource (optional). Defaults to
+ * true. If it is 'true', the value will try to be resolved as a message
+ * resource.
*/
-public String getName() {
-return this.name;
-}
+protected boolean resource = true;
/**
- * Sets the name of the dependency.
- * @param name the name of the dependency.
+ * Creates and returns a copy of this object.
+ * @return A copy of this object.
*/
-public void setName(String name) {
-this.name = name;
+public Object clone() {
+try {
+return super.clone();
+
+} catch (CloneNotSupportedException e) {
+throw new InternalError(e.toString());
+}
}
/**
@@ -131,11 +129,18 @@
}
/**
- * Sets the key/value.
- * @param key They to access the argument.
+ * Gets the name of the dependency.
+ * @return the name of the dependency.
*/
-public void setKey(String key) {
-this.key = key;
+public String getName() {
+return this.name;
+}
+
+/**
+ * @return This argument's replacement position.
+ */
+public int getPosition() {
+return this.position;
}
/**
@@ -156,24 +161,34 @@
}
/**
- * Sets whether or not the key is a resource.
- * @param resource If true indicates the key is a resource.
+ * Sets the key/value.
+ * @param key They to access the argument.
*/
-public void setResource(boolean resource) {
-this.resource = resource;
+public void setKey(String key) {
+this.key = key;
}
/**
- * Creates and returns a copy of this object.
- * @return A copy of this object.
+ * Sets the name of the dependency.
+ * @param name the name of the dependency.
*/
-public Object clone() {
-try {
-return super.clone();
+public void setName(String name) {
+this.name = name;
+}
-} catch (CloneNotSupportedException e) {
-throw new InternalError(e.toString());
-}
+/**
+ * Set this argument's replacement position.
+ */
+public void setPosition(int position) {
+this.position = position;
+}
+
+/**
+ * Sets whether or not the key is a resource.
+ * @param resource If true indicates the key is a resource.
+ */
+public void setResource(boolean resource) {
+this.resource = resource;
}
/**
@@ -192,20 +207,6 @@
results.append(\n);
return results.toString();
-}
-
-/**
- * @return This argument's replacement position.
- */
-public int getPosition() {
-return this.position;
-}
-
-/**
- * Set this argument's replacement position.
- */
-public void setPosition(int position) {
-this.position = position;
}
}
-
To
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator MultipleTests.java TypeTest.java DoubleTest.java ByteTest.java LongTest.java FloatTest.java IntegerTest.java LocaleTest.java ShortTest.java RequiredIfTest.java EmailTest.java
dgraham 2003/08/03 10:39:11
Modified:validator/src/test/org/apache/commons/validator
MultipleTests.java TypeTest.java DoubleTest.java
ByteTest.java LongTest.java FloatTest.java
IntegerTest.java LocaleTest.java ShortTest.java
RequiredIfTest.java EmailTest.java
Log:
javadoc fixes only.
Revision ChangesPath
1.8 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/MultipleTests.java
Index: MultipleTests.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/MultipleTests.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- MultipleTests.java28 May 2003 04:28:00 - 1.7
+++ MultipleTests.java3 Aug 2003 17:39:11 - 1.8
@@ -126,7 +126,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-multipletest.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.10 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/TypeTest.java
Index: TypeTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/TypeTest.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- TypeTest.java 28 May 2003 04:28:00 - 1.9
+++ TypeTest.java 3 Aug 2003 17:39:11 - 1.10
@@ -129,7 +129,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-type.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.9 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/DoubleTest.java
Index: DoubleTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/DoubleTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- DoubleTest.java 28 May 2003 04:27:59 - 1.8
+++ DoubleTest.java 3 Aug 2003 17:39:11 - 1.9
@@ -127,7 +127,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-numeric.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.9 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/ByteTest.java
Index: ByteTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/ByteTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- ByteTest.java 28 May 2003 04:28:00 - 1.8
+++ ByteTest.java 3 Aug 2003 17:39:11 - 1.9
@@ -127,7 +127,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-numeric.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.9 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/LongTest.java
Index: LongTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/LongTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- LongTest.java 28 May 2003 04:28:00 - 1.8
+++ LongTest.java 3 Aug 2003 17:39:11 - 1.9
@@ -127,7 +127,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-numeric.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.9 +5 -5
jakarta-commons/validator/src/test/org/apache/commons/validator/FloatTest.java
Index: FloatTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/FloatTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- FloatTest.java28 May 2003 04:28:00 - 1.8
+++ FloatTest.java3 Aug 2003 17:39:11 - 1.9
@@ -127,7 +127,7 @@
/**
* Load codeValidatorResources/code from
-* validator-name-required.xml.
+* validator-numeric.xml.
*/
protected void setUp() throws IOException {
// Load resources
1.9 +5 -5
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator validator-name-required.xml
dgraham 2003/08/03 10:42:58
Modified:validator/src/share/org/apache/commons/validator Arg.java
Msg.java
validator/src/test/org/apache/commons/validator
validator-name-required.xml
Log:
Added bundle attribute to Arg and Msg to support alternate resource
bundles for PR# 17543.
Revision ChangesPath
1.11 +31 -6
jakarta-commons/validator/src/share/org/apache/commons/validator/Arg.java
Index: Arg.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/share/org/apache/commons/validator/Arg.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- Arg.java 3 Aug 2003 17:13:55 - 1.10
+++ Arg.java 3 Aug 2003 17:42:58 - 1.11
@@ -85,6 +85,13 @@
public class Arg implements Cloneable, Serializable {
/**
+ * The resource bundle name that this Arg's codekey/code should be
+ * resolved in (optional).
+ * @since Validator 1.1
+ */
+protected String bundle = null;
+
+/**
* The key or value of the argument.
*/
protected String key = null;
@@ -93,10 +100,11 @@
* The name dependency that this argument goes with (optional).
*/
protected String name = null;
-
+
/**
* This argument's position in the message (ie. you would set postion=0 to
* make a replacement in this string some msg {0}).
+ * @since Validator 1.1
*/
protected int position = 0;
@@ -121,6 +129,14 @@
}
/**
+ * Returns the resource bundle name.
+ * @since Validator 1.1
+ */
+public String getBundle() {
+return this.bundle;
+}
+
+/**
* Gets the key/value.
* @return the key value.
*/
@@ -151,13 +167,22 @@
public boolean getResource() {
return this.isResource();
}
-
+
/**
* Tests whether or not the key is a resource key or literal value.
* @return codetrue/code if key is a resource key.
*/
public boolean isResource() {
return this.resource;
+}
+
+/**
+ * Sets the resource bundle name.
+ * @param bundle The new bundle name.
+ * @since Validator 1.1
+ */
+public void setBundle(String bundle) {
+this.bundle = bundle;
}
/**
1.7 +52 -28
jakarta-commons/validator/src/share/org/apache/commons/validator/Msg.java
Index: Msg.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/share/org/apache/commons/validator/Msg.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- Msg.java 25 May 2003 18:18:31 - 1.6
+++ Msg.java 3 Aug 2003 17:42:58 - 1.7
@@ -75,11 +75,13 @@
* @version $Revision$ $Date$
*/
public class Msg implements Cloneable, Serializable {
-
+
/**
- * The name dependency that this argument goes with (optional).
+ * The resource bundle name that this Msg's codekey/code should be
+ * resolved in (optional).
+ * @since Validator 1.1
*/
-protected String name = null;
+protected String bundle = null;
/**
* The key or value of the argument.
@@ -87,58 +89,80 @@
protected String key = null;
/**
+ * The name dependency that this argument goes with (optional).
+ */
+protected String name = null;
+
+/**
+ * Returns the resource bundle name.
+ * @since Validator 1.1
+ */
+public String getBundle() {
+return this.bundle;
+}
+
+/**
+ * Sets the resource bundle name.
+ * @param bundle The new bundle name.
+ * @since Validator 1.1
+ */
+public void setBundle(String bundle) {
+this.bundle = bundle;
+}
+
+/**
* Gets the name of the dependency.
*/
public String getName() {
- return name;
+return name;
}
/**
* Sets the name of the dependency.
*/
public void setName(String name) {
- this.name = name;
+this.name = name;
}
-
+
/**
* Gets the key/value.
*/
public String getKey() {
- return key;
+return key;
}
/**
* Sets the key/value.
*/
public void setKey(String key) {
- this.key = key;
+this.key = key;
}
/**
* Creates and returns a copy of this object.
*/
public Object clone() {
- try {
- return super.clone();
+try {
+return super.clone();
- }
cvs commit: jakarta-commons/validator/conf/share validator_1_1.dtd
dgraham 2003/08/03 10:43:17 Modified:validator/conf/share validator_1_1.dtd Log: Added bundle attribute to Arg and Msg to support alternate resource bundles for PR# 17543. Revision ChangesPath 1.4 +7 -1 jakarta-commons/validator/conf/share/validator_1_1.dtd Index: validator_1_1.dtd === RCS file: /home/cvs/jakarta-commons/validator/conf/share/validator_1_1.dtd,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- validator_1_1.dtd 25 May 2003 18:00:24 - 1.3 +++ validator_1_1.dtd 3 Aug 2003 17:43:17 - 1.4 @@ -126,6 +126,8 @@ The msg element accepts these attributes. nameThe name of the validator corresponding to this msg. + + bundle The resource bundle name that the key should be resolved in. key The key that will return the message template from a resource bundle. @@ -135,6 +137,7 @@ [true] -- !ELEMENT msg EMPTY +!ATTLIST msg bundle CDATA #IMPLIED !ATTLIST msg name CDATA #IMPLIED !ATTLIST msg key CDATA #IMPLIED !ATTLIST msg resource CDATA #IMPLIED @@ -149,6 +152,8 @@ nameThe name of the validator corresponding to this msg. If not supplied, this argument will be used in the given position for every validator. + + bundle The resource bundle name that the key should be resolved in. key The key that will return the message template from a resource bundle. @@ -163,6 +168,7 @@ -- !ELEMENT arg EMPTY !ATTLIST arg key CDATA #REQUIRED +!ATTLIST msg bundle CDATA #IMPLIED !ATTLIST arg name CDATA #IMPLIED !ATTLIST arg resource CDATA #IMPLIED !ATTLIST arg position CDATA #IMPLIED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17543] - Add support for non-default resource bundles
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17543. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17543 Add support for non-default resource bundles [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 17:46 --- arg and msg now support a bundle attribute. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20579] - GenericValidator.isEmail() fails for address toto@web.de./de
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20579. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20579 GenericValidator.isEmail() fails for address [EMAIL PROTECTED]/de [EMAIL PROTECTED] changed: What|Removed |Added Summary|org.apache.commons.validator|GenericValidator.isEmail() |.GenericValidator.isEmail |fails for address |validator fails for address |[EMAIL PROTECTED]/de |[EMAIL PROTECTED]/de | - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HttpMethod.java HttpMethodBase.java
olegk 2003/08/03 14:59:13 Modified:httpclient/src/java/org/apache/commons/httpclient HttpMethod.java HttpMethodBase.java Log: Javadocs clean-up in HttpMethod HttpMethodBase Contributed by Oleg Kalnicvhevski Revision ChangesPath 1.26 +19 -14 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java Index: HttpMethod.java === RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java,v retrieving revision 1.25 retrieving revision 1.26 diff -u -r1.25 -r1.26 --- HttpMethod.java 2 Aug 2003 22:26:55 - 1.25 +++ HttpMethod.java 3 Aug 2003 21:59:13 - 1.26 @@ -86,7 +86,7 @@ // --- Property Setters and Getters /** - * Obtain the name of the HTTP method as used in the HTTP request line, + * Obtains the name of the HTTP method as used in the HTTP request line, * for example ttGET/tt or ttPOST/tt. * * @return the name of this method @@ -102,8 +102,11 @@ /** * Sets the path of the HTTP method. + * It is responsibility of the caller to ensure that the path is + * properly encoded (URL safe). * - * @param path the path of the HTTP method + * @param path the path of the HTTP method. The path is expected + *to be URL-encoded */ void setPath(String path); @@ -114,7 +117,7 @@ * return the emactual/em path, following any redirects automatically * handled by this HTTP method. * - * @return the path to request + * @return the path of the HTTP method */ String getPath(); @@ -138,12 +141,13 @@ void setURI(URI uri) throws URIException; /** - * pTurns strict mode on or off. In the strict mode the HTTP method exactly - * follows the HTTP specification. In the non-strict mode the HTTP method attempts - * to violate the specification in the same way that most HTTP user agent's do - * (and, unfortunately, as many HTTP servers expect)./p - * - * @param strictMode tttrue/tt to enable the strict mode. + * Defines how strictly the method follows the HTTP protocol specification + * (RFC 2616 and other relevant RFCs). In the strict mode the method precisely + * implements the requirements of the specification, whereas in non-strict mode + * it attempts to mimic the exact behaviour of commonly used HTTP agents, + * which many HTTP servers expect. + * + * @param strictMode tttrue/tt for strict mode, ttfalse/tt otherwise */ void setStrictMode(boolean strictMode); @@ -343,7 +347,8 @@ * Execute the HTTP method. * * @param state the [EMAIL PROTECTED] HttpState state} information to associate with this method - * @param connection the [EMAIL PROTECTED] HttpConnection connection} to be used + * @param connection the [EMAIL PROTECTED] HttpConnection connection} used to execute + *this HTTP method * * @throws IOException if an I/O (transport) error occurs. Some transport exceptions * can be recovered from. 1.175 +405 -343 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java Index: HttpMethodBase.java === RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java,v retrieving revision 1.174 retrieving revision 1.175 diff -u -r1.174 -r1.175 --- HttpMethodBase.java 30 Jul 2003 21:11:17 - 1.174 +++ HttpMethodBase.java 3 Aug 2003 21:59:13 - 1.175 @@ -151,37 +151,38 @@ // - Instance variables -/** My request headers, if any. */ +/** Request headers, if any. */ private HeaderGroup requestHeaders = new HeaderGroup(); /** The Status-Line from the response. */ private StatusLine statusLine = null; -/** My response headers, if any. */ +/** Response headers, if any. */ private HeaderGroup responseHeaders = new HeaderGroup(); -/** My response trailer headers, if any. */ +/** Response trailer headers, if any. */ private HeaderGroup responseTrailerHeaders = new HeaderGroup(); -/** Realms that we tried to authenticate to */ +/** Realms this method tried to authenticate to */ private Set realms = null; /** Actual authentication realm */ private String realm = null; -/** Proxy Realms that we tried to authenticate to */ +/** Proxy Realms this method tried to
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HttpMethod.java HttpMethodBase.java
olegk 2003/08/03 15:01:32 Modified:httpclient/src/java/org/apache/commons/httpclient Tag: HTTPCLIENT_2_0_BRANCH HttpMethod.java HttpMethodBase.java Log: Javadocs clean-up in HttpMethod HttpMethodBase Contributed by Oleg Kalnichevski Revision ChangesPath No revision No revision 1.23.2.2 +19 -14 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java Index: HttpMethod.java === RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethod.java,v retrieving revision 1.23.2.1 retrieving revision 1.23.2.2 diff -u -r1.23.2.1 -r1.23.2.2 --- HttpMethod.java 2 Aug 2003 22:27:49 - 1.23.2.1 +++ HttpMethod.java 3 Aug 2003 22:01:31 - 1.23.2.2 @@ -86,7 +86,7 @@ // --- Property Setters and Getters /** - * Obtain the name of the HTTP method as used in the HTTP request line, + * Obtains the name of the HTTP method as used in the HTTP request line, * for example ttGET/tt or ttPOST/tt. * * @return the name of this method @@ -102,8 +102,11 @@ /** * Sets the path of the HTTP method. + * It is responsibility of the caller to ensure that the path is + * properly encoded (URL safe). * - * @param path the path of the HTTP method + * @param path the path of the HTTP method. The path is expected + *to be URL-encoded */ void setPath(String path); @@ -114,7 +117,7 @@ * return the emactual/em path, following any redirects automatically * handled by this HTTP method. * - * @return the path to request + * @return the path of the HTTP method */ String getPath(); @@ -129,12 +132,13 @@ URI getURI() throws URIException; /** - * pTurns strict mode on or off. In the strict mode the HTTP method exactly - * follows the HTTP specification. In the non-strict mode the HTTP method attempts - * to violate the specification in the same way that most HTTP user agent's do - * (and, unfortunately, as many HTTP servers expect)./p - * - * @param strictMode tttrue/tt to enable the strict mode. + * Defines how strictly the method follows the HTTP protocol specification + * (RFC 2616 and other relevant RFCs). In the strict mode the method precisely + * implements the requirements of the specification, whereas in non-strict mode + * it attempts to mimic the exact behaviour of commonly used HTTP agents, + * which many HTTP servers expect. + * + * @param strictMode tttrue/tt for strict mode, ttfalse/tt otherwise */ void setStrictMode(boolean strictMode); @@ -336,7 +340,8 @@ * Execute the HTTP method. * * @param state the [EMAIL PROTECTED] HttpState state} information to associate with this method - * @param connection the [EMAIL PROTECTED] HttpConnection connection} to be used + * @param connection the [EMAIL PROTECTED] HttpConnection connection} used to execute + *this HTTP method * * @throws IOException if an I/O (transport) error occurs. Some transport exceptions * can be recovered from. 1.159.2.6 +438 -359 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java Index: HttpMethodBase.java === RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpMethodBase.java,v retrieving revision 1.159.2.5 retrieving revision 1.159.2.6 diff -u -r1.159.2.5 -r1.159.2.6 --- HttpMethodBase.java 26 Jul 2003 14:07:34 - 1.159.2.5 +++ HttpMethodBase.java 3 Aug 2003 22:01:31 - 1.159.2.6 @@ -161,37 +161,38 @@ // - Instance variables -/** My request headers, if any. */ +/** Request headers, if any. */ private HeaderGroup requestHeaders = new HeaderGroup(); /** The Status-Line from the response. */ private StatusLine statusLine = null; -/** My response headers, if any. */ +/** Response headers, if any. */ private HeaderGroup responseHeaders = new HeaderGroup(); -/** My response trailer headers, if any. */ +/** Response trailer headers, if any. */ private HeaderGroup responseTrailerHeaders = new HeaderGroup(); -/** Realms that we tried to authenticate to */ +/** Realms this method tried to authenticate to */ private Set realms = null; /** Actual
DO NOT REPLY [Bug 22095] New: - [lang] Javadoc, tests improvements for CharSet, CharSetUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22095. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22095 [lang] Javadoc, tests improvements for CharSet, CharSetUtils Summary: [lang] Javadoc, tests improvements for CharSet, CharSetUtils Product: Commons Version: Nightly Builds Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Lang AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The attached patch makes some small improvements to the javadoc for CharSet, CharSetUtils, adds some more test cases for CharSet and modifies the tests in CharSetTest to use assertTrue(*) instead of assertEquals(true,*). One syntactical ambiguity is shown in the new test cases: ^-a is ambiguous. Currently, this produces two CharRanges, ^- and a. On the other hand, a-^ is interpreted as the range from '^' to 'a' (the other interpretation of ^-a). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22095] - [lang] Javadoc, tests improvements for CharSet, CharSetUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22095. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22095 [lang] Javadoc, tests improvements for CharSet, CharSetUtils --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 22:45 --- Created an attachment (id=7634) Patch for CharSet, CharSetUtils - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/math Fraction.java
scolebourne2003/08/03 15:43:03 Modified:lang/src/java/org/apache/commons/lang/math Fraction.java Log: Javadoc fixes bug 22094, from Tim O'Brien Revision ChangesPath 1.6 +7 -6 jakarta-commons/lang/src/java/org/apache/commons/lang/math/Fraction.java Index: Fraction.java === RCS file: /home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/math/Fraction.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- Fraction.java 26 Jul 2003 00:57:02 - 1.5 +++ Fraction.java 3 Aug 2003 22:43:03 - 1.6 @@ -64,6 +64,7 @@ * * @author Travis Reeder * @author Stephen Colebourne + * @author Tim O'Brien * @since 2.0 * @version $Id$ */ @@ -331,7 +332,7 @@ * pGets the numerator part of the fraction./p * * pThis method may return a value greater than the denominator, an - * improper fraction, such as the seven in 7/8./p + * improper fraction, such as the seven in 7/4./p * * @return the numerator fraction part */ @@ -351,10 +352,10 @@ /** * pGets the proper numerator, always positive./p * - * pAn improper fraction 7/8 can be resolved into a proper one, 1 3/4. + * pAn improper fraction 7/4 can be resolved into a proper one, 1 3/4. * This method returns the 3 from the proper fraction./p * - * pIf the fraction is negative such as -7/8, it can be resolved into + * pIf the fraction is negative such as -7/4, it can be resolved into * -1 3/4, so this method returns the positive proper numerator, 3./p * * @return the numerator fraction part of a proper fraction, always positive @@ -366,10 +367,10 @@ /** * pGets the proper whole part of the fraction./p * - * pAn improper fraction 7/8 can be resolved into a proper one, 1 3/4. + * pAn improper fraction 7/4 can be resolved into a proper one, 1 3/4. * This method returns the 1 from the proper fraction./p * - * pIf the fraction is negative such as -7/8, it can be resolved into + * pIf the fraction is negative such as -7/4, it can be resolved into * -1 3/4, so this method returns the positive whole part -1./p * * @return the whole fraction part of a proper fraction, that includes the sign - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[lang] DateUtils round and truncate functionality with Calendar.AM_PM
Does anyone know how the DateUtils methods round and truncate are suppose to behave when passed Calendar.AM_PM? I've tried several combinations of round, and they all seem to truncate instead. There is nothing in the Javadocs for these methods about the expected result, and I'm not able to tell if the methods are working properly. Steven Caswell [EMAIL PROTECTED] In our own native land, in defense of the freedom that is our birthright, and which we ever enjoyed till the late violation of it -- for the protection of our property, acquired solely by the honest industry of our fore-fathers and ourselves, against violence actually offered, we have taken up arms. We shall lay them down when hostilities shall cease on the part of the aggressors, and all danger of their being renewed shall be removed, and not before. - Thomas Jefferson
DO NOT REPLY [Bug 22094] - A small, but important javadoc fix for Fraction proper whole and numerator
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094 A small, but important javadoc fix for Fraction proper whole and numerator [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 22:45 --- Patch applied. Good catch. Thanks - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22094] - A small, but important javadoc fix for Fraction proper whole and numerator
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22094 A small, but important javadoc fix for Fraction proper whole and numerator [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[lang] DateUtils parseCVS with time format
One of the supported formats for input to parseCVS is h:mm z. The method parses the time correctly, but the date is left as the default of January 1, 1970. Does this make sense, or does it make sense to have it fill in the current date? Since the API is silent on the expected behavior, it is difficult to test the API for correctness. Steven Caswell [EMAIL PROTECTED] In our own native land, in defense of the freedom that is our birthright, and which we ever enjoyed till the late violation of it -- for the protection of our property, acquired solely by the honest industry of our fore-fathers and ourselves, against violence actually offered, we have taken up arms. We shall lay them down when hostilities shall cease on the part of the aggressors, and all danger of their being renewed shall be removed, and not before. - Thomas Jefferson
cvs commit: jakarta-commons/lang/src/test/org/apache/commons/lang ArrayUtilsTest.java
scolebourne2003/08/03 16:29:19
Modified:lang/src/java/org/apache/commons/lang ArrayUtils.java
lang/src/test/org/apache/commons/lang ArrayUtilsTest.java
Log:
Add tolerance checking to indexOf methods
bug 22091, from Tim O'Brien
Revision ChangesPath
1.22 +127 -7
jakarta-commons/lang/src/java/org/apache/commons/lang/ArrayUtils.java
Index: ArrayUtils.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/ArrayUtils.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- ArrayUtils.java 1 Aug 2003 20:45:17 - 1.21
+++ ArrayUtils.java 3 Aug 2003 23:29:19 - 1.22
@@ -75,6 +75,7 @@
* @author a href=mailto:[EMAIL PROTECTED]Fredrik Westermarck/a
* @author Nikolay Metchev
* @author Matthew Hawthorne
+ * @author Tim O'Brien
* @since 2.0
* @version $Id$
*/
@@ -1376,6 +1377,23 @@
}
/**
+ * pFind the index of the given value within a given tolerance in the array.
+ * This method will return the index of the first value which falls between the
region
+ * defined by valueToFind - tolerance and valueToFind + tolerance./p
+ *
+ * pThis method returns code-1/code if codenull/code array input./p
+ *
+ * @param array the array to search through for the object, may be
codenull/code
+ * @param valueToFind the value to find
+ * @param tolerance tolerance of the search
+ * @return the index of the value within the array,
+ * code-1/code if not found or codenull/code array input
+ */
+public static int indexOf(final double[] array, final double valueToFind, final
double tolerance) {
+return indexOf(array, valueToFind, 0, tolerance);
+}
+
+/**
* pFind the index of the given value in the array starting at the given
index./p
*
* pThis method returns code-1/code if codenull/code array input./p
@@ -1390,7 +1408,7 @@
* code-1/code if not found or codenull/code array input
*/
public static int indexOf(final double[] array, final double valueToFind, int
startIndex) {
-if (array == null) {
+if (array == null || array.length == 0) {
return -1;
}
if (startIndex 0) {
@@ -1405,6 +1423,40 @@
}
/**
+ * pFind the index of the given value in the array starting at the given
index.
+ * This method will return the index of the first value which falls between the
region
+ * defined by valueToFind - tolerance and valueToFind + tolerance./p
+ *
+ * pThis method returns code-1/code if codenull/code array input./p
+ *
+ * pA negative startIndex is treated as zero. A startIndex larger than the
array
+ * length will return -1./p
+ *
+ * @param array the array to search through for the object, may be
codenull/code
+ * @param valueToFind the value to find
+ * @param startIndex the index to start searching at
+ * @param tolerance tolerance of the search
+ * @return the index of the value within the array,
+ * code-1/code if not found or codenull/code array input
+ */
+public static int indexOf(final double[] array, final double valueToFind, int
startIndex, double tolerance) {
+if (array == null || array.length == 0) {
+return -1;
+}
+if (startIndex 0) {
+startIndex = 0;
+}
+double min = valueToFind - tolerance;
+double max = valueToFind + tolerance;
+for (int i = startIndex; i array.length; i++) {
+if (array[i] = min array[i] = max) {
+return i;
+}
+}
+return -1;
+}
+
+/**
* pFind the last index of the given value within the array./p
*
* pThis method returns code-1/code if codenull/code array input./p
@@ -1419,6 +1471,23 @@
}
/**
+ * pFind the last index of the given value within a given tolerance in the
array.
+ * This method will return the index of the last value which falls between the
region
+ * defined by valueToFind - tolerance and valueToFind + tolerance./p
+ *
+ * pThis method returns code-1/code if codenull/code array input./p
+ *
+ * @param array the array to search through for the object, may be
codenull/code
+ * @param valueToFind the value to find
+ * @param tolerance tolerance of the search
+ * @return the index of the value within the array,
+ * code-1/code if not found or codenull/code array input
+ */
+public static int lastIndexOf(final double[] array, final double valueToFind,
final double tolerance) {
+return
DO NOT REPLY [Bug 22091] - Adding tolerance to double[] search methods in ArrayUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091 Adding tolerance to double[] search methods in ArrayUtils [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 23:32 --- Patch committed with changes, thanks. (Please no tabs!) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22091] - Adding tolerance to double[] search methods in ArrayUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22091 Adding tolerance to double[] search methods in ArrayUtils [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] DateUtils round and truncate functionality with Calendar.AM_PM
I don't know what it should do offhand. Perhaps you could suggest sensible behaviour? Stephen - Original Message - From: Steven Caswell [EMAIL PROTECTED] Does anyone know how the DateUtils methods round and truncate are suppose to behave when passed Calendar.AM_PM? I've tried several combinations of round, and they all seem to truncate instead. There is nothing in the Javadocs for these methods about the expected result, and I'm not able to tell if the methods are working properly. Steven Caswell [EMAIL PROTECTED] In our own native land, in defense of the freedom that is our birthright, and which we ever enjoyed till the late violation of it -- for the protection of our property, acquired solely by the honest industry of our fore-fathers and ourselves, against violence actually offered, we have taken up arms. We shall lay them down when hostilities shall cease on the part of the aggressors, and all danger of their being renewed shall be removed, and not before. - Thomas Jefferson - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [lang] DateUtils round and truncate functionality with Calendar.AM_PM
I don't know that rounding to AM_PM makes sense. I'm having a difficult time coming up with any rounding scenario that makes sense. I think it makes sense to say that the boundary is 12:00PM, and that times before that value cause round down, and times after that value cause round up. But what does round down mean? What does round up mean? Maybe someone who has a use case for this functionality can provide a good suggestion. Steven Caswell [EMAIL PROTECTED] a.k.a Mungo Knotwise of Michel Delving One ring to rule them all, one ring to find them... -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Sunday, August 03, 2003 6:32 PM To: Jakarta Commons Developers List; [EMAIL PROTECTED] Subject: Re: [lang] DateUtils round and truncate functionality with Calendar.AM_PM I don't know what it should do offhand. Perhaps you could suggest sensible behaviour? Stephen - Original Message - From: Steven Caswell [EMAIL PROTECTED] Does anyone know how the DateUtils methods round and truncate are suppose to behave when passed Calendar.AM_PM? I've tried several combinations of round, and they all seem to truncate instead. There is nothing in the Javadocs for these methods about the expected result, and I'm not able to tell if the methods are working properly. Steven Caswell [EMAIL PROTECTED] In our own native land, in defense of the freedom that is our birthright, and which we ever enjoyed till the late violation of it -- for the protection of our property, acquired solely by the honest industry of our fore-fathers and ourselves, against violence actually offered, we have taken up arms. We shall lay them down when hostilities shall cease on the part of the aggressors, and all danger of their being renewed shall be removed, and not before. - Thomas Jefferson - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] DateUtils parseCVS with time format
Steven Caswell wrote: One of the supported formats for input to parseCVS is h:mm z. The method parses the time correctly, but the date is left as the default of January 1, 1970. Does this make sense, or does it make sense to have it fill in the current date? Since the API is silent on the expected behavior, it is difficult to test the API for correctness. Do you know how CVS works? does it set the date as that time in the last 24 hours, or does it always set today's date? There are some unit tests that are based on the current time, so I can put together unit tests and correct this behavior once I'm sure what it should be. -- Serge Knystautas President Lokitech software . strategy . design http://www.lokitech.com/ p. 1.301.656.5501 e. [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] DateUtils round and truncate functionality with Calendar.AM_PM
Steven Caswell wrote: I don't know that rounding to AM_PM makes sense. I'm having a difficult time coming up with any rounding scenario that makes sense. I think it makes sense to say that the boundary is 12:00PM, and that times before that value cause round down, and times after that value cause round up. But what does round down mean? What does round up mean? Maybe someone who has a use case for this functionality can provide a good suggestion. Here's how I approached most of this logic... I treated truncating and rounding functions as eliminating all units below this order of specificity. How to apply this to AM_PM? Well, you'd keep the day unit and drop the hours unit. So aside from the date, the two possible values are: AM, 0 hours, 0 minutes, 0 sec, 0 ms. PM, 0 hours, 0 minutes, 0 sec, 0 ms. The first case is somewhat straight-forward... 0 hour is equivalent to 12:00 AM. The second case is a bit more confusing, but to be parallel, I would say it should be 12:00 PM. So truncating would have 12:00 AM to 11:59:59.999 AM - 12:00 AM, and 12:00 PM to 11:59:59.999 PM - 12:00 PM. Rounding would then have 6:00 PM to 5:59:59.999 AM - 12:00 AM and 6:00 AM to 5:59:59.999 PM - 12:00 PM. (I believe our convention is to always round up, so 6:00 AM - 12:00 PM). Does this make sense? Probably not a very commonly used case, but seems like we should have predictable behavior is someone passes this unit. Or conversely it could throw an exception with an unanticipated time unit? -- Serge Knystautas President Lokitech software . strategy . design http://www.lokitech.com/ p. 1.301.656.5501 e. [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] DateUtils round and truncate functionality with Calendar.AM_PM
Best guess: roundDown 01:30 goes to 00:00 roundUp 01:30 goes to 12:00 roundDown 13:30 goes to 12:00 roundUp 13:30 goes to 00:00 next day Stephen - Original Message - From: Steven Caswell [EMAIL PROTECTED] To: 'Jakarta Commons Developers List' [EMAIL PROTECTED] Sent: Monday, August 04, 2003 12:45 AM Subject: RE: [lang] DateUtils round and truncate functionality with Calendar.AM_PM I don't know that rounding to AM_PM makes sense. I'm having a difficult time coming up with any rounding scenario that makes sense. I think it makes sense to say that the boundary is 12:00PM, and that times before that value cause round down, and times after that value cause round up. But what does round down mean? What does round up mean? Maybe someone who has a use case for this functionality can provide a good suggestion. Steven Caswell [EMAIL PROTECTED] a.k.a Mungo Knotwise of Michel Delving One ring to rule them all, one ring to find them... -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Sunday, August 03, 2003 6:32 PM To: Jakarta Commons Developers List; [EMAIL PROTECTED] Subject: Re: [lang] DateUtils round and truncate functionality with Calendar.AM_PM I don't know what it should do offhand. Perhaps you could suggest sensible behaviour? Stephen - Original Message - From: Steven Caswell [EMAIL PROTECTED] Does anyone know how the DateUtils methods round and truncate are suppose to behave when passed Calendar.AM_PM? I've tried several combinations of round, and they all seem to truncate instead. There is nothing in the Javadocs for these methods about the expected result, and I'm not able to tell if the methods are working properly. Steven Caswell [EMAIL PROTECTED] In our own native land, in defense of the freedom that is our birthright, and which we ever enjoyed till the late violation of it -- for the protection of our property, acquired solely by the honest industry of our fore-fathers and ourselves, against violence actually offered, we have taken up arms. We shall lay them down when hostilities shall cease on the part of the aggressors, and all danger of their being renewed shall be removed, and not before. - Thomas Jefferson - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] DateUtils parseCVS with time format
I don't know the CVS answer, but todays date makes more sense here. Stephen - Original Message - From: Serge Knystautas [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Monday, August 04, 2003 12:46 AM Subject: Re: [lang] DateUtils parseCVS with time format Steven Caswell wrote: One of the supported formats for input to parseCVS is h:mm z. The method parses the time correctly, but the date is left as the default of January 1, 1970. Does this make sense, or does it make sense to have it fill in the current date? Since the API is silent on the expected behavior, it is difficult to test the API for correctness. Do you know how CVS works? does it set the date as that time in the last 24 hours, or does it always set today's date? There are some unit tests that are based on the current time, so I can put together unit tests and correct this behavior once I'm sure what it should be. -- Serge Knystautas President Lokitech software . strategy . design http://www.lokitech.com/ p. 1.301.656.5501 e. [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/jrcs/src/test/org/apache/commons/jrcs/diff DiffTest.java
juanco 2003/08/03 17:04:50
Modified:jrcs/src/java/org/apache/commons/jrcs/diff Diff.java
jrcs/src/test/org/apache/commons/jrcs/diff DiffTest.java
Log:
BUG: Diff crashed with two empty sequences as input. Fixed, with test cases added.
Revision ChangesPath
1.15 +5 -2
jakarta-commons-sandbox/jrcs/src/java/org/apache/commons/jrcs/diff/Diff.java
Index: Diff.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/jrcs/src/java/org/apache/commons/jrcs/diff/Diff.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- Diff.java 10 May 2003 18:55:10 - 1.14
+++ Diff.java 4 Aug 2003 00:04:50 - 1.15
@@ -194,7 +194,10 @@
public Revision diff(Object[] rev)
throws DifferentiationFailedException
{
-return algorithm.diff(orig, rev);
+if (orig.length == 0 rev.length == 0)
+return new Revision();
+else
+return algorithm.diff(orig, rev);
}
/**
1.12 +33 -1
jakarta-commons-sandbox/jrcs/src/test/org/apache/commons/jrcs/diff/DiffTest.java
Index: DiffTest.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/jrcs/src/test/org/apache/commons/jrcs/diff/DiffTest.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- DiffTest.java 26 May 2003 18:14:49 - 1.11
+++ DiffTest.java 4 Aug 2003 00:04:50 - 1.12
@@ -62,7 +62,7 @@
public abstract class DiffTest
extends TestCase
{
-static final int LARGE=4*1024;
+static final int LARGE=2*1024;
protected DiffAlgorithm algorithm;
@@ -122,6 +122,38 @@
assertTrue(!Diff.compare(empty, original));
assertTrue(Diff.compare(empty, empty));
assertTrue(Diff.compare(original, original));
+}
+
+public void testEmptySequences()
+throws DifferentiationFailedException
+{
+String[] emptyOrig = {};
+String[] emptyRev = {};
+Revision revision = Diff.diff(emptyOrig, emptyRev, algorithm);
+
+assertEquals(revision size is not zero, 0, revision.size());
+}
+
+public void testOriginalEmpty()
+throws DifferentiationFailedException
+{
+String[] emptyOrig = {};
+String[] rev = {1, 2, 3};
+Revision revision = Diff.diff(emptyOrig, rev, algorithm);
+
+assertEquals(revision size should be one, 1, revision.size());
+assertTrue(revision.getDelta(0) instanceof AddDelta);
+}
+
+public void testRevisedEmpty()
+throws DifferentiationFailedException
+{
+String[] orig = {1, 2, 3};
+String[] emptyRev = {};
+Revision revision = Diff.diff(orig, emptyRev, algorithm);
+
+assertEquals(revision size should be one, 1, revision.size());
+assertTrue(revision.getDelta(0) instanceof DeleteDelta);
}
public void testDeleteAll()
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/test/org/apache/commons/lang/math IntRangeTest.java FloatRangeTest.java LongRangeTest.java DoubleRangeTest.java NumberRangeTest.java AbstractRangeTest.java
scolebourne2003/08/03 18:14:02
Modified:lang/src/java/org/apache/commons/lang/math Range.java
IntRange.java NumberRange.java FloatRange.java
LongRange.java DoubleRange.java
lang/src/test/org/apache/commons/lang/math IntRangeTest.java
FloatRangeTest.java LongRangeTest.java
DoubleRangeTest.java NumberRangeTest.java
AbstractRangeTest.java
Log:
Rename includeXxx() to containsXxx()
for consistency with rest of [lang] and Java
Revision ChangesPath
1.4 +27 -27
jakarta-commons/lang/src/java/org/apache/commons/lang/math/Range.java
Index: Range.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/math/Range.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Range.java24 Jun 2003 21:14:50 - 1.3
+++ Range.java4 Aug 2003 01:14:01 - 1.4
@@ -203,7 +203,7 @@
* @return codetrue/code if the specified number occurs within this range
* @throws IllegalArgumentException if the codeNumber/code cannot be
compared
*/
-public abstract boolean includesNumber(Number number);
+public abstract boolean containsNumber(Number number);
/**
* pTests whether the specified codeNumber/code occurs within
@@ -211,17 +211,17 @@
*
* pcodenull/code is handled and returns codefalse/code./p
*
- * pThis implementation forwards to the [EMAIL PROTECTED]
#includesLong(long)} method./p
+ * pThis implementation forwards to the [EMAIL PROTECTED]
#containsLong(long)} method./p
*
* @param value the long to test, may be codenull/code
* @return codetrue/code if the specified number occurs within this
* range by codelong/code comparison
*/
-public boolean includesLong(Number value) {
+public boolean containsLong(Number value) {
if (value == null) {
return false;
}
-return includesLong(value.longValue());
+return containsLong(value.longValue());
}
/**
@@ -235,7 +235,7 @@
* @return codetrue/code if the specified number occurs within this
* range by codelong/code comparison
*/
-public boolean includesLong(long value) {
+public boolean containsLong(long value) {
return (value = getMinimumLong() value = getMaximumLong());
}
@@ -245,17 +245,17 @@
*
* pcodenull/code is handled and returns codefalse/code./p
*
- * pThis implementation forwards to the [EMAIL PROTECTED]
#includesInteger(int)} method./p
+ * pThis implementation forwards to the [EMAIL PROTECTED]
#containsInteger(int)} method./p
*
* @param value the integer to test, may be codenull/code
* @return codetrue/code if the specified number occurs within this
* range by codeint/code comparison
*/
-public boolean includesInteger(Number value) {
+public boolean containsInteger(Number value) {
if (value == null) {
return false;
}
-return includesInteger(value.intValue());
+return containsInteger(value.intValue());
}
/**
@@ -269,7 +269,7 @@
* @return codetrue/code if the specified number occurs within this
* range by codeint/code comparison
*/
-public boolean includesInteger(int value) {
+public boolean containsInteger(int value) {
return (value = getMinimumInteger() value = getMaximumInteger());
}
@@ -279,17 +279,17 @@
*
* pcodenull/code is handled and returns codefalse/code./p
*
- * pThis implementation forwards to the [EMAIL PROTECTED]
#includesDouble(double)} method./p
+ * pThis implementation forwards to the [EMAIL PROTECTED]
#containsDouble(double)} method./p
*
* @param value the double to test, may be codenull/code
* @return codetrue/code if the specified number occurs within this
* range by codedouble/code comparison
*/
-public boolean includesDouble(Number value) {
+public boolean containsDouble(Number value) {
if (value == null) {
return false;
}
-return includesDouble(value.doubleValue());
+return containsDouble(value.doubleValue());
}
/**
@@ -303,7 +303,7 @@
* @return codetrue/code if the specified number occurs within this
* range by codedouble/code comparison
*/
-public boolean includesDouble(double value) {
+public boolean containsDouble(double value) {
int compareMin = NumberUtils.compare(getMinimumDouble(), value);
Re: [lang] DateUtils parseCVS with time format
The parseCVS h:mm z now fails on my PC. Locale en_GB, timezone Europe/London. GMT+01:00 Stephen - Original Message - From: Steven Caswell [EMAIL PROTECTED] To: 'Jakarta Commons Developers List' [EMAIL PROTECTED] Sent: Monday, August 04, 2003 1:11 AM Subject: RE: [lang] DateUtils parseCVS with time format And I should have said that I don't know the CVS behavior either. So I guess the next question is how closely should we try to mimic the CVS format, given that this is the parseCVS method. Are we trying to approximate the behavior, or do we believe someone will need it to behave as it were strictly compliant to CVS behavior? Steven Caswell [EMAIL PROTECTED] a.k.a Mungo Knotwise of Michel Delving One ring to rule them all, one ring to find them... -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Sunday, August 03, 2003 6:58 PM To: Jakarta Commons Developers List Subject: Re: [lang] DateUtils parseCVS with time format I don't know the CVS answer, but todays date makes more sense here. Stephen - Original Message - From: Serge Knystautas [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Monday, August 04, 2003 12:46 AM Subject: Re: [lang] DateUtils parseCVS with time format Steven Caswell wrote: One of the supported formats for input to parseCVS is h:mm z. The method parses the time correctly, but the date is left as the default of January 1, 1970. Does this make sense, or does it make sense to have it fill in the current date? Since the API is silent on the expected behavior, it is difficult to test the API for correctness. Do you know how CVS works? does it set the date as that time in the last 24 hours, or does it always set today's date? There are some unit tests that are based on the current time, so I can put together unit tests and correct this behavior once I'm sure what it should be. -- Serge Knystautas President Lokitech software . strategy . design http://www.lokitech.com/ p. 1.301.656.5501 e. [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/math Fraction.java
scolebourne2003/08/03 18:20:47
Modified:lang/src/java/org/apache/commons/lang CharSet.java
CharRange.java
lang/src/java/org/apache/commons/lang/math Fraction.java
Log:
Make serialvers consistent
Revision ChangesPath
1.12 +2 -2
jakarta-commons/lang/src/java/org/apache/commons/lang/CharSet.java
Index: CharSet.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/CharSet.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- CharSet.java 4 Aug 2003 00:50:14 - 1.11
+++ CharSet.java 4 Aug 2003 01:20:47 - 1.12
@@ -74,7 +74,7 @@
public class CharSet implements Serializable {
/** Serialization lock, Lang version 2.0 */
-static final long serialVersionUID = 5947847346149275958L;
+private static final long serialVersionUID = 5947847346149275958L;
/** A CharSet defining no characters */
public static final CharSet EMPTY = new CharSet((String) null);
1.12 +2 -2
jakarta-commons/lang/src/java/org/apache/commons/lang/CharRange.java
Index: CharRange.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/CharRange.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- CharRange.java4 Aug 2003 00:46:24 - 1.11
+++ CharRange.java4 Aug 2003 01:20:47 - 1.12
@@ -69,7 +69,7 @@
public final class CharRange implements Serializable {
/** Serialization lock, Lang version 2.0 */
-static final long serialVersionUID = 8270183163158333422L;
+private static final long serialVersionUID = 8270183163158333422L;
/** The first character, inclusive, in the range */
private final char start;
1.7 +2 -1
jakarta-commons/lang/src/java/org/apache/commons/lang/math/Fraction.java
Index: Fraction.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/math/Fraction.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- Fraction.java 3 Aug 2003 22:43:03 - 1.6
+++ Fraction.java 4 Aug 2003 01:20:47 - 1.7
@@ -70,6 +70,7 @@
*/
public final class Fraction extends Number implements Serializable, Comparable {
+/** Serialization lock, Lang version 2.0 */
private static final long serialVersionUID = 65382027393090L;
public static final Fraction ZERO = new Fraction(0, 1);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] Ranges method name change
Change made Stephen - Original Message - From: Stephen Colebourne [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Saturday, August 02, 2003 5:25 PM Subject: [lang] Ranges method name change I am planning on changing the names of the include methods in Range and subclasses in the math package. includesXxx() -- containsXxx() This brings these classes in line with the rest of [lang]. There will be no deprecation, as these classes are unreleased. Any Objections??? Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/math Fraction.java
scolebourne2003/08/03 19:01:53
Modified:lang/src/test/org/apache/commons/lang/math IntRangeTest.java
FloatRangeTest.java FractionTest.java
DoubleRangeTest.java AbstractRangeTest.java
NumberUtilsTest.java
lang/src/java/org/apache/commons/lang/math Fraction.java
Log:
Extra tests suggested by Clover
Revision ChangesPath
1.4 +7 -1
jakarta-commons/lang/src/test/org/apache/commons/lang/math/IntRangeTest.java
Index: IntRangeTest.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/math/IntRangeTest.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- IntRangeTest.java 4 Aug 2003 01:14:02 - 1.3
+++ IntRangeTest.java 4 Aug 2003 02:01:53 - 1.4
@@ -131,6 +131,12 @@
assertSame(five, nr.getMinimumNumber());
assertEquals(ten, nr.getMaximumNumber());
+// test non Integer, for full coverage
+Long fiveL = new Long(5L);
+Long tenL = new Long(10L);
+assertEquals(five, nr.getMinimumNumber());
+assertEquals(ten, nr.getMaximumNumber());
+
// not null
try {
new IntRange(five, null);
1.4 +4 -2
jakarta-commons/lang/src/test/org/apache/commons/lang/math/FloatRangeTest.java
Index: FloatRangeTest.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/math/FloatRangeTest.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- FloatRangeTest.java 4 Aug 2003 01:14:02 - 1.3
+++ FloatRangeTest.java 4 Aug 2003 02:01:53 - 1.4
@@ -197,7 +197,9 @@
}
public void testToString() {
-assertEquals(Range[10.0,20.0], tenToTwenty.toString());
+String str = tenToTwenty.toString();
+assertEquals(Range[10.0,20.0], str);
+assertSame(str, tenToTwenty.toString());
assertEquals(Range[-20.0,-10.0], createRange(new Integer(-20), new
Integer(-10)).toString());
}
1.3 +19 -3
jakarta-commons/lang/src/test/org/apache/commons/lang/math/FractionTest.java
Index: FractionTest.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/math/FractionTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- FractionTest.java 22 Dec 2002 21:18:51 - 1.2
+++ FractionTest.java 4 Aug 2003 02:01:53 - 1.3
@@ -703,6 +703,18 @@
assertEquals(7, f.getNumerator());
assertEquals(5, f.getDenominator());
+f1 = Fraction.getFraction(0, 5);
+f2 = Fraction.getFraction(4, 5);
+f = f1.subtract(f2);
+assertEquals(-4, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
+f1 = Fraction.getFraction(0, 5);
+f2 = Fraction.getFraction(-4, 5);
+f = f1.subtract(f2);
+assertEquals(4, f.getNumerator());
+assertEquals(5, f.getDenominator());
+
f1 = Fraction.getFraction(3, 5);
f2 = Fraction.getFraction(1, 2);
f = f1.subtract(f2);
@@ -845,7 +857,9 @@
Fraction f = null;
f = Fraction.getFraction(3, 5);
-assertEquals(3/5, f.toString());
+String str = f.toString();
+assertEquals(3/5, str);
+assertSame(str, f.toString());
f = Fraction.getFraction(7, 5);
assertEquals(7/5, f.toString());
@@ -864,7 +878,9 @@
Fraction f = null;
f = Fraction.getFraction(3, 5);
-assertEquals(3/5, f.toProperString());
+String str = f.toProperString();
+assertEquals(3/5, str);
+assertSame(str, f.toProperString());
f = Fraction.getFraction(7, 5);
assertEquals(1 2/5, f.toProperString());
1.4 +4 -2
jakarta-commons/lang/src/test/org/apache/commons/lang/math/DoubleRangeTest.java
Index: DoubleRangeTest.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/math/DoubleRangeTest.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- DoubleRangeTest.java 4 Aug 2003 01:14:02 - 1.3
+++ DoubleRangeTest.java 4 Aug 2003 02:01:53 - 1.4
@@ -197,7 +197,9 @@
}
public void testToString() {
-assertEquals(Range[10.0,20.0], tenToTwenty.toString());
+String str =
DO NOT REPLY [Bug 19030] - [lang] EnumTest fails on Linux Sun JDK 1.3.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19030. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19030 [lang] EnumTest fails on Linux Sun JDK 1.3.0 --- Additional Comments From [EMAIL PROTECTED] 2003-08-04 02:32 --- To clarify the comment above, all that is failing is compile.tests under Sun Linux JDK 1.2.2. The compile target succeeds (i.e. src/java builds fine) and the tests run clean using this JRE when compiled using 1.4. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22098] New: - [lang] Improve util.Validate tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22098. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22098 [lang] Improve util.Validate tests Summary: [lang] Improve util.Validate tests Product: Commons Version: Nightly Builds Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Lang AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The attached patch fixes some small errors in ValidateTest suggested by clover. It also inserts fail() statements to ensure that expected IllegalArgumentExceptions are thrown. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22098] - [lang] Improve util.Validate tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22098. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22098 [lang] Improve util.Validate tests --- Additional Comments From [EMAIL PROTECTED] 2003-08-04 03:42 --- Created an attachment (id=7635) Patch to ValidateTest - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Resources] When is the next release?
James Mitchell wrote: Unless I did something wrong, my search for issues on bugzilla turns up nothing, and I'm not sure what to make of issueTrackingUrl in project.xml. Does it mean that we should be using http://nagoya.apache.org/scarab/servlet/scarab/ or is it something that was just carried over when someone was creating this file? Using Maven to build and run the tests on this project fails. * Running ant test (with appropriate build.properties) will compile and test fine. * Running maven will compile fine, but does not copy the required .properties and .xml files needed by the tests. I don't know enough about Maven to determine whether this is configuration issue or a bug. So, with that out of the way, what exactly is stopping us from releasing commons-resources? Do we need more tests? Is there a checklist somewhere that I'm missing? James: Did anyone reply to this message, as to what needs to be done for a release ? -- - Rob Leland (703-525-3580) Choose a job you love, and you will never have to work a day of your life. -Confucius. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22073] - Javadocs clean-up
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22073. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22073 Javadocs clean-up --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 22:08 --- Just finished cleaning up HttpMethodBase. Changes applied to 2.0 breanch HEAD. What a terrible way to spend the weekend. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 22073] - Javadocs clean-up
Nice work Oleg. This is definitely not the most enjoyable task. I hope you didn't spend you whole weekend on Javadocs. Mike On Sunday, August 3, 2003, at 06:08 PM, [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22073. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22073 Javadocs clean-up --- Additional Comments From [EMAIL PROTECTED] 2003-08-03 22:08 --- Just finished cleaning up HttpMethodBase. Changes applied to 2.0 breanch HEAD. What a terrible way to spend the weekend. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
