Re: Commons, Maven, Site, Release
Dion Gillard wrote: And you guys are doing this to make life easier? This seems like a lot of effort. Well of course it's a lot of effort in the beginning. The setup that Brett has made in the sandbox is based on an upcoming version of the maven-site-plugin, which depends on an upcoming version of maven. All of this is brand new and in an unreleased state at the moment. When they are all released we hope that life will be easier, for all of us. But if we don't even *try* then we will never know, will we... -- Dennis Lundberg On 12/31/05, Dennis Lundberg [EMAIL PROTECTED] wrote: Hi Brett I finally found some time to try out the new Maven 2 site stuff that you have put into the sandbox. There are quite a few hurdles to jump over though and I think I fell on the last one. Hope you can help me out. Here's what I did: - Bootstrapped Maven from the 2.0.x branch - Added to the sandbox pom.xml a build/plugins/plugin/version tag for maven-site-plugin and set it to 2.0-SNAPSHOT, to get all the fancy new stuff - Added a skin/version tag, with the value '1.0-SNAPSHOT' to src/site.xml, otherwise it tried to download the release version - Added snapshot repositories to the sandbox pom - When I run 'mvn site' in sandbox-trunks I get an error from Maven when it is trying to download the classic-skin, see stack trace below [INFO] snapshot org.apache.maven.skins:maven-classic-skin:1.0-SNAPSHOT: checking for updates from apache.snapshots Downloading: http://snapshots.maven.codehaus.org/maven2/org/apache/maven/skins/maven-classic-skin/1.0-SNAPSHOT/maven-classic-skin-1.0-SNAPSHOT.jar [WARNING] Unable to get resource from repository snapshots (http://snapshots.maven.codehaus.org/maven2) Downloading: http://cvs.apache.org/maven-snapshot-repository/org/apache/maven/skins/maven-classic-skin/1.0-SNAPSHOT/maven-classic-skin-1.0-SNAPSHOT.jar [WARNING] Unable to get resource from repository apache.snapshots (http://cvs.apache.org/maven-snapshot-repository) [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] The skin does not exist: Unable to download the artifact from any repository org.apache.maven.skins:maven-classic-skin:jar:1.0-SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), apache.snapshots (http://cvs.apache.org/maven-snapshot-repository), snapshots (http://snapshots.maven.codehaus.org/maven2) Any ideas? Brett Porter wrote: Hi, I've been tracking a lot of the discussion on commons-dev and there are lots of points to reply to, so I thought it was appropriate that I do a brain dump to get everything up to date. Apologies for length. First, it seems clear that Maven 2 is a better choice to use than to do significant work on Maven 1.x. A lot of things have been proposed for a Maven 1.x plugin for commons that are already possible out of the box in Maven 2. There are some gotchas. - Some plugins may not be available. At this point, I am not aware of anywhere that this is the case in Commons, but I will do a check over this shortly and report back. - Some services are not yet available. Specifically I am thinking of Gump and the automated repository sync. I am working with Leo on the gump stuff, and I think it will be all ready by the time Gump 3 is done. there is always the ability to generate a reasonable ant build script to use here. The repository sync will be available early in the new year and is much improved. - It's a change, and any change is disruptive. I had planned to get everything working at least to the level it already does in M1 for some sandbox components before even bringing it up, so this thread was rather timely. Now, some specific thoughts on what is needed. Inheritence - I believe the common parent is a good way to go, and Maven 2 facilitates this by allowing it to be in the repository, avoiding a bizarre checkout structure. This should avoid the need for externals that has been under discussion. I am currently working on site inheritence. The descriptor goes in the repository, facilitating the same as above. I am adding breadcrumbs, top/bottom navigation inheritence (to prevent the need for the entities used previously), skins (css + images in a jar that can be shared among projects), and documenting/facilitating best practices about separation of different releases and separating developer information from user information. If the site layout + CSS is still not good enough, a single velocity template should be able to be added to the skin as well. While on the site, most people love the APT format in Maven 2, which is a definite advantage of using that. Some might want to look into the i18n aspects as well. http://docs.codehaus.org/display/MAVEN/Sites+and+Inheritence Unfortunately this didn't land during the hackathon as I had hoped, but I'll get it together very soon.
DO NOT REPLY [Bug 35828] - [configuration] Instance specific list delimiter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35828. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35828 --- Additional Comments From [EMAIL PROTECTED] 2005-12-31 12:02 --- (In reply to comment #6) Thanks for your comments, I'll fix that and send the patch again. I also have a question related to class XMLConfiguration. It contains an static inner class called XMLBuilderVisitor which needs to access the delimiter. Unfortunately as it is static it cannot access the delimiter of the current configuration. Do you think it should be changed to a non-static inner class? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29716] - [configuration] Disabling string splitting
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29716. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29716 --- Additional Comments From [EMAIL PROTECTED] 2005-12-31 12:27 --- This issue has been fixed as part of the patch sent for bug 35828. http://issues.apache.org/bugzilla/show_bug.cgi?id=35828 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38083] - [io][PATCH] Iterate over the lines in a file and the files in a directory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38083. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38083 [EMAIL PROTECTED] changed: What|Removed |Added Summary|[PATCH] IO - iterate over |[io][PATCH] Iterate over the |the lines in a file and the |lines in a file and the |files in a directory|files in a directory -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-net (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-net has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 61 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - apache-ldapber-provider : Apache Directory Project - apacheds-core : Apache Directory Server - apacheds-main : Apache Directory Server - apacheds-shared : Apache Directory Server - asn1-ber : Apache ASN.1 Tools - asn1-codec : Apache ASN.1 Tools - commons-net : Commons Net - james-server : James Server - kerberos-common : Apache Directory Project - kerberos-protocol : Apache Kerberos Server - ldap-common : Apache Directory Project - ldap-protocol : Apache Directory Server - ldap-snacc-provider : Apache Directory Project - maven-directory-plugin : Apache Directory Server - mina : A Multipurpose Infrastrusture for Network Applications - smartfrog-components : Smartfrog: Application Deployment from HP Laboratories Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-net/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-net-31122005.jar] identifier set to project name -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-net/gump_work/build_jakarta-commons_commons-net.html Work Name: build_jakarta-commons_commons-net (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 50 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-net-31122005 dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/net] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/net/target/classes:/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-oro/jakarta-oro-31122005.jar - [junit] Testcase: testConstructors took 0.007 sec [junit] Testcase: testStartSubnegotiation took 0 sec [junit] Testcase: testAnswerSubnegotiation took 0 sec [junit] Testcase: testWill took 0.005 sec [junit] Testcase: testDo took 0.001 sec [junit] Running org.apache.commons.net.telnet.TelnetClientTest [junit] Testsuite: org.apache.commons.net.telnet.TelnetClientTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 47.487 sec [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 47.487 sec [junit] Testcase: testInitial took 5.372 sec [junit] Testcase: testOptionNegotiation took 9.396 sec [junit] Testcase: testOptionRenegotiation took 5.419 sec [junit] Testcase: testNotification took 4.915 sec [junit] Testcase: testDeleteOptionHandler took 5.414 sec [junit] Testcase: testAYT took 5.459 sec [junit] Testcase: testSpy took 5.301 sec [junit] Testcase: testSetReaderThread took 5.449 sec [junit] Running org.apache.commons.net.telnet.TelnetOptionTest [junit] Testsuite: org.apache.commons.net.telnet.TelnetOptionTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.519 sec [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.519 sec [junit] Testcase: testisValidOption took 0.007 sec [junit] Testcase: testGetOption took 0.002 sec [junit] Running
[EMAIL PROTECTED]: Project commons-net (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-net has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 61 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - apache-ldapber-provider : Apache Directory Project - apacheds-core : Apache Directory Server - apacheds-main : Apache Directory Server - apacheds-shared : Apache Directory Server - asn1-ber : Apache ASN.1 Tools - asn1-codec : Apache ASN.1 Tools - commons-net : Commons Net - james-server : James Server - kerberos-common : Apache Directory Project - kerberos-protocol : Apache Kerberos Server - ldap-common : Apache Directory Project - ldap-protocol : Apache Directory Server - ldap-snacc-provider : Apache Directory Project - maven-directory-plugin : Apache Directory Server - mina : A Multipurpose Infrastrusture for Network Applications - smartfrog-components : Smartfrog: Application Deployment from HP Laboratories Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-net/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-net-31122005.jar] identifier set to project name -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-net/gump_work/build_jakarta-commons_commons-net.html Work Name: build_jakarta-commons_commons-net (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 50 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-net-31122005 dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/net] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/net/target/classes:/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-oro/jakarta-oro-31122005.jar - [junit] Testcase: testConstructors took 0.007 sec [junit] Testcase: testStartSubnegotiation took 0 sec [junit] Testcase: testAnswerSubnegotiation took 0 sec [junit] Testcase: testWill took 0.005 sec [junit] Testcase: testDo took 0.001 sec [junit] Running org.apache.commons.net.telnet.TelnetClientTest [junit] Testsuite: org.apache.commons.net.telnet.TelnetClientTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 47.487 sec [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 47.487 sec [junit] Testcase: testInitial took 5.372 sec [junit] Testcase: testOptionNegotiation took 9.396 sec [junit] Testcase: testOptionRenegotiation took 5.419 sec [junit] Testcase: testNotification took 4.915 sec [junit] Testcase: testDeleteOptionHandler took 5.414 sec [junit] Testcase: testAYT took 5.459 sec [junit] Testcase: testSpy took 5.301 sec [junit] Testcase: testSetReaderThread took 5.449 sec [junit] Running org.apache.commons.net.telnet.TelnetOptionTest [junit] Testsuite: org.apache.commons.net.telnet.TelnetOptionTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.519 sec [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.519 sec [junit] Testcase: testisValidOption took 0.007 sec [junit] Testcase: testGetOption took 0.002 sec [junit] Running
DO NOT REPLY [Bug 35828] - [configuration] Instance specific list delimiter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35828. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35828 --- Additional Comments From [EMAIL PROTECTED] 2005-12-31 16:30 --- XMLBuilderVisitor has package scope. So it is not part of the public API and can be changed to a non static class. Alternatively you could store the delimiter to use in a member of XMLBuilderVisitor and pass it in the constructor. I'd be fine with both ways. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360306 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/utils/ src/test/ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflow/fl
Author: kohsuke
Date: Sat Dec 31 07:52:45 2005
New Revision: 360306
URL: http://svn.apache.org/viewcvs?rev=360306view=rev
Log:
removed commons-io dependency to make the footprint smaller
Modified:
jakarta/commons/sandbox/javaflow/trunk/project.properties
jakarta/commons/sandbox/javaflow/trunk/project.xml
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java
jakarta/commons/sandbox/javaflow/trunk/src/test/RewriteTool.java
jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/TestClassLoader.java
jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/flow/NullVariableMethodFlow.java
Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/project.properties?rev=360306r1=360305r2=360306view=diff
==
--- jakarta/commons/sandbox/javaflow/trunk/project.properties (original)
+++ jakarta/commons/sandbox/javaflow/trunk/project.properties Sat Dec 31
07:52:45 2005
@@ -34,5 +34,4 @@
#
maven.jar.commons-jci = lib/commons-jci-r291284.jar
maven.jar.bcel = lib/jakarta-bcel-20050813.jar
-maven.jar.commons-io = lib/commons-io-20050621.133116.jar
maven.jar.asm-all = lib/asm-all-2.2.1.jar
Modified: jakarta/commons/sandbox/javaflow/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/project.xml?rev=360306r1=360305r2=360306view=diff
==
--- jakarta/commons/sandbox/javaflow/trunk/project.xml (original)
+++ jakarta/commons/sandbox/javaflow/trunk/project.xml Sat Dec 31 07:52:45 2005
@@ -100,6 +100,12 @@
/contributors
dependencies
+!-- runtime dependencies --
+dependency
+ groupIdcommons-logging/groupId
+ artifactIdcommons-logging-api/artifactId
+ version1.0.4/version
+/dependency
dependency
groupIdcommons-logging/groupId
artifactIdcommons-logging/artifactId
@@ -113,12 +119,21 @@
typejar/type
/dependency
dependency
+ groupIdasm/groupId
+ artifactIdasm-all/artifactId
+ version2.2.1/version
+ jar${basedir}/lib/asm-all-2.2.1.jar/jar
+ typejar/type
+/dependency
+!-- optional runtime dependency --
+dependency
groupIdcommons-jci/groupId
artifactIdcommons-jci/artifactId
versionr291284/version
jar${basedir}/lib/commons-jci-r291284.jar/jar
typejar/type
/dependency
+!-- build/test dependencies --
dependency
groupIdant/groupId
artifactIdant/artifactId
@@ -138,23 +153,6 @@
groupIdxstream/groupId
artifactIdxstream/artifactId
version1.1/version
-/dependency
-dependency
- groupIdcommons-logging/groupId
- artifactIdcommons-logging-api/artifactId
- version1.0.4/version
-/dependency
-dependency
- groupIdcommons-io/groupId
- artifactIdcommons-io/artifactId
- version20050621.133116/version
-/dependency
-dependency
- groupIdasm/groupId
- artifactIdasm-all/artifactId
- version2.2.1/version
- jar${basedir}/lib/asm-all-2.2.1.jar/jar
- typejar/type
/dependency
/dependencies
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java?rev=360306r1=360305r2=360306view=diff
==
---
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java
(original)
+++
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java
Sat Dec 31 07:52:45 2005
@@ -15,21 +15,22 @@
*/
package org.apache.commons.javaflow.utils;
-import java.io.ByteArrayInputStream;
+import org.apache.commons.javaflow.bytecode.transformation.ResourceTransformer;
+import
org.apache.commons.javaflow.bytecode.transformation.bcel.BcelClassTransformer;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
+import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
import java.util.jar.JarEntry;
import java.util.jar.JarInputStream;
import java.util.jar.JarOutputStream;
-import org.apache.commons.io.FileUtils;
-import org.apache.commons.io.IOUtils;
-import org.apache.commons.javaflow.bytecode.transformation.ResourceTransformer;
-import
svn commit: r360307 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java
Author: kohsuke
Date: Sat Dec 31 08:01:13 2005
New Revision: 360307
URL: http://svn.apache.org/viewcvs?rev=360307view=rev
Log:
added a new unpublished switch to decide which transformer to use.
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java?rev=360307r1=360306r2=360307view=diff
==
---
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java
(original)
+++
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java
Sat Dec 31 08:01:13 2005
@@ -22,11 +22,13 @@
import java.util.jar.JarInputStream;
import java.util.jar.JarOutputStream;
import org.apache.commons.javaflow.bytecode.transformation.ResourceTransformer;
+import
org.apache.commons.javaflow.bytecode.transformation.asm.AsmClassTransformer;
import
org.apache.commons.javaflow.bytecode.transformation.bcel.BcelClassTransformer;
import org.apache.commons.javaflow.utils.RewritingUtils;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.DirectoryScanner;
import org.apache.tools.ant.Project;
+import org.apache.tools.ant.types.FileSet;
import org.apache.tools.ant.taskdefs.MatchingTask;
/**
@@ -37,19 +39,50 @@
*/
public class AntRewriteTask extends MatchingTask {
-private ResourceTransformer transformer = new BcelClassTransformer();
+private ResourceTransformer transformer;
private File dstDir;
private File srcDir;
+/**
+ * Directory to which the transformed files will be written.
+ * This can be the same as the source directory.
+ */
public void setDstDir(final File pFile) {
dstDir = pFile;
}
+/**
+ * Directory from which the input files are read.
+ * This and the inherited [EMAIL PROTECTED] MatchingTask} forms an implicit
+ * [EMAIL PROTECTED] FileSet}.
+ */
public void setSrcDir(final File pFile) {
srcDir = pFile;
fileset.setDir(srcDir);
}
+
+/**
+ * Sets the transformer to use.
+ *
+ * p
+ * This option is unpublished, because in a long run we'll
+ * likely to just focus on one transformer and get rid
+ * of the other (and this option will be removed then.)
+ *
+ * @param name
+ * either BCEL or ASM. Case insensitive.
+ */
+public void setMode(String name) {
+name = name.toLowerCase();
+if(name.equals(bcel))
+transformer = new BcelClassTransformer();
+else
+if(name.equals(asm))
+transformer = new AsmClassTransformer();
+else
+throw new BuildException(Unrecognized mode: +name);
+}
/**
* Check that all required attributes have been set and nothing
@@ -77,9 +110,11 @@
public void execute() throws BuildException {
final DirectoryScanner ds = fileset.getDirectoryScanner(getProject());
-//final DirectoryScanner ds = getDirectoryScanner(srcDir);
final String[] fileNames = ds.getIncludedFiles();
+// default to BCEL, since the BCEL version is more stable
+if(transformer==null)
+transformer = new BcelClassTransformer();
try {
for (int i = 0; i fileNames.length; i++) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360309 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
Author: kohsuke
Date: Sat Dec 31 08:08:18 2005
New Revision: 360309
URL: http://svn.apache.org/viewcvs?rev=360309view=rev
Log:
SimpleVerifier assumes that the types involved in the computation is loadable
through Class.forName(), which isn't true when we are running inside Ant.
The correct computation would require us to parse referenced types (through a
pluggable resolver.) For now, I'm just replacing it with BasicVerifier.
Given that the purpose of this part of the code is just to check that we
generated the right code, perhaps we can remove it altogether in the production
system?
i.e.,
if(DEBUG) {
... run a verifier
}
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java?rev=360309r1=360308r2=360309view=diff
==
---
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
(original)
+++
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
Sat Dec 31 08:08:18 2005
@@ -39,6 +39,7 @@
import org.objectweb.asm.tree.analysis.DataflowValue;
import org.objectweb.asm.tree.analysis.Frame;
import org.objectweb.asm.tree.analysis.SimpleVerifier;
+import org.objectweb.asm.tree.analysis.BasicVerifier;
/**
@@ -50,22 +51,22 @@
protected final String className;
protected final ClassVisitor cv;
protected final MethodVisitor mv;
-
+
protected final List labels = new ArrayList();
protected final List nodes = new ArrayList();
protected final List methods = new ArrayList();
-
+
protected Analyzer analyzer;
-
-
-public ContinuationMethodAnalyzer(String className, ClassVisitor cv,
-MethodVisitor mv, int access, String name, String desc, String
signature, String[] exceptions) {
+
+
+public ContinuationMethodAnalyzer(String className, ClassVisitor cv,
+ MethodVisitor mv, int access, String
name, String desc, String signature, String[] exceptions) {
super( access, name, desc, signature, exceptions);
this.className = className;
this.cv = cv;
this.mv = mv;
}
-
+
public void visitMethodInsn( int opcode, String owner, String name, String
desc) {
MethodInsnNode mnode = new MethodInsnNode(opcode, owner, name, desc);
if(opcode == INVOKESPECIAL || init.equals(name)) {
@@ -79,7 +80,7 @@
}
instructions.add(mnode);
}
-
+
public void visitEnd() {
if(instructions.size()==0 || labels.size()==0) {
accept(mv);
@@ -89,10 +90,10 @@
try {
moveNew();
- analyzer = new Analyzer(new SimpleVerifier());
+ analyzer = new Analyzer(new BasicVerifier());
analyzer.analyze(className, this);
accept(new ContinuationMethodAdapter(this));
-
+
} catch(AnalyzerException ex) {
// TODO log the error or fail?
ex.printStackTrace();
@@ -105,9 +106,9 @@
DataflowInterpreter i = new DataflowInterpreter();
Analyzer a = new Analyzer(i);
a.analyze(className, this);
-
+
HashMap movable = new HashMap();
-
+
Frame[] frames = a.getFrames();
for( int j = 0; j methods.size(); j++) {
MethodInsnNode mnode = (MethodInsnNode) methods.get(j);
@@ -115,7 +116,7 @@
int n = a.getIndex(mnode);
Frame f = frames[n];
Type[] args = Type.getArgumentTypes(mnode.desc);
-
+
DataflowValue v = (DataflowValue)
f.getStack(f.getStackSize()-args.length-1);
Set insns = v.insns;
for( Iterator it = insns.iterator(); it.hasNext();) {
@@ -131,19 +132,19 @@
}
}
}
-
+
for( Iterator it = movable.entrySet().iterator(); it.hasNext();) {
- Map.Entry e = (Map.Entry) it.next();
- AbstractInsnNode node1 = (AbstractInsnNode) e.getKey();
+ Map.Entry e = (Map.Entry) it.next();
+ AbstractInsnNode node1 = (AbstractInsnNode) e.getKey();
int n1 = instructions.indexOf(node1);
AbstractInsnNode node2 = (AbstractInsnNode) instructions.get(n1+1);
boolean hasCopy = node2.getOpcode()==DUP;
-
+
instructions.remove(node1); // NEW
if(hasCopy) {
instructions.remove(node2); // DUP
}
-
+
svn commit: r360311 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Author: kohsuke
Date: Sat Dec 31 08:22:38 2005
New Revision: 360311
URL: http://svn.apache.org/viewcvs?rev=360311view=rev
Log:
I'm not totally sure about this change, but don't we need to pass through the
values, basically?
or is it really right to pass (0,0)?
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java?rev=360311r1=360310r2=360311view=diff
==
---
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
(original)
+++
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Sat Dec 31 08:22:38 2005
@@ -276,7 +276,7 @@
mv.visitLocalVariable(__stackRecorder, L+STACK_RECORDER+;, null,
startLabel, endLabel, stackRecorderVar);
-mv.visitMaxs(0, 0);
+mv.visitMaxs(maxStack,stackRecorderVar+1);
}
void pushDefault(Type type) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360312 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java
Author: kohsuke Date: Sat Dec 31 08:24:24 2005 New Revision: 360312 URL: http://svn.apache.org/viewcvs?rev=360312view=rev Log: recorded my finding. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java?rev=360312r1=360311r2=360312view=diff == --- jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java (original) +++ jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java Sat Dec 31 08:24:24 2005 @@ -38,7 +38,6 @@ import org.objectweb.asm.tree.analysis.DataflowInterpreter; import org.objectweb.asm.tree.analysis.DataflowValue; import org.objectweb.asm.tree.analysis.Frame; -import org.objectweb.asm.tree.analysis.SimpleVerifier; import org.objectweb.asm.tree.analysis.BasicVerifier; @@ -176,6 +175,8 @@ } } } + // TODO: when we move the NEW instructions, we need to update the maxStacks + // accordingly } // TODO - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360313 - /jakarta/commons/sandbox/javaflow/trunk/maven.xml
Author: kohsuke
Date: Sat Dec 31 08:24:45 2005
New Revision: 360313
URL: http://svn.apache.org/viewcvs?rev=360313view=rev
Log:
added ${test.transformer} property to control which transformer to use for
testing.
Modified:
jakarta/commons/sandbox/javaflow/trunk/maven.xml
Modified: jakarta/commons/sandbox/javaflow/trunk/maven.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/maven.xml?rev=360313r1=360312r2=360313view=diff
==
--- jakarta/commons/sandbox/javaflow/trunk/maven.xml (original)
+++ jakarta/commons/sandbox/javaflow/trunk/maven.xml Sat Dec 31 08:24:45 2005
@@ -17,7 +17,8 @@
classpathref=rewrite.classpath
/
-rewrite srcDir=target/test-classes dstDir=target/test-classes
+rewrite srcDir=target/test-classes dstDir=target/test-classes
+mode=${test.transformer}
include
name=org/apache/commons/javaflow/bytecode/transformation/asm/data/**/
include name=org/apache/commons/javaflow/flow/**/
!--
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360314 - /jakarta/commons/sandbox/javaflow/trunk/project.properties
Author: kohsuke Date: Sat Dec 31 08:25:12 2005 New Revision: 360314 URL: http://svn.apache.org/viewcvs?rev=360314view=rev Log: use BCEL for now. You can override this in your build.properties. Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/project.properties?rev=360314r1=360313r2=360314view=diff == --- jakarta/commons/sandbox/javaflow/trunk/project.properties (original) +++ jakarta/commons/sandbox/javaflow/trunk/project.properties Sat Dec 31 08:25:12 2005 @@ -23,6 +23,8 @@ #maven.test.skip = true maven.junit.sysproperties=org.xml.sax.driver org.xml.sax.driver=org.apache.xerces.parsers.SAXParser +# 'BCEL' or 'ASM' to specify the transformer to use for testing. +test.transformer=BCEL # # M A V E N J A R O V E R R I D E - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Javaflow and ASM
Kohsuke Kawaguchi wrote: So if you don't mind, I'm happy to make the necessary changes. Please go ahead. And if you don't mind please send me the test results you'll get. Will do. I added a new property to select the transformer, and tried to use ASM. I found a few issues. - ContinuationMethodAdapter.visitMaxs was passing (0,0) to the next visitor. I'm not too familiar with this, but don't we need to basically pass through values? - When moving 'new' instructions, local variables are allocated excessively. I think it would be better for it to be used little more conservatively. Namely, the number of additional local variables for save/restore should be max of all constructor parameter counts, not sum of them. - When moving 'new' instructions, The maxStacks field isn't updated correctly, but I think we needed this. - While instrumenting the FinallyFlow class, I found that ContinuationMethodAdapter.visitMethodInsn dies while trying to save a local variable that has a JSR return address in it. I don't think we can instrument method invocations in a finally block, so there needs to be code that checks it (I don't know how BCEL version is doing that, though) That's it for now. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature
Re: svn commit: r360306 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/utils/ src/test/ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflo
removed commons-io dependency to make the footprint smaller During apachecon I wrote a maven2 plugin to strip down jars automagically. No need to duplicate code here :) ...I still need need to put package it online somewhere ...and we need to move javaflow to maven2 ;) cheers -- Torsten PGP.sig Description: This is a digitally signed message part
Re: svn commit: r360306 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/utils/ src/test/ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflo
Torsten Curdt wrote: removed commons-io dependency to make the footprint smaller During apachecon I wrote a maven2 plugin to strip down jars automagically. No need to duplicate code here :) ...I still need need to put package it online somewhere ...and we need to move javaflow to maven2 ;) I'm looking forward to seeing it. I guess it's time for me to learn Maven 2. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature
[EMAIL PROTECTED]: Project commons-jelly-test (in module commons-jelly) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-test has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 19 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-test : Commons Jelly
Full details are available at:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-test/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for
property maven.jar.servletapi.
-DEBUG- Dependency on jakarta-taglibs-standard exists, no need to add for
property maven.jar.jstl.
-DEBUG- Dependency on xml-xerces exists, no need to add for property
maven.jar.xerces.
-WARNING- Overriding Maven properties:
[/usr/local/gump/public/workspace/commons-jelly/build.properties]
-DEBUG- (Gump generated) Maven Properties in:
/usr/local/gump/public/workspace/commons-jelly/build.properties
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/usr/local/gump/public/workspace/commons-jelly/project.xml
-DEBUG- Maven project properties in:
/usr/local/gump/public/workspace/commons-jelly/project.properties
-INFO- Project Reports in:
/usr/local/gump/public/workspace/commons-jelly/target/test-reports
The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-test/gump_work/build_commons-jelly_commons-jelly-test.html
Work Name: build_commons-jelly_commons-jelly-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 2 mins 49 secs
Command Line: maven --offline jar
[Working Directory: /usr/local/gump/public/workspace/commons-jelly]
CLASSPATH:
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/forehead/forehead-1.0-beta-5.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/jstl.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] org.apache.commons.jelly.JellyTagException:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly:359:75:
test:assertEquals expected:[22] but was:[22]
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] at
org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:712)
[junit] at
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:282)
[junit] at
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] Caused by:
org.apache.commons.jelly.tags.junit.JellyAssertionFailedError: expected:[22]
but was:[22]
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:39)
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.failNotEquals(AssertTagSupport.java:62)
[junit] at
org.apache.commons.jelly.tags.junit.AssertEqualsTag.doTag(AssertEqualsTag.java:55)
[EMAIL PROTECTED]: Project commons-jelly-test (in module commons-jelly) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-test has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 19 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-test : Commons Jelly
Full details are available at:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-test/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for
property maven.jar.servletapi.
-DEBUG- Dependency on jakarta-taglibs-standard exists, no need to add for
property maven.jar.jstl.
-DEBUG- Dependency on xml-xerces exists, no need to add for property
maven.jar.xerces.
-WARNING- Overriding Maven properties:
[/usr/local/gump/public/workspace/commons-jelly/build.properties]
-DEBUG- (Gump generated) Maven Properties in:
/usr/local/gump/public/workspace/commons-jelly/build.properties
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/usr/local/gump/public/workspace/commons-jelly/project.xml
-DEBUG- Maven project properties in:
/usr/local/gump/public/workspace/commons-jelly/project.properties
-INFO- Project Reports in:
/usr/local/gump/public/workspace/commons-jelly/target/test-reports
The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-test/gump_work/build_commons-jelly_commons-jelly-test.html
Work Name: build_commons-jelly_commons-jelly-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 2 mins 49 secs
Command Line: maven --offline jar
[Working Directory: /usr/local/gump/public/workspace/commons-jelly]
CLASSPATH:
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/forehead/forehead-1.0-beta-5.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/jstl.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] org.apache.commons.jelly.JellyTagException:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly:359:75:
test:assertEquals expected:[22] but was:[22]
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] at
org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:712)
[junit] at
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:282)
[junit] at
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] Caused by:
org.apache.commons.jelly.tags.junit.JellyAssertionFailedError: expected:[22]
but was:[22]
[junit] Expected expression: ${singleSize*2}
[junit] Actual expression: ${doubleSize} File:
file:/x1/gump/public/workspace/commons-jelly/target/test-classes/org/apache/commons/jelly/suite.jelly
At tag test:assertEquals: line: 359 column: 75
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:39)
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.failNotEquals(AssertTagSupport.java:62)
[junit] at
org.apache.commons.jelly.tags.junit.AssertEqualsTag.doTag(AssertEqualsTag.java:55)
svn commit: r360342 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Author: kohsuke
Date: Sat Dec 31 09:00:16 2005
New Revision: 360342
URL: http://svn.apache.org/viewcvs?rev=360342view=rev
Log:
ClassWriter recalculates the values. No need to set them.
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java?rev=360342r1=360341r2=360342view=diff
==
---
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
(original)
+++
jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java
Sat Dec 31 09:00:16 2005
@@ -276,7 +276,7 @@
mv.visitLocalVariable(__stackRecorder, L+STACK_RECORDER+;, null,
startLabel, endLabel, stackRecorderVar);
-mv.visitMaxs(maxStack,stackRecorderVar+1);
+mv.visitMaxs(0,0);
}
void pushDefault(Type type) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Javaflow and ASM
Eugene Kuleshov wrote: - ContinuationMethodAdapter.visitMaxs was passing (0,0) to the next visitor. I'm not too familiar with this, but don't we need to basically pass through values? It is actually ok. ClassWriter is used with computeMaxs flag, so visitMaxs() method is basically an indicator and its params are ignored. It might be possible to caclulate stack and locals but I decided not spend time on this for now. I see. I'll roll back the changes then. - When moving 'new' instructions, local variables are allocated excessively. I think it would be better for it to be used little more conservatively. Namely, the number of additional local variables for save/restore should be max of all constructor parameter counts, not sum of them. I spotted this too and tried to fix this but haven't completed yet. It seems that instead of using MethodNode.maxLocals as a stackRecorderVar its value should be memorized and vars for param restoration should be always started from that value + 1 Yes. - When moving 'new' instructions, The maxStacks field isn't updated correctly, but I think we needed this. It will be recalculated automatically when ClassWriter is used with computeMaxs Hmm. I got insufficient stack size error or something like that when I didn't do anything. I added maxStack += 10 for a try and that made it work, which made me suspect of this issue. - While instrumenting the FinallyFlow class, I found that ContinuationMethodAdapter.visitMethodInsn dies while trying to save a local variable that has a JSR return address in it. I don't think we can instrument method invocations in a finally block, so there needs to be code that checks it (I don't know how BCEL version is doing that, though) Another option could be to inline these blocks. I believe that one of the projects, which been using ASM did that already and we can just reuse it. I actually was thinking to package it with the asm-commons or something. That sounds like a good idea. With such code where the same set of byte code is copied into multiple places, would it still be possible for a user to set a breakpoint and etc correctly? -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature
[EMAIL PROTECTED]: Project commons-vfs (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-vfs has an issue affecting its community integration. This issue affects 72 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - cocoon : Java XML Framework - cocoon-block-ajax : Ajax - Utilities and resources for Ajax applications. - cocoon-block-apples : Java XML Framework - cocoon-block-asciiart : Java XML Framework - cocoon-block-authentication-fw : Java XML Framework - cocoon-block-axis : Java XML Framework - cocoon-block-batik : Java XML Framework - cocoon-block-bsf : Java XML Framework - cocoon-block-captcha : Utilites to generate simple CAPTCHAs - cocoon-block-chaperon : Java XML Framework - cocoon-block-core-samples-additional : Additional core samples. - cocoon-block-core-samples-main : Main core samples. - cocoon-block-cron : Java XML Framework - cocoon-block-databases : Java XML Framework - cocoon-block-deli : Java XML Framework - cocoon-block-eventcache : Java XML Framework - cocoon-block-faces : Java XML Framework - cocoon-block-fop : Java XML Framework - cocoon-block-forms : Java XML Framework - cocoon-block-hsqldb : Java XML Framework - cocoon-block-html : Java XML Framework - cocoon-block-itext : Java XML Framework - cocoon-block-javaflow : Java XML Framework - cocoon-block-jcr : A jcr: protocol for Cocoon - cocoon-block-jfor : Java XML Framework - cocoon-block-jms : Java XML Framework - cocoon-block-jsp : Java XML Framework - cocoon-block-linkrewriter : Java XML Framework - cocoon-block-lucene : Java XML Framework - cocoon-block-mail : Java XML Framework - cocoon-block-midi : Java XML Framework - cocoon-block-naming : Java XML Framework - cocoon-block-ojb : Java XML Framework - cocoon-block-paranoid : Java XML Framework - cocoon-block-petstore : Java XML Framework - cocoon-block-portal : Java XML Framework - cocoon-block-portal-sample : Java XML Framework - cocoon-block-profiler : Java XML Framework - cocoon-block-proxy : Java XML Framework - cocoon-block-python : Java XML Framework - cocoon-block-qdox : Java XML Framework - cocoon-block-querybean : Java XML Framework - cocoon-block-repository : Java XML Framework - cocoon-block-scratchpad : Java XML Framework - cocoon-block-serializers : Java XML Framework - cocoon-block-session-fw : Java XML Framework - cocoon-block-slop : Java XML Framework - cocoon-block-spring-app : A demo for Spring and Cocoon - cocoon-block-stx : Java XML Framework - cocoon-block-taglib : Java XML Framework - cocoon-block-template : Java XML Framework - cocoon-block-tour : Java XML Framework - cocoon-block-validation : In-pipeline validation of documents - cocoon-block-velocity : Java XML Framework - cocoon-block-web3 : Java XML Framework - cocoon-block-xmldb : Java XML Framework - cocoon-block-xsp : Java XML Framework - commons-vfs : Jakarta commons - excalibur-fortress-bean : Repository of reusable components. - excalibur-fortress-container-impl : Repository of reusable components. - excalibur-fortress-container-test : Repository of reusable components. - excalibur-fortress-examples : Repository of reusable components. - excalibur-fortress-migration : Repository of reusable components. - excalibur-fortress-platform : Repository of reusable components. - excalibur-fortress-testcase : Repository of reusable components. - excalibur-monitor : Repository of reusable components. - excalibur-sourceresolve : Repository of reusable components. - excalibur-xmlutil : Repository of reusable components. - forrest : Apache Forrest is an XML standards-oriented documentation fr... - forrest-test : Apache Forrest is an XML standards-oriented documentation fr... - lenya : Content Management System - logging-log4j-chainsaw : Chainsaw log viewer Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-vfs/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-vfs-31122005.jar] identifier set to project name -INFO- Optional dependency commons-net failed with reason build failed -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/vfs/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/vfs/target/test-classes] -INFO- Failed with reason build
[EMAIL PROTECTED]: Project commons-vfs (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-vfs has an issue affecting its community integration. This issue affects 72 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - cocoon : Java XML Framework - cocoon-block-ajax : Ajax - Utilities and resources for Ajax applications. - cocoon-block-apples : Java XML Framework - cocoon-block-asciiart : Java XML Framework - cocoon-block-authentication-fw : Java XML Framework - cocoon-block-axis : Java XML Framework - cocoon-block-batik : Java XML Framework - cocoon-block-bsf : Java XML Framework - cocoon-block-captcha : Utilites to generate simple CAPTCHAs - cocoon-block-chaperon : Java XML Framework - cocoon-block-core-samples-additional : Additional core samples. - cocoon-block-core-samples-main : Main core samples. - cocoon-block-cron : Java XML Framework - cocoon-block-databases : Java XML Framework - cocoon-block-deli : Java XML Framework - cocoon-block-eventcache : Java XML Framework - cocoon-block-faces : Java XML Framework - cocoon-block-fop : Java XML Framework - cocoon-block-forms : Java XML Framework - cocoon-block-hsqldb : Java XML Framework - cocoon-block-html : Java XML Framework - cocoon-block-itext : Java XML Framework - cocoon-block-javaflow : Java XML Framework - cocoon-block-jcr : A jcr: protocol for Cocoon - cocoon-block-jfor : Java XML Framework - cocoon-block-jms : Java XML Framework - cocoon-block-jsp : Java XML Framework - cocoon-block-linkrewriter : Java XML Framework - cocoon-block-lucene : Java XML Framework - cocoon-block-mail : Java XML Framework - cocoon-block-midi : Java XML Framework - cocoon-block-naming : Java XML Framework - cocoon-block-ojb : Java XML Framework - cocoon-block-paranoid : Java XML Framework - cocoon-block-petstore : Java XML Framework - cocoon-block-portal : Java XML Framework - cocoon-block-portal-sample : Java XML Framework - cocoon-block-profiler : Java XML Framework - cocoon-block-proxy : Java XML Framework - cocoon-block-python : Java XML Framework - cocoon-block-qdox : Java XML Framework - cocoon-block-querybean : Java XML Framework - cocoon-block-repository : Java XML Framework - cocoon-block-scratchpad : Java XML Framework - cocoon-block-serializers : Java XML Framework - cocoon-block-session-fw : Java XML Framework - cocoon-block-slop : Java XML Framework - cocoon-block-spring-app : A demo for Spring and Cocoon - cocoon-block-stx : Java XML Framework - cocoon-block-taglib : Java XML Framework - cocoon-block-template : Java XML Framework - cocoon-block-tour : Java XML Framework - cocoon-block-validation : In-pipeline validation of documents - cocoon-block-velocity : Java XML Framework - cocoon-block-web3 : Java XML Framework - cocoon-block-xmldb : Java XML Framework - cocoon-block-xsp : Java XML Framework - commons-vfs : Jakarta commons - excalibur-fortress-bean : Repository of reusable components. - excalibur-fortress-container-impl : Repository of reusable components. - excalibur-fortress-container-test : Repository of reusable components. - excalibur-fortress-examples : Repository of reusable components. - excalibur-fortress-migration : Repository of reusable components. - excalibur-fortress-platform : Repository of reusable components. - excalibur-fortress-testcase : Repository of reusable components. - excalibur-monitor : Repository of reusable components. - excalibur-sourceresolve : Repository of reusable components. - excalibur-xmlutil : Repository of reusable components. - forrest : Apache Forrest is an XML standards-oriented documentation fr... - forrest-test : Apache Forrest is an XML standards-oriented documentation fr... - lenya : Content Management System - logging-log4j-chainsaw : Chainsaw log viewer Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-vfs/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-vfs-31122005.jar] identifier set to project name -INFO- Optional dependency commons-net failed with reason build failed -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/vfs/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/vfs/target/test-classes] -INFO- Failed with reason build
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 14 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-xml-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-xml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-xml-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-xml-test/gump_work/build_commons-jelly_commons-jelly-tags-xml-test.html Work Name: build_commons-jelly_commons-jelly-tags-xml-test (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 14 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetSingleNodeAndAsString(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:294:81: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testSetStringLists(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/xml/target/test-classes/org/apache/commons/jelly/tags/xml/suite.jelly:339:82: x:set You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.SetTag.doTag(SetTag.java:86) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testEntities(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-swing (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-swing has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-swing : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-swing/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-swing-31122005.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/target/test-reports -WARNING- No directory [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/target/test-reports] -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-swing/gump_work/build_commons-jelly_commons-jelly-tags-swing.html Work Name: build_commons-jelly_commons-jelly-tags-swing (Type: Build) Work ended in a state of : Failed Elapsed: 11 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/commons-jelly-tags-define-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/interaction/target/commons-jelly-tags-interaction-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27) at java.lang.reflect.Constructor.newInstance(Constructor.java:274) at java.lang.Class.newInstance0(Class.java:308) at java.lang.Class.newInstance(Class.java:261) at org.apache.commons.jelly.JellyContext.getTagLibrary(JellyContext.java:432) at org.apache.maven.jelly.MavenJellyContext.getTagLibrary(MavenJellyContext.java:171) at org.apache.commons.jelly.parser.XMLParser.createTag(XMLParser.java:1033) at org.apache.commons.jelly.parser.XMLParser.startElement(XMLParser.java:647) at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source) at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source) at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.DTDConfiguration.parse(Unknown Source) at
[EMAIL PROTECTED]: Project commons-jelly-tags-swing (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-swing has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-swing : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-swing/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-swing-31122005.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/target/test-reports -WARNING- No directory [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing/target/test-reports] -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-swing/gump_work/build_commons-jelly_commons-jelly-tags-swing.html Work Name: build_commons-jelly_commons-jelly-tags-swing (Type: Build) Work ended in a state of : Failed Elapsed: 11 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/swing] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/commons-jelly-tags-define-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/interaction/target/commons-jelly-tags-interaction-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27) at java.lang.reflect.Constructor.newInstance(Constructor.java:274) at java.lang.Class.newInstance0(Class.java:308) at java.lang.Class.newInstance(Class.java:261) at org.apache.commons.jelly.JellyContext.getTagLibrary(JellyContext.java:432) at org.apache.maven.jelly.MavenJellyContext.getTagLibrary(MavenJellyContext.java:171) at org.apache.commons.jelly.parser.XMLParser.createTag(XMLParser.java:1033) at org.apache.commons.jelly.parser.XMLParser.startElement(XMLParser.java:647) at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source) at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source) at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.DTDConfiguration.parse(Unknown Source) at
DO NOT REPLY [Bug 35828] - [configuration] Instance specific list delimiter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=35828. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35828 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #17290|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-12-31 19:17 --- Created an attachment (id=17301) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17301action=view) Patch which solves the bug and adds delimiter disabling capability (revision) Here is a new version of the patch which the following addons: - Keep binary compatibility - Fix issue with XMLBuilderVisitor: I opted for the delimiter in constructor solution as it is the one which requires less code changes (and I don't know the functionality of this class so well to dare to make big changes) - Updated to latest SVN head (revision 360268) Of course all tests have been successfully rerun again. I'd thank help testing this out. Please send me failing test cases if you find some bug. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 41 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.jaxen.saxpath.base.XPathReader.unionExpr(XPathReader.java:1129) [junit] at org.jaxen.saxpath.base.XPathReader.unaryExpr(XPathReader.java:1117) [junit] at org.jaxen.saxpath.base.XPathReader.multiplicativeExpr(XPathReader.java:1039) [junit] at org.jaxen.saxpath.base.XPathReader.additiveExpr(XPathReader.java:982) [junit] at org.jaxen.saxpath.base.XPathReader.relationalExpr(XPathReader.java:902) [junit] at org.jaxen.saxpath.base.XPathReader.equalityExpr(XPathReader.java:850) [junit] at org.jaxen.saxpath.base.XPathReader.andExpr(XPathReader.java:826) [junit] at org.jaxen.saxpath.base.XPathReader.orExpr(XPathReader.java:804) [junit] at org.jaxen.saxpath.base.XPathReader.expr(XPathReader.java:797) [junit] at org.jaxen.saxpath.base.XPathReader.parse(XPathReader.java:105) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:126) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:152) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 41 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.jaxen.saxpath.base.XPathReader.unionExpr(XPathReader.java:1129) [junit] at org.jaxen.saxpath.base.XPathReader.unaryExpr(XPathReader.java:1117) [junit] at org.jaxen.saxpath.base.XPathReader.multiplicativeExpr(XPathReader.java:1039) [junit] at org.jaxen.saxpath.base.XPathReader.additiveExpr(XPathReader.java:982) [junit] at org.jaxen.saxpath.base.XPathReader.relationalExpr(XPathReader.java:902) [junit] at org.jaxen.saxpath.base.XPathReader.equalityExpr(XPathReader.java:850) [junit] at org.jaxen.saxpath.base.XPathReader.andExpr(XPathReader.java:826) [junit] at org.jaxen.saxpath.base.XPathReader.orExpr(XPathReader.java:804) [junit] at org.jaxen.saxpath.base.XPathReader.expr(XPathReader.java:797) [junit] at org.jaxen.saxpath.base.XPathReader.parse(XPathReader.java:105) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:126) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:152) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at
Re: Javaflow and ASM
By the way I thought you might find this amusing: Javaflow - the ultimate fresh-brewed coffee dispenser! http://www.javaflowllc.com/ -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 45 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:58) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:79) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:58) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 45 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar - [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:58) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:79) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:58) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at
Re: Javaflow and ASM
Kohsuke Kawaguchi wrote: So if you don't mind, I'm happy to make the necessary changes. Please go ahead. And if you don't mind please send me the test results you'll get. Will do. I added a new property to select the transformer, and tried to use ASM. I found a few issues. - ContinuationMethodAdapter.visitMaxs was passing (0,0) to the next visitor. I'm not too familiar with this, but don't we need to basically pass through values? It is actually ok. ClassWriter is used with computeMaxs flag, so visitMaxs() method is basically an indicator and its params are ignored. It might be possible to caclulate stack and locals but I decided not spend time on this for now. - When moving 'new' instructions, local variables are allocated excessively. I think it would be better for it to be used little more conservatively. Namely, the number of additional local variables for save/restore should be max of all constructor parameter counts, not sum of them. I spotted this too and tried to fix this but haven't completed yet. It seems that instead of using MethodNode.maxLocals as a stackRecorderVar its value should be memorized and vars for param restoration should be always started from that value + 1 - When moving 'new' instructions, The maxStacks field isn't updated correctly, but I think we needed this. It will be recalculated automatically when ClassWriter is used with computeMaxs - While instrumenting the FinallyFlow class, I found that ContinuationMethodAdapter.visitMethodInsn dies while trying to save a local variable that has a JSR return address in it. I don't think we can instrument method invocations in a finally block, so there needs to be code that checks it (I don't know how BCEL version is doing that, though) Another option could be to inline these blocks. I believe that one of the projects, which been using ASM did that already and we can just reuse it. I actually was thinking to package it with the asm-commons or something. regards, Eugene - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-31122005.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 36 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-31122005.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 36 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-31122005.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-31122005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-31122005.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-6/jaxen-1.1-beta-6.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
Re: Javaflow and ASM
Kohsuke Kawaguchi wrote: - When moving 'new' instructions, local variables are allocated excessively. I think it would be better for it to be used little more conservatively. Namely, the number of additional local variables for save/restore should be max of all constructor parameter counts, not sum of them. I spotted this too and tried to fix this but haven't completed yet. It seems that instead of using MethodNode.maxLocals as a stackRecorderVar its value should be memorized and vars for param restoration should be always started from that value + 1 Yes. Can you carry on this or would prefer a patch from me? - When moving 'new' instructions, The maxStacks field isn't updated correctly, but I think we needed this. It will be recalculated automatically when ClassWriter is used with computeMaxs Hmm. I got insufficient stack size error or something like that when I didn't do anything. I added maxStack += 10 for a try and that made it work, which made me suspect of this issue. That could be a error from analyzer. If so, we may not get away without fixing maxstack or will have to run a complete stack computation algorithm. - While instrumenting the FinallyFlow class, I found that ContinuationMethodAdapter.visitMethodInsn dies while trying to save a local variable that has a JSR return address in it. I don't think we can instrument method invocations in a finally block, so there needs to be code that checks it (I don't know how BCEL version is doing that, though) Another option could be to inline these blocks. I believe that one of the projects, which been using ASM did that already and we can just reuse it. I actually was thinking to package it with the asm-commons or something. That sounds like a good idea. That is why I've added Eric to this discussion. So, we can find an acceptable way to integrate this feature. With such code where the same set of byte code is copied into multiple places, would it still be possible for a user to set a breakpoint and etc correctly? As of breakpoints, they are working based on line number information and because code is basically identical we can just copy this info to both places. BTW Java6 and CLDC preverifier both doing this for finally blocks bytecode. It is actually interesting. The same line number can be referenced from several places in the bytecode and finally blocks are not the only case for this. If I recall correctly the same also happens for the loop constructs as well as for constructor and static initializers. regards, Eugene - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r360469 - /jakarta/commons/trunks-sandbox/pom.xml
Author: brett Date: Sat Dec 31 18:10:20 2005 New Revision: 360469 URL: http://svn.apache.org/viewcvs?rev=360469view=rev Log: add snapshot repositories Modified: jakarta/commons/trunks-sandbox/pom.xml Modified: jakarta/commons/trunks-sandbox/pom.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/trunks-sandbox/pom.xml?rev=360469r1=360468r2=360469view=diff == --- jakarta/commons/trunks-sandbox/pom.xml (original) +++ jakarta/commons/trunks-sandbox/pom.xml Sat Dec 31 18:10:20 2005 @@ -9,6 +9,9 @@ nameJakarta Commons Sandbox/name urlhttp://jakarta.apache.org/commons/sandbox//url inceptionYear2001/inceptionYear + prerequisites +maven2.0.2-SNAPSHOT/maven + /prerequisites ciManagement systemcontinuum/system notifiers @@ -119,5 +122,21 @@ moduleexec/module moduleopenpgp/module /modules + !-- TODO: temporary until site plugin is released -- + pluginRepositories +pluginRepository + idsnapshots/id + nameSnapshot Repository/name + urlhttp://snapshots.maven.codehaus.org/maven2/url +/pluginRepository + /pluginRepositories + !-- TODO: temporary until skins are released -- + repositories +repository + idapache.snapshots/id + nameSnapshot Repository/name + urlhttp://cvs.apache.org/maven-snapshot-repository/url +/repository + /repositories /project - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Commons, Maven, Site, Release
Hi Dennis, Thanks for trying this out. Sorry I left a couple of holes. I've uploaded everything, and removed it locally, and verified it works. The instructions are now: - Download latest integration build from http://maven.zones.apache.org/~maven/builds/branches/maven-2.0.x/ and install per normal m2 instructions (the site will require Maven 2.0.2, due for release in the next couple of weeks) - run mvn site from trunks-sandbox Let me know how it goes! Cheers, Brett Dennis Lundberg wrote: Hi Brett I finally found some time to try out the new Maven 2 site stuff that you have put into the sandbox. There are quite a few hurdles to jump over though and I think I fell on the last one. Hope you can help me out. Here's what I did: - Bootstrapped Maven from the 2.0.x branch - Added to the sandbox pom.xml a build/plugins/plugin/version tag for maven-site-plugin and set it to 2.0-SNAPSHOT, to get all the fancy new stuff - Added a skin/version tag, with the value '1.0-SNAPSHOT' to src/site.xml, otherwise it tried to download the release version - Added snapshot repositories to the sandbox pom - When I run 'mvn site' in sandbox-trunks I get an error from Maven when it is trying to download the classic-skin, see stack trace below - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[RESULT] [VOTE] Demote feedparser to sandbox/dormant
This vote has passed. 5 +1 (PMC - psteitz, bayard, scolebourne, mfncooper, commiter - rahul) 2 +0 (PMC - tcurdt, committer - joehni) No negative votes. I will make the necessary changes to the web site and svn to reflect the move. Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Logging/1.0.5ReleasePlan by SimonKitching
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by SimonKitching: http://wiki.apache.org/jakarta-commons/Logging/1%2e0%2e5ReleasePlan The comment on the change is: Point at 1.1 release plan -- == Status == - RELEASE PLAN: Release candidate 1 available + Release cancelled. After an initial release candidate was created, it was decided to do additional significant work. + This new work is being released as version 1.1; see the release plan for that version for details. + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-net (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-net has an issue affecting its community integration. This issue affects 88 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - apache-ldapber-provider : Apache Directory Project - apacheds-core : Apache Directory Server - apacheds-main : Apache Directory Server - apacheds-shared : Apache Directory Server - asn1-ber : Apache ASN.1 Tools - asn1-codec : Apache ASN.1 Tools - cocoon : Java XML Framework - cocoon-block-ajax : Ajax - Utilities and resources for Ajax applications. - cocoon-block-apples : Java XML Framework - cocoon-block-asciiart : Java XML Framework - cocoon-block-authentication-fw : Java XML Framework - cocoon-block-axis : Java XML Framework - cocoon-block-batik : Java XML Framework - cocoon-block-bsf : Java XML Framework - cocoon-block-captcha : Utilites to generate simple CAPTCHAs - cocoon-block-chaperon : Java XML Framework - cocoon-block-core-samples-additional : Additional core samples. - cocoon-block-core-samples-main : Main core samples. - cocoon-block-cron : Java XML Framework - cocoon-block-databases : Java XML Framework - cocoon-block-deli : Java XML Framework - cocoon-block-eventcache : Java XML Framework - cocoon-block-faces : Java XML Framework - cocoon-block-fop : Java XML Framework - cocoon-block-forms : Java XML Framework - cocoon-block-hsqldb : Java XML Framework - cocoon-block-html : Java XML Framework - cocoon-block-itext : Java XML Framework - cocoon-block-javaflow : Java XML Framework - cocoon-block-jcr : A jcr: protocol for Cocoon - cocoon-block-jfor : Java XML Framework - cocoon-block-jms : Java XML Framework - cocoon-block-jsp : Java XML Framework - cocoon-block-linkrewriter : Java XML Framework - cocoon-block-lucene : Java XML Framework - cocoon-block-mail : Java XML Framework - cocoon-block-midi : Java XML Framework - cocoon-block-naming : Java XML Framework - cocoon-block-ojb : Java XML Framework - cocoon-block-paranoid : Java XML Framework - cocoon-block-petstore : Java XML Framework - cocoon-block-portal : Java XML Framework - cocoon-block-portal-sample : Java XML Framework - cocoon-block-profiler : Java XML Framework - cocoon-block-proxy : Java XML Framework - cocoon-block-python : Java XML Framework - cocoon-block-qdox : Java XML Framework - cocoon-block-querybean : Java XML Framework - cocoon-block-repository : Java XML Framework - cocoon-block-scratchpad : Java XML Framework - cocoon-block-serializers : Java XML Framework - cocoon-block-session-fw : Java XML Framework - cocoon-block-slop : Java XML Framework - cocoon-block-spring-app : A demo for Spring and Cocoon - cocoon-block-stx : Java XML Framework - cocoon-block-taglib : Java XML Framework - cocoon-block-template : Java XML Framework - cocoon-block-tour : Java XML Framework - cocoon-block-validation : In-pipeline validation of documents - cocoon-block-velocity : Java XML Framework - cocoon-block-web3 : Java XML Framework - cocoon-block-xmldb : Java XML Framework - cocoon-block-xsp : Java XML Framework - commons-net : Commons Net - commons-vfs : Jakarta commons - excalibur-fortress-bean : Repository of reusable components. - excalibur-fortress-container-impl : Repository of reusable components. - excalibur-fortress-container-test : Repository of reusable components. - excalibur-fortress-examples : Repository of reusable components. - excalibur-fortress-migration : Repository of reusable components. - excalibur-fortress-platform : Repository of reusable components. - excalibur-fortress-testcase : Repository of reusable components. - excalibur-monitor : Repository of reusable components. - excalibur-sourceresolve : Repository of reusable components. - excalibur-xmlutil : Repository of reusable components. - forrest : Apache Forrest is an XML standards-oriented documentation fr... - forrest-test : Apache Forrest is an XML standards-oriented documentation fr... - james-server : James Server - kerberos-common : Apache Directory Project - kerberos-protocol : Apache Kerberos Server - ldap-common : Apache Directory Project - ldap-protocol : Apache Directory Server - ldap-snacc-provider : Apache Directory Project - lenya : Content Management System - logging-log4j-chainsaw : Chainsaw log viewer - maven-directory-plugin : Apache Directory Server - mina : A Multipurpose
[EMAIL PROTECTED]: Project commons-net (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-net has an issue affecting its community integration. This issue affects 88 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - apache-ldapber-provider : Apache Directory Project - apacheds-core : Apache Directory Server - apacheds-main : Apache Directory Server - apacheds-shared : Apache Directory Server - asn1-ber : Apache ASN.1 Tools - asn1-codec : Apache ASN.1 Tools - cocoon : Java XML Framework - cocoon-block-ajax : Ajax - Utilities and resources for Ajax applications. - cocoon-block-apples : Java XML Framework - cocoon-block-asciiart : Java XML Framework - cocoon-block-authentication-fw : Java XML Framework - cocoon-block-axis : Java XML Framework - cocoon-block-batik : Java XML Framework - cocoon-block-bsf : Java XML Framework - cocoon-block-captcha : Utilites to generate simple CAPTCHAs - cocoon-block-chaperon : Java XML Framework - cocoon-block-core-samples-additional : Additional core samples. - cocoon-block-core-samples-main : Main core samples. - cocoon-block-cron : Java XML Framework - cocoon-block-databases : Java XML Framework - cocoon-block-deli : Java XML Framework - cocoon-block-eventcache : Java XML Framework - cocoon-block-faces : Java XML Framework - cocoon-block-fop : Java XML Framework - cocoon-block-forms : Java XML Framework - cocoon-block-hsqldb : Java XML Framework - cocoon-block-html : Java XML Framework - cocoon-block-itext : Java XML Framework - cocoon-block-javaflow : Java XML Framework - cocoon-block-jcr : A jcr: protocol for Cocoon - cocoon-block-jfor : Java XML Framework - cocoon-block-jms : Java XML Framework - cocoon-block-jsp : Java XML Framework - cocoon-block-linkrewriter : Java XML Framework - cocoon-block-lucene : Java XML Framework - cocoon-block-mail : Java XML Framework - cocoon-block-midi : Java XML Framework - cocoon-block-naming : Java XML Framework - cocoon-block-ojb : Java XML Framework - cocoon-block-paranoid : Java XML Framework - cocoon-block-petstore : Java XML Framework - cocoon-block-portal : Java XML Framework - cocoon-block-portal-sample : Java XML Framework - cocoon-block-profiler : Java XML Framework - cocoon-block-proxy : Java XML Framework - cocoon-block-python : Java XML Framework - cocoon-block-qdox : Java XML Framework - cocoon-block-querybean : Java XML Framework - cocoon-block-repository : Java XML Framework - cocoon-block-scratchpad : Java XML Framework - cocoon-block-serializers : Java XML Framework - cocoon-block-session-fw : Java XML Framework - cocoon-block-slop : Java XML Framework - cocoon-block-spring-app : A demo for Spring and Cocoon - cocoon-block-stx : Java XML Framework - cocoon-block-taglib : Java XML Framework - cocoon-block-template : Java XML Framework - cocoon-block-tour : Java XML Framework - cocoon-block-validation : In-pipeline validation of documents - cocoon-block-velocity : Java XML Framework - cocoon-block-web3 : Java XML Framework - cocoon-block-xmldb : Java XML Framework - cocoon-block-xsp : Java XML Framework - commons-net : Commons Net - commons-vfs : Jakarta commons - excalibur-fortress-bean : Repository of reusable components. - excalibur-fortress-container-impl : Repository of reusable components. - excalibur-fortress-container-test : Repository of reusable components. - excalibur-fortress-examples : Repository of reusable components. - excalibur-fortress-migration : Repository of reusable components. - excalibur-fortress-platform : Repository of reusable components. - excalibur-fortress-testcase : Repository of reusable components. - excalibur-monitor : Repository of reusable components. - excalibur-sourceresolve : Repository of reusable components. - excalibur-xmlutil : Repository of reusable components. - forrest : Apache Forrest is an XML standards-oriented documentation fr... - forrest-test : Apache Forrest is an XML standards-oriented documentation fr... - james-server : James Server - kerberos-common : Apache Directory Project - kerberos-protocol : Apache Kerberos Server - ldap-common : Apache Directory Project - ldap-protocol : Apache Directory Server - ldap-snacc-provider : Apache Directory Project - lenya : Content Management System - logging-log4j-chainsaw : Chainsaw log viewer - maven-directory-plugin : Apache Directory Server - mina : A Multipurpose
svn commit: r360479 - in /jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging: PathableClassLoader.java PathableTestSuite.java
Author: skitching Date: Sat Dec 31 23:42:12 2005 New Revision: 360479 URL: http://svn.apache.org/viewcvs?rev=360479view=rev Log: Tidy imports only Modified: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java Modified: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java?rev=360479r1=360478r2=360479view=diff == --- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java (original) +++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableClassLoader.java Sat Dec 31 23:42:12 2005 @@ -16,19 +16,16 @@ package org.apache.commons.logging; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; import java.net.URL; import java.net.URLClassLoader; -// TODO: use Hashtable instead of HashMap -import java.util.Map; +// TODO: use HashTable instead of HashMap for java1.2 support import java.util.HashMap; import java.util.Iterator; - -import java.util.Enumeration; -import java.util.Vector; -import java.io.File; -import java.io.InputStream; -import java.io.IOException; +import java.util.Map; /** * A ClassLoader which sees only specified classes, and which can be Modified: jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java?rev=360479r1=360478r2=360479view=diff == --- jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java (original) +++ jakarta/commons/proper/logging/trunk/src/test/org/apache/commons/logging/PathableTestSuite.java Sat Dec 31 23:42:12 2005 @@ -17,9 +17,10 @@ package org.apache.commons.logging; import java.util.Properties; + import junit.framework.Test; -import junit.framework.TestSuite; import junit.framework.TestResult; +import junit.framework.TestSuite; /** * Custom TestSuite class that can be used to control the context classloader - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
