Re: Collections-events
Michael Heuer wrote: Bryce L Nordgren wrote: I also believe that Michael Heuer may have released something related on java.net? Sorry for chiming in late, my stuff is in cvs at java.net but was never released. I would be willing to help revive collections-events if there is interest. Even more so if it can happen with generics support. Logically, this would be a generics only project now. Does this affect you Bryce? (If it does, then perhaps we might need to try retro*) Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412694 - /jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml
Author: bayard Date: Thu Jun 8 01:00:15 2006 New Revision: 412694 URL: http://svn.apache.org/viewvc?rev=412694view=rev Log: Setting release date Modified: jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml?rev=412694r1=412693r2=412694view=diff == --- jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/fileupload/trunk/xdocs/changes.xml Thu Jun 8 01:00:15 2006 @@ -41,7 +41,7 @@ body -release version=1.1.1 date=In SVN description=Bugfix release +release version=1.1.1 date=2006-06-08 description=Bugfix release action dev=martinc type=fix issue=FILEUPLOAD-20 Cache disk file item size when it is moved to a new location. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412695 - /jakarta/commons/proper/fileupload/trunk/project.properties
Author: bayard Date: Thu Jun 8 01:00:53 2006 New Revision: 412695 URL: http://svn.apache.org/viewvc?rev=412695view=rev Log: Hardcoding last release to 2005.12.24 in for release Modified: jakarta/commons/proper/fileupload/trunk/project.properties Modified: jakarta/commons/proper/fileupload/trunk/project.properties URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/project.properties?rev=412695r1=412694r2=412695view=diff == --- jakarta/commons/proper/fileupload/trunk/project.properties (original) +++ jakarta/commons/proper/fileupload/trunk/project.properties Thu Jun 8 01:00:53 2006 @@ -43,7 +43,8 @@ maven.linkcheck.enable=true maven.changelog.type=date -maven.changelog.date=lastRelease +#maven.changelog.date=lastRelease +maven.changelog.date=2005-12-24 # documentation properties maven.xdoc.date=left - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412697 - /jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf
Author: bayard Date: Thu Jun 8 01:01:23 2006 New Revision: 412697 URL: http://svn.apache.org/viewvc?rev=412697view=rev Log: Adding new release Modified: jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf Modified: jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf?rev=412697r1=412696r2=412697view=diff == --- jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf (original) +++ jakarta/commons/proper/fileupload/trunk/doap_fileupload.rdf Thu Jun 8 01:01:23 2006 @@ -24,6 +24,11 @@ release revision namecommons-fileupload/name +created2006-06-08/created +version1.1.1/version + /revision + revision +namecommons-fileupload/name created2005-12-23/created version1.1/version /revision - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412698 - /jakarta/commons/proper/fileupload/trunk/project.xml
Author: bayard Date: Thu Jun 8 01:02:18 2006 New Revision: 412698 URL: http://svn.apache.org/viewvc?rev=412698view=rev Log: Adding 1.1.1 tag Modified: jakarta/commons/proper/fileupload/trunk/project.xml Modified: jakarta/commons/proper/fileupload/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/project.xml?rev=412698r1=412697r2=412698view=diff == --- jakarta/commons/proper/fileupload/trunk/project.xml (original) +++ jakarta/commons/proper/fileupload/trunk/project.xml Thu Jun 8 01:02:18 2006 @@ -77,6 +77,11 @@ versions version + id1.1.1/id + name1.1.1/name + tagFILEUPLOAD_1_1_1/tag +/version +version id1.1/id name1.1/name tagFILEUPLOAD_1_1/tag - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412699 - /jakarta/commons/proper/fileupload/trunk/xdocs/index.xml
Author: bayard Date: Thu Jun 8 01:03:19 2006 New Revision: 412699 URL: http://svn.apache.org/viewvc?rev=412699view=rev Log: Setting release date Modified: jakarta/commons/proper/fileupload/trunk/xdocs/index.xml Modified: jakarta/commons/proper/fileupload/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/xdocs/index.xml?rev=412699r1=412698r2=412699view=diff == --- jakarta/commons/proper/fileupload/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/fileupload/trunk/xdocs/index.xml Thu Jun 8 01:03:19 2006 @@ -56,7 +56,7 @@ section name=Downloading subsection name='Full Releases' p -strongFileUpload 1.1.1/strong - ?? May 2006 +strongFileUpload 1.1.1/strong - 08 June 2006 ul liDownload the binary and source distributions from a mirror site a href='http://jakarta.apache.org/site/downloads/downloads_commons-fileupload.cgi'here/a - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412700 - /jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/
Author: bayard Date: Thu Jun 8 01:05:21 2006 New Revision: 412700 URL: http://svn.apache.org/viewvc?rev=412700view=rev Log: Tagging the 1.1.1 release Added: jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/ - copied from r412699, jakarta/commons/proper/fileupload/trunk/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412702 - /jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml
Author: bayard Date: Thu Jun 8 01:11:42 2006 New Revision: 412702 URL: http://svn.apache.org/viewvc?rev=412702view=rev Log: Fixing version Modified: jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml Modified: jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml?rev=412702r1=412701r2=412702view=diff == --- jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml (original) +++ jakarta/commons/proper/fileupload/tags/FILEUPLOAD_1_1_1/project.xml Thu Jun 8 01:11:42 2006 @@ -21,7 +21,7 @@ nameFileUpload/name groupIdcommons-fileupload/groupId artifactIdcommons-fileupload/artifactId - currentVersion1.1.1-RC1/currentVersion + currentVersion1.1.1/currentVersion inceptionYear2002/inceptionYear shortDescriptionFile upload component for Java servlets/shortDescription description - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412703 - /jakarta/commons/proper/fileupload/trunk/project.xml
Author: bayard Date: Thu Jun 8 01:12:40 2006 New Revision: 412703 URL: http://svn.apache.org/viewvc?rev=412703view=rev Log: Fixing version to the 1.1.1. Modified: jakarta/commons/proper/fileupload/trunk/project.xml Modified: jakarta/commons/proper/fileupload/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/project.xml?rev=412703r1=412702r2=412703view=diff == --- jakarta/commons/proper/fileupload/trunk/project.xml (original) +++ jakarta/commons/proper/fileupload/trunk/project.xml Thu Jun 8 01:12:40 2006 @@ -21,7 +21,7 @@ nameFileUpload/name groupIdcommons-fileupload/groupId artifactIdcommons-fileupload/artifactId - currentVersion1.1.1-RC1/currentVersion + currentVersion1.1.1/currentVersion inceptionYear2002/inceptionYear shortDescriptionFile upload component for Java servlets/shortDescription description - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [all] change group id? [WAS Re: [logging] RC on ibiblio ?]
AFAIK maven1 repo is simply a rewriteRule on maven2 repo, so that new
artifacts under org.apache.commons groupId in maven2 repo will be
available in maven1 repo under org.apache.commons/jars/artifact.jar
This may suggest to use a more specific groupId for commons, like
org.apache.commons.*lang*
to keep commons separation in maven1 repo.
Dennis Lundberg a écrit :
Carlos Sanchez wrote:
Are you thinking about doing it in the m1 or m2 repo?
I really don't have a clue. Since I have not acted as release manager
for any component, I haven't really done my homework on what the
difference between the two is. I know about the M1 an M2 repos at
ibiblio, and that there is some sort of conversion between them, but
don't know what it looks like at the Apache end.
Do you have any suggestions on which is better?
see below
On 6/7/06, Dennis Lundberg [EMAIL PROTECTED] wrote:
So, in the simple example below, covering commons-lang, the procedure
would be:
1. Copy all files from /commons-lang/ to
/org/apache/commons/commons-lang/ in the *Apache* repo
2. Change the groupId of all the pom files under
/org/apache/commons/commons-lang/ so that they use the
org.apache.commons groupId
3. Add relocation elements to all pom files in /commons-lang/ pointing
them to org.apache.commons like this:
relocation
groupIdorg.apache.commons/groupId
/relocation
If I understand the model documentation correctly, we shouldn't have to
use artifactId or version since they are the same. But should we add a
message ?
I never did.
4. Wait for a sync between the Apache repo and ibiblio, or is this
something that we need to ping someone about?
m1 repo - wait
m2 repo - ping
OK
Is that correct so far?
When we later decide to release our first artifact using the new
groupId, should we also copy it to the repo using the groupId? My gut
feeling says no, but it's best to ask.
no
OK
If I want to try this out locally first, can I test it in my local repo
${user.home}/.m2/repository/... or do I need to use a local httpd
serving as a central repo?
local is ok
Cool, I'll have a go at it, to see it I can get it right. It'll have
to wait until this weekend though.
--
Dennis Lundberg
Carlos Sanchez wrote:
You are right. This would involve copying all the old group sutff to
the new group and add the relocation poms.
On 6/7/06, Nicolas De Loof [EMAIL PROTECTED] wrote:
AFAIK there is a way in maven repo to relocate dependencies, so
that a
POM for any commons can be published at commons-xxx groupId, that
relocates to org.apache.commons groupId.
Servletapi for example is now under javax.servlet
http://www.ibiblio.org/maven2/servletapi/servletapi/2.4/servletapi-2.4.pom
Using this, when maven2 search for the latest release of any
commons
it will look at the relocated one.
Torsten Curdt a écrit :
Brett,
any comments on this?
cheers
--
Torsten
On 6/6/06, Dennis Lundberg [EMAIL PROTECTED] wrote:
Brett, I did the test that you suggested.
1. Installed commons-lang 1.0.1 into my local repo with
groupId=org.apache.commons
mvn install:install-file -DgroupId=org.apache.commons
-DartifactId=commons-lang -Dversion=1.0.1 -Dpackaging=jar
-Dfile=/path/to/commons-lang-1.0.1.jar
2. Created Maven 2 projects a, b and c with the dependencies
mentioned
below.
3. Installed projects a and b into my local repo
mvn install
4. packaged project c as a war
mvn package
The resulting war file includes both commons-lang-1.0.1.jar and
commons-lang-2.1.jar which was what you thought would happen.
So this is bad, I guess. Anyone who uses commons components
transitively
in a Maven 2 environment are likely to be bitten by this. They
must
keep
the same groupId for all commons-lang dependencies, as an
example, in
the entire chain of transitive dependencies. I.e. they can't mix
groupId=commons-lang and groupId=org.apache.commons. This can
be a
PITA
since some of the dependencies are most likely out of the
projects own
control.
What do you suggest we do? Should we wait with this relocation
until a
version of Maven 2 is released that can handle these kind of
dependencies?
--
Dennis Lundberg
Brett Porter wrote:
an extensive test should be something along the lines of:
project A depends on commons-lang:commons-lang 2.1
project B depends on o.a.c:commons-lang 1.0
project C is a webapp that depends on A and B
webapp should have only one commons-lang.
You could do this with your own repository (and something
completely
artificial instead of commons-lang if it makes it easier).
- Brett
Dennis Lundberg wrote:
Hi Brett
Sorry, I misunderstood you regarding when to do the
testing. So,
no I
haven't done the test, yet. Can you elaborate a bit more on
what
needs
to be tested? Perhaps you know of an artifact that has been
relocated
that we can have a
Re: [RESULT] Release FileUpload 1.1.1-RC1 (take two)
tar.gz and zip files are in place. signed, md5'd, current symlinked, my key added to KEYS main site is updated jars are in the m1 repo, signed and md5'd poms are too old fileupload site is replaced with new one tag exists (had to make one edit to it as I forgot to change the version from RC1) release i performed in JIRA Going to sleep on it and let mirrors/site sync do their thing, then will send an announcement email in the morning. javadoc and source jars aren't done for the m1 repo yet; tending to do those in batches rather than individually. Hen On 6/7/06, Henri Yandell [EMAIL PROTECTED] wrote: Vote passed with 5 binding +1s: Martin Cooper Niall Pemberton Henri Yandell Phil Steitz Rahul Akolkar I'll work on the release tomorrow. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-259) ValuedEnum.compareTo(Object other) not typesafe - it easily could be...
[ http://issues.apache.org/jira/browse/LANG-259?page=all ] Henri Yandell updated LANG-259: --- Fix Version: 2.3 (was: 2.2) In an effort to get 2.2 out sooner rather than later, I'm assiging all the Enum issues to 2.3. There's been no work on them currently and might be best to focus on them in a 2.3 release instead of trying to squeeze them into the 2.2 release. Hopefully this will keep the 2.3 release scope pretty tight. ValuedEnum.compareTo(Object other) not typesafe - it easily could be... --- Key: LANG-259 URL: http://issues.apache.org/jira/browse/LANG-259 Project: Commons Lang Type: Bug Versions: 2.1 Environment: all Reporter: Ralf Hauser Fix For: 2.3 int org.apache.commons.lang.enums.ValuedEnum.compareTo(Object other) is not typesafe - if the int-values are the same, it will return 0 even for two totally different sub-classes of ValuedEnum -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-258) Enum JavaDoc: 1) outline 5.0 native Enum migration 2) warn not to use the switch() , 3) point out approaches for persistence and gui
[ http://issues.apache.org/jira/browse/LANG-258?page=all ] Henri Yandell updated LANG-258: --- Fix Version: 2.3 (was: 2.2) In an effort to get 2.2 out sooner rather than later, I'm assiging all the Enum issues to 2.3. There's been no work on them currently and might be best to focus on them in a 2.3 release instead of trying to squeeze them into the 2.2 release. Hopefully this will keep the 2.3 release scope pretty tight. Enum JavaDoc: 1) outline 5.0 native Enum migration 2) warn not to use the switch() , 3) point out approaches for persistence and gui Key: LANG-258 URL: http://issues.apache.org/jira/browse/LANG-258 Project: Commons Lang Type: Improvement Versions: 2.1 Environment: all Reporter: Ralf Hauser Fix For: 2.3 http://jakarta.apache.org/commons/lang/api/org/apache/commons/lang/enums/Enum.html is great! Now that Jdk5.0 has its own approach for type-safe enums, would it be great to provide a few sentences - whether they simply should co-habit? - how one would best migrate? - where the concepts are different Also, it would be great to provide some hints how to work on the with a MVC/GUI framework - see SB-20. also, http://jakarta.apache.org/commons/lang/api/org/apache/commons/lang/enums/ValuedEnum.html has a minor typo it says doSomething(JavaVersion, but should say doSomething(JavaVersionEnum also, it should contain a big warning that by using switch(), one opens up for type-unsafety! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-76) [lang] EnumUtils.getEnum() doesn't work well in 1.5
[ http://issues.apache.org/jira/browse/LANG-76?page=all ]
Henri Yandell updated LANG-76:
--
Fix Version: 2.3
(was: 2.2)
In an effort to get 2.2 out sooner rather than later, I'm assiging all the Enum
issues to 2.3. There's been no work on them currently and might be best to
focus on them in a 2.3 release instead of trying to squeeze them into the 2.2
release.
Hopefully this will keep the 2.3 release scope pretty tight.
[lang] EnumUtils.getEnum() doesn't work well in 1.5
---
Key: LANG-76
URL: http://issues.apache.org/jira/browse/LANG-76
Project: Commons Lang
Type: Bug
Versions: 2.1
Environment: Operating System: other
Platform: Other
Reporter: Igor Laberov
Fix For: 2.3
Hi,
I encountered with problem using EnumUtils.getEnum() in 1.5. It appears that
my
Enum class should be accessed first so constructor will be called. In 1.4 it
was
enough to have myClass.class, so all static members were initialized. In 1.5
it
doesn't work.
I noticed that static members are not initialized anymore while acessing to
class definition. See the code
public class Test {
public static final class TT{
public static final TT one = new TT();
private TT(){
System.out.println(Called TT );
}
}
public static void main(String[] args) {
Class cl = TT.class;
// System.out.println( TT.one);
// System.out.println(TT.class.isAssignableFrom(String.class));
}
}
In 1.4 constructor of TT is called, while in 1.5 is not.
Actually, according to the spec
(http://java.sun.com/docs/books/jls/second_edition/html/execution.doc.html#57946),
this is right behavior of Java.
Unfortunately, I didn't succeded to think about good solution..
P.s. I know that in 1.5 we have enum built-in, but it is not the same, and we
try to move to 1.5 without too much changes
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-262) Use of enum prevents a classloader from being garbage collected resuling in out of memory exceptions.
[ http://issues.apache.org/jira/browse/LANG-262?page=all ] Henri Yandell updated LANG-262: --- Fix Version: 2.3 (was: 2.2) In an effort to get 2.2 out sooner rather than later, I'm assiging all the Enum issues to 2.3. There's been no work on them currently and might be best to focus on them in a 2.3 release instead of trying to squeeze them into the 2.2 release. Hopefully this will keep the 2.3 release scope pretty tight. Use of enum prevents a classloader from being garbage collected resuling in out of memory exceptions. - Key: LANG-262 URL: http://issues.apache.org/jira/browse/LANG-262 Project: Commons Lang Type: Bug Environment: All Reporter: Neil Redway Priority: Critical Fix For: 2.3 When an enum is created it is placed in the static hashmap - cEnumClasses. If the enum is created from a classloader which has a limited lifetime then due to the strong reference the classloader is never garbage collected resulting in a memory leak. I believe that making the cEnumClasses a WeakHashMap should resolve the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-153) [lang] Can't XMLDecode an Enum
[ http://issues.apache.org/jira/browse/LANG-153?page=all ] Henri Yandell updated LANG-153: --- Fix Version: 2.3 (was: 2.2) In an effort to get 2.2 out sooner rather than later, I'm assiging all the Enum issues to 2.3. There's been no work on them currently and might be best to focus on them in a 2.3 release instead of trying to squeeze them into the 2.2 release. Hopefully this will keep the 2.3 release scope pretty tight. [lang] Can't XMLDecode an Enum -- Key: LANG-153 URL: http://issues.apache.org/jira/browse/LANG-153 Project: Commons Lang Type: Bug Versions: 2.0 Environment: Operating System: Windows 2000 Platform: PC Reporter: Kevin Gilpin Fix For: 2.3 Attachments: CommonsLangBug33965Test.java I am encoding and decoding Enums using java.beans.XMLEncoder/Decoder. When an Enum is decoded, I am using the following to get the instance. The enumClass name and the enum name are stored in the serialized XML file, then used to restore the bean at read time return EnumUtils.getEnum(enumClass, name); The problem is that the Enum.cEnumClasses map may not contain an entry for the Enum class yet, despite the fact that the Class for the enum has been loaded. If I loop through the Class.fields using reflection and get(null) the value for each one, then the cEnumClasses is populated and getEnum works. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-197) [lang] Extending VariableFormatter to use FormatPatterns
[ http://issues.apache.org/jira/browse/LANG-197?page=all ] Henri Yandell updated LANG-197: --- Bugzilla Id: (was: 36873) Fix Version: 3.0 (was: 2.2) Doesn't look like this is going anywhere at the moment - assigning to 3.0 with other new features. [lang] Extending VariableFormatter to use FormatPatterns Key: LANG-197 URL: http://issues.apache.org/jira/browse/LANG-197 Project: Commons Lang Type: Improvement Versions: 2.1 Environment: Operating System: All Platform: Other Reporter: Tom Schindl Priority: Minor Fix For: 3.0 Attachments: VariableFormatterWithFormating.java, VariableFormatterWithFormatingTest.java, patch.txt It would be great to extend VariableFormatter to use Format-Patterns like MessageFormat does it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-180) [lang] adding a StringUtils.replace method that takes an array or List of replacement strings
[ http://issues.apache.org/jira/browse/LANG-180?page=all ] Henri Yandell updated LANG-180: --- Bugzilla Id: (was: 36584) Fix Version: 3.0 (was: 2.2) I'm still undecided on this method so moving it with other new feature requests to 3.0. [lang] adding a StringUtils.replace method that takes an array or List of replacement strings - Key: LANG-180 URL: http://issues.apache.org/jira/browse/LANG-180 Project: Commons Lang Type: Improvement Environment: Operating System: other Platform: Other Reporter: Chris Priority: Minor Fix For: 3.0 Attachments: StringUtilsAndText.java I have the situation where I have a String template with a dozen replacements I need to make. When I loop through and use StringUtils.replace each time, it has to make a StringBuffer of the whole template each time. I think we could make this more efficient if we had a replace() method which took an array of Strings to search for, and an array of Strings to replace with (or we could use a Collection or List or something). This way we could possibly do the replace in one StringBuffer result. One issue is if the replacement text has Strings to be replaced, do we iterate through again until there are no Strings to search for? Based on your replaceChars(String str, String searchChars, String replaceChars) method, I assume the answer is no, but we could have a boolean flag to have it both ways. I can write this for you if you are interested, please let me know. Thanks! Chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (CHAIN-31) Portlet Map implementations' entry Set should contain Map.Entry elements
Portlet Map implementations' entry Set should contain Map.Entry elements Key: CHAIN-31 URL: http://issues.apache.org/jira/browse/CHAIN-31 Project: Commons Chain Type: Bug Versions: 1.0 Release Reporter: Niall Pemberton Assigned to: Niall Pemberton The portlet Map implementations' entrySet() method currently returns a Set of values, rather than a Set on Map.Entry elements (as per the java.util.Map spec). This was corrected in the servlet Map implementations in revision 142894 - same changes need to be applied to the portlet varieties: http://svn.apache.org/viewvc?view=revrevision=142894 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412719 - /jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/
Author: niallp
Date: Thu Jun 8 03:49:18 2006
New Revision: 412719
URL: http://svn.apache.org/viewvc?rev=412719view=rev
Log:
Fix for CHAIN-31 - Portlet Map implementations' entry Set should contain
Map.Entry elements
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamValuesMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletRequestScopeMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java?rev=412719r1=412718r2=412719view=diff
==
---
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
(original)
+++
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
Thu Jun 8 03:49:18 2006
@@ -25,6 +25,7 @@
import java.util.Map;
import java.util.Set;
import javax.portlet.PortletContext;
+import org.apache.commons.chain.web.MapEntry;
/**
@@ -77,8 +78,10 @@
public Set entrySet() {
Set set = new HashSet();
Enumeration keys = context.getAttributeNames();
+String key;
while (keys.hasMoreElements()) {
-set.add(context.getAttribute((String) keys.nextElement()));
+key = (String)keys.nextElement();
+set.add(new MapEntry(key, context.getAttribute(key), true));
}
return (set);
}
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java?rev=412719r1=412718r2=412719view=diff
==
---
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java
(original)
+++
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletInitParamMap.java
Thu Jun 8 03:49:18 2006
@@ -25,6 +25,7 @@
import java.util.Map;
import java.util.Set;
import javax.portlet.PortletContext;
+import org.apache.commons.chain.web.MapEntry;
/**
@@ -70,8 +71,10 @@
public Set entrySet() {
Set set = new HashSet();
Enumeration keys = context.getInitParameterNames();
+String key;
while (keys.hasMoreElements()) {
-set.add(context.getInitParameter((String) keys.nextElement()));
+key = (String) keys.nextElement();
+set.add(new MapEntry(key, context.getInitParameter(key), false));
}
return (set);
}
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamMap.java?rev=412719r1=412718r2=412719view=diff
==
---
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
(original)
+++
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
Thu Jun 8 03:49:18 2006
@@ -25,6 +25,7 @@
import java.util.Map;
import java.util.Set;
import javax.portlet.PortletRequest;
+import org.apache.commons.chain.web.MapEntry;
/**
@@ -70,8 +71,10 @@
public Set entrySet() {
Set set = new HashSet();
Enumeration keys = request.getParameterNames();
+String key;
while (keys.hasMoreElements()) {
-set.add(request.getParameter((String) keys.nextElement()));
+key = (String) keys.nextElement();
+set.add(new MapEntry(key, request.getParameter(key), false));
}
return (set);
}
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamValuesMap.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletParamValuesMap.java?rev=412719r1=412718r2=412719view=diff
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: x:expr You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: x:expr You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Jun 8, 2006 4:43:34 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Jun 8, 2006 4:43:34 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-08062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-08062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-08062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-08062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-08062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
svn commit: r412787 - in /jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet: ./ MockPortletContext.java MockPortletRequest.java MockPortletSession.java PortletGetLocaleC
Author: niallp
Date: Thu Jun 8 09:12:37 2006
New Revision: 412787
URL: http://svn.apache.org/viewvc?rev=412787view=rev
Log:
Add portlet mock objects and tests
Added:
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletContext.java
(with props)
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletRequest.java
(with props)
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletSession.java
(with props)
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/PortletGetLocaleCommandTestCase.java
(with props)
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/PortletWebContextTestCase.java
(with props)
Added:
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletContext.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletContext.java?rev=412787view=auto
==
---
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletContext.java
(added)
+++
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/MockPortletContext.java
Thu Jun 8 09:12:37 2006
@@ -0,0 +1,137 @@
+/*
+ * Copyright 2006 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.chain.web.portlet;
+
+
+import javax.portlet.Portlet;
+import javax.portlet.PortletContext;
+import javax.portlet.PortletRequestDispatcher;
+import java.io.InputStream;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.Enumeration;
+import java.util.Hashtable;
+import java.util.Set;
+
+
+// Mock Object for PortletContext
+public class MockPortletContext implements PortletContext {
+
+
+private int majorVersion = 1;
+private int minorVersion = 0;
+private String portletContextName = MockPortletContext;
+private String serverInfo = portletContextName;
+private Hashtable parameters = new Hashtable();
+private Hashtable attributes = new Hashtable();
+
+
+// - Public Methods
+
+
+public void setPortletContextName(String portletContextName) {
+this.portletContextName = portletContextName;
+}
+
+public void setServerInfo(String serverInfo) {
+this.serverInfo = serverInfo;
+}
+
+public void addInitParameter(String name, String value) {
+parameters.put(name, value);
+}
+
+
+// - PortletContext Methods
+
+
+public Object getAttribute(String name) {
+return attributes.get(name);
+}
+
+public Enumeration getAttributeNames() {
+return attributes.keys();
+}
+
+public String getInitParameter(String name) {
+return (String)parameters.get(name);
+}
+
+public Enumeration getInitParameterNames() {
+return parameters.keys();
+}
+
+public int getMajorVersion() {
+return majorVersion;
+}
+
+public String getMimeType(String path) {
+throw new UnsupportedOperationException();
+}
+
+public int getMinorVersion() {
+return minorVersion;
+}
+
+public PortletRequestDispatcher getNamedDispatcher(String name) {
+throw new UnsupportedOperationException();
+}
+
+public String getPortletContextName() {
+return portletContextName;
+}
+
+public String getRealPath(String path) {
+throw new UnsupportedOperationException();
+}
+
+public PortletRequestDispatcher getRequestDispatcher(String path) {
+throw new UnsupportedOperationException();
+}
+
+public URL getResource(String path) throws MalformedURLException {
+throw new UnsupportedOperationException();
+}
+
+public InputStream getResourceAsStream(String path) {
+throw new UnsupportedOperationException();
+}
+
+public Set getResourcePaths(String path) {
+throw new UnsupportedOperationException();
+}
+
+public String getServerInfo() {
+return serverInfo;
+}
+
+public void log(String message) {
+
svn commit: r412789 - in /jakarta/commons/proper/chain/trunk/src: java/org/apache/commons/chain/web/portlet/ java/org/apache/commons/chain/web/servlet/ test/org/apache/commons/chain/web/portlet/ test/
Author: niallp
Date: Thu Jun 8 09:19:14 2006
New Revision: 412789
URL: http://svn.apache.org/viewvc?rev=412789view=rev
Log:
Fix for CHAIN-30 - ServletSessionScopeMap always forces a Session to be Created
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletWebContext.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/servlet/ServletSessionScopeMap.java
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/servlet/ServletWebContext.java
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/portlet/PortletWebContextTestCase.java
jakarta/commons/proper/chain/trunk/src/test/org/apache/commons/chain/web/servlet/ServletWebContextTestCase.java
Modified:
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java?rev=412789r1=412788r2=412789view=diff
==
---
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
(original)
+++
jakarta/commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java
Thu Jun 8 09:19:14 2006
@@ -25,6 +25,7 @@
import java.util.Map;
import java.util.Set;
import javax.portlet.PortletSession;
+import javax.portlet.PortletRequest;
import org.apache.commons.chain.web.MapEntry;
@@ -39,29 +40,37 @@
final class PortletSessionScopeMap implements Map {
-public PortletSessionScopeMap(PortletSession session) {
-this.session = session;
+public PortletSessionScopeMap(PortletRequest request) {
+this.request = request;
+sessionExists();
}
private PortletSession session = null;
+private PortletRequest request = null;
public void clear() {
-Iterator keys = keySet().iterator();
-while (keys.hasNext()) {
-session.removeAttribute((String) keys.next());
+if (sessionExists()) {
+Iterator keys = keySet().iterator();
+while (keys.hasNext()) {
+session.removeAttribute((String) keys.next());
+}
}
}
public boolean containsKey(Object key) {
-return (session.getAttribute(key(key)) != null);
+if (sessionExists()) {
+return (session.getAttribute(key(key)) != null);
+} else {
+return false;
+}
}
public boolean containsValue(Object value) {
-if (value == null) {
+if (value == null || !sessionExists()) {
return (false);
}
Enumeration keys =
@@ -78,43 +87,64 @@
public Set entrySet() {
Set set = new HashSet();
-Enumeration keys =
-session.getAttributeNames(PortletSession.PORTLET_SCOPE);
-String key;
-while (keys.hasMoreElements()) {
-key = (String) keys.nextElement();
-set.add(new MapEntry(key, session.getAttribute(key), true));
+if (sessionExists()) {
+Enumeration keys =
+session.getAttributeNames(PortletSession.PORTLET_SCOPE);
+String key;
+while (keys.hasMoreElements()) {
+key = (String) keys.nextElement();
+set.add(new MapEntry(key, session.getAttribute(key), true));
+}
}
return (set);
}
public boolean equals(Object o) {
-return (session.equals(o));
+if (sessionExists()) {
+return (session.equals(o));
+} else {
+return false;
+}
}
public Object get(Object key) {
-return (session.getAttribute(key(key)));
+if (sessionExists()) {
+return (session.getAttribute(key(key)));
+} else {
+return null;
+}
}
public int hashCode() {
-return (session.hashCode());
+if (sessionExists()) {
+return (session.hashCode());
+} else {
+return 0;
+}
}
public boolean isEmpty() {
-return (size() 1);
+if (sessionExists()
+session.getAttributeNames().hasMoreElements()) {
+return false;
+} else {
+return true;
+}
}
public Set keySet() {
Set set = new HashSet();
-Enumeration keys =
-session.getAttributeNames(PortletSession.PORTLET_SCOPE);
-while (keys.hasMoreElements()) {
-set.add(keys.nextElement());
+if (sessionExists()) {
+Enumeration keys =
+
[jira] Resolved: (CHAIN-30) ServletSessionScopeMap always forces a Session to be Created
[ http://issues.apache.org/jira/browse/CHAIN-30?page=all ] Niall Pemberton resolved CHAIN-30: -- Fix Version: 1.1 Resolution: Fixed Assign To: Niall Pemberton ServletSessionScopeMap always forces a Session to be Created Key: CHAIN-30 URL: http://issues.apache.org/jira/browse/CHAIN-30 Project: Commons Chain Type: Bug Versions: 1.0 Release Reporter: Niall Pemberton Assignee: Niall Pemberton Fix For: 1.1 The current implementation of ServletSessionScopeMap always forces a Session to be created whenever getSessionScope() is called on ServletWebContext. This could be avoided and would be smarter if ServletSessionScopeMap was instantiated with the HttpServletRequest rather than the HttpSession - that way if no Session exists it could be lazily created only during write operations on the Map. Frameworks such as Struts check session scope for various attributes for each request processed - if it used this abstracted Map representaion of session scope it would mean a session is always created (if it doesn't already exist) whether its needed or not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (CHAIN-31) Portlet Map implementations' entry Set should contain Map.Entry elements
[ http://issues.apache.org/jira/browse/CHAIN-31?page=all ] Niall Pemberton resolved CHAIN-31: -- Fix Version: 1.1 Resolution: Fixed Portlet Map implementations' entry Set should contain Map.Entry elements Key: CHAIN-31 URL: http://issues.apache.org/jira/browse/CHAIN-31 Project: Commons Chain Type: Bug Versions: 1.0 Release Reporter: Niall Pemberton Assignee: Niall Pemberton Fix For: 1.1 The portlet Map implementations' entrySet() method currently returns a Set of values, rather than a Set on Map.Entry elements (as per the java.util.Map spec). This was corrected in the servlet Map implementations in revision 142894 - same changes need to be applied to the portlet varieties: http://svn.apache.org/viewvc?view=revrevision=142894 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412796 - /jakarta/commons/proper/chain/trunk/xdocs/changes.xml
Author: niallp Date: Thu Jun 8 09:47:40 2006 New Revision: 412796 URL: http://svn.apache.org/viewvc?rev=412796view=rev Log: Update release notes Modified: jakarta/commons/proper/chain/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/chain/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/xdocs/changes.xml?rev=412796r1=412795r2=412796view=diff == --- jakarta/commons/proper/chain/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/chain/trunk/xdocs/changes.xml Thu Jun 8 09:47:40 2006 @@ -39,6 +39,14 @@ body release version=1.1-SNAPSHOT date=in SVN + action dev=niallp type=fix issue=CHAIN-30 + a href=http://svn.apache.org/viewvc?view=revamp;revision=412789;r 412789/a + ServletSessionScopeMap always forces a Session to be Created. + /action + action dev=niallp type=fix issue=CHAIN-31 + a href=http://svn.apache.org/viewvc?view=revamp;revision=412719;r 412719/a + Portlet Map implementations' entry Set should contain Map.Entry elements. + /action action dev=niallp type=add issue=CHAIN-28 a href=http://svn.apache.org/viewvc?view=revamp;revision=411948;r 411948/a Provide a Map of Cookies in the WebContext. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] Version 1.1 release candidate 2
I found a couple of issues with RC2 (CHAIN-30 and CHAN-31) which I've just fixed and will post a RC3 shortly http://issues.apache.org/jira/browse/CHAIN-30 http://issues.apache.org/jira/browse/CHAIN-31 Niall On 6/6/06, Niall Pemberton [EMAIL PROTECTED] wrote: Following an issue in RC1 found by Dennis Lundberg I have prepared release candidate 2 for Chain 1,1 for review: http://people.apache.org/~niallp/commons-chain/ Release notes for version 1.1 are here: http://people.apache.org/~niallp/commons-chain/site/changes-report.html New version of the chain site: http://people.apache.org/~niallp/commons-chain/site/ All feedback on this release candidate build is welcome. Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412844 - in /jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3: ./ project.xml xdocs/changes.xml
Author: niallp Date: Thu Jun 8 12:32:56 2006 New Revision: 412844 URL: http://svn.apache.org/viewvc?rev=412844view=rev Log: Tag Chain 1.1 RC3 Added: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/ - copied from r412842, jakarta/commons/proper/chain/trunk/ Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/project.xml jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/xdocs/changes.xml Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/project.xml?rev=412844r1=412842r2=412844view=diff == --- jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/project.xml (original) +++ jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/project.xml Thu Jun 8 12:32:56 2006 @@ -22,7 +22,7 @@ logo/images/chain-logo-white.png/logo - currentVersion1.1-SNAPSHOT/currentVersion + currentVersion1.1-RC3/currentVersion inceptionYear2003/inceptionYear shortDescriptionCommons Chain/shortDescription descriptionAn implmentation of the GoF Chain of Responsibility pattern/description Modified: jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/xdocs/changes.xml?rev=412844r1=412842r2=412844view=diff == --- jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/xdocs/changes.xml (original) +++ jakarta/commons/proper/chain/tags/CHAIN_1_1_RC3/xdocs/changes.xml Thu Jun 8 12:32:56 2006 @@ -38,7 +38,7 @@ /properties body -release version=1.1-SNAPSHOT date=in SVN +release version=1.1-RC3 date=2006-06-06 description=Version 1.1 Release Candidate 3 action dev=niallp type=fix issue=CHAIN-30 a href=http://svn.apache.org/viewvc?view=revamp;revision=412789;r 412789/a ServletSessionScopeMap always forces a Session to be Created. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Collections-events
Stephen Colebourne [EMAIL PROTECTED] wrote on 06/08/2006 01:29:25 AM: I would be willing to help revive collections-events if there is interest. Even more so if it can happen with generics support. Logically, this would be a generics only project now. Does this affect you Bryce? (If it does, then perhaps we might need to try retro*) I could go either way. I'd be biased towards keeping it 1.4 just because I don't think Generics adds anything to this particular block of code. How would you even use Generics with ObservableCollection/Set/Map/List? If there's a legitimate use of generics within the package, I may be convinced. Generics seems more applicable to commons-collections. Jeez, you start porting commons-collections to generics and you've suddenly got an awful lot of overlap with Java5 SE. You've got a really good thing going on here with your implementation! You have a typed collections framework which does not require a JVM change. Furthermore, if you do use a java 5 sdk targeted to java1.4, your type-checking still works (unlike the J2SE package). Why would you want to change that and become redundant? But the best reason to stay at 1.4, at least for now: it seems to already work! I really don't understand why this was mothballed. Might it be released as 0.1 in its current state, then refactored to 1.5 in the next release? On the other hand, I don't have a good grasp of why one would use generics at all, especially at the cost of breaking compatibility with many existing systems. Take it with a grain of salt. :) Now if it was a full-up template facility, I could see using it. Bryce - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VOTE] Release Chain1.1 based on RC3
I have just uploaded release candidate 3 (RC3) for Commons Chain 1.1 A couple of issues have been resolved since RC2 and additional tests for those issues added: http://issues.apache.org/jira/browse/CHAIN-30 http://issues.apache.org/jira/browse/CHAIN-30 RC3 is here: http://people.apache.org/~niallp/commons-chain/ Site/Docs are here: http://people.apache.org/~niallp/commons-chain/site/ Release notes here: http://people.apache.org/~niallp/commons-chain/site/changes-report.html [ ] +1 looks good [ ] +0 [ ] -0 [ ] -1 nope, something needs fixing Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r412848 - in /jakarta/commons/proper/configuration/trunk: conf/ src/java/org/apache/commons/configuration/ src/java/org/apache/commons/configuration/beanutils/ src/test/org/apache/commons/
Author: oheger
Date: Thu Jun 8 13:11:29 2006
New Revision: 412848
URL: http://svn.apache.org/viewvc?rev=412848view=rev
Log:
Enabled support for variable interpolation in DefaultConfigurationBuilder
Modified:
jakarta/commons/proper/configuration/trunk/conf/testComplexInitialization.xml
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/HierarchicalConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/SubnodeConfiguration.java
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/XMLBeanDeclaration.java
jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestDefaultConfigurationBuilder.java
jakarta/commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/beanutils/TestXMLBeanDeclaration.java
jakarta/commons/proper/configuration/trunk/xdocs/howto_configurationbuilder.xml
Modified:
jakarta/commons/proper/configuration/trunk/conf/testComplexInitialization.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/conf/testComplexInitialization.xml?rev=412848r1=412847r2=412848view=diff
==
---
jakarta/commons/proper/configuration/trunk/conf/testComplexInitialization.xml
(original)
+++
jakarta/commons/proper/configuration/trunk/conf/testComplexInitialization.xml
Thu Jun 8 13:11:29 2006
@@ -15,17 +15,19 @@
/override
/combiner
/header
+ system/
properties fileName=test.properties throwExceptionOnMissing=true
config-name=properties
reloadingStrategy
config-class=org.apache.commons.configuration.reloading.FileChangedReloadingStrategy
refreshDelay=1/
/properties
- xml fileName=test.xml config-name=xml
+ !-- Fetch the file name from a variable --
+ xml fileName=${test_file_xml} config-name=xml
expressionEngine
config-class=org.apache.commons.configuration.tree.DefaultExpressionEngine
propertyDelimiter=/ indexStart=[ indexEnd=]/
/xml
additional
-xml config-name=combiner1 fileName=testcombine1.xml/
+xml config-name=combiner1 fileName=${test_file_combine}/ --
xml config-name=combiner2 fileName=testcombine2.xml/
/additional
/configuration
Modified:
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java?rev=412848r1=412847r2=412848view=diff
==
---
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
(original)
+++
jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
Thu Jun 8 13:11:29 2006
@@ -30,6 +30,7 @@
import org.apache.commons.configuration.plist.PropertyListConfiguration;
import org.apache.commons.configuration.plist.XMLPropertyListConfiguration;
import org.apache.commons.configuration.tree.ConfigurationNode;
+import org.apache.commons.configuration.tree.DefaultExpressionEngine;
import org.apache.commons.configuration.tree.OverrideCombiner;
import org.apache.commons.configuration.tree.UnionCombiner;
import org.apache.commons.configuration.tree.xpath.XPathExpressionEngine;
@@ -152,6 +153,11 @@
* configuration under the name defined by the codeADDITIONAL_NAME/code
* constant.
* /p
+ * p
+ * Implementation note: This class is not thread-safe. Especially the
+ * codegetConfiguration()/code methods should be called by a single thread
+ * only.
+ * /p
*
* @since 1.3
* @author Oliver Heger
@@ -180,16 +186,40 @@
+ .CONFIG_BEAN_FACTORY_NAME;
/** Constant for the reserved name attribute. */
-static final String ATTR_NAME = XMLBeanDeclaration.RESERVED_PREFIX +
name;
+static final String ATTR_NAME =
DefaultExpressionEngine.DEFAULT_ATTRIBUTE_START
++ XMLBeanDeclaration.RESERVED_PREFIX
++ name
++ DefaultExpressionEngine.DEFAULT_ATTRIBUTE_END;
+
+/** Constant for the name of the at attribute. */
+static final String ATTR_ATNAME = at;
/** Constant for the reserved at attribute. */
-static final String ATTR_AT = at;
+static final String ATTR_AT_RES =
DefaultExpressionEngine.DEFAULT_ATTRIBUTE_START
++ XMLBeanDeclaration.RESERVED_PREFIX
++ ATTR_ATNAME
++ DefaultExpressionEngine.DEFAULT_ATTRIBUTE_END;
+
+/** Constant for the at attribute without the reserved prefix. */
+static final String ATTR_AT =
DefaultExpressionEngine.DEFAULT_ATTRIBUTE_START
[jira] Commented: (COLLECTIONS-110) [collections] Support parametized classes with commons.collections.
[ http://issues.apache.org/jira/browse/COLLECTIONS-110?page=comments#action_12415432 ] Michael Heuer commented on COLLECTIONS-110: --- Wanted to add that there is a second more complete project on sourceforge than the one referred to above: http://collections.sf.net Not sure what to think of the re-branding done on their project home page, however. [collections] Support parametized classes with commons.collections. --- Key: COLLECTIONS-110 URL: http://issues.apache.org/jira/browse/COLLECTIONS-110 Project: Commons Collections Type: Bug Environment: Operating System: other Platform: Other Reporter: Colbert Philippe It's time to create a parallel version of commons.collections to support parametized classes of each container class and abstract class. It's not that hard. There is a 23 PDF document on Sun Java website describing in detail how it should be done and what to watch out for. I already converted a few classes from commons.collection privately for my own needs. Once you get the hang of it, it's a rather quick process. I am even willing to volunteer my time to do some more but I need the collaboration of some of the original programmers to watch over things. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=comments#action_12415435 ] Gordon Mohr commented on POOL-75: - Re: (1) I see; it seems it would be sufficient to move the _borrowerQueue.add(Thread.currentThread()); inside the synchronized block. (I believe the idea of thread-fairness is really only sensible with respect to WHEN_EXHAUSTED_BLOCK pools -- in the others, borrowObject() never blocks, so there's never the unfair/barging risk.) Re: (2) This was a straight copy of the superclass code; I see that the superclass has been changed in the SVN tree, so definitely the same fix should apply here. Re: (3) I hadn't considered the evictor; our use case doesn't use it, and I think the usual case where thread fairness is important -- rationing a small number of pool objects among a large number of threads -- may be more likely to use non-expiring pool objects. Looking at evict(), it appears to me that it is indeterminate whether the evictor or a blocking borrower would get the first chance to run after an object is returned -- but also that it doesn't need to be determinate, and any app using eviction is going to be robust about pool objects sometimes expiring an instant before being requested. (That is, my concept of thread fairness is orthogonal to the evictor's actions.) Thanks for considering the patch. Do you want me to make the recommended changes and resubmit? [pool] GenericObjectPool not FIFO with respect to borrowing threads --- Key: POOL-75 URL: http://issues.apache.org/jira/browse/POOL-75 Project: Commons Pool Type: Improvement Versions: Nightly Builds Environment: Operating System: All Platform: All Reporter: Gordon Mohr Assignee: Sandy McArthur Priority: Minor GenericObjectPool has recently been made FIFO with respect to the managed pool objects -- however, it is still not FIFO with respect to threads requesting those objects. Specifically, because standard non-fair Java synchronization monitors are used, later threads may barge ahead of earlier threads that are already waiting for a pool object to become available. At its extreme, some threads can cycle objects through the pool many times while others wait interminable. Not every application needs FIFO fairness with respect to threads, and such fairness implies an overhead, so it need not be the default behavior, but it would be a valuable option where many threads are sharing a smaller number of pool objects. I can submit a FairGenericObjectPool which achieves thread-fairness; it only requires small changes to GenericObjectPool which allow some subclass overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (CLI-118) CLIMessageBundle for spanish (attached)
CLIMessageBundle for spanish (attached)
---
Key: CLI-118
URL: http://issues.apache.org/jira/browse/CLI-118
Project: Commons CLI
Type: Improvement
Versions: Nightly Builds
Reporter: David Leal
Just to suggest adding resource bundle of the library for spanish language. I
have translated it for CLI. Some english word where translated but still the
original english word is preserved in parenthesis because they are hard to
translate and understand.
Just to suggest consider to use choice format in order to minimize the number
of resource bundle keys, for example:
propertyAtLeastOneCharacter = The
{0,choice,1#enabledPrefix|2#disabledPrefix|3#preferredName|4#idirectPosition}
MUST be at least 1 character long.
of just to use a single variable:
propertyAtLeastOneCharacter = The {0} MUST be at least 1 character long.
such features simplifies the translation process.
=
ClassValidator.bad.classname = El nombre de la clase {0} no es válido.
ClassValidator.class.notfound = La clase {0} no puede ser encontrada.
ClassValidator.class.access= La clase {0} no puede ser accedida. \
Razón: {1}.
ClassValidator.class.create= La clase {0} no puede ser creada.
DateValidator.date.OutOfRange = La fecha ''{0}'' está fuera de rango.
NumberValidator.number.OutOfRange = El número ''{0}'' esta fuera de rango.
URLValidator.malformed.URL= No se entiende la URL: ''{0}''.
Argument.unexpected.value = Inesperado el valor {0} encontrado \
durante el procesamiento
Argument.minimum.exceeds.maximum = El mínimo número de valores no debe \
exceder el máximo número
Argument.too.few.defaults = No hay suficientes valores por defecto.
Argument.too.many.defaults= Demasiados valores por defecto.
Argument.missing.values = Falta(n) valor(es)
Argument.too.many.values = Se ha solicita más de un valor.
Option.trigger.needs.prefix = El disparador(triggers) {0} debe ser \
prefijado con el valor {1}
Option.missing.required = Falta la opción requerida
Option.no.name= Una opción debe tener al menos un nombre.
Option.illegal.short.prefix = El prefijo corto TIENE que tener al \
menos un caracter.
Option.illegal.long.prefix= El prefijo largo TIENE que tener al menos \
un caracter.
Command.preferredName.too.short = El valor de preferredName TIENE que tener \
al menos un caracter.
SourceDest.must.enforce.values= El argumento dest debe forzar un valor \
fijo de valores.
Switch.illegal.enabled.prefix = El valor de enabledPrefix TIENE tener al \
menos un caracter.
Switch.illegal.disabled.prefix= El valor de disabledPrefix TIENE que tener \
al menos un caracter.
Switch.identical.prefixes = El valor de disabledPrefix y enabledPrefix \
TIENE que ser distinto.
Switch.already.set= El interruptor ya ha sido asignado.
Switch.no.enabledPrefix = Un valor de enabledPrefix tiene que ser \
proporcionado.
Switch.no.disabledPrefix = Un valor de disabledPrefix debe ser \
proporcionado.
Switch.enabled.startsWith.disabled = El valor de enabledPrefix no debe \
comenzar con el mismo valor \
de disabledPrefix.
Switch.disabled.startsWith.enabled = El valor de disabledPrefix no puede \
comenzar con el mismo valor que \
enabledPrefix.
Switch.preferredName.too.short = El valor de preferredName TIENE que tener \
al menos un caracter.
HelpFormatter.gutter.too.long = El valor de la cadena de separación \
(gutter) no tiene suficiente espacio \
para la salida! proporcione un valor \
menor o mayor ancho.
HelpFormatter.width.too.narrow = El ancho de HelpFormatter es muy \
pequeño: {0}.
Enum.illegal.value = ''{0}'' no está permitido. Los valores \
permitidos son: {1}
Unexpected.token = Inesperado el valor {0} durante el procesamiento
Missing.option = Falta la opción
Cannot.burst = No puede quebrantar {0} durante el procesamiento
ArgumentBuilder.null.consume.remaining =
[jira] Commented: (IO-78) [io] upload javadocs and source to maven2 repo
[ http://issues.apache.org/jira/browse/IO-78?page=comments#action_12415439 ] David J. M. Karlsen commented on IO-78: --- codehaus seems to be on track again [io] upload javadocs and source to maven2 repo -- Key: IO-78 URL: http://issues.apache.org/jira/browse/IO-78 Project: Commons IO Type: Improvement Versions: 1.2 Final Environment: Operating System: other Platform: Other Reporter: David J. M. Karlsen Assignee: Henri Yandell Priority: Minor Could somebody upload javadoc's and sources to the maven2 repo at ibiblio? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (COLLECTIONS-110) [collections] Support parametized classes with commons.collections.
[ http://issues.apache.org/jira/browse/COLLECTIONS-110?page=comments#action_12415442 ] Sergei Ivanov commented on COLLECTIONS-110: --- Just had a look at it, and have a feeling that the second SF project is much, much better than the first one. Still, it is more rigid (regarding the use of generics) in many places than it should have been imho. For example, instead of: TransformingComparator(TransformerI,O transformer, ComparatorO decorated) ...I would go for a more relaxed version: TransformingComparator(Transformer? super I, ? extends O transformer, Comparator? super O decorated) So that the following is possible: ComparatorDouble c = new TransformingComparatorDouble, Comparable( StringValueTransformer.getInstance(), ComparableComparator.getInstance() ); Am I paranoid? [collections] Support parametized classes with commons.collections. --- Key: COLLECTIONS-110 URL: http://issues.apache.org/jira/browse/COLLECTIONS-110 Project: Commons Collections Type: Bug Environment: Operating System: other Platform: Other Reporter: Colbert Philippe It's time to create a parallel version of commons.collections to support parametized classes of each container class and abstract class. It's not that hard. There is a 23 PDF document on Sun Java website describing in detail how it should be done and what to watch out for. I already converted a few classes from commons.collection privately for my own needs. Once you get the hang of it, it's a rather quick process. I am even willing to volunteer my time to do some more but I need the collaboration of some of the original programmers to watch over things. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JELLY-226) Upgrade dom4j and jaxen
[ http://issues.apache.org/jira/browse/JELLY-226?page=comments#action_12415443 ] Paul Libbrecht commented on JELLY-226: -- Is now committed... looks like i need to wait to see gump take it up. Upgrade dom4j and jaxen --- Key: JELLY-226 URL: http://issues.apache.org/jira/browse/JELLY-226 Project: Commons Jelly Type: Wish Components: core / taglib.core, taglib.jsl, taglib.xml Reporter: Lukas Theussl I am struggling with upgrading dom4j and jaxen for our upcoming maven-1.1 release (see http://jira.codehaus.org/browse/MAVEN-1345 and http://jira.codehaus.org/browse/JAXEN-67 for some chunks of discussion). Part of the problem seems to be some kind of binary incompatibility in project dependencies of jelly. I tried to rebuild jelly with the latest dom4j-1.6.1 and jaxen-1.1-beta-8 but failed due to several broken test cases, in particular in the jsl tag library. It would be nice if we had a jelly release with unified dependencies, even though I am not sure it will solve our problem of dropped CDATA sections that I described in JAXEN-67. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JELLY-231) x:foreach's sort option breaks if empty result
x:foreach's sort option breaks if empty result -- Key: JELLY-231 URL: http://issues.apache.org/jira/browse/JELLY-231 Project: Commons Jelly Type: Bug Components: taglib.xml Versions: 1.1 Reporter: Paul Libbrecht as it says... if you invoke x:foreach with a sort attribute. An ArrayIndexOutOfBounds is thrown is the result-set is empty. This should not be. paul -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[ANNOUNCEMENT] Jakarta Commons FileUpload 1.1.1 released
The Commons FileUpload team would like to announce the release of Commons FileUpload 1.1.1. This release contains two bugfixes to the 1.1 release: FILEUPLOAD-20: Cache disk file item size when it is moved to a new location. http://issues.apache.org/jira/browse/FILEUPLOAD-20 FILEUPLOAD-30: File names were being inadvertently converted to lower case. http://issues.apache.org/jira/browse/FILEUPLOAD-30 Commons FileUpload 1.1.1 is available in either binary or source form from the FileUpload download page: http://jakarta.apache.org/site/downloads/downloads_commons-fileupload.cgi Thanks, Henri Yandell - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Closure is a really bad name
The Closure in commons collections is not named well: for
non-functional programmers it will induce a what's that?, and for
functional programmers it will confuse expectations.
From http://en.wikipedia.org/wiki/Closure_(computer_science):
A closure combines the code of a function with a special lexical
environment bound to that function (scope).
Java cannot pass functions, so the only way this can be done is with an
(inner) class, as follows (also from wikipedia):
class CalculationWindow extends JFrame {
private JButton btnSave;
...
public final calculateInSeparateThread(final URI uri) {
// The expression new Runnable() { ... } is an anonymous class.
Runnable runner = new Runnable() {
void run() {
// It can access final local variables:
calculate(uri);
// It can access private fields of the enclosing class:
btnSave.setEnabled(true);
}
};
new Thread(runner).start();
}
}
Note how the Runnable accesses the btnSave variable in the function
scope. This special lexical environment is NOT the same as passing a
parameter through a constructor OR execute method. A Closure should NOT
take a parameter for execute. AFAIK, a true Closure can only be
implemented in Java by means of a non-static inner class.
See also http://www.blog.dannynet.net/archives/39, and
http://codefu.taichizus.net/2006/02/19/closures-in-java/ for (IMHO)
understanding and mis-understanding of closures in java.
So, what to do?
I would propose an interface called Processor. It is more intuitive and
has many real world examples that can anchor the term so that it makes
sense to the average (and functional!) programmer.
For example, when applying for a passport, some documentation needs to
be filled out, and then it will go through a process to get you a
passport. You hand (or send) your forms to a clerk (Processor), and
that's it. The Processor does not reply - the context that is passed in
your form (your details) allows a message to be sent back at a later date.
My proposed class would be
public interface ProcessorT extends ClosureT{}
with the appropriate documentation.
Closure would be deprecated with an appropriate explanation. (I would
advocate removing it by 2008, or when the Java standard is Java 5
instead of Java 2)
Cheers
Stephen Kestle
PS. Apologies if this topic has been covered before - I didn't see a
search on the mailing list archives...
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (POOL-75) [pool] GenericObjectPool not FIFO with respect to borrowing threads
[ http://issues.apache.org/jira/browse/POOL-75?page=comments#action_12415461 ] Sandy McArthur commented on POOL-75: After having slept on it and since thread fairness only makes sense in the WHEN_EXHAUSTED_BLOCK case I think the best plan is to: 1. Patch GenericObjectPool instead of creating a subclass. GOP is a bit of a hair ball but I think adding one more configurable feature is less hairy than exposing more of it's internals to allow subclassing. Personally, I think GOP is really dangerous to extend as use of it in that way wasn't well thought out as it was patched over the years and I don't want to encourage that kind of use as it's so fragile. Also, I don't think the setting use fair queueing feature should be added to the constructors. They are unwieldily enough already and I've fixed few bugs due to the confusing nature of keeping the parameters straight. Just let it be controlled via a setter method, no need to add another constructor that will take 14 parameters, though I do think it should be added to the GOP.Config class. 2. I think all or most all of the thread fairness can be implemented in the WHEN_EXHAUSTED_BLOCK case of the switch statement. This would keep the scope of the changes as narrow as possible. 3. Since the evictor sometimes adds idle objects to the pool, despite it's name, I don't think it should get in line like the other threads as that could slow everything down. If you want to rework the patch then go for it, else I'll eventually get to it before the 2.0 release. [pool] GenericObjectPool not FIFO with respect to borrowing threads --- Key: POOL-75 URL: http://issues.apache.org/jira/browse/POOL-75 Project: Commons Pool Type: Improvement Versions: Nightly Builds Environment: Operating System: All Platform: All Reporter: Gordon Mohr Assignee: Sandy McArthur Priority: Minor GenericObjectPool has recently been made FIFO with respect to the managed pool objects -- however, it is still not FIFO with respect to threads requesting those objects. Specifically, because standard non-fair Java synchronization monitors are used, later threads may barge ahead of earlier threads that are already waiting for a pool object to become available. At its extreme, some threads can cycle objects through the pool many times while others wait interminable. Not every application needs FIFO fairness with respect to threads, and such fairness implies an overhead, so it need not be the default behavior, but it would be a valuable option where many threads are sharing a smaller number of pool objects. I can submit a FairGenericObjectPool which achieves thread-fairness; it only requires small changes to GenericObjectPool which allow some subclass overriding. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
