[jira] Commented: (BEANUTILS-185) [beanutils] Try to align BeanUtils with JSTL standard tags
[
http://issues.apache.org/jira/browse/BEANUTILS-185?page=comments#action_12415646
]
Gabriel Belingueres commented on BEANUTILS-185:
---
Hi Niall (answers starting with *)
Thanks for the patches, however I'm not that keen on implementing what
you propose.
1) In regards to RowSetDynaClass and the createDynaBean() method, the
contract of that method is IMO clear since the return type is a DynaBean
- if a specific implementation was required then the return type should
have been the specific implementation (such as BasicDynaBean).
Therefore I'm against introducing your new AbstractRowSetDynaClass as IMO its
unnecessary.
* I introduced the AbstractRowSetDynaClass class for two reasons I can remember
of now:
a) To tell with the code by itself that there is a Factory Method
createDynaBean() and it is OK to create your own type of RowSetDynaClass which
create the kind of row beans you want.
b) The introduction of the AbstractRowSetDynaClass class made it really easy to
introduce both the DirectRowSetDynaClass and IndirectRowSetDynaClass (we only
implement the createDynaBean() method)
Looking at RowSetDynaClass I am surprised there is a createDynaBean()
method at all, since DynaClass defines a perfectly good public
newInstance() method for that very purpose. IMO we should deprecate the
createDynaBean() method and switch to using newInstance() instead.
* If I understood it well, I think newInstance() would not be an adequate
method to use in this situation. From the DynaClass javadoc: A DynaClass is a
simulation of the functionality of java.lang.Class for classes implementing the
DynaBean interface.
If in a regular Java program I call newInstance() on the java.util.ArrayList
class, I would not expect to be returned a new Object instance because it is
the type of objects an ArrayList can hold, but I would expect to be returned an
instance of a new ArrayList.
With RowSetDynaClass I think it happens the same: calling newInstance() one
would expect I get returned a new RowSetDynaBean (which it is a concept that
doesn't exist!), not a BasicDynaBean instance (which is the type of the
elements in the RowSet. I think that it is why when called it throws an
UnsupportedOperationException.
May be we need to replace RowSetDynaClass with something more meaningful?
RowSetDynaClass is like an abstract class: We have the class available but we
can't instantiate it. Maybe we need to align the definition with the standard
JDBC RowSet implementation?
2) DirectAccessDynaBean gives me some concern since it is both a Map
and a DynaBean and I'm unsure whether this may confuse other BeanUtils
functionality or cause it to act inconsistently. Even if that didn't turn
out to be a problem I'm against this super interface as I don't see
how this provides any advantage/benefit over an object that implements
the two interfaces separtely rather than this combined one.
* I agree that this is dangerous. I wanted to use JSTL tags like c:out
value=${dynabean.firstname}/ with my dynabeans, so the combination of
DynaBean and Map seemed a good idea. The BasicDirectAccessDynaBean
implementation I provided treats the dynabean (when accessed from a Map method)
as immutable.
In the one hand, read access was the only thing I needed since I use JSTL with
a model 2 mvc framework (so no writing is performed in the JSP pages), and in
the other hand, I wrapped the map in a Collections.unmodifiableMap to protect
the dynabean integrity from writing.
I tend to agree that this super interface may be opening the door for bugs.
However, I think that before dropping it we could consult with a JSF
implementer to see if it would simplify the implementation of expressions like
h:inputText value=#{dynabean.property}/, which will read and WRITE on the
dynabean.
An alternative thought I had to this is to provide a Map implementation
to decorate DynaBeans - that way any DynaBean could be decorated to
look like a Map?
* This can be a good idea, however if you wrap a DynaBean with a Map interface,
then it is no longer a DynaBean. Don't know if this loss of functionality can
be counter productive or not, but would cover the requirement of being JSTL
friendly.
Also, this will require to either change the RowSetDynaClass.copy()
implementation to wrap the dynabean with an optional Map, or (easier I think)
add a getRowsAsMap() method which would create a list of Map-wrapped dynabeans.
3) On the IndirectAccessDynaBean I'm afraid I don't see any benefit in
JSTL terms since simply adding a getMap() method to a DynaBean
implementation will enable it to be used by JSTL. Also perhaps it would have
wider benefit if it was simply an interface with that one method (rather
than extending DynaBean) - that way any object could provide a Map
representation of itself.
* I agree in both.
The reasons I added this interface were:
a) To have the alternate method c:out
svn commit: r413281 - in /jakarta/commons/proper/httpclient/trunk: ./ src/java/org/apache/commons/httpclient/ src/test/org/apache/commons/httpclient/
Author: olegk
Date: Sat Jun 10 03:36:20 2006
New Revision: 413281
URL: http://svn.apache.org/viewvc?rev=413281view=rev
Log:
[HTTPCLIENT-494] Invalid redirects are not corrected
Changelog:
Invalid redirect location now causes a protocol exception
Contributed by Ortwin Glück and Oleg Kalnichevski
Reviewed by Roland Weber
Added:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/InvalidRedirectLocationException.java
(with props)
Modified:
jakarta/commons/proper/httpclient/trunk/release_notes.txt
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/URI.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestRedirects.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestURI.java
Modified: jakarta/commons/proper/httpclient/trunk/release_notes.txt
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/release_notes.txt?rev=413281r1=413280r2=413281view=diff
==
--- jakarta/commons/proper/httpclient/trunk/release_notes.txt (original)
+++ jakarta/commons/proper/httpclient/trunk/release_notes.txt Sat Jun 10
03:36:20 2006
@@ -1,5 +1,8 @@
Changes toward 3.1
+ * [HTTPCLIENT-494] - Invalid redirect location now causes a protocol exception
+ Contributed by Oleg Kalnichevski olegk at apache.org
+
* [HTTPCLIENT-582] - Allow access to registered cookie policies
Contributed by Sebastian Bazley sebb at apache.org
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java?rev=413281r1=413280r2=413281view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
Sat Jun 10 03:36:20 2006
@@ -611,9 +611,9 @@
}
method.setURI(redirectUri);
hostConfiguration.setHost(redirectUri);
- } catch (URIException e) {
- LOG.warn(Redirected location ' + location + ' is
malformed);
- return false;
+ } catch (URIException ex) {
+throw new InvalidRedirectLocationException(
+Invalid redirect location: + location, location, ex);
}
if
(this.params.isParameterFalse(HttpClientParams.ALLOW_CIRCULAR_REDIRECTS)) {
Added:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/InvalidRedirectLocationException.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/InvalidRedirectLocationException.java?rev=413281view=auto
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/InvalidRedirectLocationException.java
(added)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/InvalidRedirectLocationException.java
Sat Jun 10 03:36:20 2006
@@ -0,0 +1,73 @@
+/*
+ * $HeadRL$
+ * $Revision$
+ * $Date$
+ *
+ *
+ *
+ * Copyright 1999-2006 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ *
+ * This software consists of voluntary contributions made by many
+ * individuals on behalf of the Apache Software Foundation. For more
+ * information on the Apache Software Foundation, please see
+ * http://www.apache.org/.
+ *
+ */
+
+package org.apache.commons.httpclient;
+
+/**
+ * Signals violation of HTTP specification caused by an invalid redirect
+ * location
+ *
+ * @author a href=mailto:oleg at ural.ruOleg Kalnichevski/a
+ *
+ * @since 3.1
+ */
+public class InvalidRedirectLocationException extends RedirectException {
+
+private final String
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: x:expr You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] Root cause [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-classes/org/apache/commons/jelly/jsl/suite.jelly:123:89: x:expr You must define an attribute called 'select' for this tag. [junit] at org.apache.commons.jelly.tags.xml.ExprTag.doTag(ExprTag.java:46) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-define-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-define-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/define] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar - [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:118) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:208) [junit] at junit.framework.TestSuite.run(TestSuite.java:203) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536) [junit] Jun 10, 2006 4:31:26 AM org.apache.commons.jelly.expression.xpath.XPathExpression evaluate [junit] SEVERE: Error constructing xpath [junit] org.jaxen.XPathSyntaxException: Node-set expected [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131) [junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156) [junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101) [junit] at org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78) [junit] at org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] at junit.framework.TestCase.runBare(TestCase.java:127) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-10062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-html has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 8 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-html : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-html-10062006.jar] identifier set to project name -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build) Work ended in a state of : Failed Elapsed: 13 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/html] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-10062006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar - [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48: test:assert You must define an attribute called 'test' for this tag. [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] [junit] [junit] Testcase: testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an ERROR [junit] file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] org.apache.commons.jelly.MissingAttributeException: file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48: test:assert You must define an attribute called 'test' for this tag. [junit] at
svn commit: r413327 - in /jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration: beanutils/package.html event/package.html tree/package.html tree/xpath/package.html
Author: oheger Date: Sat Jun 10 09:35:49 2006 New Revision: 413327 URL: http://svn.apache.org/viewvc?rev=413327view=rev Log: Added missing package.html files Added: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html (with props) jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/package.html (with props) jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/xpath/package.html (with props) Modified: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/package.html Modified: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/package.html URL: http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/package.html?rev=413327r1=413326r2=413327view=diff == --- jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/package.html (original) +++ jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/beanutils/package.html Sat Jun 10 09:35:49 2006 @@ -1,6 +1,6 @@ !DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN !-- -Copyright 2002-2005 The Apache Software Foundation. +Copyright 2002-2006 The Apache Software Foundation. Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. @@ -23,6 +23,8 @@ In this package a codeConfiguration/code implementation can be found that implements the codeDynaBean/code interface. It allows to access or modify a configuration using the classes from the Commons Beanutils package. +There are also classes for declaring beans in configuration files, from which +then instances can be created. /p p font size=-2$Id$/font Added: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html URL: http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html?rev=413327view=auto == --- jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html (added) +++ jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html Sat Jun 10 09:35:49 2006 @@ -0,0 +1,31 @@ +!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN +!-- +Copyright 2005-2006 The Apache Software Foundation. + +Licensed under the Apache License, Version 2.0 (the License); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an AS IS BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +-- +html +head +/head +body + +p +This package contains interfaces and classes for receiving notifications +about changes at configurations. +/p +p +font size=-2$Id$/font +/p + +/body +/html Propchange: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html -- svn:eol-style = native Propchange: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html -- svn:keywords = Date Author Id Revision HeadURL Propchange: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/event/package.html -- svn:mime-type = text/html Added: jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/package.html URL: http://svn.apache.org/viewvc/jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/package.html?rev=413327view=auto == --- jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/package.html (added) +++ jakarta/commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/tree/package.html Sat Jun 10 09:35:49 2006 @@ -0,0 +1,30 @@ +!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN +!-- +Copyright 2005-2006 The Apache Software Foundation. + +Licensed under the Apache License, Version 2.0 (the License); +you may not use
Re: [FILEUPLOAD] RfC: Proposed API changes for streaming
On 6/9/06, Jochen Wiedmann [EMAIL PROTECTED] wrote:
Hi,
first of all, let me say thanks for giving me the possibility to
contribute
to the project as a committer. Let's hope, I'll be doing fine. ;-)
Let's hope. ;-) Please add youself to the list of developers in the
project.xml file.
As already written, the changes required for streaming are nontrivial.
This looks interesting. However, given the non-trivial nature of the
changes, and the stylistic effect on the way FileUpload works, I wonder if
this wouldn't be better incorporated into the FileUpload 2 design, rather
than being retrofitted into FileUpload 1.x.
Sadly, there is no one place where the goals for FileUpload 2 are written
down right now. Some are in existing enhancement requests, some are
mentioned in random old e-mail threads, and some are still just in my head.
Now that there are two of us, I guess I'd better try to find some time to
write things down. ;-)
I'd
like to discuss them even if I were an experienced project member. Which I
am not, so please be alert even more.
I've had coffee. I'm alert. ;-)
The main reason for API changes is, that the existing interface FileItem is
to powerful.
By too powerful, you mean that it tackles two tasks - providing an
interface to the incoming data, and implicitly providing storage for it.
That's true, and if we want to separate those functions, then perhaps that
calls for a more radical separation than you are suggesting.
Therefore I propose to introduce a new interface, let's call it
SlimFileItem, or StreamingFileItem, with the following signature:
I don't like Slim. Stream or Streaming would be better. But I'm
wondering if the relationship between this and the existing notion of a
FileItem should be so direct. I'm really thinking off the top of my head
here, and haven't thought it through, though, so I don't have any more
concrete ideas at this point. It's worth some thought, though.
public interface SlimFileItem extends Serializable {
InputStream getInputStream() throws IOException;
String getContentType();
String getName();
String getFieldName();
boolean isFormField();
}
As you can see, the FileItem can be changed to extend SlimFileItem.
Additionally, FileItem has a semantic difference: It allows to invoke
getInputStream() more than once, while SlimFileItem should throw an
IllegalStateException on the second invocation. So far, these changes
should
not introduce a problem.
Well, I guess I don't agree here. If FileItem extended SimFileItem, then I
could pass a FileItem to methods that accept a SlimFileItem. At that point,
that SlimFileItem may or may not throw an exception if getInputStream is
called more than once. That's bad API behaviour.
The SlimFileItem is not to be created by a factory: The need for a factory
is mainly caused by the fact, that the FileItem's data needs to be
written.
Sort of. It's really that FileItem is accomplishing two different tasks, as
I noted above.
SlimFileItem is best implemented as an inner class of the MultipartStream.
Hmm. Not if you expect to expose SlimFileItem as part of the public API,
which you are suggesting with the getItemIterator method below.
Multipartstream isn't (supposed to be) part of the public API, so exposing
an inner class of it through the public API is a no-no.
So the API changes can be reduced to an additional method
Iterator /* SlimFileItem */ getItemIterator(RequestContext ctx)
throws FileUploadException;
in FileUploadBase. The existing method
List parseRequest(RequestContext ctx) throws FileUploadException;
would be changed to use getItemIterator internally and convert the
SlimFileItem instances into FileItem.
Finally, a suggestion for simplification: Let's change the
FileUploadException to extend IOException, and not Exception.
No. A FileUploadException isn't always related to IO, so extending
IOException would simply be wrong.
--
Martin Cooper
It will avoid
a lot of casting, type checking, and conversions. Besides, it also makes
sense in the semantic level. At least, I do thing so.
The only argument I can see against the exception change is the following:
People will see compiler errors when using constructs like
try {
...
} catch (IOException e) {
...
} catch (FileUploadException e) {
...
}
The obvious solution would be to change the order. IMO, that's acceptable.
Regards for any comments,
Jochen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r413311 - /jakarta/commons/proper/httpclient/trunk/build.xml
Author: rolandw
Date: Sat Jun 10 07:35:13 2006
New Revision: 413311
URL: http://svn.apache.org/viewvc?rev=413311view=rev
Log:
fix for GUMP problem from HTTPCLIENT-584
Modified:
jakarta/commons/proper/httpclient/trunk/build.xml
Modified: jakarta/commons/proper/httpclient/trunk/build.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/build.xml?rev=413311r1=413310r2=413311view=diff
==
--- jakarta/commons/proper/httpclient/trunk/build.xml (original)
+++ jakarta/commons/proper/httpclient/trunk/build.xml Sat Jun 10 07:35:13 2006
@@ -160,10 +160,6 @@
copy todir=${dist.home}/src filtering=on
fileset dir=${source.home}/
/copy
-mkdir dir=${dist.home}/lib/
-copy todir=${dist.home}/lib
- fileset dir=lib/
-/copy
/target
!-- == Targets: External Targets: Clean-up = --
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (COLLECTIONS-110) [collections] Support parametized classes with commons.collections.
[ http://issues.apache.org/jira/browse/COLLECTIONS-110?page=comments#action_12415690 ] Michael Heuer commented on COLLECTIONS-110: --- Perhaps a key reason that collections isn't generified is that I don't use JDK1.5 in my day job. That is unfortunate -- a lot of developers do. Every time I start to try and get my head around them, I realise just how confusing and messy they are. Reams of rules, exceptions to rules, strange corner cases, unexpected consequences... Might you be able to write test cases for some of these concerns? [collections] Support parametized classes with commons.collections. --- Key: COLLECTIONS-110 URL: http://issues.apache.org/jira/browse/COLLECTIONS-110 Project: Commons Collections Type: Bug Environment: Operating System: other Platform: Other Reporter: Colbert Philippe It's time to create a parallel version of commons.collections to support parametized classes of each container class and abstract class. It's not that hard. There is a 23 PDF document on Sun Java website describing in detail how it should be done and what to watch out for. I already converted a few classes from commons.collection privately for my own needs. Once you get the hang of it, it's a rather quick process. I am even willing to volunteer my time to do some more but I need the collaboration of some of the original programmers to watch over things. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (VALIDATOR-190) EmailValidator allows control characters (ASCII 0-31)
[ http://issues.apache.org/jira/browse/VALIDATOR-190?page=all ]
Gabriel Belingueres updated VALIDATOR-190:
--
Attachment: EmailValidator-diff.txt
EmailTest-diff.txt
Hi,
I'm uploading the patch files that would solve the issue (ie not allowing ASCII
0..31 in the local part of the email address), along with a test case.
Gabriel
EmailValidator allows control characters (ASCII 0-31)
-
Key: VALIDATOR-190
URL: http://issues.apache.org/jira/browse/VALIDATOR-190
Project: Commons Validator
Type: Bug
Versions: 1.3.0 Release
Reporter: Cott
Priority: Minor
Attachments: EmailTest-diff.txt, EmailValidator-diff.txt
EmailValidator allows ASCII 0 - 31 in an email address.
According to RFC 821, these are forbidden.
import org.apache.commons.validator.EmailValidator;
public class Test {
public static void main(String[] args) {
EmailValidator ev = EmailValidator.getInstance();
String email =[EMAIL PROTECTED];
System.err.println(ev.isValid(email));
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (BEANUTILS-185) [beanutils] Try to align BeanUtils with JSTL standard tags
[ http://issues.apache.org/jira/browse/BEANUTILS-185?page=all ] Niall Pemberton updated BEANUTILS-185: -- Attachment: DynaBeanMapDecorator.java DynaBeanMapDecoratorTestCase.java Attaching a DynaBeanMapDecorator class (and test case) which decorates a DynaBean as a java.util.Map [beanutils] Try to align BeanUtils with JSTL standard tags -- Key: BEANUTILS-185 URL: http://issues.apache.org/jira/browse/BEANUTILS-185 Project: Commons BeanUtils Type: Improvement Environment: Operating System: other Platform: Other Reporter: Gabriel Belingueres Priority: Minor Attachments: AbstractRowSetDynaClass.java, BasicDirectAccessDynaBean.java, BasicDirectAccessDynaBeanTestCase.java, BasicIndirectAccessDynaBean.java, DirectAccessDynaBean.java, DirectRowSetDynaClass.java, DynaBeanMapDecorator.java, DynaBeanMapDecoratorTestCase.java, IndirectAccessDynaBean.java, IndirectRowSetDynaClass.java, beanutil-diff.txt Hi, I've done some modifications to the beanutils package to better support the use of DynaBeans with the JSTL tags. Some of the changes are discussed in this thread of the commons-user mailing list: http://marc.theaimsgroup.com/?l=jakarta-commons-userm=114669123403779w=2 I attach the diff file that comprises changes to the RowSetDynaClass.java file and build.xml file (since I added a TestCase.) Note: Please try to filter carefully the diffs in the build.xml file since they include some local settings I have for compilation on my machine. :-( Together with the diff file, I attach the new java files added to the package. Regards, Gabriel Belingueres [EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r413361 - /jakarta/commons/proper/commons-build/trunk/parts/components-table.ent
Author: dennisl Date: Sat Jun 10 13:38:36 2006 New Revision: 413361 URL: http://svn.apache.org/viewvc?rev=413361view=rev Log: Correct spelling. Modified: jakarta/commons/proper/commons-build/trunk/parts/components-table.ent Modified: jakarta/commons/proper/commons-build/trunk/parts/components-table.ent URL: http://svn.apache.org/viewvc/jakarta/commons/proper/commons-build/trunk/parts/components-table.ent?rev=413361r1=413360r2=413361view=diff == --- jakarta/commons/proper/commons-build/trunk/parts/components-table.ent (original) +++ jakarta/commons/proper/commons-build/trunk/parts/components-table.ent Sat Jun 10 13:38:36 2006 @@ -27,7 +27,7 @@ tr tda href=http://jakarta.apache.org/commons/cli/;CLI/a/td td - Comamnd Line arguments parser. + Command Line arguments parser. /td /tr tr - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r413369 - in /jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient: MultiThreadedHttpConnectionManager.java SimpleHttpConnectionManager.java
Author: olegk
Date: Sat Jun 10 15:07:56 2006
New Revision: 413369
URL: http://svn.apache.org/viewvc?rev=413369view=rev
Log:
[HTTPCLIENT-553] JavaDoc getConnection methods in Connection Managers
Contributed by Oleg Kalnichevski
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/SimpleHttpConnectionManager.java
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java?rev=413369r1=413368r2=413369view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java
Sat Jun 10 15:07:56 2006
@@ -373,7 +373,20 @@
}
/**
- * @see HttpConnectionManager#getConnectionWithTimeout(HostConfiguration,
long)
+ * Gets a connection or waits if one is not available. A connection is
+ * available if one exists that is not being used or if fewer than
+ * maxHostConnections have been created in the connectionPool, and fewer
+ * than maxTotalConnections have been created in all connectionPools.
+ *
+ * @param hostConfiguration The host configuration specifying the
connection
+ *details.
+ * @param timeout the number of milliseconds to wait for a connection, 0 to
+ * wait indefinitely
+ *
+ * @return HttpConnection an available connection
+ *
+ * @throws HttpException if a connection does not become available in
+ * 'timeout' milliseconds
*
* @since 3.0
*/
@@ -414,21 +427,6 @@
}
}
-/**
- * Gets a connection or waits if one is not available. A connection is
- * available if one exists that is not being used or if fewer than
- * maxHostConnections have been created in the connectionPool, and fewer
- * than maxTotalConnections have been created in all connectionPools.
- *
- * @param hostConfiguration The host configuration.
- * @param timeout the number of milliseconds to wait for a connection, 0 to
- * wait indefinitely
- *
- * @return HttpConnection an available connection
- *
- * @throws HttpException if a connection does not become available in
- * 'timeout' milliseconds
- */
private HttpConnection doGetConnection(HostConfiguration
hostConfiguration,
long timeout) throws ConnectionPoolTimeoutException {
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/SimpleHttpConnectionManager.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/SimpleHttpConnectionManager.java?rev=413369r1=413368r2=413369view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/SimpleHttpConnectionManager.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/SimpleHttpConnectionManager.java
Sat Jun 10 15:07:56 2006
@@ -138,8 +138,13 @@
}
/**
- * @see HttpConnectionManager#getConnectionWithTimeout(HostConfiguration,
long)
+ * This method always returns the same connection object. If the
connection is already
+ * open, it will be closed and the new host configuration will be applied.
*
+ * @param hostConfiguration The host configuration specifying the
connection
+ *details.
+ * @param timeout this parameter has no effect. The connection is always
returned
+ *immediately.
* @since 3.0
*/
public HttpConnection getConnectionWithTimeout(
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MATH-151) MathUtils.round incorrect result
[ http://issues.apache.org/jira/browse/MATH-151?page=comments#action_12415723 ] Phil Steitz commented on MATH-151: -- Thanks for digging into this, Luc. I agree that the source of the problem here is in the decimal - binary conversion; but I don't want to close this as invalid or wontfix until we have exhausted all practical means to address the problem from the user standpoint. In other words, I would prefer to find a workaround if that is possible. One possibility is to revert to the implementation in R226479 or earlier. See http://svn.apache.org/repos/asf/jakarta/commons/proper/math/trunk/src/java/org/apache/commons/math/util/MathUtils.java?revision=226479 where we used BigDecimal rounding. We changed this partly for efficiency, partly to address http://issues.apache.org/jira/browse/MATH-32, which we would have to address in some other way if we go that route. Ideas or patches welcome! MathUtils.round incorrect result Key: MATH-151 URL: http://issues.apache.org/jira/browse/MATH-151 Project: Commons Math Type: Bug Versions: 1.1 Final Environment: Win2K, Sun JDK1.5.0_05 b05 Reporter: Buza Zoltán MathUtils.round(39.245, 2) results 39.24, however it should be 39.25, with default rounding mode BigDecimal.ROUND_HALF_UP. I found that internally MathUtils.round multiplies the given number by 10^scale. 39.245 * 100.0 results 3924.4...5 , and after this the calculation is not correct any more. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (BEANUTILS-241) BeanComparator throws wrong exception and hides cause
BeanComparator throws wrong exception and hides cause
-
Key: BEANUTILS-241
URL: http://issues.apache.org/jira/browse/BEANUTILS-241
Project: Commons BeanUtils
Type: Bug
Versions: 1.6 Final
Reporter: Chris Hyzer
Priority: Minor
BeanComparator does this:
catch ( Exception e ) {
throw new ClassCastException( e.toString() );
}
In my case, it was a getter throwing an exception, so it wasnt a
ClassCastException, but BeanComparator threw as such. I couldnt see what the
real exception was since the exception was not propagated as cause. I
recommend:
catch(Exception e) {
if (e instanceof RuntimeException) {
throw (RuntimeException)e;
}
//if this isnt available in the java version you are targetting, the above
line will improve things...
throw new RuntimeException(e);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-185) [beanutils] Try to align BeanUtils with JSTL standard tags
[ http://issues.apache.org/jira/browse/BEANUTILS-185?page=comments#action_12415729 ] Gabriel Belingueres commented on BEANUTILS-185: --- snip OK but I don't see anything different here that changes my mind about what I said about the existing createDynaBean() in RowSetDynaClass - your new direct/indirect DynaClass implementations could extend RowSetDynaClass and override that method. /snip Of course you can extend RowSetDynaClass directly to override the createDynaBean() method. If you decide both to do this and decide to keep the createDynaBean() method, I guess you should add a remark in the javadocs to show that the best practice for creating a different kind of DynaBean for the RowSet is by overriding createDynaBean() method. This should be sufficient guide for everyone. snip RowSetDynaClass is still the DynaClass (i.e. property meta data) for the individual row DynaBeans (in this case BasicDynaBean) and so I would disagree with you - newInstance() is exactly what should be called. Just because it bizarely creates a List of those DynaBeans as well doesn't change that. /snip If this work as you said, then I guess the class name RowSetDynaClass is very confusing/misleading, because when you call newInstance, it creates an instance of a single row of a RowSet, not the whole RowSet. A better name would be RowDynaBean? In addition, I see a problem here because creating a new instance make sense ONLY when iterating over the java.sql.ResultSet; i.e. only make sense calling it from the inside, never from the outside (the ResultSet could be already closed). Now, the newInstance() is public, and createDynaBean() is protected...this also makes sense to me. Perhaps the best course of action would be to separate the two concepts of RowSet and the Row itself? We know that the DynaBean concept fits very well with the Row concept, but the RowSet I see it more like an utility class to create the list of Rows and then I can discard it whenever I want (usually in my applications I'm interested in the dynabean list, not the RowSetDynaClass per se) snip Also I'm happy to add getMap() method to BasicDynaBean which returns a Map decorator - which would provide the indirect access method of your requirement. /snip Don't know if this is a good idea and I suppose we think different here. From a performance point of view, you probably want to add a boolean isReadonly flag as a parameter in the BasicDynaBean constructor so that you can add a private Map instance variable representing the unmodifiable map of properties (if isReadonly==true, or the DynaBeanMapDecorator if false), so that whenever any of the dynabean clients call the getMap() method, only the first time is the unmodifiable map created. (This performance optimization is probably to make a difference if you think that the dynabean will be referenced from several JSTL expressions in the same JSP page.) Now if my particular application never have to deal with this new getMap() functionality: Why would it have to pay for this new functionality/overhead on the BasicDynaBean? May be I'm over complicating things...don't know what is the policy here in this cases. Gabriel [beanutils] Try to align BeanUtils with JSTL standard tags -- Key: BEANUTILS-185 URL: http://issues.apache.org/jira/browse/BEANUTILS-185 Project: Commons BeanUtils Type: Improvement Environment: Operating System: other Platform: Other Reporter: Gabriel Belingueres Priority: Minor Attachments: AbstractRowSetDynaClass.java, BasicDirectAccessDynaBean.java, BasicDirectAccessDynaBeanTestCase.java, BasicIndirectAccessDynaBean.java, DirectAccessDynaBean.java, DirectRowSetDynaClass.java, DynaBeanMapDecorator.java, DynaBeanMapDecoratorTestCase.java, IndirectAccessDynaBean.java, IndirectRowSetDynaClass.java, beanutil-diff.txt Hi, I've done some modifications to the beanutils package to better support the use of DynaBeans with the JSTL tags. Some of the changes are discussed in this thread of the commons-user mailing list: http://marc.theaimsgroup.com/?l=jakarta-commons-userm=114669123403779w=2 I attach the diff file that comprises changes to the RowSetDynaClass.java file and build.xml file (since I added a TestCase.) Note: Please try to filter carefully the diffs in the build.xml file since they include some local settings I have for compilation on my machine. :-( Together with the diff file, I attach the new java files added to the package. Regards, Gabriel Belingueres [EMAIL PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
