[jira] Updated: (MATH-153) RandomDataImpl nextInt(int, int) nextLong(long, long)
[ http://issues.apache.org/jira/browse/MATH-153?page=all ] Remi Arntzen updated MATH-153: -- Attachment: Test.diff RandomDataImpl nextInt(int, int) nextLong(long, long) - Key: MATH-153 URL: http://issues.apache.org/jira/browse/MATH-153 Project: Commons Math Issue Type: Bug Affects Versions: Nightly Builds, 1.1 Final Reporter: Remi Arntzen Priority: Critical Fix For: 1.2 Final Attachments: diff.txt, Test.diff RandomDataImpl.nextInt(Integer.MIN_VALUE, Integer.MAX_VALUE) suffers from overflow errors. change return lower + (int) (rand.nextDouble() * (upper - lower + 1)); to return (int) (lower + (long) (rand.nextDouble()*((long) upper - lower + 1))); additional checks must be made for the nextlong(long, long) method. At first I thought about using MathUtils.subAndCheck(long, long) but there is only an int version avalible, and the problem is that subAndCheck internaly uses long values to check for overflow just as my previous channge proposes. The only thing I can think of is using a BigInteger to check for the number of bits required to express the difference. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (SANDBOX-166) Improve memory use
Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-09082006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-09082006.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:63) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:58) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:65) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:112) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-09082006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-09082006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-09082006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-09082006.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:63) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:58) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:65) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:112) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91) [junit] at
[jira] Commented: (SANDBOX-166) Improve memory use
[ http://issues.apache.org/jira/browse/SANDBOX-166?page=comments#action_12426905 ] Ortwin Glück commented on SANDBOX-166: -- The most important optimization is to reuse Token (and their StringBuffer) objects. CSV files usually contain the same number of columns throughout the file. The parser should adapt itself dynamically after the first line and size its internal arrays correctly. Also the columns have maximum lengths. The parser should adapt itself dynamically and size it's StringBuffers correctly. Because of JDK 1.3 compatibility there is StringBuffer.append(StringBuffer.toString()) which copies data twice. Using a better character buffer can alleviate the problem. CSVParser: getLine(): String[0] is immutable and should be a constant. Token objects should be reused! nextToken(): reuse intermediate StringBuffer wsBuf. Don't create a new instance on every call simpleTokenLexer(): reuse intermediate StringBuffer wsBuf. Don't create a new instance on every call I'll attach a patch that addresses those issues shortly. Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (SANDBOX-166) Improve memory use
[ http://issues.apache.org/jira/browse/SANDBOX-166?page=all ] Ortwin Glück updated SANDBOX-166: - Attachment: patch.txt This patch reduces the number of object allocations drastically. Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: patch.txt, profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (SANDBOX-166) Improve memory use
[ http://issues.apache.org/jira/browse/SANDBOX-166?page=all ] Ortwin Glück updated SANDBOX-166: - Attachment: optimized.png These are the figures parsing the same file as before but with the patch applied. The file contained 47632 rows of 10 columns each. The total file size is around 4MB. You can clearly see: - char[] are now down to the number of fields in the file: 476.741 now vs. 1.620.351 befor - A single CSVParser$Token is now reused: 1 now vs. 476.315 before - The intermediate String/StringBuffer objects are not reported, but they basically are the same number as char[] and now 4 CharBuffer instances are used only. Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: optimized.png, patch.txt, profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints by JesseSweetland
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by JesseSweetland: http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints The comment on the change is: Added link to Java5Enums page describing a method for using them with Betwixt -- * XMLIntrospector caches the results of introspection (which takes quite a bit of time) and so as long as readers and writers share the same configuration, you'll get better performance if they share the same instance + * /Java5Enums + Up to [:Betwixt] Previous [:Betwixt/FrequentlyAskedQuestions] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints/Java5Enums by JesseSweetland
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki
for change notification.
The following page has been changed by JesseSweetland:
http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints/Java5Enums
New page:
To render Java 5 Enums as primitive strings, two steps are needed. First,
Betwixt needs to be told that the Enum class should be treated as a primitive
and not a Bean, otherwise the Enum will be introspected and the property
accessor getDeclaringClass will be found. The result is this:
{{{
myEnumType
declaringClassmy.package.MyEnumType/declaringClass
/myEnumType
}}}
To make Betwixt treat Java 5 Enums as primitive types, implement a
TypeBindingStrategy:
{{{
import org.apache.commons.betwixt.strategy.*;
public class EnumTypeBindingStrategy extends TypeBindingStrategy {
public TypeBindingStrategy.BindingType bindingType(Class type) {
TypeBindingStrategy.BindingType bindingType = null;
if(Enum.class.isAssignableFrom(type)) {
bindingType = TypeBindingStrategy.BindingType.PRIMITIVE;
} else {
bindingType = TypeBindingStrategy.DEFAULT.bindingType(type);
}
return bindingType;
}
}
}}}
Once the TypeBindingStrategy class has been created, configure the Betwixt
BeanWriter to use it:
{{{
StringWriter sw = new StirngWriter();
BeanWriter bw = new BeanWriter(sw);
bw.getXMLIntrospector().getConfiguration().setTypeBindingStrategy(new
EnumTypeBindingStrategy());
}}}
Next, we need to tell Betwixt how to convert back and forth between String and
Enum values. To do this, implement an ObjectStringConverter:
{{{
import org.apache.commons.betwixt.expression.*;
import org.apache.commons.betwixt.strategy.*;
public class EnumObjectStringConverter extends ObjectStringConverter {
public String objectToString(Object object, Class type, Context context) {
String value = null;
if(object instanceof Enum) {
value = ((Enum)object).name();
} else {
value = super.objectToString(object, type, context);
}
return value;
}
public Object stringToObject(String value, Class type, Context context) {
Object object = null;
if(Enum.class.isAssignableFrom(type)) {
object = Enum.valueOf(type, value);
} else {
object = super.stringToObject(value, type, context);
}
return object;
}
}
}}}
Now, configure the converter on the BeanWriter:
{{{
StringWriter sw = new StirngWriter();
BeanWriter bw = new BeanWriter(sw);
bw.getXMLIntrospector().getConfiguration().setTypeBindingStrategy(new
EnumTypeBindingStrategy());
bw.getBindingConfiguration().setObjectStringConverter(new
EnumObjectStringConverter());
}}}
Now the above enumeration should render like this:
{{{
myEnumTypeSOME_CONSTANT/myEnumType
}}}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[nightly build] failed.
Failed build logs: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] failed.
Sorry about that. This message should not have been generated, since no builds failed. Will fix for tonight. Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] failed.
On 8/9/06, Phil Steitz [EMAIL PROTECTED] wrote: Sorry about that. This message should not have been generated, since no builds failed. Will fix for tonight. If you want the challenge - it should be remembering the previous failures and then sending an email when a failure becomes a success. I was hoping this would happen so I could know that my changes yesterday had all worked :) Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (SANDBOX-166) Improve memory use
[ http://issues.apache.org/jira/browse/SANDBOX-166?page=comments#action_12426973 ] Henri Yandell commented on SANDBOX-166: --- Very cool :) Thanks Ortwin. I'll take a look tonight (hopefully). Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: optimized.png, patch.txt, profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (IO-86) Add FileFinder back into Commons IO
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12426974 ] Henri Yandell commented on IO-86: - On Mario's VFS comment: I suspect we'll never have IO depending on VFS - it's lower level architectually; but having Finder dependent on a VFSWalker (in addition to IO's TreeWalker) seems like a great idea. Add FileFinder back into Commons IO --- Key: IO-86 URL: http://issues.apache.org/jira/browse/IO-86 Project: Commons IO Issue Type: New Feature Affects Versions: 1.2 Reporter: Niall Pemberton Fix For: 1.3 Attachments: FileFinder.java, FileFinderTestCase.java, io-filefinder-start-end.patch I'd like to propose adding a FileFinder back into Commons IO. This is a simplified version of what was recently moved out of Commons IO into the finder component currently in the sandbox. I believe this is a simpler, more generic implementation than the finder component and therefore would be considered suitable for inclusion in Commons IO. Although simpler it could be used as the basis for achieving the finder component's aims - namely to emulate the unix find command. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] failed.
Henri Yandell wrote: On 8/9/06, Phil Steitz [EMAIL PROTECTED] wrote: Sorry about that. This message should not have been generated, since no builds failed. Will fix for tonight. If you want the challenge - it should be remembering the previous failures and then sending an email when a failure becomes a success. I was hoping this would happen so I could know that my changes yesterday had all worked :) Hen Perhaps an empty message with the subject [nightly build] Successful? -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints by JesseSweetland
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by JesseSweetland: http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints -- * /Java5Enums + * /XSDDateTime + Up to [:Betwixt] Previous [:Betwixt/FrequentlyAskedQuestions] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints by JesseSweetland
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by JesseSweetland: http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints -- * /Java5Enums - * /XSDDateTime + * /XsdDateTime - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints/XsdDateTime by JesseSweetland
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki
for change notification.
The following page has been changed by JesseSweetland:
http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints/XsdDateTime
New page:
Here is an ObjectStringConverter implementation that will convert
java.util.Date into the ISO 8601 format used in the XML Schema Definition types
xsd:dateTime, xsd:date, and xsd:time, depending on the specified flavour.
{{{
import java.text.*;
import java.util.*;
import org.apache.commons.betwixt.expression.*;
import org.apache.commons.betwixt.strategy.*;
/**
* @author Jesse Sweetland
*/
public class DateObjectStringConverter extends ObjectStringConverter {
private static final DateFormat PSUEDO_ISO8601_DATETIME_FORMAT = new
SimpleDateFormat(-MM-dd'T'HH:mm:ss);
private static final DateFormat PSUEDO_ISO8601_DATETIME_FORMAT_TZ = new
SimpleDateFormat(-MM-dd'T'HH:mm:ssZ);
private static final DateFormat PSUEDO_ISO8601_DATE_FORMAT = new
SimpleDateFormat(-MM-dd);
private static final DateFormat PSUEDO_ISO8601_DATE_FORMAT_TZ = new
SimpleDateFormat(-MM-ddZ);
private static final DateFormat PSUEDO_ISO8601_TIME_FORMAT = new
SimpleDateFormat(HH:mm:ss);
private static final DateFormat PSUEDO_ISO8601_TIME_FORMAT_TZ = new
SimpleDateFormat(HH:mm:ssZ);
protected String getFlavor(Context context) {
return context.getOptions().getValue(FLAVOUR_OPTION_NAME);
}
public String objectToString(Object object, Class type, Context context) {
String flavor = getFlavor(context);
if(xsd:date.equals(flavor)){
return toIso8601Date((Date)object);
} else if(xsd:time.equals(flavor)){
return toIso8601Time((Date)object);
} else {
// Assume xsd:dateTime if not specified
return toIso8601DateTime((Date)object);
}
}
public Object stringToObject(String value, Class type, Context context) {
String flavor = getFlavor(context);
if(xsd:date.equals(flavor)){
return fromIso8601Date(value);
} else if(xsd:time.equals(flavor)){
return fromIso8601Time(value);
} else {
// Assume xsd:dateTime if not specified
return fromIso8601DateTime(value);
}
}
private String toIso8601DateTime(Date dateTime) {
if(dateTime == null) return null;
StringBuilder psuedoIso8601DateTime = new
StringBuilder(PSUEDO_ISO8601_DATETIME_FORMAT_TZ.format(dateTime));
String iso8601DateTime =
psuedoIso8601DateTime.insert(psuedoIso8601DateTime.length() - 2,
':').toString();
return iso8601DateTime;
}
private String toIso8601Date(Date date) {
if(date == null) return null;
StringBuilder psuedoIso8601Date = new
StringBuilder(PSUEDO_ISO8601_DATE_FORMAT_TZ.format(date));
String iso8601Date =
psuedoIso8601Date.insert(psuedoIso8601Date.length() - 2, ':').toString();
return iso8601Date;
}
private String toIso8601Time(Date time) {
if(time == null) return null;
StringBuilder psuedoIso8601Time = new
StringBuilder(PSUEDO_ISO8601_TIME_FORMAT_TZ.format(time));
String iso8601Time =
psuedoIso8601Time.insert(psuedoIso8601Time.length() - 2, ':').toString();
return iso8601Time;
}
private Date fromIso8601DateTime(String iso8601DateTime) {
if(iso8601DateTime == null) return null;
try {
iso8601DateTime = iso8601DateTime.trim();
boolean tzPresent = iso8601DateTime.length() 19;
if(tzPresent) {
String psuedoIso8601DateTime;
if(iso8601DateTime.charAt(19) == 'Z') {
psuedoIso8601DateTime = new
StringBuilder(iso8601DateTime.substring(0, 19)).append(-).toString();
} else {
psuedoIso8601DateTime = new
StringBuilder(iso8601DateTime).deleteCharAt(22).toString();
}
return
PSUEDO_ISO8601_DATETIME_FORMAT_TZ.parse(psuedoIso8601DateTime);
} else {
return PSUEDO_ISO8601_DATETIME_FORMAT.parse(iso8601DateTime);
}
} catch(Throwable t) {
throw new IllegalArgumentException(t);
}
}
private Date fromIso8601Date(String iso8601Date) {
if(iso8601Date == null) return null;
try {
iso8601Date = iso8601Date.trim();
boolean tzPresent = iso8601Date.length() 10;
if(tzPresent) {
String psuedoIso8601Date;
if(iso8601Date.charAt(10) == 'Z') {
psuedoIso8601Date = new
StringBuilder(iso8601Date.substring(0, 10)).append(-).toString();
} else {
psuedoIso8601Date = new
StringBuilder(iso8601Date).deleteCharAt(13).toString();
}
return
[Jakarta-commons Wiki] Update of Betwixt/TipsAndHints/Java5Enums by JesseSweetland
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki
for change notification.
The following page has been changed by JesseSweetland:
http://wiki.apache.org/jakarta-commons/Betwixt/TipsAndHints/Java5Enums
--
{{{
import org.apache.commons.betwixt.strategy.*;
+ /**
+ * @author Jesse Sweetland
+ */
public class EnumTypeBindingStrategy extends TypeBindingStrategy {
public TypeBindingStrategy.BindingType bindingType(Class type) {
TypeBindingStrategy.BindingType bindingType = null;
@@ -28, +31 @@
Once the TypeBindingStrategy class has been created, configure the Betwixt
BeanWriter to use it:
{{{
- StringWriter sw = new StirngWriter();
+ StringWriter sw = new StringWriter();
BeanWriter bw = new BeanWriter(sw);
bw.getXMLIntrospector().getConfiguration().setTypeBindingStrategy(new
EnumTypeBindingStrategy());
}}}
@@ -38, +41 @@
{{{
import org.apache.commons.betwixt.expression.*;
import org.apache.commons.betwixt.strategy.*;
+ /**
+ * @author Jesse Sweetland
+ */
public class EnumObjectStringConverter extends ObjectStringConverter {
public String objectToString(Object object, Class type, Context context) {
String value = null;
@@ -64, +70 @@
Now, configure the converter on the BeanWriter:
{{{
- StringWriter sw = new StirngWriter();
+ StringWriter sw = new StringWriter();
BeanWriter bw = new BeanWriter(sw);
bw.getXMLIntrospector().getConfiguration().setTypeBindingStrategy(new
EnumTypeBindingStrategy());
bw.getBindingConfiguration().setObjectStringConverter(new
EnumObjectStringConverter());
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] failed.
On 8/9/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Henri Yandell wrote: On 8/9/06, Phil Steitz [EMAIL PROTECTED] wrote: Sorry about that. This message should not have been generated, since no builds failed. Will fix for tonight. If you want the challenge - it should be remembering the previous failures and then sending an email when a failure becomes a success. I was hoping this would happen so I could know that my changes yesterday had all worked :) Hen Perhaps an empty message with the subject [nightly build] Successful? It gets very spammy, which induces people to turn things off and mentally not pay attention. Ideally you want the build errors to be a rare exception that people respond to quickly, and for their to be a single message to show that they fixed things but no more. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Fwd: [FILEUPLOAD] Remove deprecated API]
Sorry, had sent this to ws-commons-dev ... ---BeginMessage--- Hi, we have had two releases of commons fileupload with deprecated methods. As the required changes for replacing the deprecated with the recommended API are rather small (basically replace FileUpload with ServletFileUpload and the DefaultFileItemFactory with DiskFileItemFactory), I'd consider that tolerable for the users. Would anyone reject, if I removed the deprecated stuff for 1.2? Jochen -- My wife Mary and I have been married for forty-seven years and not once have we had an argument serious enough to consider divorce; murder, yes, but divorce, never. (Jack Benny) ---End Message--- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Fwd: [FILEUPLOAD] Remove deprecated API]
-- Forwarded message -- From: Jochen Wiedmann [EMAIL PROTECTED] To: commons-dev@ws.apache.org Date: Mon, 7 Aug 2006 01:22:23 +0200 Subject: [FILEUPLOAD] Remove deprecated API Hi, we have had two releases of commons fileupload with deprecated methods. As the required changes for replacing the deprecated with the recommended API are rather small (basically replace FileUpload with ServletFileUpload and the DefaultFileItemFactory with DiskFileItemFactory), I'd consider that tolerable for the users. Would anyone reject, if I removed the deprecated stuff for 1.2? Yep, I object :) Our loose process is that we remove deprecateds in the next major release; not a minor. So if you choose to remove the deprecated API, you need to call it 2.0. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430129 - in /jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder: Finder.java filters/CanReadFilter.java filters/CanWriteFilter.java filters/HiddenFilter.java
Author: bayard Date: Wed Aug 9 12:36:47 2006 New Revision: 430129 URL: http://svn.apache.org/viewvc?rev=430129view=rev Log: Moved to IO versions of Hidden, CanWrite and CanRead filters Removed: jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/CanReadFilter.java jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/CanWriteFilter.java jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/HiddenFilter.java Modified: jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/Finder.java Modified: jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/Finder.java URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/Finder.java?rev=430129r1=430128r2=430129view=diff == --- jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/Finder.java (original) +++ jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/Finder.java Wed Aug 9 12:36:47 2006 @@ -17,12 +17,12 @@ import java.io.File; import java.util.Map; -import org.apache.commons.finder.filters.CanReadFilter; -import org.apache.commons.finder.filters.CanWriteFilter; -import org.apache.commons.io.filefilter.EmptyFileFilter; -import org.apache.commons.finder.filters.HiddenFilter; import org.apache.commons.io.filefilter.DirectoryFileFilter; +import org.apache.commons.io.filefilter.CanReadFileFilter; +import org.apache.commons.io.filefilter.CanWriteFileFilter; +import org.apache.commons.io.filefilter.EmptyFileFilter; +import org.apache.commons.io.filefilter.HiddenFileFilter; import org.apache.commons.io.filefilter.IOFileFilter; import org.apache.commons.io.filefilter.NotFileFilter; @@ -63,14 +63,14 @@ // type of file public static final IOFileFilter DIRECTORY = DirectoryFileFilter.INSTANCE; public static final IOFileFilter FILE = new NotFileFilter(DirectoryFileFilter.INSTANCE); -public static final IOFileFilter HIDDEN = HiddenFilter.HIDDEN; -public static final IOFileFilter VISIBLE= HiddenFilter.VISIBLE; +public static final IOFileFilter HIDDEN = HiddenFileFilter.HIDDEN; +public static final IOFileFilter VISIBLE= HiddenFileFilter.VISIBLE; // permission replacements -public static final IOFileFilter CAN_READ = CanReadFilter.CAN_READ; -public static final IOFileFilter CANNOT_READ = CanReadFilter.CANNOT_READ; -public static final IOFileFilter CAN_WRITE= CanWriteFilter.CAN_WRITE; -public static final IOFileFilter CANNOT_WRITE = CanWriteFilter.CANNOT_WRITE; +public static final IOFileFilter CAN_READ = CanReadFileFilter.CAN_READ; +public static final IOFileFilter CANNOT_READ = CanReadFileFilter.CANNOT_READ; +public static final IOFileFilter CAN_WRITE= CanWriteFileFilter.CAN_WRITE; +public static final IOFileFilter CANNOT_WRITE = CanWriteFileFilter.CANNOT_WRITE; public void addFindListener(FindListener fl); public void removeFindListener(FindListener fl); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[RESULT] [VOTE] Andrew Shirley as committer?
On 8/4/06, Henri Yandell [EMAIL PROTECTED] wrote: I'd like to propose Andrew Shirley as a committer. Andrew's been doing tons for the CLI component - answering user questions, commenting on jira issues and serving up patches and unit tests to both his issues and other peoples issues. The only reason I've hesitated until recently is because CLI didn't have a clear direction (now it does). [ ] +1 [ ] -1 Vote ends Wednesday 9th August. Vote passes. Binding +1s Davanum Srinivas Niall Pemberton Craig McClanahan Rahul Akolkar Oliver Heger Martin van den Bemt Phil Steitz Mario Ivankovits (I really need to remember to vote +1 from me too). Non-binding +1s Jörg Schaible - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[RESULT] [VOTE] Kris Nuttycombe as committer?
On 8/4/06, Henri Yandell [EMAIL PROTECTED] wrote: I'd like to nominate Kris as a committer. Kris has been active on the developer mailing list concerning the pipeline component for over a year, and has been involved on other threads as well (notably digester). I think he's been around long enough to have picked up the way of doing things and it'll be good for pipeline (and ultimately commons). [ ] +1 [ ] -1 Vote ends Wednesday 9th August. Vote passes. Binding +1s Davanum Srinivas Niall Pemberton Craig McClanahan Rahul Akolkar Oliver Heger Martin van den Bemt Phil Steitz Mario Ivankovits (I really need to remember to vote +1 from me too). Non-binding +1s Jörg Schaible - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (CONFIGURATION-219) PropertiesConfiguration.clone() does not properly handle the layout object
PropertiesConfiguration.clone() does not properly handle the layout object -- Key: CONFIGURATION-219 URL: http://issues.apache.org/jira/browse/CONFIGURATION-219 Project: Commons Configuration Issue Type: Bug Affects Versions: Nightly Builds Reporter: Oliver Heger If a PropertiesConfiguration object is cloned, the clone will have the same PropertiesConfigurationLayout object. Of course this will cause trouble when later both objects are modified and then written to a file. PropertiesConfiguration needs a specific clone() implementation, which also clones the layout object. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [RESULT] [VOTE] Kris Nuttycombe as committer?
Thank you all for this honor! I'm really excited to be a part of this community. Now, can someone please hold my hand while I make my first tentative steps as a committer, i.e., let me know what needs to be done to get set up? Kris Henri Yandell wrote: On 8/4/06, Henri Yandell [EMAIL PROTECTED] wrote: I'd like to nominate Kris as a committer. Kris has been active on the developer mailing list concerning the pipeline component for over a year, and has been involved on other threads as well (notably digester). I think he's been around long enough to have picked up the way of doing things and it'll be good for pipeline (and ultimately commons). [ ] +1 [ ] -1 Vote ends Wednesday 9th August. Vote passes. Binding +1s Davanum Srinivas Niall Pemberton Craig McClanahan Rahul Akolkar Oliver Heger Martin van den Bemt Phil Steitz Mario Ivankovits (I really need to remember to vote +1 from me too). Non-binding +1s Jörg Schaible - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430154 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Author: ggregory
Date: Wed Aug 9 15:07:04 2006
New Revision: 430154
URL: http://svn.apache.org/viewvc?rev=430154view=rev
Log:
Unnecessary cast from Object to Enum.
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java?rev=430154r1=430153r2=430154view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Wed Aug 9 15:07:04 2006
@@ -372,7 +372,7 @@
if (entry == null) {
return null;
}
-return (Enum) entry.map.get(getName());
+return entry.map.get(getName());
}
//
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430156 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Author: ggregory
Date: Wed Aug 9 15:08:34 2006
New Revision: 430156
URL: http://svn.apache.org/viewvc?rev=430156view=rev
Log:
Access to enclosing constructor Enum.Entry() is emulated by a synthetic
accessor method. Increasing its visibility will improve your performance
(Eclipse compiler).
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java?rev=430156r1=430155r2=430156view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Wed Aug 9 15:08:34 2006
@@ -296,7 +296,7 @@
/**
* pRestrictive constructor./p
*/
-private Entry() {
+protected Entry() {
super();
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430157 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Author: ggregory
Date: Wed Aug 9 15:09:11 2006
New Revision: 430157
URL: http://svn.apache.org/viewvc?rev=430157view=rev
Log:
Unnecessary cast from Object to Enum.
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java?rev=430157r1=430156r2=430157view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Wed Aug 9 15:09:11 2006
@@ -369,7 +369,7 @@
if (entry == null) {
return null;
}
-return (Enum) entry.map.get(getName());
+return entry.map.get(getName());
}
//
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430161 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Author: ggregory
Date: Wed Aug 9 15:10:03 2006
New Revision: 430161
URL: http://svn.apache.org/viewvc?rev=430161view=rev
Log:
Access to enclosing constructor Enum.Entry() is emulated by a synthetic
accessor method. Increasing its visibility will improve your performance
(Eclipse compiler).
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java?rev=430161r1=430160r2=430161view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums/Enum.java
Wed Aug 9 15:10:03 2006
@@ -293,7 +293,7 @@
/**
* pRestrictive constructor./p
*/
-private Entry() {
+protected Entry() {
super();
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430163 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java
Author: ggregory
Date: Wed Aug 9 15:11:03 2006
New Revision: 430163
URL: http://svn.apache.org/viewvc?rev=430163view=rev
Log:
Unnecessary cast from String[] to String[]
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java?rev=430163r1=430162r2=430163view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/builder/ReflectionToStringBuilder.java
Wed Aug 9 15:11:03 2006
@@ -833,7 +833,7 @@
if (excludeFieldNamesParam == null) {
this.excludeFieldNames = null;
} else {
-this.excludeFieldNames =
(String[])toNoNullStringArray(excludeFieldNamesParam);
+this.excludeFieldNames =
toNoNullStringArray(excludeFieldNamesParam);
Arrays.sort(this.excludeFieldNames);
}
return this;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430164 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java
Author: ggregory Date: Wed Aug 9 15:14:15 2006 New Revision: 430164 URL: http://svn.apache.org/viewvc?rev=430164view=rev Log: Remove unused import java.lang.reflect.Field Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java?rev=430164r1=430163r2=430164view=diff == --- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java (original) +++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/builder/EqualsBuilderTest.java Wed Aug 9 15:14:15 2006 @@ -15,7 +15,6 @@ */ package org.apache.commons.lang.builder; -import java.lang.reflect.Field; import java.util.Arrays; import junit.framework.Test; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430165 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java
Author: ggregory Date: Wed Aug 9 15:14:51 2006 New Revision: 430165 URL: http://svn.apache.org/viewvc?rev=430165view=rev Log: Remove unused import java.util.Date Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java?rev=430165r1=430164r2=430165view=diff == --- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java (original) +++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/time/DurationFormatUtilsTest.java Wed Aug 9 15:14:51 2006 @@ -19,7 +19,6 @@ import java.lang.reflect.Constructor; import java.lang.reflect.Modifier; import java.util.Calendar; -import java.util.Date; import java.util.TimeZone; import junit.framework.Test; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430166 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Author: ggregory
Date: Wed Aug 9 15:16:21 2006
New Revision: 430166
URL: http://svn.apache.org/viewvc?rev=430166view=rev
Log:
Unnecessary cast from char to int
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java?rev=430166r1=430165r2=430166view=diff
==
---
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Wed Aug 9 15:16:21 2006
@@ -81,7 +81,7 @@
r1 = RandomStringUtils.randomAscii(50);
assertEquals(randomAscii(50) length, 50, r1.length());
for(int i = 0; i r1.length(); i++) {
-assertTrue(char between 32 and 127, (int) r1.charAt(i) = 32
(int) r1.charAt(i) = 127);
+assertTrue(char between 32 and 127, r1.charAt(i) = 32
r1.charAt(i) = 127);
}
r2 = RandomStringUtils.randomAscii(50);
assertTrue(!r1.equals(r2), !r1.equals(r2));
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430167 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Author: ggregory
Date: Wed Aug 9 15:18:43 2006
New Revision: 430167
URL: http://svn.apache.org/viewvc?rev=430167view=rev
Log:
Format method for legibility (added some spaces in expressions.)
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java?rev=430167r1=430166r2=430167view=diff
==
---
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/RandomStringUtilsTest.java
Wed Aug 9 15:18:43 2006
@@ -309,9 +309,9 @@
private double chiSquare(int[] expected, int[] observed) {
double sumSq = 0.0d;
double dev = 0.0d;
-for (int i = 0; i observed.length; i++) {
-dev = (double)(observed[i] - expected[i]);
-sumSq += dev*dev/(double)expected[i];
+for (int i = 0; i observed.length; i++) {
+dev = (double) (observed[i] - expected[i]);
+sumSq += dev * dev / (double) expected[i];
}
return sumSq;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430168 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java
Author: ggregory Date: Wed Aug 9 15:21:38 2006 New Revision: 430168 URL: http://svn.apache.org/viewvc?rev=430168view=rev Log: Unnecessary cast from char to int Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java?rev=430168r1=430167r2=430168view=diff == --- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java (original) +++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringEscapeUtilsTest.java Wed Aug 9 15:21:38 2006 @@ -256,8 +256,8 @@ Character c1 = new Character(i); Character c2 = new Character((char)(i+1)); String expected = c1.toString() + c2.toString(); -String escapedC1 = #x + Integer.toHexString((int)(c1.charValue())) + ;; -String escapedC2 = #x + Integer.toHexString((int)(c2.charValue())) + ;; +String escapedC1 = #x + Integer.toHexString((c1.charValue())) + ;; +String escapedC2 = #x + Integer.toHexString((c2.charValue())) + ;; assertEquals(hex number unescape index + (int)i, expected, StringEscapeUtils.unescapeHtml(escapedC1 + escapedC2)); } } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (DBCP-196) Unexpected error with DBCP and OJB where OJB was unable to get a connection. The root cause appears to be a org.apache.commons.dbcp.SQLNestedException: Cannot get a conne
[ http://issues.apache.org/jira/browse/DBCP-196?page=comments#action_12427046 ] Henri Yandell commented on DBCP-196: Not that I'm a DBCP expert (and especially not OJB), but thought I'd ask a question. Any idea if the DBCP being used is configured in a particular way? My limited understanding is that your code should have blocked indefinitely, even if there are only the 8 default connections available in the pool. Unexpected error with DBCP and OJB where OJB was unable to get a connection. The root cause appears to be a org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool exhausted, cause: null - Key: DBCP-196 URL: http://issues.apache.org/jira/browse/DBCP-196 Project: Commons Dbcp Issue Type: Bug Environment: Jboss 4.0 commons-dbcp-1.1.jar commons-pool-1.1.jar db-ojb-1.0.rc6.jar Reporter: Eric Ferrer Priority: Critical Attachments: dbcp_exhausted_connection_error.txt Our application has been running fine for 9 months and this is the first time I have encounted this error. It happend randomly throughout the day in an inconsistent pattern (user was entering data on web, user was searching for data, ect.) It did not occur on any particular screen. Attached is the stack trace from OJB Broker loadByExample request to DBCP error. THe rest of the stack trace was ommitted since it involves the uncaught exception entire stack back to the web tier -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430176 - in /jakarta/commons/proper/lang/trunk/src: java/org/apache/commons/lang/text/StrSubstitutor.java test/org/apache/commons/lang/text/StrSubstitutorTest.java
Author: scolebourne
Date: Wed Aug 9 15:52:45 2006
New Revision: 430176
URL: http://svn.apache.org/viewvc?rev=430176view=rev
Log:
Enhance StrSubtstitutor with StringBuffer methods and replaceIn() methods
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrSubstitutor.java
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/text/StrSubstitutorTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrSubstitutor.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrSubstitutor.java?rev=430176r1=430175r2=430176view=diff
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrSubstitutor.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrSubstitutor.java
Wed Aug 9 15:52:45 2006
@@ -248,8 +248,51 @@
//---
/**
- * Replaces all the occurrences of variables in the given source array with
- * their matching values from the resolver.
+ * Replaces all the occurrences of variables with their matching values
+ * from the resolver using the given source string as a template.
+ *
+ * @param source the string to replace in, null returns null
+ * @return the result of the replace operation
+ */
+public String replace(String source) {
+if (source == null) {
+return null;
+}
+StrBuilder buf = new StrBuilder(source);
+if (substitute(buf, 0, source.length()) == false) {
+return source;
+}
+return buf.toString();
+}
+
+/**
+ * Replaces all the occurrences of variables with their matching values
+ * from the resolver using the given source string as a template.
+ * p
+ * Only the specified portion of the string will be processed.
+ * The rest of the string is not processed, and is not returned.
+ *
+ * @param source the string to replace in, null returns null
+ * @param offset the start offset within the array, must be valid
+ * @param length the length within the array to be processed, must be
valid
+ * @return the result of the replace operation
+ */
+public String replace(String source, int offset, int length) {
+if (source == null) {
+return null;
+}
+StrBuilder buf = new StrBuilder(length).append(source, offset, length);
+if (substitute(buf, 0, length) == false) {
+return source.substring(offset, offset + length);
+}
+return buf.toString();
+}
+
+//---
+/**
+ * Replaces all the occurrences of variables with their matching values
+ * from the resolver using the given source array as a template.
+ * The array is not altered by this method.
*
* @param source the character array to replace in, not altered, null
returns null
* @return the result of the replace operation
@@ -264,9 +307,12 @@
}
/**
- * Replaces all the occurrences of variables in the given source array by
with
- * their matching values from the resolver.
+ * Replaces all the occurrences of variables with their matching values
+ * from the resolver using the given source array as a template.
+ * The array is not altered by this method.
+ * p
* Only the specified portion of the array will be processed.
+ * The rest of the array is not processed, and is not returned.
*
* @param source the character array to replace in, not altered, null
returns null
* @param offset the start offset within the array, must be valid
@@ -284,41 +330,81 @@
//---
/**
- * Replaces all the occurrences of variables in the given source string
with
- * their matching values from the resolver.
+ * Replaces all the occurrences of variables with their matching values
+ * from the resolver using the given source buffer as a template.
+ * The buffer is not altered by this method.
*
- * @param source the string to replace in, null returns null
+ * @param source the buffer to use as a template, not changed, null
returns null
* @return the result of the replace operation
*/
-public String replace(String source) {
+public String replace(StringBuffer source) {
if (source == null) {
return null;
}
-StrBuilder buf = new StrBuilder(source);
-if (substitute(buf, 0, source.length()) == false) {
-return source;
-}
+StrBuilder buf = new StrBuilder(source.length()).append(source);
+substitute(buf,
[jira] Commented: (DBCP-196) Unexpected error with DBCP and OJB where OJB was unable to get a connection. The root cause appears to be a org.apache.commons.dbcp.SQLNestedException: Cannot get a conne
[ http://issues.apache.org/jira/browse/DBCP-196?page=comments#action_12427057 ] Eric Ferrer commented on DBCP-196: -- OJB is configured to use DBCP as its pool, the params passed are as follows jdbc-connection-descriptor jcd-alias=APPLICATION default-connection=true platform=MsSQLServer jdbc-level=4.0 driver=net.sourceforge.jtds.jdbc.Driver dbalias=//myDba:8989/myDBA;SelectMethod=cursor username=myDBA password=myDBA eager-release=false batch-mode=false protocol=jdbc subprotocol=jtds:sqlserver useAutoCommit=1 ignoreAutoCommitExceptions=false connection-pool maxActive=255 validationQuery=SELECT 1 / /jdbc-connection-descriptor Unexpected error with DBCP and OJB where OJB was unable to get a connection. The root cause appears to be a org.apache.commons.dbcp.SQLNestedException: Cannot get a connection, pool exhausted, cause: null - Key: DBCP-196 URL: http://issues.apache.org/jira/browse/DBCP-196 Project: Commons Dbcp Issue Type: Bug Environment: Jboss 4.0 commons-dbcp-1.1.jar commons-pool-1.1.jar db-ojb-1.0.rc6.jar Reporter: Eric Ferrer Priority: Critical Attachments: dbcp_exhausted_connection_error.txt Our application has been running fine for 9 months and this is the first time I have encounted this error. It happend randomly throughout the day in an inconsistent pattern (user was entering data on web, user was searching for data, ect.) It did not occur on any particular screen. Attached is the stack trace from OJB Broker loadByExample request to DBCP error. THe rest of the stack trace was ommitted since it involves the uncaught exception entire stack back to the web tier -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430201 - /jakarta/commons/proper/commons-build/trunk/commons_nightly.sh
Author: psteitz
Date: Wed Aug 9 18:00:51 2006
New Revision: 430201
URL: http://svn.apache.org/viewvc?rev=430201view=rev
Log:
No failures - no CI-spam.
Modified:
jakarta/commons/proper/commons-build/trunk/commons_nightly.sh
Modified: jakarta/commons/proper/commons-build/trunk/commons_nightly.sh
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-build/trunk/commons_nightly.sh?rev=430201r1=430200r2=430201view=diff
==
--- jakarta/commons/proper/commons-build/trunk/commons_nightly.sh (original)
+++ jakarta/commons/proper/commons-build/trunk/commons_nightly.sh Wed Aug 9
18:00:51 2006
@@ -223,17 +223,20 @@
# Make files group writable
ssh $deploy_host chmod -R g+w $deploy_location
-# Send failure notification email
-rm /home/$deploy_user/build_report
-echo Failed build logs: /home/$deploy_user/build_report
-subject=\[nightly build] [EMAIL PROTECTED] failed.\
-for i in [EMAIL PROTECTED]; do
- echo ${log_url}/${time_stamp}/${i}.log /home/$deploy_user/build_report
-done
-scp /home/$deploy_user/build_report [EMAIL PROTECTED]:/home/$deploy_user
-ssh $deploy_host mail -s $subject $notification_email
/home/$deploy_user/build_report
-ssh $deploy_host rm /home/$deploy_user/build_report
-rm /home/$deploy_user/build_report
+# Send failure notification email if there are build failures
+if [ [EMAIL PROTECTED] ]
+then
+ rm /home/$deploy_user/build_report
+ echo Failed build logs: /home/$deploy_user/build_report
+ subject=\[nightly build] [EMAIL PROTECTED] failed.\
+ for i in [EMAIL PROTECTED]; do
+echo ${log_url}/${time_stamp}/${i}.log /home/$deploy_user/build_report
+ done
+ scp /home/$deploy_user/build_report [EMAIL PROTECTED]:/home/$deploy_user
+ ssh $deploy_host mail -s $subject $notification_email
/home/$deploy_user/build_report
+ ssh $deploy_host rm /home/$deploy_user/build_report
+ rm /home/$deploy_user/build_report
+fi
exit 0
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[nightly build] m2 support - a little help, pls
I would like to add m2 support to the nightly build script, but am still an m2 newbie, so could use a little help. I thought that starting with [csv] would be good, since the migration page lists it as done. I have a couple of questions. 1. It seems to use pom inheritence, which I am sure someone will convince me is a good thing, despite the fact that my first experience with it is a build failure because of it. How do I find and I guess install the commons-sandbox-parent? How do we indicate to users that they are going to need to set this up for builds to work? Do we really need this? 2. Properties files seem to be replaced by settings.xml. Is this where we designate repo lists? If so, can someone commit a settings.xml.sample? 3. I assume that the reference to 'minotaur' in the distributionManagement section of the csv pom should be changed to 'people'? Once this is fixed, I assume deploy will work correctly using the ssh key that the script is using to connect to people now. 4. The dist plugin seems to be gone and the release plugin looks like it is really just aiming to deploy jars and tag releases. Should I use ant tasks to roll the distros manually or is there some m2 plugin that will do this? Thanks! Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] m2 support - a little help, pls
On 10/08/2006 1:21 PM, Phil Steitz wrote: I would like to add m2 support to the nightly build script, but am still an m2 newbie, so could use a little help. I thought that starting with [csv] would be good, since the migration page lists it as done. I have a couple of questions. 1. It seems to use pom inheritence, which I am sure someone will convince me is a good thing, despite the fact that my first experience with it is a build failure because of it. How do I find and I guess install the commons-sandbox-parent? It's in sandbox-trunks for now How do we indicate to users that they are going to need to set this up for builds to work? It shouldn't be necessary. If the parent is finalised and released as an independant artifact first, it will be downloaded from the repository like any dependency. Do we really need this? It's extremely useful for reducing duplication and making changes (such as repository location) easier, and also allows the same for any generated sites, so I'd say yes :) 2. Properties files seem to be replaced by settings.xml. Is this where we designate repo lists? If so, can someone commit a settings.xml.sample? project.properties is replaced by pom.xml (ie, plugin configuration is brought in). This is all you should need to commit to SVN, and it can contain repository references if needed. settings.xml is the equivalent of ~/build.properties. It should only need additions if you are a deployer or want to add additional repositories yourself. 3. I assume that the reference to 'minotaur' in the distributionManagement section of the csv pom should be changed to 'people'? Once this is fixed, I assume deploy will work correctly using the ssh key that the script is using to connect to people now. Should do. 4. The dist plugin seems to be gone and the release plugin looks like it is really just aiming to deploy jars and tag releases. Should I use ant tasks to roll the distros manually or is there some m2 plugin that will do this? The assembly plugin is the equivalent of dist (but is a lot more flexible). There is a default descriptor for building source and binary tarballs/zips, but you can also create your own, describing the layout of the resulting archive. Thanks! - Brett - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430236 - in /jakarta/commons/sandbox: compress/trunk/pom.xml csv/trunk/pom.xml exec/trunk/pom.xml jci/trunk/pom.xml openpgp/trunk/pom.xml
Author: bayard Date: Wed Aug 9 21:12:30 2006 New Revision: 430236 URL: http://svn.apache.org/viewvc?rev=430236view=rev Log: Switching from minotaur.apache.org to people.apache.org in the distributionManagement Modified: jakarta/commons/sandbox/compress/trunk/pom.xml jakarta/commons/sandbox/csv/trunk/pom.xml jakarta/commons/sandbox/exec/trunk/pom.xml jakarta/commons/sandbox/jci/trunk/pom.xml jakarta/commons/sandbox/openpgp/trunk/pom.xml Modified: jakarta/commons/sandbox/compress/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/compress/trunk/pom.xml?rev=430236r1=430235r2=430236view=diff == --- jakarta/commons/sandbox/compress/trunk/pom.xml (original) +++ jakarta/commons/sandbox/compress/trunk/pom.xml Wed Aug 9 21:12:30 2006 @@ -54,7 +54,7 @@ site idwebsite/id nameApache Website/name - urlscp://minotaur.apache.org/www/jakarta.apache.org/commons/sandbox/compress//url + urlscp://people.apache.org/www/jakarta.apache.org/commons/sandbox/compress//url /site /distributionManagement Modified: jakarta/commons/sandbox/csv/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/csv/trunk/pom.xml?rev=430236r1=430235r2=430236view=diff == --- jakarta/commons/sandbox/csv/trunk/pom.xml (original) +++ jakarta/commons/sandbox/csv/trunk/pom.xml Wed Aug 9 21:12:30 2006 @@ -43,7 +43,7 @@ site idwebsite/id nameApache Website/name - urlscp://minotaur.apache.org/www/jakarta.apache.org/commons/sandbox/csv//url + urlscp://people.apache.org/www/jakarta.apache.org/commons/sandbox/csv//url /site /distributionManagement Modified: jakarta/commons/sandbox/exec/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/exec/trunk/pom.xml?rev=430236r1=430235r2=430236view=diff == --- jakarta/commons/sandbox/exec/trunk/pom.xml (original) +++ jakarta/commons/sandbox/exec/trunk/pom.xml Wed Aug 9 21:12:30 2006 @@ -55,7 +55,7 @@ site idwebsite/id nameApache Website/name - urlscp://minotaur.apache.org/www/jakarta.apache.org/commons/sandbox/exec//url + urlscp://people.apache.org/www/jakarta.apache.org/commons/sandbox/exec//url /site /distributionManagement Modified: jakarta/commons/sandbox/jci/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/pom.xml?rev=430236r1=430235r2=430236view=diff == --- jakarta/commons/sandbox/jci/trunk/pom.xml (original) +++ jakarta/commons/sandbox/jci/trunk/pom.xml Wed Aug 9 21:12:30 2006 @@ -121,7 +121,7 @@ /snapshotRepository site idwebsite/id - urlscpexe://minotaur.apache.org/www/jakarta.apache.org/commons/sandbox/jci/url + urlscpexe://people.apache.org/www/jakarta.apache.org/commons/sandbox/jci/url /site /distributionManagement Modified: jakarta/commons/sandbox/openpgp/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/openpgp/trunk/pom.xml?rev=430236r1=430235r2=430236view=diff == --- jakarta/commons/sandbox/openpgp/trunk/pom.xml (original) +++ jakarta/commons/sandbox/openpgp/trunk/pom.xml Wed Aug 9 21:12:30 2006 @@ -49,7 +49,7 @@ site idwebsite/id nameApache Website/name - urlscp://minotaur.apache.org/www/jakarta.apache.org/commons/sandbox/openpgp//url + urlscp://people.apache.org/www/jakarta.apache.org/commons/sandbox/openpgp//url /site /distributionManagement - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] m2 support - a little help, pls
On 8/9/06, Brett Porter [EMAIL PROTECTED] wrote: On 10/08/2006 1:21 PM, Phil Steitz wrote: I would like to add m2 support to the nightly build script, but am still an m2 newbie, so could use a little help. I thought that starting with [csv] would be good, since the migration page lists it as done. I have a couple of questions. 1. It seems to use pom inheritence, which I am sure someone will convince me is a good thing, despite the fact that my first experience with it is a build failure because of it. How do I find and I guess install the commons-sandbox-parent? It's in sandbox-trunks for now OK, so I just did mvn install from the root of sandbox trunk and I guess that did it. How do we indicate to users that they are going to need to set this up for builds to work? It shouldn't be necessary. If the parent is finalised and released as an independant artifact first, it will be downloaded from the repository like any dependency. Do we really need this? It's extremely useful for reducing duplication and making changes (such as repository location) easier, and also allows the same for any generated sites, so I'd say yes :) OK, so the repo list will eventually go there? When it failed once it displayed a list of repos including apache.snapshots that I could not figure out where it was getting. I guess those are defaults and the right way to set things up is to use repository elements in the pom. So these should probably be specified then in the sandbox-parent and proper-parent. 2. Properties files seem to be replaced by settings.xml. Is this where we designate repo lists? If so, can someone commit a settings.xml.sample? project.properties is replaced by pom.xml (ie, plugin configuration is brought in). This is all you should need to commit to SVN, and it can contain repository references if needed. settings.xml is the equivalent of ~/build.properties. It should only need additions if you are a deployer or want to add additional repositories yourself. Good. We should then provide examples for RMs eventually. 3. I assume that the reference to 'minotaur' in the distributionManagement section of the csv pom should be changed to 'people'? Once this is fixed, I assume deploy will work correctly using the ssh key that the script is using to connect to people now. Should do. 4. The dist plugin seems to be gone and the release plugin looks like it is really just aiming to deploy jars and tag releases. Should I use ant tasks to roll the distros manually or is there some m2 plugin that will do this? The assembly plugin is the equivalent of dist (but is a lot more flexible). There is a default descriptor for building source and binary tarballs/zips, but you can also create your own, describing the layout of the resulting archive. Nice! Much nicer than the old muck with maven.xml approach. I will have a play with this and either use built-ins or commit descriptors that we can use for the nightlies to start and then standardize for releases. Suggestions / commits welcome! Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] m2 support - a little help, pls
On 8/9/06, Phil Steitz [EMAIL PROTECTED] wrote: On 8/9/06, Brett Porter [EMAIL PROTECTED] wrote: On 10/08/2006 1:21 PM, Phil Steitz wrote: I would like to add m2 support to the nightly build script, but am still an m2 newbie, so could use a little help. I thought that starting with [csv] would be good, since the migration page lists it as done. I have a couple of questions. 1. It seems to use pom inheritence, which I am sure someone will convince me is a good thing, despite the fact that my first experience with it is a build failure because of it. How do I find and I guess install the commons-sandbox-parent? It's in sandbox-trunks for now OK, so I just did mvn install from the root of sandbox trunk and I guess that did it. Keep the faith Phil ... despite some frustrations with how Maven resolves conflicts over requests for differing versions of the same dependency, there's a lot of good stuff here :-). How do we indicate to users that they are going to need to set this up for builds to work? It shouldn't be necessary. If the parent is finalised and released as an independant artifact first, it will be downloaded from the repository like any dependency. Do we really need this? It's extremely useful for reducing duplication and making changes (such as repository location) easier, and also allows the same for any generated sites, so I'd say yes :) OK, so the repo list will eventually go there? When it failed once it displayed a list of repos including apache.snapshots that I could not figure out where it was getting. I guess those are defaults and the right way to set things up is to use repository elements in the pom. So these should probably be specified then in the sandbox-parent and proper-parent. The Struts, Shale, and MyFaces projects have evolved some pretty intricate multiple level build environments with Maven2 that might be worth looking at for inspiration and ideas. The commons world is a subset of that kind of complexity (because it's not likely to be hierarchical to more than one level, since each library is pretty much independent), but there's good ideas in those POMs. 2. Properties files seem to be replaced by settings.xml. Is this where we designate repo lists? If so, can someone commit a settings.xml.sample? project.properties is replaced by pom.xml (ie, plugin configuration is brought in). This is all you should need to commit to SVN, and it can contain repository references if needed. settings.xml is the equivalent of ~/build.properties. It should only need additions if you are a deployer or want to add additional repositories yourself. Good. We should then provide examples for RMs eventually. 3. I assume that the reference to 'minotaur' in the distributionManagement section of the csv pom should be changed to 'people'? Once this is fixed, I assume deploy will work correctly using the ssh key that the script is using to connect to people now. Should do. 4. The dist plugin seems to be gone and the release plugin looks like it is really just aiming to deploy jars and tag releases. Should I use ant tasks to roll the distros manually or is there some m2 plugin that will do this? The assembly plugin is the equivalent of dist (but is a lot more flexible). There is a default descriptor for building source and binary tarballs/zips, but you can also create your own, describing the layout of the resulting archive. Nice! Much nicer than the old muck with maven.xml approach. I will have a play with this and either use built-ins or commit descriptors that we can use for the nightlies to start and then standardize for releases. Suggestions / commits welcome! This was actually one of my favorite discoveries about m2. For Shale, I took the philosophy that a release artifact should include: * The binary artifacts (jar, war, or whatever) * A directory containing all the binary dependencies * Javadocs * Sources * And the pom.xml in the top level directory so that, if you have Maven2 installed, you can just type mvn install in the top level directory of the release, and it reconstitutes itself. Check out framework/shale-dist (in the Shale repository) for how this works for the framework release artifact (which accumulates a bunch of individual jars from sub-projects ... could do something like this for an uber-commons release pretty easily once everything was m2-ized), or how each of the webapps under framework/shale-apps can create a self contained release that includes all of the above stuff (similar to what you might do for an individual commons library). Phil Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430240 - /jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java
Author: bayard
Date: Wed Aug 9 21:49:05 2006
New Revision: 430240
URL: http://svn.apache.org/viewvc?rev=430240view=rev
Log:
Optimisation from Ortwin Glueck (#SANDBOX-166) in which empty String arrays are
replaced with constants.
Modified:
jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java
Modified:
jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java?rev=430240r1=430239r2=430240view=diff
==
---
jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java
(original)
+++
jakarta/commons/sandbox/csv/trunk/src/java/org/apache/commons/csv/CSVUtils.java
Wed Aug 9 21:49:05 2006
@@ -24,6 +24,9 @@
*/
public class CSVUtils {
+private static final String[] EMPTY_STRING_ARRAY = new String[0];
+private static final String[][] EMPTY_DOUBLE_STRING_ARRAY = new
String[0][0];
+
/**
* pcodeCSVUtils/code instances should NOT be constructed in
* standard programming.
@@ -86,7 +89,7 @@
if (result == null) {
// since CSVStrategy ignores empty lines an empty array is returned
// (i.e. not result = new String[][] {{}};)
- result = new String[0][0];
+ result = EMPTY_DOUBLE_STRING_ARRAY;
}
return result;
}
@@ -108,7 +111,7 @@
}
// uh,jh: make sure that parseLine().length == 0
if (s.length() == 0) {
- return new String[0];
+ return EMPTY_STRING_ARRAY;
}
return (new CSVParser(new StringReader(s))).getLine();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (SANDBOX-166) Improve memory use
[ http://issues.apache.org/jira/browse/SANDBOX-166?page=comments#action_12427099 ] Henri Yandell commented on SANDBOX-166: --- Looks good to me. I think we'll want to attack the CharBuffer class for bugs a bit as it's at the heart of the system, and it might be valuable for Lang (or there might be something already in there that does the same thing); but the looking at the patch all the changes look good. Do you want to go ahead and do the commits Ortwin? You'll find that I accidentally committed the CsvUtils class before realising that I really should be leaving it for you to do the commit - sorry about that. Improve memory use -- Key: SANDBOX-166 URL: http://issues.apache.org/jira/browse/SANDBOX-166 Project: Commons Sandbox Issue Type: Improvement Components: CSV Affects Versions: Nightly Builds Reporter: Ortwin Glück Attachments: optimized.png, patch.txt, profile.png The parser is currently a real memory burner. I fed it a 4MB CSV file and ran the TPTP profiler. As you can see the parser creates around 100MB of garbage whereas it could (in really optimized) use around 4MBs. Such figures are not acceptable within a server environment. Please attach insights and patches to this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430244 - /jakarta/commons/proper/lang/trunk/project.xml
Author: bayard Date: Wed Aug 9 22:06:59 2006 New Revision: 430244 URL: http://svn.apache.org/viewvc?rev=430244view=rev Log: Switching viewcvs url to viewvc Modified: jakarta/commons/proper/lang/trunk/project.xml Modified: jakarta/commons/proper/lang/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/project.xml?rev=430244r1=430243r2=430244view=diff == --- jakarta/commons/proper/lang/trunk/project.xml (original) +++ jakarta/commons/proper/lang/trunk/project.xml Wed Aug 9 22:06:59 2006 @@ -49,7 +49,7 @@ distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/lang//distributionDirectory repository connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk/connection - urlhttp://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/url + urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/url /repository mailingLists mailingList - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430245 - in /jakarta/commons/proper: chain/trunk/ email/trunk/ jelly/trunk/ math/trunk/ scxml/trunk/ validator/trunk/ vfs/trunk/
Author: bayard
Date: Wed Aug 9 22:09:05 2006
New Revision: 430245
URL: http://svn.apache.org/viewvc?rev=430245view=rev
Log:
Switching viewcvs url to viewvc
Modified:
jakarta/commons/proper/chain/trunk/project.xml
jakarta/commons/proper/email/trunk/project.xml
jakarta/commons/proper/jelly/trunk/project.xml
jakarta/commons/proper/math/trunk/project.xml
jakarta/commons/proper/scxml/trunk/pom.xml
jakarta/commons/proper/scxml/trunk/project.xml
jakarta/commons/proper/validator/trunk/project.xml
jakarta/commons/proper/vfs/trunk/pom.xml
jakarta/commons/proper/vfs/trunk/project.xml
Modified: jakarta/commons/proper/chain/trunk/project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/chain/trunk/project.xml?rev=430245r1=430244r2=430245view=diff
==
--- jakarta/commons/proper/chain/trunk/project.xml (original)
+++ jakarta/commons/proper/chain/trunk/project.xml Wed Aug 9 22:09:05 2006
@@ -52,7 +52,7 @@
repository
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/${pom.artifactId.substring(8)}/trunk/connection
-urlhttp://svn.apache.org/viewcvs.cgi/url
+urlhttp://svn.apache.org/viewvc/url
/repository
mailingLists
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/project.xml?rev=430245r1=430244r2=430245view=diff
==
--- jakarta/commons/proper/email/trunk/project.xml (original)
+++ jakarta/commons/proper/email/trunk/project.xml Wed Aug 9 22:09:05 2006
@@ -51,7 +51,7 @@
distributionDirectory/www/cvs.apache.org/dist/jakarta/commons/email//distributionDirectory
repository
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/email/trunk/connection
-
urlhttp://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/url
+
urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/url
/repository
versions
version
@@ -186,15 +186,15 @@
/contributors
dependencies
dependency
-groupIdjavamail/groupId
-artifactIdjavamail/artifactId
-version1.3.3/version
+groupIdjavax.mail/groupId
+artifactIdmail/artifactId
+version1.4/version
urlhttp://java.sun.com/products/javamail//url
/dependency
dependency
-groupIdactivation/groupId
+groupIdjavax.activation/groupId
artifactIdactivation/artifactId
-version1.0.2/version
+version1.1/version
urlhttp://java.sun.com/products/javabeans/glasgow/jaf.html/url
/dependency
dependency
Modified: jakarta/commons/proper/jelly/trunk/project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/project.xml?rev=430245r1=430244r2=430245view=diff
==
--- jakarta/commons/proper/jelly/trunk/project.xml (original)
+++ jakarta/commons/proper/jelly/trunk/project.xml Wed Aug 9 22:09:05 2006
@@ -64,7 +64,7 @@
repository
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/jelly/trunk/connection
developerConnectionscm:svn:https://svn.apache.org/repos/asf/jakarta/commons/proper/jelly/trunk/developerConnection
-
urlhttp://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/jelly/trunk/url
+urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/url
/repository
mailingLists
mailingList
Modified: jakarta/commons/proper/math/trunk/project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/math/trunk/project.xml?rev=430245r1=430244r2=430245view=diff
==
--- jakarta/commons/proper/math/trunk/project.xml (original)
+++ jakarta/commons/proper/math/trunk/project.xml Wed Aug 9 22:09:05 2006
@@ -48,7 +48,7 @@
distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/${pom.artifactId.substring(8)}//distributionDirectory
repository
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/${pom.artifactId.substring(8)}/trunk/connection
-
urlhttp://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/math/trunk//url
+urlhttp://svn.apache.org/viewvc/jakarta/commons/proper/math/trunk//url
/repository
mailingLists
mailingList
Modified: jakarta/commons/proper/scxml/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/scxml/trunk/pom.xml?rev=430245r1=430244r2=430245view=diff
==
--- jakarta/commons/proper/scxml/trunk/pom.xml (original)
+++ jakarta/commons/proper/scxml/trunk/pom.xml Wed Aug 9 22:09:05 2006
@@ -44,7 +44,7 @@
scm
svn commit: r430247 - in /jakarta/commons/sandbox: csv/trunk/project.xml finder/trunk/project.xml id/trunk/project.xml javaflow/trunk/pom.xml jci/trunk/pom.xml proxy/trunk/project.xml
Author: bayard Date: Wed Aug 9 22:10:14 2006 New Revision: 430247 URL: http://svn.apache.org/viewvc?rev=430247view=rev Log: Switching viewcvs url to viewvc Modified: jakarta/commons/sandbox/csv/trunk/project.xml jakarta/commons/sandbox/finder/trunk/project.xml jakarta/commons/sandbox/id/trunk/project.xml jakarta/commons/sandbox/javaflow/trunk/pom.xml jakarta/commons/sandbox/jci/trunk/pom.xml jakarta/commons/sandbox/proxy/trunk/project.xml Modified: jakarta/commons/sandbox/csv/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/csv/trunk/project.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/csv/trunk/project.xml (original) +++ jakarta/commons/sandbox/csv/trunk/project.xml Wed Aug 9 22:10:14 2006 @@ -37,7 +37,7 @@ repository connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/sandbox/csv/trunk/connection -urlhttp://svn.apache.org/viewcvs/jakarta/commons/sandbox/csv/trunk/url +urlhttp://svn.apache.org/viewvc/jakarta/commons/sandbox/csv/trunk/url /repository mailingLists Modified: jakarta/commons/sandbox/finder/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/project.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/finder/trunk/project.xml (original) +++ jakarta/commons/sandbox/finder/trunk/project.xml Wed Aug 9 22:10:14 2006 @@ -37,7 +37,7 @@ repository connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/sandbox/finder/trunk/connection - urlhttp://svn.apache.org/viewcvs/jakarta/commons/sandbox/finder/trunk/url + urlhttp://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/url /repository mailingLists Modified: jakarta/commons/sandbox/id/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/id/trunk/project.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/id/trunk/project.xml (original) +++ jakarta/commons/sandbox/id/trunk/project.xml Wed Aug 9 22:10:14 2006 @@ -52,7 +52,7 @@ distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons-sandbox/id//distributionDirectory repository connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/sandbox/id/trunk/connection -urlhttp://svn.apache.org/viewcvs.cgi/jakarta/commons/sandbox/id//url +urlhttp://svn.apache.org/viewvc/jakarta/commons/sandbox/id//url /repository mailingLists mailingList Modified: jakarta/commons/sandbox/javaflow/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/javaflow/trunk/pom.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/javaflow/trunk/pom.xml (original) +++ jakarta/commons/sandbox/javaflow/trunk/pom.xml Wed Aug 9 22:10:14 2006 @@ -103,7 +103,7 @@ scm connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/sandbox/javaflow/trunk/connection developerConnectionscn:svn:https://svn.apache.org/repos/asf/jakarta/commons/sandbox/javaflow/trunk/developerConnection - urlhttp://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/url + urlhttp://svn.apache.org/viewvc/jakarta/commons/sandbox/javaflow/trunk/url /scm distributionManagement Modified: jakarta/commons/sandbox/jci/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/pom.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/jci/trunk/pom.xml (original) +++ jakarta/commons/sandbox/jci/trunk/pom.xml Wed Aug 9 22:10:14 2006 @@ -105,7 +105,7 @@ scm connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/sandbox/jci/trunk/connection developerConnectionscn:svn:https://svn.apache.org/repos/asf/jakarta/commons/sandbox/jci/trunk/developerConnection -urlhttp://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/url +urlhttp://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/url /scm distributionManagement Modified: jakarta/commons/sandbox/proxy/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/proxy/trunk/project.xml?rev=430247r1=430246r2=430247view=diff == --- jakarta/commons/sandbox/proxy/trunk/project.xml (original) +++ jakarta/commons/sandbox/proxy/trunk/project.xml Wed Aug 9 22:10:14 2006 @@ -37,7 +37,7 @@ siteDirectory/www/jakarta.apache.org/commons/sandbox/proxy//siteDirectory repository
svn commit: r430249 - in /jakarta/commons/proper: email/trunk/doap_email.rdf jelly/trunk/doap_jelly.rdf lang/trunk/doap_lang.rdf math/trunk/doap_math.rdf vfs/trunk/doap_vfs.rdf
Author: bayard Date: Wed Aug 9 22:12:13 2006 New Revision: 430249 URL: http://svn.apache.org/viewvc?rev=430249view=rev Log: Switching viewcvs url to viewvc Modified: jakarta/commons/proper/email/trunk/doap_email.rdf jakarta/commons/proper/jelly/trunk/doap_jelly.rdf jakarta/commons/proper/lang/trunk/doap_lang.rdf jakarta/commons/proper/math/trunk/doap_math.rdf jakarta/commons/proper/vfs/trunk/doap_vfs.rdf Modified: jakarta/commons/proper/email/trunk/doap_email.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/doap_email.rdf?rev=430249r1=430248r2=430249view=diff == --- jakarta/commons/proper/email/trunk/doap_email.rdf (original) +++ jakarta/commons/proper/email/trunk/doap_email.rdf Wed Aug 9 22:12:13 2006 @@ -16,7 +16,7 @@ /description repository SVNRepository -browse rdf:resource=http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/ +browse rdf:resource=http://svn.apache.org/viewvc/jakarta/commons/proper/email/trunk/ location rdf:resource=http://svn.apache.org/repos/asf/jakarta/commons/proper/email/ /SVNRepository /repository Modified: jakarta/commons/proper/jelly/trunk/doap_jelly.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/doap_jelly.rdf?rev=430249r1=430248r2=430249view=diff == --- jakarta/commons/proper/jelly/trunk/doap_jelly.rdf (original) +++ jakarta/commons/proper/jelly/trunk/doap_jelly.rdf Wed Aug 9 22:12:13 2006 @@ -13,7 +13,7 @@ description xml:lang=enJelly is a Java and XML based scripting engine. Jelly combines the best ideas from JSTL, Velocity, DVSL, Ant and Cocoon all together in a simple yet powerful scripting engine./description repository SVNRepository -browse rdf:resource=http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/jelly/trunk/ +browse rdf:resource=http://svn.apache.org/viewvc/jakarta/commons/proper/jelly/trunk/ location rdf:resource=http://svn.apache.org/repos/asf/jakarta/commons/proper/jelly/ /SVNRepository /repository Modified: jakarta/commons/proper/lang/trunk/doap_lang.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/doap_lang.rdf?rev=430249r1=430248r2=430249view=diff == --- jakarta/commons/proper/lang/trunk/doap_lang.rdf (original) +++ jakarta/commons/proper/lang/trunk/doap_lang.rdf Wed Aug 9 22:12:13 2006 @@ -17,7 +17,7 @@ /description repository SVNRepository -browse rdf:resource=http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/ +browse rdf:resource=http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/ location rdf:resource=http://svn.apache.org/repos/asf/jakarta/commons/proper/lang/ /SVNRepository /repository Modified: jakarta/commons/proper/math/trunk/doap_math.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/math/trunk/doap_math.rdf?rev=430249r1=430248r2=430249view=diff == --- jakarta/commons/proper/math/trunk/doap_math.rdf (original) +++ jakarta/commons/proper/math/trunk/doap_math.rdf Wed Aug 9 22:12:13 2006 @@ -13,7 +13,7 @@ description xml:lang=enThe Math project is a library of lightweight, self-contained mathematics and statistics components addressing the most common practical problems not immediately available in the Java programming language or commons-lang./description repository SVNRepository -browse rdf:resource=http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/math/trunk// +browse rdf:resource=http://svn.apache.org/viewvc/jakarta/commons/proper/math/trunk// location rdf:resource=http://svn.apache.org/repos/asf/jakarta/commons/proper/math/ /SVNRepository /repository Modified: jakarta/commons/proper/vfs/trunk/doap_vfs.rdf URL: http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/doap_vfs.rdf?rev=430249r1=430248r2=430249view=diff == --- jakarta/commons/proper/vfs/trunk/doap_vfs.rdf (original) +++ jakarta/commons/proper/vfs/trunk/doap_vfs.rdf Wed Aug 9 22:12:13 2006 @@ -15,7 +15,7 @@ /description repository SVNRepository -browse rdf:resource=http://svn.apache.org/viewcvs.cgi/ +browse rdf:resource=http://svn.apache.org/viewvc/ location rdf:resource=http://svn.apache.org/repos/asf/jakarta/commons/proper/vfs/ /SVNRepository /repository - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430252 - /jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
Author: bayard
Date: Wed Aug 9 22:16:54 2006
New Revision: 430252
URL: http://svn.apache.org/viewvc?rev=430252view=rev
Log:
Rolling back the matchOnSystem parameter as it's really an ignoreCase parameter
Modified:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
Modified:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java?rev=430252r1=430251r2=430252view=diff
==
---
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
(original)
+++
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
Wed Aug 9 22:16:54 2006
@@ -30,10 +30,10 @@
* wildcard criteria.
*
* @param wildcardmatcher the wildcard string to match against
- * @param matchOnSystem whether to use the system (windows or unix)
+ * @param ignoreCase whether to ignore the case
*/
-public PathFilter(String wildcardmatcher, boolean matchOnSystem) {
-super(wildcardmatcher, matchOnSystem);
+public PathFilter(String wildcardmatcher, boolean ignoreCase) {
+super(wildcardmatcher, ignoreCase);
}
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r430256 - in /jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder: FindingFilter.java filters/NameFilter.java filters/PathFilter.java
Author: bayard
Date: Wed Aug 9 22:29:06 2006
New Revision: 430256
URL: http://svn.apache.org/viewvc?rev=430256view=rev
Log:
Switched Finder from using its own NameFilter to using IO's WildcardFileFilter.
This involved some hackery in Finder's PathFilter as it extended NameFilter. It
now extends WildcardFileFilter - which is not a class built for inheritence.
Removed:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/NameFilter.java
Modified:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/FindingFilter.java
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
Modified:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/FindingFilter.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/FindingFilter.java?rev=430256r1=430255r2=430256view=diff
==
---
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/FindingFilter.java
(original)
+++
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/FindingFilter.java
Wed Aug 9 22:29:06 2006
@@ -19,12 +19,12 @@
import java.io.File;
import java.util.Map;
import java.util.Iterator;
-import org.apache.commons.finder.filters.NameFilter;
import org.apache.commons.finder.filters.PathFilter;
import org.apache.commons.finder.filters.RegexFilter;
import org.apache.commons.finder.filters.SizeFilter;
-// import org.apache.commons.io.filefilter.WildcardFileFilter; // todo switch
to WildcardFileFilter
+import org.apache.commons.io.IOCase;
+import org.apache.commons.io.filefilter.WildcardFileFilter;
import org.apache.commons.io.filefilter.IOFileFilter;
import org.apache.commons.io.filefilter.AgeFileFilter;
import org.apache.commons.io.filefilter.NotFileFilter;
@@ -106,13 +106,11 @@
return (invert ? new NotFileFilter(filter) : filter);
}
if( option.equals(Finder.NAME) ) {
-//IOFileFilter filter = new
WildcardFileFilter(argument.toString(), false);
-IOFileFilter filter = new NameFilter(argument.toString(), false);
+IOFileFilter filter = new WildcardFileFilter(argument.toString(),
IOCase.SENSITIVE);
return (invert ? new NotFileFilter(filter) : filter);
}
if( option.equals(Finder.INAME) ) {
-//WildcardFileFilter filter = new
WildcardFileFilter(argument.toString(), true);
-IOFileFilter filter = new NameFilter(argument.toString(), true);
+IOFileFilter filter = new WildcardFileFilter(argument.toString(),
IOCase.INSENSITIVE);
return (invert ? new NotFileFilter(filter) : filter);
}
if( option.equals(Finder.PATH) ) {
Modified:
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java?rev=430256r1=430255r2=430256view=diff
==
---
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
(original)
+++
jakarta/commons/sandbox/finder/trunk/src/java/org/apache/commons/finder/filters/PathFilter.java
Wed Aug 9 22:29:06 2006
@@ -16,6 +16,9 @@
package org.apache.commons.finder.filters;
import java.io.File;
+import org.apache.commons.io.filefilter.WildcardFileFilter;
+import org.apache.commons.io.FilenameUtils;
+import org.apache.commons.io.IOCase;
/**
* codeIOFileFilter/code implementation that uses wildcard matching on the
file's path.
@@ -23,7 +26,14 @@
* @version $Id$
* @since 0.1
*/
-public class PathFilter extends NameFilter {
+public class PathFilter extends WildcardFileFilter {
+
+// Ideally this would just use the same variable in the parent, but it's
+// not accessible
+private IOCase caseSensitivity;
+
+// Same here
+private String wildcard;
/**
* Construct a new codeIOFileFilter/code specifying whether the
@@ -33,16 +43,39 @@
* @param ignoreCase whether to ignore the case
*/
public PathFilter(String wildcardmatcher, boolean ignoreCase) {
-super(wildcardmatcher, ignoreCase);
+super(wildcardmatcher, ignoreCase ? IOCase.INSENSITIVE :
IOCase.SENSITIVE);
+this.caseSensitivity = ignoreCase ? IOCase.INSENSITIVE :
IOCase.SENSITIVE;
+this.wildcard = wildcardmatcher;
}
+
/**
- * Return the name of the path.
- *
- * @param file The [EMAIL PROTECTED] File} to test.
- * @return the name of the path
+ * Checks to see if the filename matches the wildcard.
+ *
+ * @param dir the file directory
+ * @param name the full filename
+ * @return true if the full filename matches the wildcard
