Re: [commons-parent] Make deployment URL pluggable
Jochen Wiedmann wrote:
Hi,
in light of
http://marc.theaimsgroup.com/?l=jakarta-commons-devm=116560781629523w=2
and following a suggestion by Jörg Schaible, I'd like to propose the
attached patch. It introduces properties
commons.deployment.protocol
commons.deployment.release.url
commons.deployment.rc.url
The former is specifies as scp and may be overwritten, for example,
to be scpexe. The others are used by the release and rc
profiles, respectively. Both are referencing
${commons.deployment.protocol}.
In other words, the proposed patch is upwards compatible with the
current settings, except that it allows to override the deployment
protocol or URL. Both makes sense, IMO. For example, nightly builds
might wish to override the rc URL.
Thoughts? If noone else intervenes, I'll apply the patch.
Jochen
The idea of using a different protocol is fine by me, as long as I can
continue to use scp is I want to. That does seem to be the default
setting. So +1 for that.
I don't see any reason to change the urls though. If the nightly builds
don't want to release an RC then it shouldn't use the rc profile. The
profiles were set up to make sure that nothing get's deployed unless
someone explicitly says it should.
The comment in the patch indicates that it might if users are working
locally on people.apache.org. IIUC you are not supposed to do building
and releasing on that machine. You also risk that someone changes the
url to something that is completely wrong. Unless there is another
reason for it, I'm -1 on that change.
--
Dennis Lundberg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 8 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package - commons-jelly-tags-betwixt : Commons Jelly - commons-jelly-tags-ojb : Commons Jelly - db-ddlutils : Easy-to-use component for working with Database Definition (... - db-ojb : ObjectRelationalBridge - db-ojb-from-packages : ObjectRelationalBridge - maven-bootstrap : Project Management Tools - test-ojb : ObjectRelationalBridge Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-29122006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 55 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-29122006 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Running org.apache.commons.betwixt.TestOptions [junit] Testsuite: org.apache.commons.betwixt.TestOptions [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.256 sec [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.256 sec [junit] [junit] Testcase: testGetValue took 0.008 sec [junit] Testcase: testGetNames took 0.003 sec [junit] Testcase: testAddOptions took 0.001 sec [junit] Running org.apache.commons.betwixt.TestRSSRoundTrip [junit] Testsuite: org.apache.commons.betwixt.TestRSSRoundTrip [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.59 sec [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.59 sec [junit] [junit] Testcase: testRoundTrip took 20.355 sec [junit] Caused an ERROR [junit] my.netscape.com [junit] java.net.UnknownHostException: my.netscape.com [junit] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177) [junit] at java.net.Socket.connect(Socket.java:507) [junit] at java.net.Socket.connect(Socket.java:457) [junit] at sun.net.NetworkClient.doConnect(NetworkClient.java:157) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:365) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:477) [junit] at sun.net.www.http.HttpClient.init(HttpClient.java:214)
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 8 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package - commons-jelly-tags-betwixt : Commons Jelly - commons-jelly-tags-ojb : Commons Jelly - db-ddlutils : Easy-to-use component for working with Database Definition (... - db-ojb : ObjectRelationalBridge - db-ojb-from-packages : ObjectRelationalBridge - maven-bootstrap : Project Management Tools - test-ojb : ObjectRelationalBridge Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-29122006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 55 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-29122006 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Running org.apache.commons.betwixt.TestOptions [junit] Testsuite: org.apache.commons.betwixt.TestOptions [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.256 sec [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.256 sec [junit] [junit] Testcase: testGetValue took 0.008 sec [junit] Testcase: testGetNames took 0.003 sec [junit] Testcase: testAddOptions took 0.001 sec [junit] Running org.apache.commons.betwixt.TestRSSRoundTrip [junit] Testsuite: org.apache.commons.betwixt.TestRSSRoundTrip [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.59 sec [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.59 sec [junit] [junit] Testcase: testRoundTrip took 20.355 sec [junit] Caused an ERROR [junit] my.netscape.com [junit] java.net.UnknownHostException: my.netscape.com [junit] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177) [junit] at java.net.Socket.connect(Socket.java:507) [junit] at java.net.Socket.connect(Socket.java:457) [junit] at sun.net.NetworkClient.doConnect(NetworkClient.java:157) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:365) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:477) [junit] at sun.net.www.http.HttpClient.init(HttpClient.java:214)
[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-soap has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-soap : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-soap-29122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-soap -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.axis. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.jaxrpc-api. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.saaj-api. -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for property maven.jar.servletapi. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 1929122006, vmgump.apache.org:vmgump-public:1929122006 Gump E-mail Identifier (unique within run) #32. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-soap has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-soap : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-soap-29122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-soap -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.axis. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.jaxrpc-api. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.saaj-api. -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for property maven.jar.servletapi. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 1929122006, vmgump.apache.org:vmgump-public:1929122006 Gump E-mail Identifier (unique within run) #32. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[nightly build] io failed.
Failed build logs: http://people.apache.org/~psteitz/commons-nightlies/20061229/io.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-29122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on Project:commons-jelly-tags-jaxme -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 1929122006, vmgump.apache.org:vmgump-public:1929122006 Gump E-mail Identifier (unique within run) #39. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-29122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on Project:commons-jelly-tags-jaxme -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 1929122006, vmgump.apache.org:vmgump-public:1929122006 Gump E-mail Identifier (unique within run) #39. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490987 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java
Author: scolebourne
Date: Fri Dec 29 04:11:48 2006
New Revision: 490987
URL: http://svn.apache.org/viewvc?view=revrev=490987
Log:
Document synchronization
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java?view=diffrev=490987r1=490986r2=490987
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileCleaner.java
Fri Dec 29 04:11:48 2006
@@ -49,7 +49,7 @@
/**
* Collection of codeTracker/code instances in existence.
*/
-static Collection /* Tracker */ trackers = new Vector();
+static Collection /* Tracker */ trackers = new Vector(); // synchronized
/**
* Whether to terminate the thread when the tracking is complete.
*/
@@ -128,6 +128,7 @@
* @param deleteStrategy the strategy to delete the file, null means
normal
*/
private static synchronized void addTracker(String path, Object marker,
FileDeleteStrategy deleteStrategy) {
+// synchronized block protects reaper
if (exitWhenFinished) {
throw new IllegalStateException(No new trackers can be added once
exitWhenFinished() is called);
}
@@ -171,6 +172,7 @@
* One called, no new objects can be tracked by the file cleaner.
*/
public static synchronized void exitWhenFinished() {
+// synchronized block protects reaper
exitWhenFinished = true;
if (reaper != null) {
synchronized (reaper) {
@@ -179,7 +181,7 @@
}
}
-// ---
+//---
/**
* The reaper thread.
*/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490988 - /jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
Author: scolebourne
Date: Fri Dec 29 04:24:36 2006
New Revision: 490988
URL: http://svn.apache.org/viewvc?view=revrev=490988
Log:
IO-107 - Increase test robustness for openOutputStream
Modified:
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
Modified:
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java?view=diffrev=490988r1=490987r2=490988
==
---
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
(original)
+++
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
Fri Dec 29 04:24:36 2006
@@ -119,11 +119,14 @@
public void test_openOutputStream_existsButIsDirectory() throws Exception {
File directory = new File(getTestDirectory(), subdir);
directory.mkdirs();
+FileOutputStream out = null;
try {
-FileUtils.openOutputStream(directory);
+out = FileUtils.openOutputStream(directory);
fail();
} catch (IOException ioe) {
// expected
+} finally {
+IOUtils.closeQuietly(out);
}
}
@@ -140,12 +143,23 @@
}
public void test_openOutputStream_notExistsCannotCreate() throws Exception
{
-File file = new File(getTestDirectory(), a/:#$!/test.txt); // empty
path segment is bad directory name
+// according to Wikipedia, most filing systems have a 256 limit on
filename
+String longStr =
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz +
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz +
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz +
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz +
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz +
+abcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyzabcdevwxyz; // 300 chars
+File file = new File(getTestDirectory(), a/ + longStr + /test.txt);
+FileOutputStream out = null;
try {
-FileUtils.openOutputStream(file);
+out = FileUtils.openOutputStream(file);
fail();
} catch (IOException ioe) {
// expected
+} finally {
+IOUtils.closeQuietly(out);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490992 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Author: scolebourne
Date: Fri Dec 29 04:37:58 2006
New Revision: 490992
URL: http://svn.apache.org/viewvc?view=revrev=490992
Log:
Add since tag
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=490992r1=490991r2=490992
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Fri Dec 29 04:37:58 2006
@@ -122,6 +122,7 @@
* @param file the file to create, not null
* @throws IOException if the file object is a directory
* @throws IOException if a parent directory needs creating but that fails
+ * @since Commons IO 1.3
*/
public static FileOutputStream openOutputStream(File file) throws
IOException {
if (file.exists()) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490997 - in /jakarta/commons/proper/io/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/io/FileUtils.java src/test/org/apache/commons/io/FileUtilsTestCase.java
Author: scolebourne
Date: Fri Dec 29 05:10:03 2006
New Revision: 490997
URL: http://svn.apache.org/viewvc?view=revrev=490997
Log:
IO-107 - Add FileUtils.openInputStream, with better error messages than the JDK
Modified:
jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/FileUtilsTestCase.java
Modified: jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt?view=diffrev=490997r1=490996r2=490997
==
--- jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt (original)
+++ jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt Fri Dec 29 05:10:03 2006
@@ -110,6 +110,8 @@
- FileUtils.writeByteArrayToFile
- FileUtils.writeLines
- enhanced to create parent directories if required
+- FileUtils.openInputStream [IO-107]
+ - new method to open a FileInputStream, providing better error messages than
the JDK
- FileUtils.isFileOlder
- new methods to check if a file is older (i.e. isFileOlder()) - counterparts
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=490997r1=490996r2=490997
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Fri Dec 29 05:10:03 2006
@@ -25,6 +25,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.net.URL;
+import java.nio.channels.FileChannel;
import java.util.Collection;
import java.util.Date;
import java.util.Iterator;
@@ -107,6 +108,38 @@
//---
/**
+ * Opens a [EMAIL PROTECTED] FileInputStream} for the specified file,
providing better
+ * error messages than simply calling codenew
FileInputStream(file)/code.
+ * p
+ * At the end of the method either the stream will be successfully opened,
+ * or an exception will have been thrown.
+ * p
+ * An exception is thrown if the file does not exist.
+ * An exception is thrown if the file object exists but is a directory.
+ * An exception is thrown if the file exists but cannot be read.
+ *
+ * @param file the file to open for input, not null
+ * @throws IOException if the file does not exist
+ * @throws IOException if the file object is a directory
+ * @throws IOException if the file cannot be read
+ * @since Commons IO 1.3
+ */
+public static FileInputStream openInputStream(File file) throws
IOException {
+if (file.exists()) {
+if (file.isDirectory()) {
+throw new IOException(File ' + file + ' exists but is a
directory);
+}
+if (file.canRead() == false) {
+throw new IOException(File ' + file + ' cannot be read);
+}
+} else {
+throw new IOException(File ' + file + ' does not exist);
+}
+return new FileInputStream(file);
+}
+
+//---
+/**
* Opens a [EMAIL PROTECTED] FileOutputStream} for the specified file,
checking and
* creating the parent directory if it does not exist.
* p
@@ -119,8 +152,9 @@
* An exception is thrown if the file exists but cannot be written to.
* An exception is thrown if the parent directory cannot be created.
*
- * @param file the file to create, not null
+ * @param file the file to open for output, not null
* @throws IOException if the file object is a directory
+ * @throws IOException if the file cannot be written to
* @throws IOException if a parent directory needs creating but that fails
* @since Commons IO 1.3
*/
@@ -918,17 +952,16 @@
* the default encoding can differ between platforms and will have
* inconsistent results.
*
- * @param file the file to read
+ * @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
- * @return the file contents or null if read failed
+ * @return the file contents, never null
* @throws IOException in case of an I/O error
* @throws java.io.UnsupportedEncodingException if the encoding is not
supported by the VM
*/
-public static String readFileToString(
-File file, String encoding) throws IOException {
+public static String readFileToString(File file, String encoding) throws
IOException {
InputStream in = null;
try
[jira] Resolved: (IO-99) FileCleaner thread never ends and cause memory leak in AS
[ http://issues.apache.org/jira/browse/IO-99?page=all ] Stephen Colebourne resolved IO-99. -- Resolution: Fixed Assignee: Stephen Colebourne I took a look at getTrackerCount(), but its already synchronized because the list is a Vector. I added a few comments about synchronization to the file to help clarify. Closing the call as fixed. FileCleaner thread never ends and cause memory leak in AS - Key: IO-99 URL: http://issues.apache.org/jira/browse/IO-99 Project: Commons IO Issue Type: Bug Affects Versions: 1.2 Environment: JBOssPortal with commons.fileupload Reporter: Vera Mickaël Assigned To: Stephen Colebourne Priority: Critical Fix For: 1.3 Attachments: IO-99.patch FileCleaner opens a thread and no solution is given to the user to end it. So when an application is undeployed in an Application Server, a thread is still alive. The WebApp can't be undeployed and this results in a classloader leak that will cause an OutOfMemoryError. I think the API should be extended so that a user can end the thread. A better way would be to provide a class that cleans everything for commons IO. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491001 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Author: scolebourne
Date: Fri Dec 29 05:15:33 2006
New Revision: 491001
URL: http://svn.apache.org/viewvc?view=revrev=491001
Log:
IO-107 - Add FileUtils.openInputStream, with better error messages than the JDK
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=491001r1=491000r2=491001
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Fri Dec 29 05:15:33 2006
@@ -25,7 +25,6 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.net.URL;
-import java.nio.channels.FileChannel;
import java.util.Collection;
import java.util.Date;
import java.util.Iterator;
@@ -119,7 +118,7 @@
* An exception is thrown if the file exists but cannot be read.
*
* @param file the file to open for input, not null
- * @throws IOException if the file does not exist
+ * @throws FileNotFoundException if the file does not exist
* @throws IOException if the file object is a directory
* @throws IOException if the file cannot be read
* @since Commons IO 1.3
@@ -133,7 +132,7 @@
throw new IOException(File ' + file + ' cannot be read);
}
} else {
-throw new IOException(File ' + file + ' does not exist);
+throw new FileNotFoundException(File ' + file + ' does not
exist);
}
return new FileInputStream(file);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 85 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-29122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:64) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:59) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:263) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:66) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:113) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:161) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 85 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-29122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:64) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:59) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:263) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:66) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:113) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:161) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 29 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-fmt-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-29122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jelly-tags-fmt-29122006.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128)
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 29 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-fmt-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-29122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-29122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jelly-tags-fmt-29122006.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128)
svn commit: r491007 - in /jakarta/commons/proper/io/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/io/output/ByteArrayOutputStream.java src/test/org/apache/commons/io/output/ByteArrayOutputStrea
Author: scolebourne
Date: Fri Dec 29 05:50:34 2006
New Revision: 491007
URL: http://svn.apache.org/viewvc?view=revrev=491007
Log:
IO-97 - ByteArrayOutputStream performance enhancements, from Holger Hoffstatte
Modified:
jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java
jakarta/commons/proper/io/trunk/src/test/org/apache/commons/io/output/ByteArrayOutputStreamTestCase.java
Modified: jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt?view=diffrev=491007r1=491006r2=491007
==
--- jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt (original)
+++ jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt Fri Dec 29 05:50:34 2006
@@ -189,6 +189,9 @@
- NullReader
- New reader that emulates a reader of a specified size
+- ByteArrayOutputStream [IO-97]
+ - Performance enhancements
+
Feedback
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java?view=diffrev=491007r1=491006r2=491007
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/output/ByteArrayOutputStream.java
Fri Dec 29 05:50:34 2006
@@ -44,14 +44,23 @@
* deprecated toString(int) method that has been ignored.
*
* @author a href=mailto:[EMAIL PROTECTED]Jeremias Maerki/a
+ * @author Holger Hoffstatte
* @version $Id$
*/
public class ByteArrayOutputStream extends OutputStream {
+/** A singleton empty byte array. */
+private static final byte[] EMPTY_BYTE_ARRAY = new byte[0];
+
+/** The list of buffers, which grows and never reduces. */
private List buffers = new ArrayList();
+/** The index of the current buffer. */
private int currentBufferIndex;
+/** The total count of bytes in all the filled buffers. */
private int filledBufferSum;
+/** The current buffer. */
private byte[] currentBuffer;
+/** The total count of bytes written. */
private int count;
/**
@@ -85,7 +94,7 @@
* @return the buffer
*/
private byte[] getBuffer(int index) {
-return (byte[])buffers.get(index);
+return (byte[]) buffers.get(index);
}
/**
@@ -123,7 +132,7 @@
/**
* @see java.io.OutputStream#write(byte[], int, int)
*/
-public synchronized void write(byte[] b, int off, int len) {
+public void write(byte[] b, int off, int len) {
if ((off 0)
|| (off b.length)
|| (len 0)
@@ -133,34 +142,40 @@
} else if (len == 0) {
return;
}
-int newcount = count + len;
-int remaining = len;
-int inBufferPos = count - filledBufferSum;
-while (remaining 0) {
-int part = Math.min(remaining, currentBuffer.length - inBufferPos);
-System.arraycopy(b, off + len - remaining, currentBuffer,
inBufferPos, part);
-remaining -= part;
-if (remaining 0) {
-needNewBuffer(newcount);
-inBufferPos = 0;
+synchronized (this) {
+int newcount = count + len;
+int remaining = len;
+int inBufferPos = count - filledBufferSum;
+while (remaining 0) {
+int part = Math.min(remaining, currentBuffer.length -
inBufferPos);
+System.arraycopy(b, off + len - remaining, currentBuffer,
inBufferPos, part);
+remaining -= part;
+if (remaining 0) {
+needNewBuffer(newcount);
+inBufferPos = 0;
+}
}
+count = newcount;
}
-count = newcount;
}
/**
- * Calls the write(byte[]) method.
- *
* @see java.io.OutputStream#write(int)
*/
public synchronized void write(int b) {
-write(new byte[] {(byte)b}, 0, 1);
+int inBufferPos = count - filledBufferSum;
+if (inBufferPos == currentBuffer.length) {
+needNewBuffer(count + 1);
+inBufferPos = 0;
+}
+currentBuffer[inBufferPos] = (byte) b;
+count++;
}
/**
* @see java.io.ByteArrayOutputStream#size()
*/
-public int size() {
+public synchronized int size() {
return count;
}
@@ -216,8 +231,11 @@
*/
public synchronized byte[] toByteArray() {
int remaining = count;
+if (remaining == 0) {
+return EMPTY_BYTE_ARRAY;
+
[jira] Resolved: (IO-97) Trivial performance improvements to ByteArrayOutputStream
[ http://issues.apache.org/jira/browse/IO-97?page=all ] Stephen Colebourne resolved IO-97. -- Fix Version/s: 1.3 (was: 1.4) Resolution: Fixed Assignee: Stephen Colebourne Trivial performance improvements to ByteArrayOutputStream - Key: IO-97 URL: http://issues.apache.org/jira/browse/IO-97 Project: Commons IO Issue Type: Improvement Components: Streams/Writers Affects Versions: 1.2 Reporter: Holger Hoffstätte Assigned To: Stephen Colebourne Fix For: 1.3 Attachments: BAOS.patch Found a few trivial ways to improve performance in ByteArrayOutputStream by fast paths: - write(int) does not have to be synchronized - write(byte[]..) does not have to be synchronized as a whole either; it's enough to synchonize the code that follows the first paramter-checking if-then statement (so parameter checks can pop out quickly) - toByteArray() could just check if count == 0 and quickly return an empty static final byte[] instead of returning a new zero-sized one, doing useless System.arraycopy() etc. A somewhat more involved optimization would be to implement write(int) without the new byte[1] since just poking the byte into the right page is going to be much faster than what happens in write(byte[]..); I'll see if I can do a patch for that. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: snip/ The idea of using a different protocol is fine by me, as long as I can continue to use scp is I want to. That does seem to be the default setting. So +1 for that. snap/ scpexe (see patch at the bottom of the email -- yes, formatting will be off) defaults to the 'scp' executable for transport. -Rahul Index: pom.xml === --- pom.xml (revision 490357) +++ pom.xml (working copy) @@ -148,7 +148,7 @@ repository idapache.releases/id nameApache Release Distribution Repository/name - urlscp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url + urlscpexe://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url /repository /distributionManagement build @@ -187,7 +187,7 @@ repository idapache.snapshots/id nameApache Development Snapshot Repository/name - urlscp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url + urlscpexe://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url /repository /distributionManagement build -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
Rahul Akolkar wrote:
On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote:
snip/
The idea of using a different protocol is fine by me, as long as I can
continue to use scp is I want to. That does seem to be the default
setting. So +1 for that.
snap/
scpexe (see patch at the bottom of the email -- yes, formatting will
be off) defaults to the 'scp' executable for transport.
Sorry, I wasn't being clear. I want to be able to use the scp:
*protocol* so that I don't need to worry about installing and
configuring an scp *executable*. The scp: protocol uses JSch [1] a
pure Java implementation of ssh2.
So I'm OK with adding a property for the protocol, like Jochen had in
his first patch. But without the ability to change the urls.
I'm suggesting that we have something like this:
repository
idapache.releases/id
nameApache Release Distribution Repository/name
url${commons.deployment.protocol}://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url
/repository
...
properties
commons.deployment.protocolscp/commons.deployment.protocol
/properties
[1] http://www.jcraft.com/jsch/
-Rahul
Index: pom.xml
===
--- pom.xml(revision 490357)
+++ pom.xml(working copy)
@@ -148,7 +148,7 @@
repository
idapache.releases/id
nameApache Release Distribution Repository/name
-
urlscp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url
+
urlscpexe://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url
/repository
/distributionManagement
build
@@ -187,7 +187,7 @@
repository
idapache.snapshots/id
nameApache Development Snapshot Repository/name
-
urlscp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
+
urlscpexe://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
/repository
/distributionManagement
build
--
Dennis Lundberg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
On 29.12.2006, at 16:31, Dennis Lundberg wrote: Rahul Akolkar wrote: On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: snip/ The idea of using a different protocol is fine by me, as long as I can continue to use scp is I want to. That does seem to be the default setting. So +1 for that. snap/ scpexe (see patch at the bottom of the email -- yes, formatting will be off) defaults to the 'scp' executable for transport. Sorry, I wasn't being clear. I want to be able to use the scp: *protocol* so that I don't need to worry about installing and configuring an scp *executable*. The scp: protocol uses JSch [1] a pure Java implementation of ssh2. ...which does not utilize ssh-agent (last time I tied) Does that work now? cheers -- Torsten - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [io] Non-encoding versions of readFileToString etc
On 12/28/06, Stephen Colebourne [EMAIL PROTECTED] wrote: Henri Yandell wrote: We have encoding in io.* in two places, FileUtils and IOUtils. In IOUtils we provide the default variant, in FileUtils we don't. Whatever the arguments for or against this, I prefer consistency if possible. On reviewing the code in more detail, we do have defaults for encoding, and defaults for other parameters as well. There is thus no overriding good reason not to allow these additional defaulting methods. If you want them, go ahead and add them ;-) Will do :) [opening a JIRA so I don't forget] Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (IO-108) Add default encoding overrides for FileUtils methods
Add default encoding overrides for FileUtils methods
Key: IO-108
URL: http://issues.apache.org/jira/browse/IO-108
Project: Commons IO
Issue Type: Improvement
Components: Utilities
Reporter: Henri Yandell
Assigned To: Henri Yandell
Fix For: 1.3
ie:
public String readFileToString(File f) {
return readFileToString(f, null);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491050 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java
Author: scolebourne
Date: Fri Dec 29 09:04:00 2006
New Revision: 491050
URL: http://svn.apache.org/viewvc?view=revrev=491050
Log:
LANG-291 - Move min/max methods above inner class, add javadoc and format
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java?view=diffrev=491050r1=491049r2=491050
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ObjectUtils.java
Fri Dec 29 09:04:00 2006
@@ -237,6 +237,50 @@
return obj == null ? nullStr : obj.toString();
}
+// Min/Max
+//---
+/**
+ * Null safe comparison of Comparables.
+ *
+ * @param c1 the first comparable, may be null
+ * @param c2 the second comparable, may be null
+ * @return
+ * ul
+ * liIf both objects are non-null and unequal, the lesser object.
+ * liIf both objects are non-null and equal, c1.
+ * liIf one of the comparables is null, the non-null object.
+ * liIf both the comparables are null, null is returned.
+ * /ul
+ */
+public static Object min(Comparable c1, Comparable c2) {
+if (c1 != null c2 != null) {
+return c1.compareTo(c2) 1 ? c1 : c2;
+} else {
+return c1 != null ? c1 : c2;
+}
+}
+
+/**
+ * Null safe comparison of Comparables.
+ *
+ * @param c1 the first comparable, may be null
+ * @param c2 the second comparable, may be null
+ * @return
+ * ul
+ * liIf both objects are non-null and unequal, the greater object.
+ * liIf both objects are non-null and equal, c1.
+ * liIf one of the comparables is null, the non-null object.
+ * liIf both the comparables are null, null is returned.
+ * /ul
+ */
+public static Object max(Comparable c1, Comparable c2) {
+if (c1 != null c2 != null) {
+return c1.compareTo(c2) = 0 ? c1 : c2;
+} else {
+return c1 != null ? c1 : c2;
+}
+}
+
// Null
//---
/**
@@ -277,52 +321,5 @@
return ObjectUtils.NULL;
}
}
-
-
-/**
- * Null safe comparison of Comparables.
- *
- * @param c1
- * @param c2
- * @return
- * ul
- * liIf both objects are non-null and unequal, the lesser object.
- * liIf both objects are non-null and equal, c1.
- * liIf one of the comparables is null, the non-null object.
- * liIf both the comparables are null, null is returned.
- * /ul
- */
-public static Object min( Comparable c1, Comparable c2 ) {
-if ( c1 != null c2 != null ) {
-return c1.compareTo( c2 ) 1 ? c1 : c2;
-}
-else {
-return c1 != null ? c1 : c2;
-}
-}
-
-/**
- * Null safe comparison of Comparables.
- *
- * @param c1
- * @param c2
- * @return
- * ul
- * liIf both objects are non-null and unequal, the greater object.
- * liIf both objects are non-null and equal, c1.
- * liIf one of the comparables is null, the non-null object.
- * liIf both the comparables are null, null is returned.
- * /ul
- */
-public static Object max( Comparable c1, Comparable c2 ) {
-if ( c1 != null c2 != null ) {
-return c1.compareTo( c2 ) = 0 ? c1 : c2;
-}
-else {
-return c1 != null ? c1 : c2;
-}
-}
-
-
-
+
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491052 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
Author: scolebourne
Date: Fri Dec 29 09:16:37 2006
New Revision: 491052
URL: http://svn.apache.org/viewvc?view=revrev=491052
Log:
Avoid new Boolean() via BooleanUtils
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java?view=diffrev=491052r1=491051r2=491052
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/mutable/MutableBoolean.java
Fri Dec 29 09:16:37 2006
@@ -19,6 +19,8 @@
import java.io.Serializable;
+import org.apache.commons.lang.BooleanUtils;
+
/**
* A mutable codeboolean/code wrapper.
*
@@ -121,9 +123,7 @@
* @return the value as a Boolean
*/
public Object getValue() {
-return new Boolean(this.value);
-// TODO: JDK 1.4+
-//return Boolean.valueOf(this.value);
+return BooleanUtils.toBooleanObject(this.value);
}
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491056 - /jakarta/commons/proper/io/trunk/project.xml
Author: scolebourne Date: Fri Dec 29 09:34:25 2006 New Revision: 491056 URL: http://svn.apache.org/viewvc?view=revrev=491056 Log: IO-97 - ByteArrayOutputStream performance enhancements, from Holger Hoffstatte Modified: jakarta/commons/proper/io/trunk/project.xml Modified: jakarta/commons/proper/io/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/project.xml?view=diffrev=491056r1=491055r2=491056 == --- jakarta/commons/proper/io/trunk/project.xml (original) +++ jakarta/commons/proper/io/trunk/project.xml Fri Dec 29 09:34:25 2006 @@ -199,6 +199,9 @@ nameJim Harrington/name /contributor contributor + nameHolger Hoffstatte/name +/contributor +contributor nameThomas Ledoux/name /contributor contributor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Reopened: (LANG-238) [lang] Add equals(type[]) to NumberUtils
[ http://issues.apache.org/jira/browse/LANG-238?page=all ] Stephen Colebourne reopened LANG-238: - These methods exist in the JDK in Arrays. We shouldn't duplicate that code unless we've got a good reason. [lang] Add equals(type[]) to NumberUtils Key: LANG-238 URL: http://issues.apache.org/jira/browse/LANG-238 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Environment: Operating System: other Platform: Other Reporter: Paul Benedict Priority: Minor Fix For: 2.3 It would be useful to add an equals() method like the current min and max methods which take an array type and determine if all the values are equal. I have found myself in need of this often. I have to retrieve objects from multiple data sources in parallel to build an array of complex object. To ensure validity, I always compare that my sub-retrievals returned the same number of objects as expected. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
Torsten Curdt wrote: On 29.12.2006, at 16:31, Dennis Lundberg wrote: Rahul Akolkar wrote: On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: snip/ The idea of using a different protocol is fine by me, as long as I can continue to use scp is I want to. That does seem to be the default setting. So +1 for that. snap/ scpexe (see patch at the bottom of the email -- yes, formatting will be off) defaults to the 'scp' executable for transport. Sorry, I wasn't being clear. I want to be able to use the scp: *protocol* so that I don't need to worry about installing and configuring an scp *executable*. The scp: protocol uses JSch [1] a pure Java implementation of ssh2. ...which does not utilize ssh-agent (last time I tied) Does that work now? There seems to be circumstances when scp: protocol does not work. I just haven't encountered them myself. But since they exist, there is good reason to be able to change the protocol for these cases. That being said I think that scp: should be the default, as it covers most use cases. -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491059 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java
Author: scolebourne Date: Fri Dec 29 09:44:59 2006 New Revision: 491059 URL: http://svn.apache.org/viewvc?view=revrev=491059 Log: Fix javadoc link Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java?view=diffrev=491059r1=491058r2=491059 == --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/time/DurationFormatUtils.java Fri Dec 29 09:44:59 2006 @@ -261,8 +261,8 @@ * choosing March - February = 1 month and then calculating days * backwards. /p * - * pFor more control, the Joda Time library is recommended - * (a href=http://joda-time.sf.net/;). /p + * pFor more control, the a href=http://joda-time.sf.net/;Joda-Time/a + * library is recommended./p * * @param startMillis the start of the duration * @param endMillis the end of the duration - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (LANG-305) Deprecate methods found in the JDK 1.5/1.6?
[ http://issues.apache.org/jira/browse/LANG-305?page=all ] Stephen Colebourne resolved LANG-305. - Fix Version/s: (was: 2.3) Resolution: Won't Fix Deprecate methods found in the JDK 1.5/1.6? --- Key: LANG-305 URL: http://issues.apache.org/jira/browse/LANG-305 Project: Commons Lang Issue Type: Task Affects Versions: 2.2 Reporter: Henri Yandell Not too sure on this one - but it seems to me that it would be a good time to deprecate the methods that now have replacements in the standard Java libraries. We could also consider deprecating methods that have replacements in Joda Time. This would allow us to consider removing them in 3.0. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491063 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Author: scolebourne
Date: Fri Dec 29 09:55:32 2006
New Revision: 491063
URL: http://svn.apache.org/viewvc?view=revrev=491063
Log:
LANG-301 - Document cloneReset()
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java?view=diffrev=491063r1=491062r2=491063
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Fri Dec 29 09:55:32 2006
@@ -1099,6 +1099,7 @@
* @throws CloneNotSupportedException if there is a problem cloning
*/
Object cloneReset() throws CloneNotSupportedException {
+// this method exists to enable 100% test coverage
StrTokenizer cloned = (StrTokenizer) super.clone();
if (cloned.chars != null) {
cloned.chars = (char[]) cloned.chars.clone();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (LANG-301) Unnecessary code in StrTokenizer
[ http://issues.apache.org/jira/browse/LANG-301?page=all ]
Stephen Colebourne resolved LANG-301.
-
Fix Version/s: (was: 3.0)
Resolution: Invalid
The cloneReset() method exists to enable testing.
The return null should never happen, as super.clone() should succeed. Its
really just a way around the JDK flaw of the exception not being a runtime
exception.
Unnecessary code in StrTokenizer
Key: LANG-301
URL: http://issues.apache.org/jira/browse/LANG-301
Project: Commons Lang
Issue Type: Bug
Affects Versions: 2.2
Reporter: Henri Yandell
In StrTokenizer, we have the following:
1086 public Object clone() {
1087 try {
1088 return cloneReset();
1089 } catch (CloneNotSupportedException ex) {
1090 return null;
1091 }
1092 }
...
1101 Object cloneReset() throws CloneNotSupportedException {
1102 StrTokenizer cloned = (StrTokenizer) super.clone();
1103 if (cloned.chars != null) {
1104 cloned.chars = (char[]) cloned.chars.clone();
1105 }
1106 cloned.reset();
1107 return cloned;
1108 }
FindBugs just reported it because the clone() method doesn't call
super.clone(). While that's not a worry (because the method it calls does), I
don't understand why we're not just doing:
public Object clone() {
StrTokenizer cloned = (StrTokenizer) super.clone();
if (cloned.chars != null) {
cloned.chars = (char[]) cloned.chars.clone();
}
cloned.reset();
return cloned;
}
and why we return null and not a runtime CloneNotSupportedException.
Also, is there any value in StrTokenizer being Cloneable? Or is it just done
for the sake of the getXxxInstance methods?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-284) TextTable for printing a fixedlength columns format text tables
[ http://issues.apache.org/jira/browse/LANG-284?page=comments#action_12461421 ] Stephen Colebourne commented on LANG-284: - I never commented on this at the time. I personally think this is out of scope for [lang]. It has the potential to expand in any number of directions, and has no simple correct implementation. TextTable for printing a fixedlength columns format text tables --- Key: LANG-284 URL: http://issues.apache.org/jira/browse/LANG-284 Project: Commons Lang Issue Type: New Feature Affects Versions: 2.2 Reporter: David Leal Fix For: 3.0 Attachments: TestTextTable.java, TestTextTable.out, TextTable.java Just to suggest adding a TextTable class for printing in text (ASCII) format fixed columns table. It is usefull for printing information from command line application, that informs about directly on DOS Windows of Xterm direclty. I am adding a patch a possible solution for that, Thanks, David -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-286) Serialization - not backwards compatible
[ http://issues.apache.org/jira/browse/LANG-286?page=all ] Stephen Colebourne updated LANG-286: Summary: Serialization - not backwards compatible (was: Not backwards compatible) Changed issue title Serialization - not backwards compatible Key: LANG-286 URL: http://issues.apache.org/jira/browse/LANG-286 Project: Commons Lang Issue Type: Bug Affects Versions: 2.2 Environment: N/A Reporter: David J. M. Karlsen Fix For: 2.3 Release report states that commons-lang 2.2 is binary backwards compatible, this does not seem to be correct between commons-lang 2.1 and 2.2 Running 2.2 at the server and 2.1 on client will result in an exception: org.omg.CORBA.MARSHAL: Unable to read value from underlying bridge : Mismatched serialization UIDs : Source (Rep. IDRMI:org.apache.commons.lang.exception.NestableDelegate:4F998DA78EFC2530:F68F1455DDEE96BB) = F68F1455DDEE96BB whereas Target (Rep. ID RMI:org.apache.commons.lang.exception.NestableDelegate:4F998DA78EFC2530:0001) = 0001 minor code: 4942F89A completed: No -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-284) TextTable for printing a fixedlength columns format text tables
[ http://issues.apache.org/jira/browse/LANG-284?page=comments#action_12461425 ] Gary Gregory commented on LANG-284: --- I agree with Stephen [http://issues.apache.org/jira/browse/LANG-284#action_12461421], this sounds complicated enough and would need enough parameters and customizable features to make it its own component. TextTable for printing a fixedlength columns format text tables --- Key: LANG-284 URL: http://issues.apache.org/jira/browse/LANG-284 Project: Commons Lang Issue Type: New Feature Affects Versions: 2.2 Reporter: David Leal Fix For: 3.0 Attachments: TestTextTable.java, TestTextTable.out, TextTable.java Just to suggest adding a TextTable class for printing in text (ASCII) format fixed columns table. It is usefull for printing information from command line application, that informs about directly on DOS Windows of Xterm direclty. I am adding a patch a possible solution for that, Thanks, David -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-283) Visitors for Builders
[
http://issues.apache.org/jira/browse/LANG-283?page=comments#action_12461426 ]
Stephen Colebourne commented on LANG-283:
-
This looks very clever, but is probably beyond that which the builders were
originally intended for.
Visitors for Builders
-
Key: LANG-283
URL: http://issues.apache.org/jira/browse/LANG-283
Project: Commons Lang
Issue Type: New Feature
Affects Versions: 2.2
Environment: Any
Reporter: Aldrin Leal
Priority: Trivial
Fix For: 3.0
Attachments: visitors.patch
While doing commons-lang stuff, I found the repetitive nature of
Builder stuff. Therefore, i decided to:
a) Create a SingleBuilder (for ToString / HashCode) and a
DualBuilder (CompareTo / Equals) interface, and make their classes
implementing;
b) Create a SingleBuilderVisitor and DualBuilderVisitor;
c) Do the proper wiring, while creating new constructors using the visitors;
d) Create new tests and ensuring javadoc plays nice along;
There's a patch attached in this e-mail, done against the latest
svn STABLE url for 2.2
(http://svn.apache.org/repos/asf/jakarta/commons/proper/lang/branches/LANG_2_2_X/)
There might be errors, but methinks it's a great idea to declare a
constant like this in your source code.
private static final EQUALS_VISITOR = new DualBuilderVisitor() {
public void visit(DualBuilder builder, Object lhs, Object rhs) {
Type lhsObj = (Type) lhs;
Type rhsObj = (Type) rhs;
builder.append(lhsObj.getId(),
rhsObj.getId()).append(lhsObj.getName(), rhsObj.getName());
}
};
And then, declare and instantiate builders like as, say:
public boolean equals(Object anotherObj) {
return new EqualsVisitor(EQUALS_VISITOR, this, anotherObj);
}
Please note this implementation, overrall, also lets you easily use
a single visitor for either equals and compareto, thus creating a
single point of management for all your
field-maintenance-in-value-objects-needs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (LANG-52) [lang] Validate.notNull should throw NullArgumentException
[ http://issues.apache.org/jira/browse/LANG-52?page=all ] Stephen Colebourne resolved LANG-52. Fix Version/s: (was: 3.0) Resolution: Won't Fix Yes, this method probably should have thrown NullArgumentException, but it doesn't and its too late to fix now. Also, the JDK should have has a NullArgumentException, but there's not much we can do about that either. [lang] Validate.notNull should throw NullArgumentException -- Key: LANG-52 URL: http://issues.apache.org/jira/browse/LANG-52 Project: Commons Lang Issue Type: Bug Environment: Operating System: All Platform: All Reporter: Jörg Gottschling Priority: Trivial Attachments: LANG-52.patch Validate.notNull throws a IllegalArgumentException but should throw a NullArgumentException -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491073 - /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
Author: bayard
Date: Fri Dec 29 10:42:08 2006
New Revision: 491073
URL: http://svn.apache.org/viewvc?view=revrev=491073
Log:
Rolling back r490355 - StrBuilder implements Cloneable again
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java?view=diffrev=491073r1=491072r2=491073
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
Fri Dec 29 10:42:08 2006
@@ -67,7 +67,7 @@
* @since 2.2
* @version $Id$
*/
-public class StrBuilder {
+public class StrBuilder implements Cloneable {
/**
* The extra capacity for new builders.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-302) StrBuilder does not implement clone()
[ http://issues.apache.org/jira/browse/LANG-302?page=comments#action_12461427 ] Henri Yandell commented on LANG-302: svn ci -m Rolling back r490355 - StrBuilder implements Cloneable again src/java/org/apache/commons/lang/text/StrBuilder.java Sendingsrc/java/org/apache/commons/lang/text/StrBuilder.java Transmitting file data . Committed revision 491073. StrBuilder does not implement clone() - Key: LANG-302 URL: http://issues.apache.org/jira/browse/LANG-302 Project: Commons Lang Issue Type: Bug Affects Versions: 2.2 Reporter: Henri Yandell Fix For: 3.0 As reported by FindBugs. Does StrBuilder need to be Cloneable? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-302) StrBuilder does not implement clone()
[ http://issues.apache.org/jira/browse/LANG-302?page=all ] Henri Yandell updated LANG-302: --- Fix Version/s: 3.0 (was: 2.3) StrBuilder does not implement clone() - Key: LANG-302 URL: http://issues.apache.org/jira/browse/LANG-302 Project: Commons Lang Issue Type: Bug Affects Versions: 2.2 Reporter: Henri Yandell Fix For: 3.0 As reported by FindBugs. Does StrBuilder need to be Cloneable? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491076 - in /jakarta/commons/proper/lang/trunk/src: java/org/apache/commons/lang/math/NumberUtils.java test/org/apache/commons/lang/math/NumberUtilsTest.java
Author: bayard
Date: Fri Dec 29 10:48:37 2006
New Revision: 491076
URL: http://svn.apache.org/viewvc?view=revrev=491076
Log:
Rolling back r467482 as the methods are already in java.util.Arrays. These were
added as a part of #LANG-238.
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/math/NumberUtilsTest.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java?view=diffrev=491076r1=491075r2=491076
==
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
Fri Dec 29 10:48:37 2006
@@ -666,170 +666,6 @@
return new BigDecimal(str);
}
-// Equals in array
-//
-/**
- * pWhether the contents of two byte[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return whether the two arrays are equal
- */
-public static boolean equals(byte[] array1, byte[] array2) {
-if (array1 == array2) {
-return true;
-}
-if (array1 == null || array2 == null) {
-return false;
-}
-if (array1.length != array2.length) {
-return false;
-}
-
-for (int i=0; iarray1.length; i++) {
-if (array1[i] != array2[i]) {
-return false;
-}
-}
-
-return true;
-}
-
-/**
- * pWhether the contents of two short[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return whether the two arrays are equal
- */
-public static boolean equals(short[] array1, short[] array2) {
-if (array1 == array2) {
-return true;
-}
-if (array1 == null || array2 == null) {
-return false;
-}
-if (array1.length != array2.length) {
-return false;
-}
-
-for (int i=0; iarray1.length; i++) {
-if (array1[i] != array2[i]) {
-return false;
-}
-}
-
-return true;
-}
-
-/**
- * pWhether the contents of two int[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return whether the two arrays are equal
- */
-public static boolean equals(int[] array1, int[] array2) {
-if (array1 == array2) {
-return true;
-}
-if (array1 == null || array2 == null) {
-return false;
-}
-if (array1.length != array2.length) {
-return false;
-}
-
-for (int i=0; iarray1.length; i++) {
-if (array1[i] != array2[i]) {
-return false;
-}
-}
-
-return true;
-}
-
-/**
- * pWhether the contents of two long[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return whether the two arrays are equal
- */
-public static boolean equals(long[] array1, long[] array2) {
-if (array1 == array2) {
-return true;
-}
-if (array1 == null || array2 == null) {
-return false;
-}
-if (array1.length != array2.length) {
-return false;
-}
-
-for (int i=0; iarray1.length; i++) {
-if (array1[i] != array2[i]) {
-return false;
-}
-}
-
-return true;
-}
-
-/**
- * pWhether the contents of two float[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return whether the two arrays are equal
- */
-public static boolean equals(float[] array1, float[] array2) {
-if (array1 == array2) {
-return true;
-}
-if (array1 == null || array2 == null) {
-return false;
-}
-if (array1.length != array2.length) {
-return false;
-}
-
-for (int i=0; iarray1.length; i++) {
-if (compare(array1[i], array2[i]) != 0) {
-return false;
-}
-}
-
-return true;
-}
-
-/**
- * pWhether the contents of two double[] arrays are equal./p
- *
- * @param array1 first array to compare
- * @param array2 second array to compare
- * @return
[jira] Closed: (LANG-238) [lang] Add equals(type[]) to NumberUtils
[ http://issues.apache.org/jira/browse/LANG-238?page=all ] Henri Yandell closed LANG-238. -- Resolution: Won't Fix Doh - Thanks for catching that Stephen. Rolling back the commit: svn merge -r467482:467481 . svn ci -m Rolling back r467482 as the methods are already in java.util.Arrays. These were added as a part of #LANG-238. Sendingsrc/java/org/apache/commons/lang/math/NumberUtils.java Sendingsrc/test/org/apache/commons/lang/math/NumberUtilsTest.java Transmitting file data .. Committed revision 491076. [lang] Add equals(type[]) to NumberUtils Key: LANG-238 URL: http://issues.apache.org/jira/browse/LANG-238 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Environment: Operating System: other Platform: Other Reporter: Paul Benedict Priority: Minor Fix For: 2.3 It would be useful to add an equals() method like the current min and max methods which take an array type and determine if all the values are equal. I have found myself in need of this often. I have to retrieve objects from multiple data sources in parallel to build an array of complex object. To ensure validity, I always compare that my sub-retrievals returned the same number of objects as expected. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[httpclient] multicast message
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi there, Does commons-httpclient support multicast messages? I want to send a SSDP Multicast Message. I could create the HTTP Header myself and send the bytes brute force with java.net but if I use httpclient I suppose I will have way more flexibility I will love to have later. As I digged in the sources, I could not find something like this. Can I write my own ProtocolSocketFactory that creates a MulticastSocket instead of a regular socket? How do I use my custom socket factory together with httpclient? Thanks Jörg -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFlXxcmPuec2Dcv/8RApgCAJ4oYISxksICtlI7m7rnCWbpvuJGTwCfY/5C VzCwsyOLmr3rBc7CdR+kqmI= =4SeJ -END PGP SIGNATURE- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-297) Addition to ObjectUtils: public static List getAllSuperclassesUpTo( Class cls, Class upToClass )
[ http://issues.apache.org/jira/browse/LANG-297?page=comments#action_12461439 ] David J. M. Karlsen commented on LANG-297: -- It may well be featuritis. :) Initially I wanted this for an spring exception converting interceptor; but I fell down on a solution using Class' isAssignableFrom() instead. Though, it might be needed for some other use case - so we can just let the patch stick around in jira for an unscheduled release. Addition to ObjectUtils: public static List getAllSuperclassesUpTo( Class cls, Class upToClass ) Key: LANG-297 URL: http://issues.apache.org/jira/browse/LANG-297 Project: Commons Lang Issue Type: Improvement Affects Versions: 2.3 Environment: N/A Reporter: David J. M. Karlsen Attachments: CommonsLang-patch-JIRA297.txt Add another method: /** * Gets a codeList/code of superclasses up to, but not including codeupToClass/code. * If upToClass is null this is effectively the same as getAllSuperClasses( cls ) (e.g. the whole hierarchy). * returns null if cls is null */ public static List getAllSuperclassesUpTo( Class cls, Class upToClass ) Patch with code and test will be added. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: I don't see any reason to change the urls though. If the nightly builds don't want to release an RC then it shouldn't use the rc profile. The profiles were set up to make sure that nothing get's deployed unless someone explicitly says it should. The comment in the patch indicates that it might if users are working locally on people.apache.org. IIUC you are not supposed to do building and releasing on that machine. You also risk that someone changes the url to something that is completely wrong. Unless there is another reason for it, I'm -1 on that change. Understood your concerns about people.apache.org. Nevertheless, I see use cases for a pluggable URL. For example, when doing deployment for the first time, I was very cautious and feared I might do things wrong. If I had had the chance to *test* deployment by simply specifying a property like -Dcommons.deployment.rc.url=file:///tmp/test-repository, then that would have been nice. I'd like to see it. Besides, I do not see any negative side effects. So I'd like to ask you to reconsider your -1. Jochen -- My wife Mary and I have been married for forty-seven years and not once have we had an argument serious enough to consider divorce; murder, yes, but divorce, never. (Jack Benny) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
Jochen Wiedmann wrote: On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: I don't see any reason to change the urls though. If the nightly builds don't want to release an RC then it shouldn't use the rc profile. The profiles were set up to make sure that nothing get's deployed unless someone explicitly says it should. The comment in the patch indicates that it might if users are working locally on people.apache.org. IIUC you are not supposed to do building and releasing on that machine. You also risk that someone changes the url to something that is completely wrong. Unless there is another reason for it, I'm -1 on that change. Understood your concerns about people.apache.org. Nevertheless, I see use cases for a pluggable URL. For example, when doing deployment for the first time, I was very cautious and feared I might do things wrong. If I had had the chance to *test* deployment by simply specifying a property like -Dcommons.deployment.rc.url=file:///tmp/test-repository, then that would have been nice. I'd like to see it. Besides, I do not see any negative side effects. So I'd like to ask you to reconsider your -1. Jochen I understand your fears when doing your first release - I felt the same way. The very reason for having a parent pom is to have something that is tried and tested - it just works. So you shouldn't feel nervous using it. If you have the need to deploy somewhere else you can easily add another profile, temporarily, in the component you are working on. -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491112 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Author: bayard
Date: Fri Dec 29 13:44:17 2006
New Revision: 491112
URL: http://svn.apache.org/viewvc?view=revrev=491112
Log:
Added default encoding variants for 6 methods in FileUtils. See: #IO-108
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=491112r1=49r2=491112
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Fri Dec 29 13:44:17 2006
@@ -946,10 +946,6 @@
/**
* Reads the contents of a file into a String.
* The file is always closed.
- * p
- * There is no readFileToString method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -967,6 +963,20 @@
}
}
+
+/**
+ * Reads the contents of a file into a String using the default encoding
for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the file contents, never null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public String readFileToString(File f) throws IOException {
+return readFileToString(f, null);
+}
+
/**
* Reads the contents of a file into a byte array.
* The file is always closed.
@@ -989,10 +999,6 @@
/**
* Reads the contents of a file line by line to a List of Strings.
* The file is always closed.
- * p
- * There is no readLines method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1012,6 +1018,19 @@
}
/**
+ * Reads the contents of a file line by line to a List of Strings using
the default encoding for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the list of Strings representing each line in the file, never
null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public static List readLines(File file) throws IOException {
+return readLines(file, null);
+}
+
+/**
* Return an Iterator for the lines in a codeFile/code.
* p
* This method opens an codeInputStream/code for the file.
@@ -1035,10 +1054,6 @@
* p
* If an exception occurs during the creation of the iterator, the
* underlying stream is closed.
- * p
- * There is no lineIterator method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1060,14 +1075,20 @@
}
}
+/**
+ * Return an Iterator for the lines in a codeFile/code using the
default encoding for the VM.
+ *
+ * @since Commons IO 1.3
+ * @see lineIterator(File, String)
+ */
+public static LineIterator lineIterator(File file) throws IOException {
+return lineIterator(file, null);
+}
+
//---
/**
* Writes a String to a file creating the file if it does not exist.
- * p
- * There is no writeStringToFile method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
- * p
+ *
* NOTE: As from v1.3, the parent directories of the file will be created
* if they do not exist.
*
@@ -1088,6 +1109,17 @@
}
/**
+ * Writes a String to a file creating the file if it does not exist using
the default encoding for the VM.
+ *
+ * @param file the file to write
+ * @param data the content to write to the file
+ * @throws IOException in case of an I/O error
+ */
+public static void writeStringToFile(File file, String data) throws
IOException {
+writeStringToFile(file, data, null);
+}
+
+/**
* Writes a byte array to a file creating the file if it does not exist.
* p
* NOTE: As from v1.3, the parent directories of the file will be created
@@ -1113,10 +1145,6 @@
* the specified codeFile/code line by line.
[jira] Closed: (IO-108) Add default encoding overrides for FileUtils methods
[ http://issues.apache.org/jira/browse/IO-108?page=all ]
Henri Yandell closed IO-108.
Resolution: Fixed
svn ci -m Added default encoding variants for 6 methods in FileUtils. See:
#IO-108
src/java/org/apache/commons/io/FileUtils.java
Sendingsrc/java/org/apache/commons/io/FileUtils.java
Transmitting file data .
Committed revision 491112.
Add default encoding overrides for FileUtils methods
Key: IO-108
URL: http://issues.apache.org/jira/browse/IO-108
Project: Commons IO
Issue Type: Improvement
Components: Utilities
Reporter: Henri Yandell
Assigned To: Henri Yandell
Fix For: 1.3
ie:
public String readFileToString(File f) {
return readFileToString(f, null);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491116 - /jakarta/commons/proper/commons-parent/trunk/pom.xml
Author: jochen
Date: Fri Dec 29 13:53:16 2006
New Revision: 491116
URL: http://svn.apache.org/viewvc?view=revrev=491116
Log:
Made the protocol in the deployment URL pluggable, so that users can choose
scpexe over scp.
Modified:
jakarta/commons/proper/commons-parent/trunk/pom.xml
Modified: jakarta/commons/proper/commons-parent/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/commons-parent/trunk/pom.xml?view=diffrev=491116r1=491115r2=491116
==
--- jakarta/commons/proper/commons-parent/trunk/pom.xml (original)
+++ jakarta/commons/proper/commons-parent/trunk/pom.xml Fri Dec 29 13:53:16 2006
@@ -164,7 +164,7 @@
repository
idapache.releases/id
nameApache Release Distribution Repository/name
-
urlscp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url
+
url${commons.deployment.protocol}://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository/url
/repository
/distributionManagement
build
@@ -203,8 +203,13 @@
repository
idapache.snapshots/id
nameApache Development Snapshot Repository/name
-
urlscp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
+
url${commons.deployment.protocol}://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
/repository
+snapshotRepository
+ idapache.snapshots/id
+ nameApache Development Snapshot Repository/name
+
url${commons.deployment.protocol}://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
+/snapshotRepository
/distributionManagement
build
plugins
@@ -245,4 +250,11 @@
maven.compile.target1.3/maven.compile.target
/properties
--
-/project
\ No newline at end of file
+ properties
+!--
+ Make the deployment protocol pluggable. This allows to switch to
+ other protocols like scpexe, which some users prefer over scp.
+--
+commons.deployment.protocolscp/commons.deployment.protocol
+ /properties
+/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [commons-parent] Make deployment URL pluggable
On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: If you have the need to deploy somewhere else you can easily add another profile, temporarily, in the component you are working on. Ok, my impression is that we all agree on the pluggable protocol, so I have committed that, and only that. Jochen -- My wife Mary and I have been married for forty-seven years and not once have we had an argument serious enough to consider divorce; murder, yes, but divorce, never. (Jack Benny) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r491112 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
You need to add these to RELEASE-NOTES ;-)
Stephen
[EMAIL PROTECTED] wrote:
Author: bayard
Date: Fri Dec 29 13:44:17 2006
New Revision: 491112
URL: http://svn.apache.org/viewvc?view=revrev=491112
Log:
Added default encoding variants for 6 methods in FileUtils. See: #IO-108
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=491112r1=49r2=491112
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Fri Dec 29 13:44:17 2006
@@ -946,10 +946,6 @@
/**
* Reads the contents of a file into a String.
* The file is always closed.
- * p
- * There is no readFileToString method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -967,6 +963,20 @@
}
}
+
+/**
+ * Reads the contents of a file into a String using the default encoding for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the file contents, never null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public String readFileToString(File f) throws IOException {
+return readFileToString(f, null);
+}
+
/**
* Reads the contents of a file into a byte array.
* The file is always closed.
@@ -989,10 +999,6 @@
/**
* Reads the contents of a file line by line to a List of Strings.
* The file is always closed.
- * p
- * There is no readLines method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1012,6 +1018,19 @@
}
/**
+ * Reads the contents of a file line by line to a List of Strings using
the default encoding for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the list of Strings representing each line in the file, never
null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public static List readLines(File file) throws IOException {
+return readLines(file, null);
+}
+
+/**
* Return an Iterator for the lines in a codeFile/code.
* p
* This method opens an codeInputStream/code for the file.
@@ -1035,10 +1054,6 @@
* p
* If an exception occurs during the creation of the iterator, the
* underlying stream is closed.
- * p
- * There is no lineIterator method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1060,14 +1075,20 @@
}
}
+/**
+ * Return an Iterator for the lines in a codeFile/code using the
default encoding for the VM.
+ *
+ * @since Commons IO 1.3
+ * @see lineIterator(File, String)
+ */
+public static LineIterator lineIterator(File file) throws IOException {
+return lineIterator(file, null);
+}
+
//---
/**
* Writes a String to a file creating the file if it does not exist.
- * p
- * There is no writeStringToFile method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
- * p
+ *
* NOTE: As from v1.3, the parent directories of the file will be created
* if they do not exist.
*
@@ -1088,6 +1109,17 @@
}
/**
+ * Writes a String to a file creating the file if it does not exist using
the default encoding for the VM.
+ *
+ * @param file the file to write
+ * @param data the content to write to the file
+ * @throws IOException in case of an I/O error
+ */
+public static void writeStringToFile(File file, String data) throws
IOException {
+writeStringToFile(file, data, null);
+}
+
+/**
* Writes a byte array to a file creating the file if it does not exist.
* p
* NOTE: As from v1.3, the parent directories of the file will
[io] Ready for v1.3
As far as I can tell, everything is set for v1.3. Anyone disagree? And does anyone want to crank the handle and do the release? Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491127 - /jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt
Author: bayard Date: Fri Dec 29 14:58:03 2006 New Revision: 491127 URL: http://svn.apache.org/viewvc?view=revrev=491127 Log: Adding IO-108 to the release notes Modified: jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt Modified: jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt?view=diffrev=491127r1=491126r2=491127 == --- jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt (original) +++ jakarta/commons/proper/io/trunk/RELEASE-NOTES.txt Fri Dec 29 14:58:03 2006 @@ -102,6 +102,14 @@ - wildcardMatch - new method that has IOCase as a parameter - equals - new method that has IOCase as a parameter +- FileUtils [IO-108] - new default encoding methods for: + - readFileToString(File) + - readLines(File) + - lineIterator(File) + - writeStringToFile(File, String) + - writeLines(File, Collection) + - writeLines(File, Collection, String) + - FileUtils.openOutputStream [IO-107] - new method to open a FileOutputStream, creating parent directories if required - FileUtils.touch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r491112 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Too used to 'svn -v log' being a part of creating the release notes :)
Done.
Hen
On 12/29/06, Stephen Colebourne [EMAIL PROTECTED] wrote:
You need to add these to RELEASE-NOTES ;-)
Stephen
[EMAIL PROTECTED] wrote:
Author: bayard
Date: Fri Dec 29 13:44:17 2006
New Revision: 491112
URL: http://svn.apache.org/viewvc?view=revrev=491112
Log:
Added default encoding variants for 6 methods in FileUtils. See: #IO-108
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diffrev=491112r1=49r2=491112
==
---
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
(original)
+++
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java Fri
Dec 29 13:44:17 2006
@@ -946,10 +946,6 @@
/**
* Reads the contents of a file into a String.
* The file is always closed.
- * p
- * There is no readFileToString method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -967,6 +963,20 @@
}
}
+
+/**
+ * Reads the contents of a file into a String using the default encoding
for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the file contents, never null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public String readFileToString(File f) throws IOException {
+return readFileToString(f, null);
+}
+
/**
* Reads the contents of a file into a byte array.
* The file is always closed.
@@ -989,10 +999,6 @@
/**
* Reads the contents of a file line by line to a List of Strings.
* The file is always closed.
- * p
- * There is no readLines method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1012,6 +1018,19 @@
}
/**
+ * Reads the contents of a file line by line to a List of Strings using
the default encoding for the VM.
+ * The file is always closed.
+ *
+ * @param file the file to read, not null
+ * @return the list of Strings representing each line in the file, never
null
+ * @throws IOException in case of an I/O error
+ * @since Commons IO 1.3
+ */
+public static List readLines(File file) throws IOException {
+return readLines(file, null);
+}
+
+/**
* Return an Iterator for the lines in a codeFile/code.
* p
* This method opens an codeInputStream/code for the file.
@@ -1035,10 +1054,6 @@
* p
* If an exception occurs during the creation of the iterator, the
* underlying stream is closed.
- * p
- * There is no lineIterator method without encoding parameter because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
*
* @param file the file to read, not null
* @param encoding the encoding to use, null means platform default
@@ -1060,14 +1075,20 @@
}
}
+/**
+ * Return an Iterator for the lines in a codeFile/code using the
default encoding for the VM.
+ *
+ * @since Commons IO 1.3
+ * @see lineIterator(File, String)
+ */
+public static LineIterator lineIterator(File file) throws IOException {
+return lineIterator(file, null);
+}
+
//---
/**
* Writes a String to a file creating the file if it does not exist.
- * p
- * There is no writeStringToFile method without encoding parameter
because
- * the default encoding can differ between platforms and will have
- * inconsistent results.
- * p
+ *
* NOTE: As from v1.3, the parent directories of the file will be created
* if they do not exist.
*
@@ -1088,6 +1109,17 @@
}
/**
+ * Writes a String to a file creating the file if it does not exist
using the default encoding for the VM.
+ *
+ * @param file the file to write
+ * @param data the content to write to the file
+ * @throws IOException in case of an I/O error
+ */
+public static void writeStringToFile(File file,
Re: [io] Ready for v1.3
+1 for a release. Lang 2.3 is the same way I think once the release notes are happy. I can dedicate Tuesday to doing RC builds for both IO and Lang - unless someone gets to them sooner. Hen On 12/29/06, Stephen Colebourne [EMAIL PROTECTED] wrote: As far as I can tell, everything is set for v1.3. Anyone disagree? And does anyone want to crank the handle and do the release? Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491129 - /jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt
Author: bayard Date: Fri Dec 29 15:08:49 2006 New Revision: 491129 URL: http://svn.apache.org/viewvc?view=revrev=491129 Log: Adding bugfixes and improvements from JIRA Modified: jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt Modified: jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt?view=diffrev=491129r1=491128r2=491129 == --- jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt (original) +++ jakarta/commons/proper/lang/trunk/RELEASE-NOTES.txt Fri Dec 29 15:08:49 2006 @@ -57,8 +57,28 @@ BUG FIXES IN 2.3: -? +* [LANG-69 ] - [lang] ToStringBuilder throws StackOverflowError when an Object cycle exists +* [LANG-153] - [lang] Can't XMLDecode an Enum +* [LANG-262] - Use of enum prevents a classloader from being garbage collected resuling in out of memory exceptions. +* [LANG-279] - HashCodeBuilder throws java.lang.StackOverflowError when an object contains a cycle. +* [LANG-281] - DurationFormatUtils returns wrong result +* [LANG-286] - Serialization - not backwards compatible +* [LANG-292] - unescapeXml(12345678;) should be 12345678; +* [LANG-294] - StrBuilder.replaceAll and StrBuilder.deleteAll can throw ArrayIndexOutOfBoundsException. +* [LANG-295] - StrBuilder contains usages of thisBuf.length when they should use size +* [LANG-299] - Bug in method appendFixedWidthPadRight of class StrBuilder causes an ArrayIndexOutOfBoundsException +* [LANG-300] - NumberUtils.createNumber throws NumberFormatException for one digit long +* [LANG-303] - FastDateFormat.mRules is not transient or serializable +* [LANG-304] - NullPointerException in isAvailableLocale(Locale) IMPROVEMENTS IN 2.3: -? +* [LANG-238] - [lang] Add equals(type[]) to NumberUtils +* [LANG-258] - Enum JavaDoc +* [LANG-268] - StringUtils.join should allow you to pass a range for it (so it only joins a part of the array) +* [LANG-287] - Optimize StringEscapeUtils.unescapeXml(String) +* [LANG-289] - NumberUtils.max(byte[]) and NumberUtils.min(byte[]) are missing +* [LANG-291] - Null-safe comparison methods for finding most recent / least recent dates. +* [LANG-282] - Create more tests to test out the +=31 replacement code in DurationFormatUtils. +* [LANG-266] - Wish for StringUtils.join(Collection, *) + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491134 - /jakarta/commons/proper/logging/trunk/pom.xml
Author: dennisl
Date: Fri Dec 29 15:27:57 2006
New Revision: 491134
URL: http://svn.apache.org/viewvc?view=revrev=491134
Log:
Add our own manifest to all the produced jar files.
Modified:
jakarta/commons/proper/logging/trunk/pom.xml
Modified: jakarta/commons/proper/logging/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/pom.xml?view=diffrev=491134r1=491133r2=491134
==
--- jakarta/commons/proper/logging/trunk/pom.xml (original)
+++ jakarta/commons/proper/logging/trunk/pom.xml Fri Dec 29 15:27:57 2006
@@ -158,6 +158,11 @@
--
plugin
artifactIdmaven-jar-plugin/artifactId
+configuration
+ archive
+manifestFilesrc/conf/MANIFEST.MF/manifestFile
+ /archive
+/configuration
executions
execution
idtestjar/id
@@ -197,7 +202,8 @@
dest=${workdir}/
jar
basedir=${workdir}
- destfile=${project.build.directory}/${target}.jar
+ destfile=${project.build.directory}/${target}.jar
+ manifest=${basedir}/src/conf/MANIFEST.MF
exclude name=org/apache/commons/logging/impl/Log4J*/
exclude name=org/apache/commons/logging/impl/Avalon*/
exclude name=org/apache/commons/logging/impl/Jdk13*/
@@ -226,7 +232,8 @@
dest=${workdir}/
jar
basedir=${workdir}
- destfile=${project.build.directory}/${target}.jar
+ destfile=${project.build.directory}/${target}.jar
+ manifest=${basedir}/src/conf/MANIFEST.MF
exclude name=org/apache/commons/logging/*/
exclude
name=org/apache/commons/logging/impl/WeakHashtable*/
exclude
name=org/apache/commons/logging/impl/LogFactoryImpl*/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JELLY-273) Reference to %JAVA_HOME%\bin\java in jelly.bat should be %JAVA_HOME%\bin\java
[ http://issues.apache.org/jira/browse/JELLY-273?page=comments#action_12461455 ] dion gillard commented on JELLY-273: Yep, the quoting of JAVA_HOME is definitely wrong Reference to %JAVA_HOME%\bin\java in jelly.bat should be %JAVA_HOME%\bin\java - Key: JELLY-273 URL: http://issues.apache.org/jira/browse/JELLY-273 Project: Commons Jelly Issue Type: Bug Components: core / taglib.core Environment: Windows XP Reporter: David M. Karr Priority: Minor On Windows XP, when the released jelly.bat is executed, it complains very obtusely: Exception in thread main java.lang.NoClassDefFoundError: \bin\java With some experimentation, I realized that all that is required is to change: %JAVA_HOME%\bin\java -classpath %CLASSPATH%;%JELLY_HOME%\lib\forehead-1.0-beta-5.jar -Dforehead.conf.file=%FOREHEAD_CONF% -Djelly.home=%JELLY_HOME% -Dtools.jar=%JAVA_HOME%\lib\tools.jar %JELLY_OPTS% com.werken.forehead.Forehead %* to: %JAVA_HOME%\bin\java -classpath %CLASSPATH%;%JELLY_HOME%\lib\forehead-1.0-beta-5.jar -Dforehead.conf.file=%FOREHEAD_CONF% -Djelly.home=%JELLY_HOME% -Dtools.jar=%JAVA_HOME%\lib\tools.jar %JELLY_OPTS% com.werken.forehead.Forehead %* The only change is moving the double-quote from before /bin/java to after it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491135 - /jakarta/commons/proper/logging/trunk/
Author: dennisl Date: Fri Dec 29 15:40:31 2006 New Revision: 491135 URL: http://svn.apache.org/viewvc?view=revrev=491135 Log: Ignore default dependency directory used by ant build. Ignore IDEA files. Modified: jakarta/commons/proper/logging/trunk/ (props changed) Propchange: jakarta/commons/proper/logging/trunk/ -- --- svn:ignore (original) +++ svn:ignore Fri Dec 29 15:40:31 2006 @@ -11,3 +11,7 @@ *.tar.gz *.zip artifacts +lib +*.iml +*.ipr +*.iws - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491137 - in /jakarta/commons/proper/logging/trunk: pom.xml project.xml
Author: dennisl Date: Fri Dec 29 15:48:11 2006 New Revision: 491137 URL: http://svn.apache.org/viewvc?view=revrev=491137 Log: Fix issue management url. Modified: jakarta/commons/proper/logging/trunk/pom.xml jakarta/commons/proper/logging/trunk/project.xml Modified: jakarta/commons/proper/logging/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/pom.xml?view=diffrev=491137r1=491136r2=491137 == --- jakarta/commons/proper/logging/trunk/pom.xml (original) +++ jakarta/commons/proper/logging/trunk/pom.xml Fri Dec 29 15:48:11 2006 @@ -37,7 +37,7 @@ urlhttp://jakarta.apache.org/commons/logging/url issueManagement -urlhttp://issues.apache.org/jira//url +urlhttp://issues.apache.org/jira/browse/LOGGING/url /issueManagement inceptionYear2001/inceptionYear Modified: jakarta/commons/proper/logging/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/project.xml?view=diffrev=491137r1=491136r2=491137 == --- jakarta/commons/proper/logging/trunk/project.xml (original) +++ jakarta/commons/proper/logging/trunk/project.xml Fri Dec 29 15:48:11 2006 @@ -50,7 +50,7 @@ /licenses gumpRepositoryIdjakarta/gumpRepositoryId - issueTrackingUrlhttp://issues.apache.org/jira//issueTrackingUrl + issueTrackingUrlhttp://issues.apache.org/jira/browse/LOGGING/issueTrackingUrl siteAddresspeople.apache.org/siteAddress siteDirectory/www/jakarta.apache.org/commons/logging//siteDirectory distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/logging//distributionDirectory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r491138 - /jakarta/commons/proper/logging/trunk/commons-logging-api.pom
Author: dennisl
Date: Fri Dec 29 16:07:23 2006
New Revision: 491138
URL: http://svn.apache.org/viewvc?view=revrev=491138
Log:
Merge in recent changes from project.xml.
Modified:
jakarta/commons/proper/logging/trunk/commons-logging-api.pom
Modified: jakarta/commons/proper/logging/trunk/commons-logging-api.pom
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/commons-logging-api.pom?view=diffrev=491138r1=491137r2=491138
==
--- jakarta/commons/proper/logging/trunk/commons-logging-api.pom (original)
+++ jakarta/commons/proper/logging/trunk/commons-logging-api.pom Fri Dec 29
16:07:23 2006
@@ -1,11 +1,12 @@
?xml version=1.0 encoding=UTF-8?
!--
- Copyright 2001-2006 The Apache Software Foundation.
-
- Licensed under the Apache License, Version 2.0 (the License);
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the License); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
@@ -22,7 +23,7 @@
nameLogging/name
groupIdcommons-logging/groupId
artifactIdcommons-logging-api/artifactId
- currentVersion1.1/currentVersion
+ currentVersion1.1.1-SNAPSHOT/currentVersion
inceptionYear2001/inceptionYear
shortDescriptionCommons Logging/shortDescription
description
@@ -31,8 +32,8 @@
/description
logo/images/logo.png/logo
- urlhttp://jakarta.apache.org/commons/${pom.artifactId.substring(8)}//url
- packageorg.apache.commons.${pom.artifactId.substring(8)}/package
+ urlhttp://jakarta.apache.org/commons/logging//url
+ packageorg.apache.commons.logging/package
organization
nameThe Apache Software Foundation/name
@@ -41,23 +42,22 @@
/organization
licenses
- license
- nameThe Apache Software License, Version 2.0/name
- url/LICENSE.txt/url
- distributionrepo/distribution
- /license
+license
+ nameThe Apache Software License, Version 2.0/name
+ url/LICENSE.txt/url
+ distributionrepo/distribution
+/license
/licenses
gumpRepositoryIdjakarta/gumpRepositoryId
- issueTrackingUrlhttp://issues.apache.org/jira//issueTrackingUrl
+
issueTrackingUrlhttp://issues.apache.org/jira/browse/LOGGING/issueTrackingUrl
siteAddresspeople.apache.org/siteAddress
-
siteDirectory/www/jakarta.apache.org/commons/${pom.artifactId.substring(8)}//siteDirectory
-
distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/${pom.artifactId.substring(8)}//distributionDirectory
+ siteDirectory/www/jakarta.apache.org/commons/logging//siteDirectory
+
distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/logging//distributionDirectory
repository
-
!--connectionscm:cvs:${logging.cvs}:jakarta-commons/logging//connection--
-
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/${pom.artifactId.substring(8)}/trunk/connection
-
urlhttp://svn.apache.org/repos/asf/jakarta/commons/proper/${pom.artifactId.substring(8)}/trunk/url
+
connectionscm:svn:http://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk//connection
+
urlhttp://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk//url
/repository
versions
@@ -190,6 +190,7 @@
properties
commentUsed for testing only./comment
scopetest/scope
+optionaltrue/optional
/properties
/dependency
@@ -200,16 +201,17 @@
urlhttp://maven.apache.org/maven-1.x/reference/plugins/xdoc//url
typeplugin/type
properties
- comment
- lt;stronggt;Site Onlylt;/stronggt; - v1.9.2 (minimum)
- /comment
+comment
+ lt;stronggt;Site Onlylt;/stronggt; - v1.9.2 (minimum)
+/comment
+optionaltrue/optional
/properties
/dependency
-
/dependencies
build
nagEmailAddresscommons-dev@jakarta.apache.org/nagEmailAddress
sourceDirectorysrc/java/sourceDirectory
+unitTestSourceDirectorysrc/test/unitTestSourceDirectory
sourceModifications
sourceModification
classNamejava.util.logging.Logger/className
@@ -219,12 +221,12 @@
/sourceModification
/sourceModifications
unitTest
-!--
+ !--
At the moment there are problems running the unit tests under maven.
The unit tests are run by custom ant targets which perform configuration
before the tests are run.
There is no easy way to run these under maven at the moment.
---
+ --
/unitTest
/build
Re: [commons-parent] Make deployment URL pluggable
Jochen Wiedmann wrote: On 12/29/06, Dennis Lundberg [EMAIL PROTECTED] wrote: If you have the need to deploy somewhere else you can easily add another profile, temporarily, in the component you are working on. Ok, my impression is that we all agree on the pluggable protocol, so I have committed that, and only that. Looks good. - Jörg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[logging] Using Maven 2 for everything
Hi all I've spent some time going over the pom.xml file and using Maven 2 to build all the jars. These jars were then compared to the ones created with the ant build. Here's a rundown on the differences I found: 1. The M2 jars is missing parts of the manifest. As you might have seen in the commits I have now added the missing manifest parts to the jars. 2. The manifests have a couple of other lines that are different. Where ant has: Ant-Version: Apache Ant 1.6.5 Created-By: 1.4.2_13-b06 (Sun Microsystems Inc.) M2 has: Archiver-Version: Plexus Archiver Created-By: Apache Maven Built-By: dlg01 Build-Jdk: 1.4.2_13 This has to do with what program is used to create the jar, and doesn't seem that important. 3. The class files in the test jars are different. It turned out that the ant build does not set source.version and target.version when compiling the test classes. After adding that to the ant build, the class files are equal. Should I commit my patched build.xml file? 4. The M2 jars has the files pom.properties and pom.xml in the /META_INF/maven/commons-logging/commons-logging/ directory. To summarize: I feel confident that the jars produced by Maven 2 are equivalent to the ones produced by Ant. So Maven 2 could be used to produce the jars for the next release of commons-logging. Still to check: A. The site. To enable the M2 site build all it takes is a src/site/site.xml file and to bump the version of commons-parent to 2-SNAPSHOT. I have these changes made locally. Commons-skin is not perfect yet, but it's getting there. It shouldn't be that long. I'm still trying to solve Phil's rendering problem. Should I commit the site.xml file? B. Distributions. As far as I can see we need to have source and binary distros as well. I'll have a look at producing these with M2 as well. -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Introducing commons-skin
Phil Steitz wrote: Hmmm. http://people.apache.org/~dennisl/commons-lang3/http://people.apache.org/%7Edennisl/commons-lang3/ puts the nav bar in the right place flush left, but shows a big black box between the Jakarta and Lang logos on the top. Yes, I used the standard maven-classic-skin for this one. Just to see if the problem is in commons-skin or if it was inherited from maven-classic-skin. Seems that I have made something wrong in commons-skin :( http://people.apache.org/~dennisl/commons-lang4/http://people.apache.org/%7Edennisl/commons-lang4/ puts the nav bar in the middle, as before. That's odd. There must be something more that is wrong then. Unfortunately I haven't been able to reproduce this myself. I looked around to find a linux live-cd with Firefox 2 on it. I found one and burned a copy of Ubuntu 6.10 with Firefox 2.0.0.0. But I can't see the issues that you do. I can however see it on both Ubuntu and Windows if make the font size smaller (!) in firefox (CTRL -) about 6 times, then the navbar pops away to the right a bit. I'll continue searching for a solution. Thanks for helping me check this. Phil On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Phil Steitz wrote: On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) There's no built-in support for these arrows. I'm going to ask over in Maven-land if it can be done with a custom Velocity template. A couple of things I noticed: * The Docs for 2.2 is missing. Personally, I think it's important to know the version that I'm looking at, so I hope that can be put back. * The current page now shows in the menu as black, and looks the same as a menu heading. Previously it was bolded blue, which made it a distinct style from other items and from the headers. I managed to fix both of these. A new staged site can be found here: http://people.apache.org/~dennisl/commons-lang2/ Still has the leftcolumn offset problem for me on Firefox/Linux. Phil OK, I think I've found and fixed the problem now. Please double check this one: http://people.apache.org/~dennisl/commons-lang4/ -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Introducing commons-skin
Thanks, and sorry I can't be of more help. I am pretty clueless when it comes to css. I am happy to help test, though. I don't think my browser font setting are funny. I did not change them from the defaults when I installed FireFox. Phil
Re: [logging] Using Maven 2 for everything
On Sat, 2006-12-30 at 02:27 +0100, Dennis Lundberg wrote: Hi all I've spent some time going over the pom.xml file and using Maven 2 to build all the jars. These jars were then compared to the ones created with the ant build. Here's a rundown on the differences I found: 1. The M2 jars is missing parts of the manifest. As you might have seen in the commits I have now added the missing manifest parts to the jars. Yep, thanks! 2. The manifests have a couple of other lines that are different. Where ant has: Ant-Version: Apache Ant 1.6.5 Created-By: 1.4.2_13-b06 (Sun Microsystems Inc.) M2 has: Archiver-Version: Plexus Archiver Created-By: Apache Maven Built-By: dlg01 Build-Jdk: 1.4.2_13 This has to do with what program is used to create the jar, and doesn't seem that important. Agreed. 3. The class files in the test jars are different. It turned out that the ant build does not set source.version and target.version when compiling the test classes. After adding that to the ant build, the class files are equal. Should I commit my patched build.xml file? Yes. 4. The M2 jars has the files pom.properties and pom.xml in the /META_INF/maven/commons-logging/commons-logging/ directory. To summarize: I feel confident that the jars produced by Maven 2 are equivalent to the ones produced by Ant. So Maven 2 could be used to produce the jars for the next release of commons-logging. That's great. Still to check: A. The site. To enable the M2 site build all it takes is a src/site/site.xml file and to bump the version of commons-parent to 2-SNAPSHOT. I have these changes made locally. Commons-skin is not perfect yet, but it's getting there. It shouldn't be that long. I'm still trying to solve Phil's rendering problem. Should I commit the site.xml file? Yes please. I guess this would mean that a logging release is now blocked on a commons-parent 2.0 release, but that seems ok to me. At least now we can switch to maven2 for nightlies and get the user community testing what is pretty close to a release candidate.. B. Distributions. As far as I can see we need to have source and binary distros as well. I'll have a look at producing these with M2 as well. That would be cool. Having a -src jarfile for the next JCL release would be great. Cheers, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 8 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package - commons-jelly-tags-betwixt : Commons Jelly - commons-jelly-tags-ojb : Commons Jelly - db-ddlutils : Easy-to-use component for working with Database Definition (... - db-ojb : ObjectRelationalBridge - db-ojb-from-packages : ObjectRelationalBridge - maven-bootstrap : Project Management Tools - test-ojb : ObjectRelationalBridge Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-29122006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 57 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-29122006 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Running org.apache.commons.betwixt.TestOptions [junit] Testsuite: org.apache.commons.betwixt.TestOptions [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.238 sec [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.238 sec [junit] [junit] Testcase: testGetValue took 0.008 sec [junit] Testcase: testGetNames took 0.002 sec [junit] Testcase: testAddOptions took 0.002 sec [junit] Running org.apache.commons.betwixt.TestRSSRoundTrip [junit] Testsuite: org.apache.commons.betwixt.TestRSSRoundTrip [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.784 sec [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.784 sec [junit] [junit] Testcase: testRoundTrip took 20.537 sec [junit] Caused an ERROR [junit] my.netscape.com [junit] java.net.UnknownHostException: my.netscape.com [junit] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177) [junit] at java.net.Socket.connect(Socket.java:507) [junit] at java.net.Socket.connect(Socket.java:457) [junit] at sun.net.NetworkClient.doConnect(NetworkClient.java:157) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:365) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:477) [junit] at sun.net.www.http.HttpClient.init(HttpClient.java:214) [junit] at
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 8 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package - commons-jelly-tags-betwixt : Commons Jelly - commons-jelly-tags-ojb : Commons Jelly - db-ddlutils : Easy-to-use component for working with Database Definition (... - db-ojb : ObjectRelationalBridge - db-ojb-from-packages : ObjectRelationalBridge - maven-bootstrap : Project Management Tools - test-ojb : ObjectRelationalBridge Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-29122006.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 57 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-29122006 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29122006.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [junit] Running org.apache.commons.betwixt.TestOptions [junit] Testsuite: org.apache.commons.betwixt.TestOptions [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.238 sec [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.238 sec [junit] [junit] Testcase: testGetValue took 0.008 sec [junit] Testcase: testGetNames took 0.002 sec [junit] Testcase: testAddOptions took 0.002 sec [junit] Running org.apache.commons.betwixt.TestRSSRoundTrip [junit] Testsuite: org.apache.commons.betwixt.TestRSSRoundTrip [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.784 sec [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 20.784 sec [junit] [junit] Testcase: testRoundTrip took 20.537 sec [junit] Caused an ERROR [junit] my.netscape.com [junit] java.net.UnknownHostException: my.netscape.com [junit] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177) [junit] at java.net.Socket.connect(Socket.java:507) [junit] at java.net.Socket.connect(Socket.java:457) [junit] at sun.net.NetworkClient.doConnect(NetworkClient.java:157) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:365) [junit] at sun.net.www.http.HttpClient.openServer(HttpClient.java:477) [junit] at sun.net.www.http.HttpClient.init(HttpClient.java:214) [junit] at
[jira] Commented: (LANG-238) [lang] Add equals(type[]) to NumberUtils
[ http://issues.apache.org/jira/browse/LANG-238?page=comments#action_12461475 ] Paul Benedict commented on LANG-238: The rollback is correct, but that's because the implementation is wrong. The enhancement request is not to compare two arrays of whatever type, but to compare one array of values to make sure they contain the same value -- ala the max and min method signatures. Not: equals(int[], int[]) But: equals(int[]) [lang] Add equals(type[]) to NumberUtils Key: LANG-238 URL: http://issues.apache.org/jira/browse/LANG-238 Project: Commons Lang Issue Type: Improvement Affects Versions: Nightly Builds Environment: Operating System: other Platform: Other Reporter: Paul Benedict Priority: Minor Fix For: 2.3 It would be useful to add an equals() method like the current min and max methods which take an array type and determine if all the values are equal. I have found myself in need of this often. I have to retrieve objects from multiple data sources in parallel to build an array of complex object. To ensure validity, I always compare that my sub-retrievals returned the same number of objects as expected. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
