[email] Re: Apache Jakarta Commons Email 1.0 released
There is no mention of the v1.0 release of Commons Email listed in the "Latest Jakarta News" on http://jakarta.apache.org. It's not a big deal, but it would be nice if it were added. Henning Schmiedehausen wrote: The Commons Email team of the Jakarta Project of the ASF is happy to announce the release of Commons Email 1.0. Jakarta Commons Email provides an API for sending email. It is built on top of the Java Mail API, which it aims to simplify. While this is the first official release for Commons Email, the code itself has been available through the commons sandbox and the commons proper for a very long time and is considered mature and stable by the developers. Commons Email is available as source and binary from the Apache Mirror System through its download page at http://jakarta.apache.org/site/downloads/downloads_commons-email.cgi It will also be available from the Apache Maven repository at http://www.apache.org/dist/java-repository/ and the Maven main repository at http://www.ibiblio.org/maven/. Documentation, Javadocs and further information can be found at http://jakarta.apache.org/commons/email/ The Commons Email team - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Commons Status document
+1 Oliver Zeigermann wrote: Sounds good and useful. Oliver On 8/21/05, Henri Yandell <[EMAIL PROTECTED]> wrote: How about making a wiki page which lists every Commons component (proper and sandbox) with a status. Something like my http://www.generationjava.com/article/apache/StateOfTheSandbox.shtml but not 18 months out of date. It'd include things like: Working on 2.1 Releasing 1.0 Inactive Stable with N reported bugs Seem useful? Unless I hear -1's, I'll charge on with it at some point anyway, but mentioning here in case anyone wants to kick it off earlier. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [email] Someone on commons-email?
I've been casually following commons email on this list for the past few months and it's been pretty low traffic. If I remember correctly, someone mentioned that a release would be put out at the end of May, but it never happened. I've submitted two trivial patches for email a few weeks ago and I hope that they would be committed before a release - whenever it is. Ramiro Pereira de Magalhaes wrote: Hello folks! I just checked out the email project from the SVN repository (http://svn.apache.org/repos/asf/jakarta/commons/proper/email/trunk commons-email) and noticed that it's last commit has a timestamp from march! Is it right? The last change on this project was from 3 month ago? Also it seems that the last message sent to this mailing list was from this year's 28 january. Is someone maintaining this project? What needs to be done right now? Is the commons-email bug list abandonned? Looking forward to help, Ramiro Pereira de Magalhães Yahoo! Mail, cada vez melhor: agora com 1GB de espaço grátis! http://mail.yahoo.com.br - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] [EMAIL] Checkstyle errors cleaned up
I agree with you that breaking existing API's is a bad thing. However, the project is currently at 1.0-dev and the main page itself states: * The code is unreleased * Methods and classes can and will appear and disappear without warning While changing the API at this point is less than ideal, most people would accept that there exists a potential of change between 1.0-dev and 1.0. When it comes down to it, all we're talking about is changing a public method's return object from a Hashtable to a Map. This is likely the last opportunity to make this (trivial) change before the v1.0 release and it would then have to be postponed until 1.1 (or whatever). I think changing it now is in everyone's best interest. Although I disagree with you in this specific circumstance, you've got a great point in general. This weekend I plan to follow Corey's feedback and break the patch down into discrete parts, one for Checkstyle clean up and one for this code change. That way, the commiters have the freedom to decide if they want to break the API now or down the road. Thanks for the food for thought, Eric Eric Spiegelberg wrote: Matt Benson wrote: I just joined the list myself... (for sandbox commons-pgp) but I noticed that in the non-checkstyle changes from this patch, the signature of a public method is modified in at least one place. This will break already-compiled code running against the library. Over in Ant-land we consider that bad; I can only assume the same would be true in Jakarta commons. $0.02, Matt --- Corey Scott <[EMAIL PROTECTED]> wrote: Eric, Firstly, welcome... Secondly... thanks. There are two things that would like to suggest with your patch. First: Please try to break this patch down into discrete sections. i.e. one patch for formatting and one for each of the other changes. Second: Please submit your patch(es) to the bugzilla as files. This allows use to keep everything in one place. Again, welcome and thanks. Corey - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Discover Yahoo! Stay in touch with email, IM, photo sharing and more. Check it out! http://discover.yahoo.com/stayintouch.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] [EMAIL] Checkstyle errors cleaned up
I read on the user list that Commons Email is approaching a v1.0 release
and decided to take a look at the Maven reports to see how close it was
and what needed to be done. I'm always somewhat disappointed when the
reports reflect that things aren't as tight as I've come to expect from
Jakarta software. Instead of groaning, I decided to do the clean up
myself. I am submitting a patch that fixes 184 of the192 Checkstyle
errors in Commons Email.
The patch includes trivial refactoring to use the Map interface instead
of Hashtable. Other things such as cleaning up or adding missing
javadoc, cleaning indentation, curly braces, parenthesis, and removing
tabs and trailing spaces at the end of lines. The 8 remaining errors
indicate that the file does not end with a newline, which they do. I
assume this is an error with the Maven-Checkstyle plugin.
It's not glamorous and it's not going to set anyone's world on fire, but
I felt it would be nice to have a clean Checkstyle report for a v1.0
release. This is my first submission to Jakarta and I welcome any
feedback in order to make this patch accepted smoothly.
Thanks,
Eric Spiegelberg
Index: src/test/org/apache/commons/mail/EmailTest.java
===
--- src/test/org/apache/commons/mail/EmailTest.java (revision 169394)
+++ src/test/org/apache/commons/mail/EmailTest.java (working copy)
@@ -21,6 +21,8 @@
import java.util.Date;
import java.util.Enumeration;
import java.util.Hashtable;
+import java.util.Iterator;
+import java.util.Map;
import java.util.Properties;
import javax.mail.Authenticator;
@@ -1289,25 +1291,25 @@
//
// Test Success
//
-Hashtable ht = new Hashtable();
-ht.put("X-Priority", "1");
-ht.put("Disposition-Notification-To", "[EMAIL PROTECTED]");
-ht.put("X-Mailer", "Sendmail");
+Map m = new Hashtable();
-Enumeration enumKey = ht.keys();
+m.put("X-Priority", "1");
+m.put("Disposition-Notification-To", "[EMAIL PROTECTED]");
+m.put("X-Mailer", "Sendmail");
-while (enumKey.hasMoreElements())
+Iterator iterKey = m.keySet().iterator();
+while (iterKey.hasNext())
{
-String strName = (String) enumKey.nextElement();
-String strValue = (String) ht.get(strName);
+String strName = (String) iterKey.next();
+String strValue = (String) m.get(strName);
this.email.addHeader(strName, strValue);
}
-assertEquals(ht.size(), this.email.getHeaders().size());
-assertEquals(ht, this.email.getHeaders());
+assertEquals(m.size(), this.email.getHeaders().size());
+assertEquals(m, this.email.getHeaders());
}
-
+
/** */
public void testAddHeaderEx()
{
Index: src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java
===
--- src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java
(revision 169394)
+++ src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java
(working copy)
@@ -15,8 +15,8 @@
*/
package org.apache.commons.mail.mocks;
-import java.util.Hashtable;
import java.util.List;
+import java.util.Map;
import javax.mail.Authenticator;
import javax.mail.Session;
@@ -128,7 +128,7 @@
/**
* @return headers
*/
-public Hashtable getHeaders()
+public Map getHeaders()
{
return this.headers;
}
Index: src/java/org/apache/commons/mail/EmailException.java
===
--- src/java/org/apache/commons/mail/EmailException.java(revision
169394)
+++ src/java/org/apache/commons/mail/EmailException.java(working copy)
@@ -1,7 +1,7 @@
/*
* Copyright 2001-2004 The Apache Software Foundation
*
- * Licensed under the Apache License, Version 2.0 ( the "License" );
+ * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
@@ -21,25 +21,25 @@
* EmailException
* @author jakarta-commons
*/
-public class EmailException extends NestableException
+public class EmailException extends NestableException
{
/** */
public EmailException()
{
super();
}
-
+
/**
- *
+ *
* @param msg msg
*/
public EmailException(String msg)
{
super(msg);
}
-
+
/**
- *
+ *
* @param msg msg
* @param cause cause
*/
@@ -
