Patch for DiskFileItem.java

2006-03-27 Thread Sven Schliesing

Hi,

I've been reviewing the code of the commons "FileUpload" package and 
would like to contribute a patch. This is no big thing, but some cleanup.


First of all, is this the right list for contributing patches?

Thanks in advance,

Sven

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: validator: email-validation not accepting german "umlaute"

2004-04-20 Thread Sven Schliesing

Runs with success. So the address "[EMAIL PROTECTED]" is validated by the 
EmailValidator with success.
never mind, wrong charset in eclipse.
thanks anyway
Sven

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: validator: email-validation not accepting german "umlaute"

2004-04-20 Thread Sven Schliesing
I wrote a test to make sure where the problem is:

public class ValidatorTest extends TestCase {
public void testEmail() {
EmailValidator emailValidator = EmailValidator.getInstance();
boolean result = emailValidator.isValid("[EMAIL PROTECTED]");
assertTrue("invalid email", result);
}
}
Runs with success. So the address "[EMAIL PROTECTED]" is validated by the 
EmailValidator with success.

Seems that the problem is with struts. I also explicitly set the charset 
in the struts-config:



No change.

Any other ideas?

Michael Davey wrote:
 > Valid domain names must contain only the characters a-z, A-Z, 0-9, "."
and "-".  They must start with a letter and end with
a letter or digit.  The "." symbol is used exclusively to seperate 
subdomains (see RFC 1035 section 2.3.1 
).

To support internationalised domain names (IDN), both the client and the 
server must be punycode aware.  Punycode is a fairly new standards 
proposal (rfc3492) that encodes non-ascii characters into an ascii 
string, prefixed with "xn--".  For instance, müller.de is encoded as 
xn--mller-kva.de.



Commons-Validator would need to be made Punycode-aware to achieve what 
you need, or alternatively, you could do the punycode translation in 
your own code, before passing the string to validator.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


validator: email-validation not accepting german "umlaute"

2004-04-20 Thread Sven Schliesing
As for version 1.1.1 the Jakarta Commons-Validator is not accepting 
german "umlaute" as parts of valid domain names like müller.de or münchen.de

Is this a known issue in validator or might this be a setting in Struts?

Thanks!

Sven Schliesing

PS: No problems with "umlaute" and struts in other parts.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]