DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|commons-|[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2006-04-09 21:13 ---
Created an attachment (id=18048)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18048&action=view)
Candidate replacement 3 - from Steve Cohen

henrik - please have a look at this file.  I believe it does basically the same
thing as yours albeit in a much different way.  We use
CompositeFileEntryParser, which delegates to two internal classes, one for the
"Memberlist" and one for the "FileList".  Anything else is rejected.  It uses
regexes, which, once you get over the hump, add clarity to the process.

I don't want to commit this until you have had a chance to test it in your
environment.  Also, this breaks existing JUnit tests which, in my opinion,
weren't very robust anyway.  If you understand JUnit, please have a look and
see what you can do.  If you don't understand JUnit, could you please attach
lists of good and bad listings that we can work into a test?

As per earlier note, this FileList parser doesn't do anything with the date,
which I believe has "last access" semantics, not "last modified" semantics,
which is what we need for the date to be of value.

Please send me your comments, and thanks for your contributions, without which
mine would not have been possible.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-04-08 23:44 ---
henrik - one thing I notice in your code compared with the previous - in the
"FILELIST" mode, according to the guy who contributed the previous code, the
"date" field is a "Date Last Accessed" and therefore not suitable for the
timestamp field of FTPFile which assumes "Date Modified" semantics (for example
the FTP tasks of Ant will use this for "newer" comparisons.  Do you know if he
was right?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-04-08 17:16 ---
Thanks very much for your comments on this OS.  They help me to finally
understand what it is we are working with here.


OK, here's what I think we'll do.  I just noticed upthread your "I am not a java
programmer" which explains why you're not using the regex thing, and a few other
things I'd wondered about that a java programmer might know about but you may
not.  I wouldn't expect you to write JUnit tests for example as a non-java
programmer. 

Let me have a whack at what you have done.  Now that I understand the code, I
can probably find the best way to fit it into our system.  Then I'll send it
back to you for testing, and we'll work collaboratively.  Does that sound okay
to you?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17989|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-04-07 12:17 ---
Created an attachment (id=18038)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18038&action=view)
MVSFTPEntryParser.java replacement v2.

this is a much cleaned up version of the MVSFTP parser.
TODO:
- make it configurable
- figure out how to report errors

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-04-05 19:36 ---
this is my current comments in my working version of MVSFTPEntryParser.java. 
 
try to read it and let know if it is understandable. 
 
/* 
 * Very brief and imcomplete description of the zOS/MVS-filesystem.  
 * (Note: "zOS" is the operating system on the mainframe,  
 *and is the new name for MVS) 
 *  
 * The filesystem on the mainframe does not have hierarchal structure as  
 * for example the unix filesystem. 
 * For a more comprehensive description, please refer to the IBM manuals 
 * @LINK:www.ibm 
 *  
 * Dataset names 
 * = 
 *  
 * A dataset name consist of a number of qualifiers separated by '.', 
 * each qualifier can be at most 8 characters, and the total length 
 * of a dataset can be max 44 characters including the dots. 
 *  
 *  
 * Dataset organisation 
 *  
 *  
 * A dataset represents a piece of storage allocated on one or more disks.  
 * The structure of the storage is described with the field dataset  
organinsation (DSORG). 
 * There are a number of dataset organisations, but only two are usable for FTP 
transfer. 
 *  
 * DSORG: 
 * PS: sequential, or flat file 
 * PO: partitioned dataset 
 * PO-E: extended partitioned dataset 
 *  
 * The PS file is just a flat file, as you would find it on the unix 
 * file system. 
 *  
 * The PO and PO-E files, can be compared to a single level directory  
structure. 
 * A PO file consist of a number of dataset members, or files if you 
 * will. It is possible to CD into the file, and to retrieve the  
 * individual members. 
 *  
 *  
 * Dataset record format 
 * = 
 *  
 * The physical layout of the dataset is described on the dataset itself. 
 * There are a number of record formats (RECFM), but just a few is relavant for 
 
 * the FTP transfer. 
 *  
 * Any one beginning with either F or V can safely used by FTP transfer. 
 * All others should only be used with great care. 
 * F means a fixed number of records per allocated storage, and V means a 
variable  
 * number of records. 
 *  
 *  
 * Other notes 
 * === 
 * 
 * The file system supports automatically backup and retrieval of datasets. If 
a 
 * file is backed up, the ftp LIST command will return: 
 * ARCIVE Not Direct Access DeviceKJ.IOP998.ERROR.PL.UNITTEST 
 * 
 * 
 * Implementation notes 
 *  
 * 
 * Only datasets that have dsorg PS, PO or PO-E and have recfm  
 * beginning with F or V, is fully parsed. 
 *  
 * The following fields in FTPFile is used: 
 * FTPFile.Rawlisting: Always set. 
 * FTPFile.Type: DIRECTORY_TYPE or FILE_TYPE or UNKNOWN or null 
 * FTPFile.Name: name or null 
 * FTPFile.Timestamp: create time or null 
 *  
 */ 
 
 
 
/* Format of ZOS/MVS file list: 
 * 01 2  345  6 78 9  
 * Volume UnitReferred Ext Used Recfm Lrecl BlkSz Dsorg Dsname 
 * B10142 3390   2006/03/20  2   31  F   8080  PS  MDI.OKL.WORK 
 * ARCIVE Not Direct Access Device KJ.IOP998.ERROR.PL.UNITTEST 
 * B1N231 3390   2006/03/20  1   15  VB 256 27998  PO   PLU 
 * B1N231 3390   2006/03/20  1   15  VB 256 27998  PO-E PLB 
 *  
 */ 
 /* --- 
  * [0] Volume 
  * [1] Unit 
  * [2] Referred 
  * [3] Ext: number of extents 
  * [4] Used 
  * [5] Recfm: Record format 
  * [6] Lrecl: Logical record length 
  * [7] BlkSz: Block size 
  * [8] Dsorg: Dataset organisation. Many exists but only support: PS, PO, PO-E 
  * [9] Dsname: Dataset name 
  *  
  * Note: When volume is ARCIVE, it means the dataset is stored somewhere in 
  *   a tape archive. These entries is currently not supported by this 
  *   parser. A null value is returned. 
  *
  *  
  */ 
// dsorg last two tokens describe file: 
// 'PS': sequential file 
// 'PO': partioned dataset PDS 
// 'PO-E': PDS Library 
// '  ': unknown, probably archived. 

/* 
 * Format of a PDS: 
 *0 12  34 5 6  78 
 *   Name  VV.MM   Created   Changed  Size  Init   Mod   Id 
 *   TBSHELF   01.03 2002/09/12 2002/10/11 09:371111 0 KIL001 
 *   TBTOOL01.12 2002/09/12 2004/11/26 19:545128 0 KIL001 
 *  
 */ 
/* 
 * [0] Name 
 * [1] VV.MM: Version . modification 
 * [2] Created:  / MM / dd 
 * [3,4] Changed:  / MM / dd  HH:mm 
 * [5] Size: number of lines 
 * [6] Init: number of lines when first created 
 * [7] Mod: number of modified lines a last save 
 * [8] Id: User id for last update 
 *  
 */ 
 

-- 
Configure bugmail: http://issues.apac

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-03-31 03:48 ---
To answer your question, I guess your choices are

1.  Redo your code to use Regular Expressions and inherit from
ConfigurableFTPFileEntryParserImpl which would be my recommendation.

2.  If really don't want to use regex or it's impossible to write the parser
this way (i can't tell from your patch), then you should probably inherit from
FTPFileEntryParserImpl 

As far as copyright goes, just start with what's in MVSFTPEntryParser.java.  You
can change every line of code after that if you like.

However, it looks like you still have some work to do.  Your code, I see, still
has TODOs in it.  If you're going to change the parser implementation, let's get
as complete an implementation as you can.  

Out of curiosity, would you mind also explaining for our benefit what these ZOS
and PDS things are?  Comments might be a good place to do that.  This OS is much
different from many of the others we handle.

Finally, don't forget the JUnit tests.  Please do not submit your patch until
all existing tests pass.  And please add more tests that exercise the new
functionalities you are adding.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-03-28 20:53 ---
thanks for taking this into consideration.
I am more than willing to get this committed, so what is the process ?

Must the copyright be assigned to Apache.org, and is so what are the paper work
needed for this ?

For the code ...
Since I do not use the Regex for the file name parsing, which FtpParserImpl
should be extended ?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109





--- Additional Comments From [EMAIL PROTECTED]  2006-03-28 02:22 ---
You are quite correct.  I remember thinking the same thing when this code was
submitted.  However, it filled the needs of the original author and was better
than nothing.  

None of the committers has access to an MVS system or any knowledge of it, as
you apparently do.  And so, the bottom line is, we humbly request you, in the
spirit of Open Source, to contribute a fully implemented parser, since you have
the expertise.  We'll be happy to commit such a contribution if you submit it,
and help you get it done if you aren't familiar with the process.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39109] - [net] MVSFTPEntryParser.java only halfway implemented

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39109


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Keywords||PatchAvailable
Summary|MVSFTPEntryParser.java only |[net] MVSFTPEntryParser.java
   |halfway implemented |only halfway implemented




--- Additional Comments From [EMAIL PROTECTED]  2006-03-27 05:04 ---
added [net] to summary, and keyword PatchAvailable

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]