Re: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Mario Ivankovits

Phil Steitz wrote:

Has now been fixed in svn.
So if you checkout the latest maven 1 dist plugin sources from
http://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk/dist/
and then do
maven plugin:install from the dist plugin directory, maven dist will
put windows style line endings in the zips.
 

Thanks!

But it was a challenge to install.
I had to remove the assert:assertPluginAvailable tag from plugin.jelly 
and to build plugin-xdoc too, to make it work with maven 1.0.2.


BTW: I tried to build maven 1.1 but its tests failed, so I gave up.

Now dist fixes *.txt files, but I thought it should fix *.java too, 
shouldnt it?



---
Mario


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Arnaud HERITIER
Hi Mario,

For the assert:assertPluginAvailable tag you need the last 
plugin-plugin. Sorry, we'll try to simplify this ASAP.

For maven 1.1, did you try the bootstrap ? What is the error ? Can you 
send it to me please.

I will publish in some minutes a new snapshot for the dist plugin. 
You'll be able to retreive it with :

maven plugin:download -Dmaven.repo.remote=http://cvs.apache.org/repository/ 
-DgroupId=maven -DartifactId=maven-dist-plugin
-Dversion=1.7-SNAPSHOT 

I'm agree for *.java in sources. Can you open an issue please ?

Arnaud



 

 -Message d'origine-
 De : Mario Ivankovits [mailto:[EMAIL PROTECTED] 
 Envoyé : lundi 14 novembre 2005 09:37
 À : Jakarta Commons Developers List
 Objet : Re: [maven] dist plugin for zip-crlf conversation 
 (was: [vfs][VOTE] release version 1.0)
 
 Phil Steitz wrote:
 Has now been fixed in svn.
 So if you checkout the latest maven 1 dist plugin sources from 
 http://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk/dist/
 and then do
 maven plugin:install from the dist plugin directory, maven dist will 
 put windows style line endings in the zips.
   
 Thanks!
 
 But it was a challenge to install.
 I had to remove the assert:assertPluginAvailable tag from 
 plugin.jelly and to build plugin-xdoc too, to make it work 
 with maven 1.0.2.
 
 BTW: I tried to build maven 1.1 but its tests failed, so I gave up.
 
 Now dist fixes *.txt files, but I thought it should fix 
 *.java too, shouldnt it?
 
 
 ---
 Mario
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Phil Steitz
On 11/14/05, Arnaud HERITIER [EMAIL PROTECTED] wrote:
 Hi Mario,

For the assert:assertPluginAvailable tag you need the last 
 plugin-plugin. Sorry, we'll try to simplify this ASAP.

For maven 1.1, did you try the bootstrap ? What is the error ? Can you 
 send it to me please.

I will publish in some minutes a new snapshot for the dist plugin. 
 You'll be able to retreive it with :

 maven plugin:download -Dmaven.repo.remote=http://cvs.apache.org/repository/ 
 -DgroupId=maven -DartifactId=maven-dist-plugin
 -Dversion=1.7-SNAPSHOT

I'm agree for *.java in sources. Can you open an issue please ?

That will screw up diffs, won't it?  Probably best to leave the
sources along and just apply to .txt files, as the current version
does.

Phil

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Stephen Colebourne

Phil Steitz wrote:

That will screw up diffs, won't it?  Probably best to leave the
sources along and just apply to .txt files, as the current version
does.
Not sure about that. When I use subversion to get files they end up with 
Windows EOL. I think thats what we are trying to replicate.


Stephen


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Phil Steitz
On 11/14/05, Stephen Colebourne [EMAIL PROTECTED] wrote:
 Phil Steitz wrote:
  That will screw up diffs, won't it?  Probably best to leave the
  sources along and just apply to .txt files, as the current version
  does.
 Not sure about that. When I use subversion to get files they end up with
 Windows EOL. I think thats what we are trying to replicate.

We should be consistent in any case.  Right now the Ant build for
[collections] does this:

fixcrlf srcdir=${build.dist.src.work} eol=crlf
includes=*.txt,*.properties /
and [io] does this
fixcrlf srcdir=${dist.src} eol=crlf
includes=*.txt,*.xml,*.css,*.properties /

Neither appear to mess with the java sources.  Do many people open the
java files in windows editors not capable of handling lf line endings?

Could be the right solution for the maven dist plugin is to expose a
property that holds the filter.

Phil

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [maven] dist plugin for zip-crlf conversation (was: [vfs][VOTE] release version 1.0)

2005-11-14 Thread Arnaud HERITIER
Yes, it could be a good idea to have a property to define the filter for files 
to change EOL.
Is there someone who can open an issue ? I'll do it in the next days.

Arnaud

 -Message d'origine-
 De : Phil Steitz [mailto:[EMAIL PROTECTED] 
 Envoyé : mardi 15 novembre 2005 06:32
 À : Jakarta Commons Developers List
 Objet : Re: [maven] dist plugin for zip-crlf conversation 
 (was: [vfs][VOTE] release version 1.0)
 
 On 11/14/05, Stephen Colebourne [EMAIL PROTECTED] wrote:
  Phil Steitz wrote:
   That will screw up diffs, won't it?  Probably best to leave the 
   sources along and just apply to .txt files, as the 
 current version 
   does.
  Not sure about that. When I use subversion to get files they end up 
  with Windows EOL. I think thats what we are trying to replicate.
 
 We should be consistent in any case.  Right now the Ant build 
 for [collections] does this:
 
 fixcrlf srcdir=${build.dist.src.work} eol=crlf
 includes=*.txt,*.properties /
 and [io] does this
 fixcrlf srcdir=${dist.src} eol=crlf
 includes=*.txt,*.xml,*.css,*.properties /
 
 Neither appear to mess with the java sources.  Do many people 
 open the java files in windows editors not capable of 
 handling lf line endings?
 
 Could be the right solution for the maven dist plugin is to 
 expose a property that holds the filter.
 
 Phil
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]