Re: [sandbox/i18n] Could sombody commit my JDBC provider?
Haven't heard from Daniel this week either. I would be glad if James
(or anybody else with sandbox access) would care to review and commit
the following patches:
- "Maven settings to fix problems with JCoverage on JDK 1.5",
http://issues.apache.org/bugzilla/attachment.cgi?id=15665
- "Fix for character encoding issue in test case",
http://issues.apache.org/bugzilla/attachment.cgi?id=15667
- "Issue 6: JDBC/database MessageProvider",
http://issues.apache.org/bugzilla/attachment.cgi?id=15743
Regarding the other patches, I think we need to wait another while to
see if Daniel gets back to discuss the "Return null when id is found
but entry is not", and the remaining two ("Issue 3: Removing
semi-circular dependies", "Issue 7: Example with JDBC and qualified
provider") are diffed agains that version, so...
Thanks in advance,
Mattias Jiderhamn
At 2005-07-14 17:59, James Mitchell wrote:
If you don't hear anything back in a few days from Daniel or others,
I'll make the changes.
--
James Mitchell
On Jul 14, 2005, at 1:41 AM, Mattias Jiderhamn wrote:
As you may have noticed, I chose to create a Bugzilla entry (35726,
http://issues.apache.org/bugzilla/show_bug.cgi?id=35726), where I
intend to post the patches for the remaining issues, so that they
are readily available to anyone.
At 2005-07-13 22:35, Mattias Jiderhamn wrote:
I haven't heard from Daniel Florey for a while now, so my guess is
he is on vacation. Therefore I wonder if there is somebody else
with sandbox commit access that could commit my patch below,
adding a JDBC/database MessageProvider to the i18n component.
I intend to continue working on the remaining issues (as of e-mail
on 2005-06-18) and I would prefer to separate the different issues
into different patches/commits, rather than one big "my
contributions".
If needed for correct encoding/line breaks, I could e-mail a
zipped diff to somebody privately, or create a Bugzilla entry.
Thanks in advance.
Mattias Jiderhamn
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [sandbox/i18n] Could sombody commit my JDBC provider?
If you don't hear anything back in a few days from Daniel or others,
I'll make the changes.
--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
http://www.edgetechservices.net/
678.910.8017
AIM: jmitchtx
Yahoo: jmitchtx
MSN: [EMAIL PROTECTED]
Skype: jmitchtx
On Jul 14, 2005, at 1:41 AM, Mattias Jiderhamn wrote:
As you may have noticed, I chose to create a Bugzilla entry (35726,
http://issues.apache.org/bugzilla/show_bug.cgi?id=35726), where I
intend to post the patches for the remaining issues, so that they
are readily available to anyone.
At 2005-07-13 22:35, Mattias Jiderhamn wrote:
I haven't heard from Daniel Florey for a while now, so my guess is
he is on vacation. Therefore I wonder if there is somebody else
with sandbox commit access that could commit my patch below,
adding a JDBC/database MessageProvider to the i18n component.
I intend to continue working on the remaining issues (as of e-mail
on 2005-06-18) and I would prefer to separate the different issues
into different patches/commits, rather than one big "my
contributions".
If needed for correct encoding/line breaks, I could e-mail a
zipped diff to somebody privately, or create a Bugzilla entry.
Thanks in advance.
Mattias Jiderhamn
Here is the patch:
Index: project.properties
===
--- project.properties (revision 201952)
+++ project.properties (working copy)
@@ -28,3 +28,8 @@
# M A V E N J A R O V E R R I D E
#
-
---
maven.jar.override = on
+
+
+# Set target to Java 1.4, since JCoverage does not work with Java
1.5
+maven.compile.source=1.4
+maven.compile.target=1.4
\ No newline at end of file
Index: project.xml
===
--- project.xml (revision 201952)
+++ project.xml (working copy)
@@ -74,6 +74,23 @@
+
+
+hsqldb
+1.7.3.3
+
+
+commons-dbcp
+1.2.1
+
+
+commons-pool
+1.2
+
+
+commons-collections
+2.1.1
+
Index: src/test/org/apache/commons/i18n/I18nUtilsTest.java
===
--- src/test/org/apache/commons/i18n/I18nUtilsTest.java (revision 0)
+++ src/test/org/apache/commons/i18n/I18nUtilsTest.java (revision 0)
@@ -0,0 +1,45 @@
+/*
+*
+*
+*
+* Copyright 2004 The Apache Software Foundation
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+* See the License for the specific language governing permissions
and
+* limitations under the License.
+*
+*/
+package org.apache.commons.i18n;
+
+import junit.framework.TestCase;
+
+import java.util.Locale;
+
+/**
+ * @author Mattias Jiderhamn
+ */
+public class I18nUtilsTest extends TestCase {
+public void testGetParentLocale() {
+assertEquals("Language, country and variant",
+new Locale("en", "GB"),
+I18nUtils.getParentLocale(new Locale("en", "GB",
"scottish")));
+
+assertEquals("Language and country",
+Locale.ENGLISH,
+I18nUtils.getParentLocale(new Locale("en", "GB")));
+
+assertEquals("Language and variant",
+Locale.ENGLISH,
+I18nUtils.getParentLocale(new Locale("en", "",
"scottish")));
+
+assertNull("Language only", I18nUtils.getParentLocale
(Locale.ENGLISH));
+}
+}
Index: src/test/org/apache/commons/i18n/
ResourceBundleMessageProviderTest.java
===
--- src/test/org/apache/commons/i18n/
ResourceBundleMessageProviderTest.java (revision 201952)
+++ src/test/org/apache/commons/i18n/
ResourceBundleMessageProviderTest.java (working copy)
@@ -137,7 +137,7 @@
Map germanEntries = new ResourceBundleMessageProvider
("messageBundle").getEntries("helloWorld", Locale.GERMAN);
assertEquals("No of entries", 3, germanEntries.size());
assertEquals("Hallo Welt", germanEntries.get("title"));
-assertEquals("Ich w�nsche Dir alles Gute und ein frohes
Fest!", germanEntries.get("text"));
+assertEquals("Ich wünsche Dir alles Gute und ein frohes
Fest!", germanEntries.get("text"));
assert
Re: [sandbox/i18n] Could sombody commit my JDBC provider?
As you may have noticed, I chose to create a
Bugzilla entry (35726,
http://issues.apache.org/bugzilla/show_bug.cgi?id=35726),
where I intend to post the patches for the
remaining issues, so that they are readily available to anyone.
At 2005-07-13 22:35, Mattias Jiderhamn wrote:
I haven't heard from Daniel Florey for a while
now, so my guess is he is on vacation. Therefore
I wonder if there is somebody else with sandbox
commit access that could commit my patch below,
adding a JDBC/database MessageProvider to the i18n component.
I intend to continue working on the remaining
issues (as of e-mail on 2005-06-18) and I would
prefer to separate the different issues into
different patches/commits, rather than one big "my contributions".
If needed for correct encoding/line breaks, I
could e-mail a zipped diff to somebody privately, or create a Bugzilla entry.
Thanks in advance.
Mattias Jiderhamn
Here is the patch:
Index: project.properties
===
--- project.properties (revision 201952)
+++ project.properties (working copy)
@@ -28,3 +28,8 @@
# M A V E N J A R O V E R R I D E
#
maven.jar.override = on
+
+
+# Set target to Java 1.4, since JCoverage does not work with Java 1.5
+maven.compile.source=1.4
+maven.compile.target=1.4
\ No newline at end of file
Index: project.xml
===
--- project.xml (revision 201952)
+++ project.xml (working copy)
@@ -74,6 +74,23 @@
+
+
+hsqldb
+1.7.3.3
+
+
+commons-dbcp
+1.2.1
+
+
+commons-pool
+1.2
+
+
+commons-collections
+2.1.1
+
Index: src/test/org/apache/commons/i18n/I18nUtilsTest.java
===
--- src/test/org/apache/commons/i18n/I18nUtilsTest.java (revision 0)
+++ src/test/org/apache/commons/i18n/I18nUtilsTest.java (revision 0)
@@ -0,0 +1,45 @@
+/*
+*
+*
+*
+* Copyright 2004 The Apache Software Foundation
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*
+*/
+package org.apache.commons.i18n;
+
+import junit.framework.TestCase;
+
+import java.util.Locale;
+
+/**
+ * @author Mattias Jiderhamn
+ */
+public class I18nUtilsTest extends TestCase {
+public void testGetParentLocale() {
+assertEquals("Language, country and variant",
+new Locale("en", "GB"),
+I18nUtils.getParentLocale(new
Locale("en", "GB", "scottish")));
+
+assertEquals("Language and country",
+Locale.ENGLISH,
+I18nUtils.getParentLocale(new Locale("en", "GB")));
+
+assertEquals("Language and variant",
+Locale.ENGLISH,
+I18nUtils.getParentLocale(new Locale("en", "", "scottish")));
+
+assertNull("Language only",
I18nUtils.getParentLocale(Locale.ENGLISH));
+}
+}
Index: src/test/org/apache/commons/i18n/ResourceBundleMessageProviderTest.java
===
---
src/test/org/apache/commons/i18n/ResourceBundleMessageProviderTest.java
(revision 201952)
+++
src/test/org/apache/commons/i18n/ResourceBundleMessageProviderTest.java
(working copy)
@@ -137,7 +137,7 @@
Map germanEntries = new
ResourceBundleMessageProvider("messageBundle").getEntries("helloWorld",
Locale.GERMAN);
assertEquals("No of entries", 3, germanEntries.size());
assertEquals("Hallo Welt", germanEntries.get("title"));
-assertEquals("Ich w�nsche Dir alles
Gute und ein frohes Fest!", germanEntries.get("text"));
+assertEquals("Ich wünsche Dir alles
Gute und ein frohes Fest!", germanEntries.get("text"));
assertEquals("This entry is not
translated to any other languages", germanEntries.get("notTranslated"));
Map frenchEntries = new
ResourceBundleMessageProvider("messageBundle").getEntries("helloWorld",
Locale.FRENCH);
Index: src/test/org/apache/commons/i18n/JdbcMessageProviderTest.java
===
---
src/test/org/apache/commons/i18n/JdbcMessageProviderTe
