DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 13:35 ---
Patch committed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 13:06 ---
It does not affect it at all. I believe the patch is good to go now 

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 12:59 ---
gah... You're right.  Your changes make sense and looks good to me.

Oleg, how does this affect your reorganisation of that method?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 12:52 ---
Created an attachment (id=6912)
patch 3

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 12:52 ---
This patch does not work in the absence of keep-alive headers.  I will attach a fix 
for this plus 
some more test cases in a moment.  This patch just moves the content length test to 
the top of 
shouldCloseConnection().

Mike

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 10:22 ---
Sure. Let Mike take a look. As far as I am concerned all the issues have been 
addressed. I would like to streamline HttpMethodBase#getResponseContentLength() 
method a bit, but I'll submit it as a separate incremental patch

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 10:17 ---
Good point, my mind is now at ease.  :)  Any other issues you can see?  I'd like to 
wait for Mike to 
take a look at the patch before committing it anyway since he'd been looking into the 
problem 
earlier.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 10:03 ---
Adrian,
My rationale is that by the time decision needs to be made whether the
connection is to be closed, an invalid 'Transfer-Encoding' or 'Content-Length'
header would already have caused an exception. I would even go as far as saying
that the check would be sufficient

+  if (responseHeaders.getFirstHeader("Transfer-Encoding") == null &&
+  responseHeaders.getFirstHeader("Content-Length") == null) {
+  LOG.debug("Should close connection as content-length is missing.");
+  return true;
+  }

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 09:40 ---
Created an attachment (id=6910)
Take 3.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 09:36 ---
Yeah, I didn't like the flag much either (and I never understood why you'd recycle 
methods) but 
didn't really like blindly assuming that the transfer encoding header was right.  I'm 
happy with it if 
you are though.  New patch coming soon.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 09:25 ---
Adrian,
I do not like that darn 'isChunked' flag. Besides, you forget to reset it in
HttpMethodBase#recycle. (I DO get convinced that the whole idea of recycling is
evil after all).

I suggest that you just check for presence of 'Transfer-Encoding' or
'Content-Length' header in response. That is it. Do not even parse them. We can
assume that the headers will be correctly reacted upon elsewhere.

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 09:14 ---
Patch take 2 features:

1. Works with chunked encoding.
2. A test case for chunked encoding.
3. Everything that was in take 1.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 09:13 ---
Created an attachment (id=6909)
Fix take 2.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 07:30 ---
doh...  Do we not have test cases for that?  I guess that's something else to add.  
I'll take another 
shot at it tonight.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-20 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 07:27 ---
Adrian,
I am afraid the patch will break support for chunk-encoded responses.
Chunk-encoded responses use 'Transfer-Encoding' header instead of
'Content-Length' header. The patch in its existing form will cause connections
to be dropped after a chunk-encoded response is received.
Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20938] - Missing Content-Length header causes a SocketException

2003-06-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20938

Missing Content-Length header causes a SocketException





--- Additional Comments From [EMAIL PROTECTED]  2003-06-20 05:35 ---
Created an attachment (id=6906)
Fix take 1

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]