DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess





--- Additional Comments From [EMAIL PROTECTED]  2003-09-11 07:03 ---
I just looked at the patch very closely. And I found thing which I don't like:

Handling of the qop Parameter is fishy. qop can be auth or auth-int or
auth,auth-int or not present.

The patch does not support auth-int at all.
Moreover it removes support for the case where qop is not present.

I will try and add adequate auth-int support while supporting the non-present
qop case as well. Test cases will follow.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess





--- Additional Comments From [EMAIL PROTECTED]  2003-09-11 08:11 ---
Are you certain?  The only thing I see in the patch related to qop is logging when the 
qop was not 
provided.  Other than that, it's the original implementation.

I admit that I did not add support for the other two qop methods as I don't have 
anything against 
which I could confidentally test, however, I believe this patch only adds 
functionality and does not 
remove any.

Please correct me if I'm wrong.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess





--- Additional Comments From [EMAIL PROTECTED]  2003-09-08 08:01 ---
No objections from me. I believe it is good to be included into 2.0 release as 
well. 

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess





--- Additional Comments From [EMAIL PROTECTED]  2003-09-08 16:34 ---
Not to argue feature/bugfix, but I think there was an actual bug here which is
what got me looking in the first place.

The server I was accessing was trying to negotiate the MD5-sess algorithm which
was silently ignored and the client responded with an MD5 algorithm which caused
a ``Bad request'' response from the server.

I'd suggest that if this does not go into 2.0, that 2.0 at least log a warning
when the algorithm is not MD5.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||commons-httpclient-
   ||[EMAIL PROTECTED]
 AssignedTo|commons-httpclient- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |



--- Additional Comments From [EMAIL PROTECTED]  2003-09-08 16:47 ---
If no objections arrive within 24 hours from now I will commit it to 2.0 branch
and HEAD then.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926

[patch] Support for digest auth MD5-sess





--- Additional Comments From [EMAIL PROTECTED]  2003-09-07 18:56 ---
I believe the patch is good to be committed. The question remains, though, if
the patch should be applied to HEAD only or to 2.0 branch and HEAD. Opinions?

Oleg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]