DO NOT REPLY [Bug 31680] - DefaultHttpParamsFactory.getDefaultParams() is not thread safe

2004-10-13 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31680

DefaultHttpParamsFactory.getDefaultParams() is not thread safe





--- Additional Comments From [EMAIL PROTECTED]  2004-10-13 20:37 ---
Yes, calling createParams() twice is ok.  This is a bug about assigning to a 
reference variable which is shared between threads without using 
synchronization.  That can have what the Java Language Specification Chapter 
17 calls "surprising" consequences.  Thanks for synchronizing it.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31680] - DefaultHttpParamsFactory.getDefaultParams() is not thread safe

2004-10-12 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31680

DefaultHttpParamsFactory.getDefaultParams() is not thread safe

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-10-13 00:59 ---
Patch applied to HEAD.

Mike

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31680] - DefaultHttpParamsFactory.getDefaultParams() is not thread safe

2004-10-12 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31680

DefaultHttpParamsFactory.getDefaultParams() is not thread safe





--- Additional Comments From [EMAIL PROTECTED]  2004-10-13 00:52 ---
Thanks for filing a bug report.

If I remember correctly this method was intentionally left unsynchronized since 
calling createParams() 
more than once has no real negative side effects. Having said that it does seems 
somewhat unclean to 
leave this open.  I'll make getDefaultParams() synchronized in CVS shortly.

Mike

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]