Re: [concordance-devel] Bug 1898492 - no one else affected, or just not interested?
Andreas Schulz wrote: > no, you didn't - here it comes... I tweaked it a bit (you'd been waiting so long on this patch, I figured I'd just tweak it for you rather than have you re-submit) to make it more consistent with the rest of the code - we just use rsp[68] instead of stop_rsp - and since we had one already, I changed its scope slightly so we could re-use it. Applied, thanks. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming signature.asc Description: OpenPGP digital signature - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Bug 1898492 - no one else affected, or just not interested?
On Monday 31 March 2008, Phil Dibowitz wrote:
> Phil Dibowitz wrote:
> > 1. It's generated against 0.13, but CVS has changed DRASTICALLY since
> > then - can you please re-gen against CVS, and also check our new
> > SubmittingPatches file for further details.
done (hopefully conforming the rules now - just left out all the local ?files
from the cvs diff)
> > 3. Why do you comment out the 'else if (r == RESPONSE_DONE) {' ? While we
> > shouldn't get this in the middle of things, it's certainly bad if we do,
> > and a good reason to stop - I'd prefer we leave that check in.
OK - left it in
> > 4. Can you add braces to your outer iff statement for me?
done
> > If you could re-submit a patch (to the list, please), with the above
> > changes, I'd appreciate it. The idea behind the patch looks solid to me.
>
> Andreas,
>
> I never saw you re-submit this patch - did I miss it?
no, you didn't - here it comes...
Index: libconcord/remote.cpp
===
RCS file: /cvsroot/concordance/concordance/libconcord/remote.cpp,v
retrieving revision 1.26
diff -u -3 -p -u -p -r1.26 remote.cpp
--- libconcord/remote.cpp 30 Mar 2008 23:59:48 - 1.26
+++ libconcord/remote.cpp 1 Apr 2008 07:21:26 -
@@ -782,6 +782,15 @@ int CRemote::LearnIR(string *learn_strin
const static uint8_t stop_ir_learn[] = { 0x00, COMMAND_STOP_IRCAP };
HID_WriteReport(stop_ir_learn);
+ /* read returned RESPONSE_DONE, otherwise next command wil fail! */
+ uint8_t stop_rsp[68];
+ err = HID_ReadReport(stop_rsp);
+ if (err == 0) {
+ if ((stop_rsp[1] & COMMAND_MASK) != RESPONSE_DONE) {
+ err = 1;
+ }
+ }
+
/*
* Encode our pulses into string
*/
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Bug 1898492 - no one else affected, or just not interested?
Phil Dibowitz wrote:
>> Didn't see you'd attached a patch. I *really* need to write a "submitting
>> patches" doc.
>>
>> I just read your description, and it sounds pretty spot-on. I'll make a note
>> to look at this as well, though I prefer patches be sent to the list, just
>> FYI.
>
> Looking at your patch, I have a few comments:
>
> 1. It's generated against 0.13, but CVS has changed DRASTICALLY since then -
> can you please re-gen against CVS, and also check our new SubmittingPatches
> file for further details.
>
> 2. It looks like you're right - RESPONSE_DONE should only be received after
> we send COMMAND_STOP_IRCAP, and by reading, we can flush that. Nice catch.
>
> 3. Why do you comment out the 'else if (r == RESPONSE_DONE) {' ? While we
> shouldn't get this in the middle of things, it's certainly bad if we do, and
> a good reason to stop - I'd prefer we leave that check in.
>
> 4. Can you add braces to your outer iff statement for me?
>
> If you could re-submit a patch (to the list, please), with the above
> changes, I'd appreciate it. The idea behind the patch looks solid to me.
Andreas,
I never saw you re-submit this patch - did I miss it?
--
Phil Dibowitz [EMAIL PROTECTED]
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Never write it in C if you can do it in 'awk';
Never do it in 'awk' if 'sed' can handle it;
Never use 'sed' when 'tr' can do the job;
Never invoke 'tr' when 'cat' is sufficient;
Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Bug 1898492 - no one else affected, or just not interested?
Phil Dibowitz wrote:
> Andreas Schulz wrote:
>> [ 1898492 ] LearnIR makes next run fail on H785:
>> After any run of harmony -l.. to learn IR command, any next run of harmony
>> fails. Any subsequent run after the failed one is OK again (until the next
>> '-l').
>>
>> Anyone willing to try at least if this is reproducible with
>> other Harmonys, and if yes, verify if my patch is OK (it is
>> for me, at least)?
>
> Didn't see you'd attached a patch. I *really* need to write a "submitting
> patches" doc.
>
> I just read your description, and it sounds pretty spot-on. I'll make a note
> to look at this as well, though I prefer patches be sent to the list, just
> FYI.
Looking at your patch, I have a few comments:
1. It's generated against 0.13, but CVS has changed DRASTICALLY since then -
can you please re-gen against CVS, and also check our new SubmittingPatches
file for further details.
2. It looks like you're right - RESPONSE_DONE should only be received after
we send COMMAND_STOP_IRCAP, and by reading, we can flush that. Nice catch.
3. Why do you comment out the 'else if (r == RESPONSE_DONE) {' ? While we
shouldn't get this in the middle of things, it's certainly bad if we do, and
a good reason to stop - I'd prefer we leave that check in.
4. Can you add braces to your outer iff statement for me?
If you could re-submit a patch (to the list, please), with the above
changes, I'd appreciate it. The idea behind the patch looks solid to me.
Thanks!
--
Phil Dibowitz [EMAIL PROTECTED]
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Never write it in C if you can do it in 'awk';
Never do it in 'awk' if 'sed' can handle it;
Never use 'sed' when 'tr' can do the job;
Never invoke 'tr' when 'cat' is sufficient;
Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Bug 1898492 - no one else affected, or just not interested?
Andreas Schulz wrote: > [ 1898492 ] LearnIR makes next run fail on H785: > After any run of harmony -l.. to learn IR command, any next run of harmony > fails. Any subsequent run after the failed one is OK again (until the next > '-l'). > > Anyone willing to try at least if this is reproducible with > other Harmonys, and if yes, verify if my patch is OK (it is > for me, at least)? Didn't see you'd attached a patch. I *really* need to write a "submitting patches" doc. I just read your description, and it sounds pretty spot-on. I'll make a note to look at this as well, though I prefer patches be sent to the list, just FYI. Thanks! -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming signature.asc Description: OpenPGP digital signature - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Bug 1898492 - no one else affected, or just not interested?
[ 1898492 ] LearnIR makes next run fail on H785: After any run of harmony -l.. to learn IR command, any next run of harmony fails. Any subsequent run after the failed one is OK again (until the next '-l'). Anyone willing to try at least if this is reproducible with other Harmonys, and if yes, verify if my patch is OK (it is for me, at least)? Andreas - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
