[jira] [Updated] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Rübner updated CONNECTORS-223: - Attachment: CONNECTORS-223.patch This patch includes the updated versions of the maven poms. I also added minor changes to run the jetty-runner module by invoking mvn exec:exec on the command line (or eclipse). There is still an issue with the end-to-end test, which requires a more detailed look into the code base. Invoking more than one test ends up in a database not found error. Your supplied test_reset.patch does not fix the issue. Maybe you can have a look on it. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067802#comment-13067802 ] Karl Wright commented on CONNECTORS-223: r1148417. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067811#comment-13067811 ] Karl Wright commented on CONNECTORS-223: bq. Invoking more than one test ends up in a database not found error. So let me be sure I understand the model. These tests are all executing in one JVM, correct? Can you attach a stack trace? I suspect that the issue has to do with setup/teardown of the database; I believe that each test's cleanup method removes the database, so if the sequence looks like this, for tests A, B, and C: setup (A) setup (B) setup (C) (A) (B) (C) cleanup (C) cleanup (B) cleanup (A) ... then this could happen. But if the sequence is: setup (A) (A) cleanup (A) etc. ... then it is a complete mystery. I should be able to tell what sequence it is from a trace though. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067837#comment-13067837 ] Karl Wright commented on CONNECTORS-223: I tried to simulate what maven does by changing the ant build's junit invocation from fork=true to fork=false. When I do this without the patch, I get the same symptom as you see under Maven. With the patch, however, it works fine. I think perhaps there is a problem with your testing procedure? I'm going to commit the patch changes now - could you synch up and try them again under maven? r1148443. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
