[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108894#comment-13108894 ] Alex Ott commented on CONNECTORS-223: - I'm not sure, that packages not available at Maven central, or other repositories, should be used in pom's - in Tika project another approach is used - all needed jars are promoted to repository first, and only after it are used... Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, CONNECTORS-223_forkMode.patch, CONNECTORS-223_jetty-runner.patch, CONNECTORS-223_tests.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068263#comment-13068263 ] Karl Wright commented on CONNECTORS-223: bq. Per default, maven also runs the tests in a separate process. So does it start the process, run all the tests, and shut the process down? Or does it start a process for each test? bq. The execution procedure is sequential. Each tests runs to the whole lifecycle, before an other test starts. Ok, that's a relief. Other than trying to run these tests myself under maven, I can't think of any other way to proceed other than to ask you to figure out a way to get at the manifoldcf.log output for the test that fails. The timeout is happening because the crawl it sets up is never finishing. This could well be due to some static objects hanging around from one cycle to the next, but I'm never going to be able to tell without some work. I would have thought using ant with fork=false would exercise the same path, but clearly Maven is doing something different from that. Maybe the best way forward is to give me detailed instructions on how to set maven up in the way you have it, so I can debug at length. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068326#comment-13068326 ] Karl Wright commented on CONNECTORS-223: I tried running mvn on the pom's currently checked in and I get this: [ERROR] Failed to execute goal on project mcf-core: Could not resolve dependenci es for project org.apache.manifoldcf:mcf-core:jar:0.3.0-SNAPSHOT: Could not find artifact com.bitmechanic:jdbcpool:jar:0.99 in central (http://repo1.maven.org/m aven2) - [Help 1] [ERROR] Do you see this error too? Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068334#comment-13068334 ] Karl Wright commented on CONNECTORS-223: r1148733. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, CONNECTORS-223_forkMode.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068363#comment-13068363 ] Karl Wright commented on CONNECTORS-223: With this and similar imports, I was able to get further. Now I am stopped by the following error, which looks like something new: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin: 2.1:copy (copy-war) on project mcf-jettyrunner: Unable to find artifact. Could n ot find artifact org.apache.manifoldcf:mcf-api-service:war:0.3.0-SNAPSHOT [ERROR] Thoughts? (I'm keeping all this information around in order to update the how-to-build-and-deploy page, FWIW.) Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, CONNECTORS-223_forkMode.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[
https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068383#comment-13068383
]
Tobias Rübner commented on CONNECTORS-223:
--
For building the framework with maven, you just need to invoke
{{mvn clean install}}
on the root level of the project.
for running the jetty-runner app invoke
{{mvn exec:exec}}
in the jetty-runner module.
Tests in project hierarchy do not adhere to maven conventions
-
Key: CONNECTORS-223
URL: https://issues.apache.org/jira/browse/CONNECTORS-223
Project: ManifoldCF
Issue Type: Bug
Components: Build
Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3
Reporter: Karl Wright
Assignee: Karl Wright
Fix For: ManifoldCF 0.3
Attachments: CONNECTORS-223.patch, CONNECTORS-223_forkMode.patch,
CONNECTORS-223_jetty-runner.patch, test_reset.patch
Maven expects unit tests under .../src/test/java, and root-level project
tests under tests/xxx/src/test/java (or equivalent, along with their own
pom.xml at tests and tests/xxx). This is basically compatible with the ant
build except in location detail. The proposal is to move stuff around to
make the tests work with maven.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[
https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068397#comment-13068397
]
Tobias Rübner commented on CONNECTORS-223:
--
Did you applied my patch (CONNECTORS-223_jetty-runner.patch) for restructuring
the build order?
Thereafter the build order should be
{code}
[INFO] Reactor Summary:
[INFO]
[INFO] ManifoldCF SUCCESS [0.543s]
[INFO] ManifoldCF - Framework SUCCESS [0.010s]
[INFO] ManifoldCF - Framework - Core . SUCCESS [5.906s]
[INFO] ManifoldCF - Framework - UI Core .. SUCCESS [1.113s]
[INFO] ManifoldCF - Framework - Agents ... SUCCESS [7.232s]
[INFO] ManifoldCF - Framework - Pull Agent ... SUCCESS [12.588s]
[INFO] ManifoldCF - Framework - Authority Servlet SUCCESS [0.808s]
[INFO] ManifoldCF - Framework - API Servlet .. SUCCESS [0.834s]
[INFO] ManifoldCF - Framework - Authority Service SUCCESS [1.667s]
[INFO] ManifoldCF - Framework - API Service .. SUCCESS [1.070s]
[INFO] ManifoldCF - Framework - Crawler UI ... SUCCESS [1.207s]
[INFO] ManifoldCF - Connectors ... SUCCESS [0.006s]
[INFO] ManifoldCF - Connectors - Active Directory SUCCESS [0.957s]
[INFO] ManifoldCF - Connectors - Filesystem .. SUCCESS [9.259s]
[INFO] ManifoldCF - Connectors - MetaCarta GTS ... SUCCESS [1.394s]
[INFO] ManifoldCF - Connectors - jCIFS ... SUCCESS [1.838s]
[INFO] ManifoldCF - Connectors - JDBC SUCCESS [1.339s]
[INFO] ManifoldCF - Connectors - Null Authority .. SUCCESS [0.725s]
[INFO] ManifoldCF - Connectors - Null Output . SUCCESS [0.727s]
[INFO] ManifoldCF - Connectors - RSS . SUCCESS [1.835s]
[INFO] ManifoldCF - Connectors - Solr SUCCESS [1.483s]
[INFO] ManifoldCF - Connectors - Web . SUCCESS [2.553s]
[INFO] ManifoldCF - Tests SUCCESS [0.011s]
[INFO] ManifoldCF - Test - Filesystem SUCCESS [9:34.805s]
[INFO] ManifoldCF - Test - Sharepoint SUCCESS [0.121s]
[INFO] ManifoldCF - Framework - Jetty Runner . SUCCESS [2.217s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
Tests in project hierarchy do not adhere to maven conventions
-
Key: CONNECTORS-223
URL: https://issues.apache.org/jira/browse/CONNECTORS-223
Project: ManifoldCF
Issue Type: Bug
Components: Build
Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3
Reporter: Karl Wright
Assignee: Karl Wright
Fix For: ManifoldCF 0.3
Attachments: CONNECTORS-223.patch, CONNECTORS-223_forkMode.patch,
CONNECTORS-223_jetty-runner.patch, test_reset.patch
Maven expects unit tests under .../src/test/java, and root-level project
tests under tests/xxx/src/test/java (or equivalent, along with their own
pom.xml at tests and tests/xxx). This is basically compatible with the ant
build except in location detail. The proposal is to move stuff around to
make the tests work with maven.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067802#comment-13067802 ] Karl Wright commented on CONNECTORS-223: r1148417. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067811#comment-13067811 ] Karl Wright commented on CONNECTORS-223: bq. Invoking more than one test ends up in a database not found error. So let me be sure I understand the model. These tests are all executing in one JVM, correct? Can you attach a stack trace? I suspect that the issue has to do with setup/teardown of the database; I believe that each test's cleanup method removes the database, so if the sequence looks like this, for tests A, B, and C: setup (A) setup (B) setup (C) (A) (B) (C) cleanup (C) cleanup (B) cleanup (A) ... then this could happen. But if the sequence is: setup (A) (A) cleanup (A) etc. ... then it is a complete mystery. I should be able to tell what sequence it is from a trace though. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067837#comment-13067837 ] Karl Wright commented on CONNECTORS-223: I tried to simulate what maven does by changing the ant build's junit invocation from fork=true to fork=false. When I do this without the patch, I get the same symptom as you see under Maven. With the patch, however, it works fine. I think perhaps there is a problem with your testing procedure? I'm going to commit the patch changes now - could you synch up and try them again under maven? r1148443. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Attachments: CONNECTORS-223.patch, test_reset.patch Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066923#comment-13066923 ] Karl Wright commented on CONNECTORS-223: The only requirement I have for creation of the test databases and configuration files is that it must be possible to have multiple workareas checked out with on tests running on each so that the tests do not collide with one another. Setting up paths that depend on resources may therefore not work. Other than than, I'm open to any patch you want to propose. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065744#comment-13065744 ] Tobias Rübner commented on CONNECTORS-223: -- The structure looks good, but the tests need more dependencies. Currently in maven all tests will fail! I will create a patch for the maven poms, that includes the dependencies for the maven test lifecycle. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065748#comment-13065748 ] Karl Wright commented on CONNECTORS-223: Please go ahead, and attach the patch to this ticket; I'll commit it right away. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065780#comment-13065780 ] Karl Wright commented on CONNECTORS-223: Renaming the tests should not be hard. But what about the test base classes? Since they begin with Test they will be executed independently, although they do not have any actual tests in them. They do have expensive setup and teardown methods though. Thus they should probably also be renamed to something that won't execute on its own. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065853#comment-13065853 ] Karl Wright commented on CONNECTORS-223: r1147086. Let me know if there's anything further you need. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Assignee: Karl Wright Fix For: ManifoldCF 0.3 Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065237#comment-13065237 ] Tobias Rübner commented on CONNECTORS-223: -- That sounds great. For the end-to-end tests I would also suggest to make a maven project per test szenario (filesystem, sharepoint, ...). The test code should be in the src/test/java directory. When you are done, I could update the maven pom's. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065257#comment-13065257 ] Karl Wright commented on CONNECTORS-223: I just ran into a potential issue. The framework tests are organized as follows: - the core test package consists of tests and a TestBase class - the agents test package consists of tests and a TestBase class that extends the core TestBase class - the pull-agent test package consists of tests and a TestBase class that extends the agents TestBase class The question is, where should the TestBase classes live? Will maven do the right thing if these are all moved, to core/src/test/java, agents/src/test/java, and pull-agent/src/test/java, respectively? Or do we need specific mcf-core-test, mcf-agents-test, and mcf-pull-agent-test subprojects, for the test base classes? How is this usually handled in Maven? Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065301#comment-13065301 ] Tobias Rübner commented on CONNECTORS-223: -- That is no problem for maven. You should leave the TestBase classes in their modules. While building the module, I can add an additional instruction to include the test-classes to an xxx-test.jar. On the module depending on those test-classes, I can include the test package to the test lifecycle. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065329#comment-13065329 ] Karl Wright commented on CONNECTORS-223: I've created a branch, https://svn.apache.org/repos/asf/incubator/lcf/branches/CONNECTORS-223, where I've started the rearrangement. If you could have a look at the framework subproject in this branch to see if I have arranged things properly, that would be great. If that all looks OK, I'm planning to tackle the connectors next, then the end-to-end tests. Tests in project hierarchy do not adhere to maven conventions - Key: CONNECTORS-223 URL: https://issues.apache.org/jira/browse/CONNECTORS-223 Project: ManifoldCF Issue Type: Bug Components: Build Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 Reporter: Karl Wright Maven expects unit tests under .../src/test/java, and root-level project tests under tests/xxx/src/test/java (or equivalent, along with their own pom.xml at tests and tests/xxx). This is basically compatible with the ant build except in location detail. The proposal is to move stuff around to make the tests work with maven. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
