[jira] [Commented] (CONNECTORS-317) minor GUI improvement for jcifs connector
[ https://issues.apache.org/jira/browse/CONNECTORS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169376#comment-13169376 ] Karl Wright commented on CONNECTORS-317: Hi Martin, There is no style called "operation" in the current style sheet. Is there more to this patch you may have inadvertantly missed? > minor GUI improvement for jcifs connector > - > > Key: CONNECTORS-317 > URL: https://issues.apache.org/jira/browse/CONNECTORS-317 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector >Reporter: Martin Goldhahn >Priority: Trivial > Attachments: SharedDriveConnector.java.patch > > > The table on Paths tab (in edit job for jcifs connector) looks strange. > The Add and Delete button should be aligned, i.e. in the first column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-317) minor GUI improvement for jcifs connector
[ https://issues.apache.org/jira/browse/CONNECTORS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179060#comment-13179060 ] Karl Wright commented on CONNECTORS-317: bq. The value style is used a couple of other places as well. But removing this doesn't screw up those pages. The "value" style is used widely; I'll have to confirm that change. As for the patch itself, the position of the "Add" button as it currently exists is consistent with similar screens in the ManifoldCF core itself, as well as many other connectors. Changing the paradigm is thus a more global affair, and also it is in accordance with taste. So I'm not really sure what to do with this ticket. Separating out the style of the button does, however, seem like a good idea, and I'd be willing to do that for the 0.5 release if you think that would be helpful. > minor GUI improvement for jcifs connector > - > > Key: CONNECTORS-317 > URL: https://issues.apache.org/jira/browse/CONNECTORS-317 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector >Reporter: Martin Goldhahn >Priority: Trivial > Attachments: SharedDriveConnector.java.patch, style.css.patch > > > The table on Paths tab (in edit job for jcifs connector) looks strange. > The Add and Delete button should be aligned, i.e. in the first column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-317) minor GUI improvement for jcifs connector
[ https://issues.apache.org/jira/browse/CONNECTORS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180650#comment-13180650 ] Martin Goldhahn commented on CONNECTORS-317: It is really not a big deal. Having a separate style for the button would definitely be helpful. If you feel the rest of the patch corrupts the consistency with the other connectors, you can just close the ticket. > minor GUI improvement for jcifs connector > - > > Key: CONNECTORS-317 > URL: https://issues.apache.org/jira/browse/CONNECTORS-317 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector >Reporter: Martin Goldhahn >Priority: Trivial > Attachments: SharedDriveConnector.java.patch, style.css.patch > > > The table on Paths tab (in edit job for jcifs connector) looks strange. > The Add and Delete button should be aligned, i.e. in the first column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-317) minor GUI improvement for jcifs connector
[ https://issues.apache.org/jira/browse/CONNECTORS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180683#comment-13180683 ] Karl Wright commented on CONNECTORS-317: bq. Having a separate style for the button would definitely be helpful. Ok, then I'll triage this for 0.5 and interpret the ticket as being complete when that is added. > minor GUI improvement for jcifs connector > - > > Key: CONNECTORS-317 > URL: https://issues.apache.org/jira/browse/CONNECTORS-317 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector >Reporter: Martin Goldhahn >Priority: Trivial > Attachments: SharedDriveConnector.java.patch, style.css.patch > > > The table on Paths tab (in edit job for jcifs connector) looks strange. > The Add and Delete button should be aligned, i.e. in the first column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
