Re: Need an opinion, on whether to change package or not
+1 for a complete change On Mon, Aug 23, 2010 at 6:34 AM, Mark Miller markrmil...@gmail.com wrote: +1 to renaming the package - nows the time. - Mark http://www.lucidimagination.com (mobile) On Aug 22, 2010, at 8:01 PM, Jack Krupansky jack.krupan...@lucidimagination.com wrote: +1 -- Jack Krupansky -- From: Karl Wright daddy...@gmail.com Sent: Sunday, August 22, 2010 1:49 PM To: connectors-dev connectors-dev@incubator.apache.org Subject: Need an opinion, on whether to change package or not Consider this an official request for a vote. +1 indicates you think we should change the following in the source code, as soon as is practical: org.apache.lcf.xxx - org.apache.acf.xxx All classes LCF.java and LCFException.java should change to ACF.java and ACFException.java Bear in mind that users of ACF/LCF who currently have existing database instances will need to reinitialize those instances if we do this change. This is because the class names of connectors are stored in the database when the connector is registered. (FWIW, my vote on this is -1. It doesn't seem worth the disruption. But I will of course abide by the consensus.) Vote will be considered closed by Wednesday evening, so vote early (and often. ;-)) Karl -- Jettro Coenradie http://www.gridshore.nl
Re: Need an opinion, on whether to change package or not
On Mon, Aug 23, 2010 at 10:35 AM, Jettro Coenradie jettro.coenra...@gridshore.nl wrote: If we are changing stuff can we also use more descriptive names. Not Use LCF 4 to 5 times in a different Package. Use something like ACFAgent and ACFCrawler +1 for that too! simon On Mon, Aug 23, 2010 at 10:33 AM, Jettro Coenradie jettro.coenra...@gridshore.nl wrote: +1 for a complete change On Mon, Aug 23, 2010 at 6:34 AM, Mark Miller markrmil...@gmail.comwrote: +1 to renaming the package - nows the time. - Mark http://www.lucidimagination.com (mobile) On Aug 22, 2010, at 8:01 PM, Jack Krupansky jack.krupan...@lucidimagination.com wrote: +1 -- Jack Krupansky -- From: Karl Wright daddy...@gmail.com Sent: Sunday, August 22, 2010 1:49 PM To: connectors-dev connectors-dev@incubator.apache.org Subject: Need an opinion, on whether to change package or not Consider this an official request for a vote. +1 indicates you think we should change the following in the source code, as soon as is practical: org.apache.lcf.xxx - org.apache.acf.xxx All classes LCF.java and LCFException.java should change to ACF.java and ACFException.java Bear in mind that users of ACF/LCF who currently have existing database instances will need to reinitialize those instances if we do this change. This is because the class names of connectors are stored in the database when the connector is registered. (FWIW, my vote on this is -1. It doesn't seem worth the disruption. But I will of course abide by the consensus.) Vote will be considered closed by Wednesday evening, so vote early (and often. ;-)) Karl -- Jettro Coenradie http://www.gridshore.nl -- Jettro Coenradie http://www.gridshore.nl
RE: Need an opinion, on whether to change package or not
In any open-source project there is expected to be some differences in individual coding styles. There is often also incomplete understanding of the reasoning behind the multitude of architectural decisions made during development, or the history of the project. It is thus important to be pragmatic, and therefore each issue or question is basically its own topic, evaluated on its own merits. Probably the best way to deal with each *individual* concern or question is to open a jira ticket expressing that concern. Discussion should then be done within the context of that ticket. There is no guarantee, of course, that the ticket will be acted upon, but at least it will be discussed. Karl From: jettro.coenra...@gmail.com [jettro.coenra...@gmail.com] On Behalf Of ext Jettro Coenradie [jettro.coenra...@gridshore.nl] Sent: Monday, August 23, 2010 5:17 AM To: connectors-dev@incubator.apache.org Subject: Re: Need an opinion, on whether to change package or not I can understand that it is harder to do. Therefore it is better notto do it right now. I do not agree with you that it is easier to move files from one package to another. The fact that these classes have different impact should make you think before moving the classes. I would like to discuss on some of these design/code issues more as well. What is the best way to do this? Ask a question per topic to share opinions? thanks Jettro On Mon, Aug 23, 2010 at 10:54 AM, karl.wri...@nokia.com wrote: Unfortunately that is way harder to do using the python scripts I have developed for this purpose. Also, the reason the LCF root class appears in different packages has to do with the relative ease that grants to moving classes between the various acf jars. So I'd consider this proposed change to be controversial, and I don't think we should layer it in without separate consideration. Karl From: ext Simon Willnauer [simon.willna...@googlemail.com] Sent: Monday, August 23, 2010 4:40 AM To: connectors-dev@incubator.apache.org Subject: Re: Need an opinion, on whether to change package or not On Mon, Aug 23, 2010 at 10:35 AM, Jettro Coenradie jettro.coenra...@gridshore.nl wrote: If we are changing stuff can we also use more descriptive names. Not Use LCF 4 to 5 times in a different Package. Use something like ACFAgent and ACFCrawler +1 for that too! simon On Mon, Aug 23, 2010 at 10:33 AM, Jettro Coenradie jettro.coenra...@gridshore.nl wrote: +1 for a complete change On Mon, Aug 23, 2010 at 6:34 AM, Mark Miller markrmil...@gmail.com wrote: +1 to renaming the package - nows the time. - Mark http://www.lucidimagination.com (mobile) On Aug 22, 2010, at 8:01 PM, Jack Krupansky jack.krupan...@lucidimagination.com wrote: +1 -- Jack Krupansky -- From: Karl Wright daddy...@gmail.com Sent: Sunday, August 22, 2010 1:49 PM To: connectors-dev connectors-dev@incubator.apache.org Subject: Need an opinion, on whether to change package or not Consider this an official request for a vote. +1 indicates you think we should change the following in the source code, as soon as is practical: org.apache.lcf.xxx - org.apache.acf.xxx All classes LCF.java and LCFException.java should change to ACF.java and ACFException.java Bear in mind that users of ACF/LCF who currently have existing database instances will need to reinitialize those instances if we do this change. This is because the class names of connectors are stored in the database when the connector is registered. (FWIW, my vote on this is -1. It doesn't seem worth the disruption. But I will of course abide by the consensus.) Vote will be considered closed by Wednesday evening, so vote early (and often. ;-)) Karl -- Jettro Coenradie http://www.gridshore.nl -- Jettro Coenradie http://www.gridshore.nl -- Jettro Coenradie http://www.gridshore.nl
Re: Need an opinion, on whether to change package or not
+1 -- Jack Krupansky -- From: Karl Wright daddy...@gmail.com Sent: Sunday, August 22, 2010 1:49 PM To: connectors-dev connectors-dev@incubator.apache.org Subject: Need an opinion, on whether to change package or not Consider this an official request for a vote. +1 indicates you think we should change the following in the source code, as soon as is practical: org.apache.lcf.xxx - org.apache.acf.xxx All classes LCF.java and LCFException.java should change to ACF.java and ACFException.java Bear in mind that users of ACF/LCF who currently have existing database instances will need to reinitialize those instances if we do this change. This is because the class names of connectors are stored in the database when the connector is registered. (FWIW, my vote on this is -1. It doesn't seem worth the disruption. But I will of course abide by the consensus.) Vote will be considered closed by Wednesday evening, so vote early (and often. ;-)) Karl
Re: Need an opinion, on whether to change package or not
+1 to renaming the package - nows the time. - Mark http://www.lucidimagination.com (mobile) On Aug 22, 2010, at 8:01 PM, Jack Krupansky jack.krupan...@lucidimagination.com wrote: +1 -- Jack Krupansky -- From: Karl Wright daddy...@gmail.com Sent: Sunday, August 22, 2010 1:49 PM To: connectors-dev connectors-dev@incubator.apache.org Subject: Need an opinion, on whether to change package or not Consider this an official request for a vote. +1 indicates you think we should change the following in the source code, as soon as is practical: org.apache.lcf.xxx - org.apache.acf.xxx All classes LCF.java and LCFException.java should change to ACF.java and ACFException.java Bear in mind that users of ACF/LCF who currently have existing database instances will need to reinitialize those instances if we do this change. This is because the class names of connectors are stored in the database when the connector is registered. (FWIW, my vote on this is -1. It doesn't seem worth the disruption. But I will of course abide by the consensus.) Vote will be considered closed by Wednesday evening, so vote early (and often. ;-)) Karl
