Re: [PATCH] ipconfig: use only settings related to configuration method
On Fri, 2015-02-13 at 08:58 +0200, Pasi Sjöholm wrote: Hi, On 12.02.2015 15:28, Patrik Flykt wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com If service is ever being configured with manual ip-address, netmask and gateway and later changed to dhcp, the related settings must not be read if configuration method is not manual or fixed. Otherwise they can possible collide with the settings got from dhcp-server if they are exactly the same (eg. dhcp.c: lease_available_cb()). This could lead network interface not being configured correctly. --- Hi, I made the switch statement a bit more explicit, please check this is still how it is inteded and doesn't break anything by accident. Seems to be working as expected. :) Applied, many thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [RFC v2] network: Merge identical ipconfig code paths
On Wed, 2015-02-11 at 13:54 +0200, Patrik Flykt wrote: Configure IPv4 and IPv6 configurations only once in __connman_network_enable_ipconfig() and use this function when setting the network connected. Remove obsolete function and rework the rest to centralise configuration state and error reporting. The variable network-connecting is true as long as the IPv4 or IPv6 address configuration phase is ongoing. Fixed according to Jukka's comment and applied. Cheers, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: installation of connmanctl
On Mon, Feb 09, 2015 at 09:47:58AM +0200, Patrik Flykt wrote: On Sun, 2015-02-08 at 22:23 -0800, Chris Hiszpanski wrote: I also found this to be strange, although I figured the original authors had a good reason for this since they explicitly added it to noinst. For myself, I created a commit on my local fork to install connmanctl by default. Here is the patch: connmanctl has indeed matured to the point that it is great for daily use and can therefore be promoted to a proper installable binary. Just send a proper patch preferable with git send-email. Was there any problem with the patch? Best regards, Tomas Cech signature.asc Description: Digital signature ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [RFC v2] network: Merge identical ipconfig code paths
Hi, tested this also with jolla's fork and seems to be working (played with it only 10min). Br, Pasi On 11.02.2015 13:54, Patrik Flykt wrote: Configure IPv4 and IPv6 configurations only once in __connman_network_enable_ipconfig() and use this function when setting the network connected. Remove obsolete function and rework the rest to centralise configuration state and error reporting. The variable network-connecting is true as long as the IPv4 or IPv6 address configuration phase is ongoing. --- Hi, This is a fairly large patch that removes duplicate code in set_connected() in favor of using the one in __connman_network_set_ipconfig(). There is no change in functionality in this patch. v2 fixes a glitch with variable naming wrt rebasing Please test, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Network state is ready instead of online after getting a DHCP address
Hi, how is $SUBJECT possible? On two different ZOTAC Mini-PCs (both ZBOXNANO-AQ01) this happened twice in the last two weeks for me while using a Yocto-based system with connman. The solution was to snap the Ethernet plug firmly into place after which the network state became online immediately. But again, the machine was network-accessible, it got IP address via DHCP but e.g. /usr/lib/connman/test/get-state said System is ready instead of System is online as usual. Does anyone has an idea why this might happen? Thanks in advance, Zoltán Böszörményi ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
