[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner daniel.wag...@bmw-carit.de
---
 gsupplicant/supplicant.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 8a16663..b483f9b 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -2411,10 +2411,12 @@ static void signal_wps_event(const char *path, 
DBusMessageIter *iter)
 
 static void create_peer_identifier(GSupplicantPeer *peer)
 {
+   const unsigned char test[6] = {};
+
if (!peer)
return;
 
-   if (!peer-device_address) {
+   if (!memcmp(peer-device_address, test, 6)) {
peer-identifier = g_strdup(peer-name);
return;
}
-- 
1.8.3.2

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-12 Thread Tomasz Bursztyka
Reported by Daniel Wagner daniel.wag...@bmw-carit.de
---
 gsupplicant/supplicant.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 2be773e..b8c89ad 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -2427,10 +2427,12 @@ static void signal_wps_event(const char *path, 
DBusMessageIter *iter)
 
 static void create_peer_identifier(GSupplicantPeer *peer)
 {
+   const unsigned char test[6] = {};
+
if (!peer)
return;
 
-   if (!peer-device_address) {
+   if (!memcmp(peer-device_address, test, 6)) {
peer-identifier = g_strdup(peer-name);
return;
}
-- 
1.8.3.2

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman