[PATCH 5/5] wifi: Set peer's connection master status when on configuration state

2014-07-16 Thread Tomasz Bursztyka 
This will let peer core starting dhcp either as a server or as a client.
---
 plugins/wifi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plugins/wifi.c b/plugins/wifi.c
index ba4ce66..eb1fad0 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -2373,6 +2373,8 @@ static void peer_changed(GSupplicantPeer *peer,
if (!g_wifi)
return;
 
+   connman_peer_set_as_master(connman_peer,
+   !g_supplicant_peer_is_client(peer));
connman_peer_set_sub_device(connman_peer, g_wifi-device);
}
 
-- 
1.8.5.5

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 5/5] wifi: Set peer's connection master status when on configuration state

2014-07-16 Thread Jukka Rissanen 
Hi Tomasz,

Could the patch #2 be put before this patch so the helper function
definition would be nearer to this one?

On ke, 2014-07-16 at 16:27 +0300, Tomasz Bursztyka wrote:
 This will let peer core starting dhcp either as a server or as a client.
 ---
  plugins/wifi.c | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/plugins/wifi.c b/plugins/wifi.c
 index ba4ce66..eb1fad0 100644
 --- a/plugins/wifi.c
 +++ b/plugins/wifi.c
 @@ -2373,6 +2373,8 @@ static void peer_changed(GSupplicantPeer *peer,
   if (!g_wifi)
   return;
  
 + connman_peer_set_as_master(connman_peer,
 + !g_supplicant_peer_is_client(peer));

This function name is a bit confusing as it only sets the master role if
parameter is true. Perhaps connman_peer_set_role() or similar. Not a big
issue thou, you decide.

   connman_peer_set_sub_device(connman_peer, g_wifi-device);
   }
  


Cheers,
Jukka


___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman