Re: [PATCH ipv6 v2 14/15] service: Do not change state if combined state does not change.

[Samuel Ortiz]

Hi Jukka,

On Tue, Feb 08, 2011 at 12:30:17PM +0200, Jukka Rissanen wrote:
 ---
  src/service.c |3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
 
 diff --git a/src/service.c b/src/service.c
 index ff20e42..a5ade8d 100644
 --- a/src/service.c
 +++ b/src/service.c
 @@ -3344,6 +3344,9 @@ int __connman_service_indicate_state(struct 
 connman_service *service,
   else if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
   service-state_ipv6 = new_state;
  
 + if (state == service_state)
 + return -EALREADY;
 +
I wouldn't mind sticking this one to patch #4. Up to you.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman

[PATCH ipv6 v2 14/15] service: Do not change state if combined state does not change.

[Jukka Rissanen]

---
 src/service.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/service.c b/src/service.c
index ff20e42..a5ade8d 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3344,6 +3344,9 @@ int __connman_service_indicate_state(struct 
connman_service *service,
else if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
service-state_ipv6 = new_state;
 
+   if (state == service_state)
+   return -EALREADY;
+
state_changed(service);
 
if (state == CONNMAN_SERVICE_STATE_ONLINE) {
-- 
1.7.0.4

___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman