Re: [PATCH 1/3] wifi: Introduce PassiveWiFiScan option

2015-04-27 Thread Patrik Flykt 
On Fri, 2015-04-24 at 14:56 +0300, Pasi Sjöholm wrote:
  If you use PassiveWiFiScan only here, then you are still using
  active scan for auto-connection - so still leaking SSIDs - when not
  connected.
 
 Yes, for hidden networks but not for anything else.

This isn't then a very good solution. So if the point is not to leak all
known SSIDs all the time while scanning, that needs to be addressed for
all scans. I'd still expect hidden networks to be scanned if they did
not turn up in the passive WiFi scan. Else there is a subset of networks
that can be connected only once; having the user to notice the
relationship between full privacy and hidden WiFi networks will fail
very reliably...

So the idea is not to reveal the WiFi networks used by doing active
scans where active scans are not strictly necessary? By doing active
scan only for known hidden networks, yes, the device reveals itself -
but that is the cost of using hidden networks, right?


Cheers,

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 1/3] wifi: Introduce PassiveWiFiScan option

2015-04-24 Thread Tomasz Bursztyka 

Hi Pasi,


-   } else if (wifi-connected) {
+   } else if (wifi-connected || 
connman_setting_get_bool(PassiveWiFiScan)) {
g_supplicant_free_scan_params(scan_params);
return wifi_scan_simple(device);


If you use PassiveWiFiScan only here, then you are still using active 
scan for auto-connection

- so still leaking SSIDs - when not connected.

Is this a wanted behavior? Because then PassiveWiFiScan is semantically 
wrong as it does

not really completely avoid active scan.

Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 1/3] wifi: Introduce PassiveWiFiScan option

2015-04-24 Thread Pasi Sjöholm 
Hi Tomasz,

 -} else if (wifi-connected) { +} else if
 (wifi-connected || connman_setting_get_bool(PassiveWiFiScan))
 { g_supplicant_free_scan_params(scan_params); return
 wifi_scan_simple(device);
 
 If you use PassiveWiFiScan only here, then you are still using
 active scan for auto-connection - so still leaking SSIDs - when not
 connected.

Yes, for hidden networks but not for anything else.

 Is this a wanted behavior? Because then PassiveWiFiScan is
 semantically wrong as it does not really completely avoid active
 scan.

Well, I would say yes because the hidden networks are just
fundamentally broken. I can rename PassiveWifiScan into something else.

Br,
Pasi
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman