Re: [RFC] ofono: Set ipconfig off if indicated that the protocol is not used

2015-02-11 Thread Patrik Flykt 
On Tue, 2015-02-10 at 12:20 +0200, Patrik Flykt wrote:
 On Mon, 2015-02-09 at 11:45 +0200, Pasi Sjöholm wrote:
  And by this I mean the two lines below could be removed. :)
  
   +if (modem-active)
   +set_connected(modem);
 
 I'll remove those from the patch, thanks!

Patch applied and modified according to above.

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [RFC] ofono: Set ipconfig off if indicated that the protocol is not used

2015-02-10 Thread Patrik Flykt 
On Mon, 2015-02-09 at 11:45 +0200, Pasi Sjöholm wrote:
 And by this I mean the two lines below could be removed. :)
 
  +if (modem-active)
  +set_connected(modem);

I'll remove those from the patch, thanks!

Patrik


___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [RFC] ofono: Set ipconfig off if indicated that the protocol is not used

2015-02-09 Thread Pasi Sjöholm 


On 09.02.2015 10:00, Pasi Sjöholm wrote:

 Otherwise everything else looks ok, but Protocol-message will never
 happen when modem-active is true. At least I don't have a modem which
 would allow changing protocol when modem is connected.

And by this I mean the two lines below could be removed. :)

 +if (modem-active)
 +set_connected(modem);

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [RFC] ofono: Set ipconfig off if indicated that the protocol is not used

2015-02-09 Thread Pasi Sjöholm 
On 06.02.2015 15:43, Patrik Flykt wrote:
 @@ -1261,6 +1312,17 @@ static gboolean context_changed(DBusConnection *conn,
  
   remove_network(modem);
   }
 +
 + } else if (g_str_equal(key, Protocol) 
 + dbus_message_iter_get_arg_type(value) == DBUS_TYPE_STRING ) {
 + const char *ip_protocol;
 +
 + dbus_message_iter_get_basic(value, ip_protocol);
 +
 + set_context_ipconfig(modem-context, ip_protocol);
 +
 + if (modem-active)
 + set_connected(modem);

Otherwise everything else looks ok, but Protocol-message will never
happen when modem-active is true. At least I don't have a modem which
would allow changing protocol when modem is connected.

Br,
Pasi
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman