[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-10 Thread [fcrozat]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784





--- Additional Comments From [EMAIL PROTECTED]  2003-10-10 18:16 ---
Thanks Jamie.. But it means there is no way to get screen lock working if you
disable screen blanking, right ?

In that case, I'll workaround that at gnome-panel level to run xlock if
xscreensaver-command -lock doesn't return 0.



-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: REOPENED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-10 Thread [jwz]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784





--- Additional Comments From [EMAIL PROTECTED]  2003-10-10 23:47 ---
If you even *ship* xlock, you're shipping a gaping security hole.

What's wrong with just popping up a dialog saying turn screen blanking on if
you want locking to work?  Selecting don't blank is effectively the same as
killing the xscreensaver daemon outright - except it's easier to re-launch.  And
you obviously can't lock the screen if the daemon isn't running.



-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: REOPENED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-07 Thread [fcrozat]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2003-07-10 10:17 ---
Reopening and removing test packages from people.mandrakesoft.com

Jamie, any idea on how to fix this cleanly ?

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: REOPENED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-07 Thread [jwz]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784





--- Additional Comments From [EMAIL PROTECTED]  2003-07-10 11:09 ---
Well, xscreensaver-demo already does give a clear message that Disable Screen
Saver implies disable locking, in that, when that item is selected, all the
locking-related items (the checkbox, etc.) are grayed out.

However, xscreensaver-command didn't produce an error message when you tried to
lock; the patch below will make it so that xscreensaver-command -lock will
print an error (and exit with non-zero) when the daemon is in Disabled mode.

I don't know what lock the screen from my computer and selected the appropriate
icon from the main menu means exactly (I mean, I don't know what clicking on
that icon does exactly) but presumably it's just running xscreensaver-command?

If xscreensaver-command exits with non-zero, then that icon ought to present the
user with an error dialog, containing the text that xscreensaver-command printed
to stderr:

% xscreensaver-command -lock
xscreensaver-command: screen blanking is currently disabled.

Exit 255

% xscreensaver-command -lock
xscreensaver-command: activating and locking.

Exit 0

This patch will be in 4.14:

diff -u -r1.115 xscreensaver.c
--- xscreensaver.c  7 Sep 2003 10:17:38 -   1.115
+++ xscreensaver.c  7 Oct 2003 08:59:40 -
@@ -1667,6 +1667,14 @@
 {
   if (until_idle_p)
{
+  if (p-mode == DONT_BLANK)
+{
+  clientmessage_response(si, window, True,
+ ACTIVATE ClientMessage received in DONT_BLANK mode.,
+ screen blanking is currently disabled.);
+  return False;
+}
+
  clientmessage_response(si, window, False,
 ACTIVATE ClientMessage received.,
 activating.);
@@ -1771,6 +1779,14 @@
   char buf2 [255];
   long which = event-xclient.data.l[1];
 
+  if (p-mode == DONT_BLANK)
+{
+  clientmessage_response(si, window, True,
+   SELECT ClientMessage received in DONT_BLANK mode.,
+ screen blanking is currently disabled.);
+  return False;
+}
+
   sprintf (buf, SELECT %ld ClientMessage received., which);
   sprintf (buf2, activating (%ld)., which);
   clientmessage_response (si, window, False, buf, buf2);
@@ -1890,7 +1906,11 @@
  not compiled with support for locking.,
  locking not enabled.);
 #else /* !NO_LOCKING */
-  if (si-locking_disabled_p)
+  if (p-mode == DONT_BLANK)
+clientmessage_response(si, window, True,
+ LOCK ClientMessage received in DONT_BLANK mode.,
+   screen blanking is currently disabled.);
+  else if (si-locking_disabled_p)
clientmessage_response (si, window, True,
  LOCK ClientMessage received, but locking is disabled.,
  locking not enabled.);


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: REOPENED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-06 Thread [fcrozat]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2003-06-10 18:03 ---
Fixed in xscreensaver 4.12-2mdk 

grab test package at http://people.mandrakesoft.com/~fcrozat/xscreensaver/

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: RESOLVED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-10-06 Thread [jwz]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784





--- Additional Comments From [EMAIL PROTECTED]  2003-06-10 20:46 ---
Please do not distribute that patch.

You misunderstand the purpose of that option -- it tells xscreensaver to do
*nothing* (e.g., when watching a DVD, don't touch the screen.)

It should *not* lock in that mode, because that would interfere with movie
playing or whatever.

Blank Only and the other modes *do* lock.

You are right that more feedback would be useful.

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: RESOLVED
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.



[Cooker] [Bug 5784] [xscreensaver] Screenlocking does not work if SXreensaver is disapled

2003-09-18 Thread [fcrozat]
http://qa.mandrakesoft.com/show_bug.cgi?id=5784


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed||1




--- Additional Comments From [EMAIL PROTECTED]  2003-18-09 10:41 ---
running xscreensaver -lock when screensaver is disabled output already locked..

Definitely an xscreensaver bug..

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: NEW
creation_date: 
description: 
I run gnome session and I tried to lock the screen from my computer and 
selected the appropriate icon from the main menu. But locking screen did not
start and I did not even get any  warning or error message boxes explaining that 
it can not be done.

First I thought that the menu was there even thought I did not have xscreensaver
installed but 

   rpm -qa | grep xscree
   xscreensaver-4.12-1mdk

shows that it is. Then I remembered that I have disapled screensaver in the
gnome configuration menu. I activated screensaver and tried again to lock the
screen but still nothing happened.

After logging the user away from the gnome session and logging in again I was
able to lock the screen.

I think that user should be able to lock the screen even if he do not want to
start screensaver after certain period.