[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-17 Thread [mr]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-17-11 19:04 ---
Those triggers never worked for me. I used to recreate those links after
updating for quite some time because I hadn't the time to figure out
what was wrong. I also remember seeing a bug report about this once, but
I cannot find it any more now.


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [ghibo]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 09:52 ---
New FlashPlayer CLUB RPM doesn't place links anymore, but real
files in /usr/lib/mozilla/plugins, so it should be right.

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [ghibo]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 10:15 ---
Apart this, before modifying any triggers, one have to test all the
cases, when EITHER the main or the triggerred package is installed,
uninstalled or upgraded.


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [ghibo]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 11:13 ---
Apart this, before modifying any triggers, one have to test all the
cases, when EITHER the main or the triggerred package is installed,
uninstalled or upgraded. So you have a totally of ninecases; if I
remember right, the %triggerun 

%triggerun -- plugin
[ $1 = 0 ] || exit 0
if [ -L %{mozillaplugindir}/plugin.so ]; then
rm -f %{mozillaplugindir}/plugin.so
fi

is there because the %triggerun (at least in the past was so)
is ALSO called when the MAIN package is upgraded, so you have to
SKIP the removing of the LINK in this case, and since the
same %triggerun weren't change since mozilla 1.2.1, I don't understand,
why in the past it worked, and shouldn't now?

-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [mr]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 13:36 ---
Comment to comment #1:

They still put the files into /usr/lib/netscape/plugins, see
http://rpms.mandrakeclub.com/rpms/MandrakeClub/comm/9.2/i586/FlashPlayer-6.0-4mdk.i586.html


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [mr]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 14:10 ---
Comment to comment #3:

Using

[ $2 = 0 ] || exit 0

should not trigger the trigger as long as at least one target package remains
($2 indicates how many instances of the target packages are installed on the
system). So updating mozilla should be ok.


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).



[Cooker] [Bug 6360] [mozilla] triggers remove links to flashplayer (and other plugins) when mozilla is updated

2003-11-15 Thread [ghibo]
http://qa.mandrakesoft.com/show_bug.cgi?id=6360





--- Additional Comments From [EMAIL PROTECTED]  2003-11-15 15:30 ---
regarding FlashPlayer, version 6.0-5mdk (ready since 5 september) was
like that, i.e. with plugins in /usr/lib/mozilla/plugins and links
to /usr/lib/netscape/plugins. Probably someone forgot to be place it
there, like RealPlayer (with plugin splitten in a separated package
RealPlayer-rpnp).

Regarding $2, i.e. number of instances of target packages installed,
that test should be already computed in %triggerin ($2 -ge 2 and
%triggerpostun ($2 = 0), so it shouldn't be needed anymore
(symbolic links should be removed when mozilla is uninstalled or triggered
plugin is uninstalled, but not when either mozilla is upgraded,
or plugin is upgraded too).

What I don't understand is why $1 is zero in %triggerun,
during the upgrade of mozilla, $1 is 0 and not something other. In
fact, rpm -vv -Fvh *1.4-17mdk* gives these commands to be executed:

+ '[' 0 = 0 ']'
+ '[' -L /usr/lib/mozilla/plugins/libflashplayer.so ']'
+ rm -f /usr/lib/mozilla/plugins/libflashplayer.so
+ rm -f /usr/lib/mozilla/plugins/flashplayer.xpt

which removes links. Has RPM triggers changed behavior? I remember
that Epoch was causing strange effects in triggers in newer rpm,
when version numbering is used.


-- 
Configure bugmail: http://qa.mandrakesoft.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


--- Reminder: ---
assigned_to: [EMAIL PROTECTED]
status: UNCONFIRMED
creation_date: 
description: 
When mozilla package is updated, the triggers of the package remove links from
/usr/lib/mozilla/plugins, e.g. the one for flashplayer.

Looking at the triggers one sees:

%triggerun ...
[ $1 = 0 ] || exit 0

This is probably wrong, it should be:

%triggerun ...
[ $2 = 0 ] || exit 0
^

This is also in the examples of /usr/share/doc/rpm-4.2/triggers and makes more
sense, because we care about what happens with the target package ($2), not our
package ($1).