[Cooker] nfs-utils startup script is STILL broken
On Mon, Jan 29, 2001 at 07:34:07PM +0100, Pixel wrote: "Brian J. Murrell" [EMAIL PROTECTED] writes: On Mon, Jan 29, 2001 at 11:45:16AM +0100, Pixel wrote: "Brian J. Murrell" [EMAIL PROTECTED] writes: the guy (florin) taking care of nfs-utils is very busy at the moment. Do you have a patch to fix the pb? I have not really modified nfslock but here's a go: ok, applied in nfs-utils-0.2.1-3mdk I have nfs-utils-0.2.1-3mdk installed and the startup script has reverted back to it's broken state. Please find the patch I sent previously below. Please apply it to nfs-utils and cut a new package ASAP. Thanx, b. --- /etc/rc.d/init.d/nfslockThu Dec 7 08:06:47 2000 +++ nfslock.new Mon Jan 29 07:29:22 2001 @@ -32,16 +32,17 @@ [ -x /usr/sbin/rpc.lockd ] || exit 0 [ -x /usr/sbin/rpc.statd ] || exit 0 -[ "$NEED_LOCKD" = no ] exit 0 # See how we were called. case "$1" in start) # Start daemons. echo "Starting NFS file locking services: " - echo -n "Starting NFS lockd: " - daemon rpc.lockd - echo + if [ "$NEED_LOCKD" = yes ]; then + echo -n "Starting NFS lockd: " + daemon rpc.lockd + echo + fi echo -n "Starting NFS statd: " daemon rpc.statd echo @@ -50,16 +51,18 @@ stop) # Stop daemons. echo "Shutting down NFS file locking services: " - pidlist=`pidofproc lockd` - if [ -n "$pidlist" ]; then - pid= - for apid in $pidlist ; do - [ -f /proc/$apid/exe ] pid="$pid $apid" - done - if [ -n "$pid" ]; then - echo -n "Shutting down NFS lockd: " - killproc lockd - echo + if [ "$NEED_LOCKD" = yes ]; then + pidlist=`pidofproc lockd` + if [ -n "$pidlist" ]; then + pid= + for apid in $pidlist ; do + [ -f /proc/$apid/exe ] pid="$pid $apid" + done + if [ -n "$pid" ]; then + echo -n "Shutting down NFS lockd: " + killproc lockd + echo + fi fi fi echo -n "Shutting down NFS statd: " @@ -73,9 +76,11 @@ ;; restart) echo -n "Restarting NFS file locking services: " - echo -n "rpc.lockd " - killproc lockd - daemon rpc.lockd + if [ "$NEED_LOCKD" = yes ]; then + echo -n "rpc.lockd " + killproc lockd + daemon rpc.lockd + fi echo -n "rpc.statd " killproc rpc.statd daemon rpc.statd @@ -87,7 +92,11 @@ echo start; exit 0 fi /sbin/pidof rpc.statd /dev/null 21; STATD="$?" - /sbin/pidof lockd /dev/null 21; LOCKD="$?" + if [ "$NEED_LOCKD" = yes ]; then + /sbin/pidof lockd /dev/null 21; LOCKD="$?" + else + LOCKD=0 + fi if [ $STATD = 1 -o $LOCKD = 1 ] ; then echo restart; exit 0 fi -- Brian J. Murrell
Re: [Cooker] nfs-utils startup script is STILL broken
"Brian J. Murrell" [EMAIL PROTECTED] writes: I have nfs-utils-0.2.1-3mdk installed and the startup script has reverted back to it's broken state. Please find the patch I sent previously below. canb you check 0.3.1 where initscripts has completely changed. Please apply it to nfs-utils and cut a new package ASAP. can you moderate your language, we are not your slaves.. -- MandrakeSoft Inc http://www.chmouel.org --Chmouel
Re: [Cooker] nfs-utils startup script is STILL broken
On Mon, Feb 19, 2001 at 11:33:38AM +, Chmouel Boudjnah wrote: "Brian J. Murrell" [EMAIL PROTECTED] writes: canb you check 0.3.1 where initscripts has completely changed. I will when it shows up on a mirror somewhere. can you moderate your language, we are not your slaves.. No you are not, but one does get tired having to deal with the same issues over and over again and doing the work of fixing them and sending the fixes here just to see them happen again release after release (even when one is told they are fixed). It seems over the last 3 months or so that I have had to report every problem I am finding with cooker at least several times before any attention is paid to it. I think (hope) I am providing quality bug reports. I try to be brief but include as much relevant detail as possible. If my reports are lacking detail (or something else) please do let me know. A lot of us here are doing a fair amount of work for you folks staying up to date on Cooker, and finding and fixing problems before your next release hits the masses. It would be nice that our efforts did not have to be unnecessarily expensive by having to repeat them over and over again. I will try to moderate my language. I can only hope that the response gets better. b. -- Brian J. Murrell
Re: [Cooker] nfs-utils startup script is STILL broken
"Brian J. Murrell" [EMAIL PROTECTED] writes: It seems over the last 3 months or so that I have had to report every problem I am finding with cooker at least several times before any attention is paid to it. I think (hope) I am providing quality bug reports. I try to be brief but include as much relevant detail as possible. If my reports are lacking detail (or something else) please do let me know. i know that you are doing a good reporting jobs, thanks you but please keep in mind that sometime there is some others way to do reports than to be agressive... -- MandrakeSoft Inc http://www.chmouel.org --Chmouel
