Re: [Cooker] xmms-1.2.7-26mdk
tisdagen den 18 november 2003 23.39 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > tisdagen den 18 november 2003 21.03 skrev Guillaume Cottenceau: > > > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > [...] > > > > > If no tooltip is possible, I'd suggest at least a README.MDK > > > holding all mandrake specific stuff? > > > > As in the new attached patches? > > That's ok for me. Cool! Thank you very much.
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > tisdagen den 18 november 2003 21.03 skrev Guillaume Cottenceau: > > Oden Eriksson <[EMAIL PROTECTED]> writes: > > [...] > > > If no tooltip is possible, I'd suggest at least a README.MDK > > holding all mandrake specific stuff? > > As in the new attached patches? That's ok for me. -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
tisdagen den 18 november 2003 21.03 skrev Guillaume Cottenceau:
> Oden Eriksson <[EMAIL PROTECTED]> writes:
[...]
> If no tooltip is possible, I'd suggest at least a README.MDK
> holding all mandrake specific stuff?
As in the new attached patches?
--- /dev/null 1970-01-01 01:00:00.0 +0100
+++ README.MDK 2003-11-18 21:24:25.0 +0100
@@ -0,0 +1,24 @@
+Additional features for the Mandrake Linux XMMS package.
+
+
+The A-B feature
+---
+
+The A-B feature by Rodrigo Martins de Matos Ventura was found here:
+http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html
+And was rediffed by Oden Eriksson Tue 18 Nov 2003.
+
+Here's Rodrigos explaination what it is about:
+
+"I just did a minor patch to CVS version of xmms, in order to
+add a small but very useful (at least to me) feature: A-B
+repetition. My old CD player has it, and it is extremely useful,
+namely for transcribing music.
+
+The idea is simple: anytime during play, you press the "A" key
+(marks A point), the music keeps playing, when you press the "A" key
+again (marks B point), it loops endlessly between the two marked
+points, until the "S" key is pressed (clear), or a new A point is
+marked. Morover, whenever a A-B range is defined, the "play"
+button/menu jumps straight to the A position."
+
--- xmms/about.c 2003-11-18 21:15:59.0 +0100
+++ xmms/about.c.oden 2003-11-18 21:15:21.0 +0100
@@ -73,6 +73,7 @@
N_("Chris Wilson"),
N_("Dave Yearke"),
N_("Stephan K. Zitz"),
+ N_("Rodrigo Martins de Matos Ventura (the A-B patch)"),
NULL,
N_("Homepage and Graphics:"),
N_("Thomas Nilsson"),
--- xmms/main.c 2002-02-27 15:30:28.0 +0100
+++ xmms/main.c.oden 2003-11-12 15:23:36.0 +0100
@@ -56,8 +56,8 @@
SButton *mainwin_srew, *mainwin_splay, *mainwin_spause, *mainwin_sstop,
*mainwin_sfwd, *mainwin_seject, *mainwin_about;
TButton *mainwin_shuffle, *mainwin_repeat, *mainwin_eq, *mainwin_pl;
-TextBox *mainwin_info, *mainwin_rate_text, *mainwin_freq_text, *mainwin_stime_min,
- *mainwin_stime_sec;
+TextBox *mainwin_info, *mainwin_rate_text, *mainwin_freq_text, *mainwin_ab_text,
+ *mainwin_stime_min,*mainwin_stime_sec;
MenuRow *mainwin_menurow;
HSlider *mainwin_volume, *mainwin_balance, *mainwin_position, *mainwin_sposition = NULL;
MonoStereo *mainwin_monostereo;
@@ -80,6 +80,9 @@
static gchar *mainwin_title_text = NULL;
static gboolean mainwin_info_text_locked = FALSE;
+static int ab_position_a = -1;
+static int ab_position_b = -1;
+
#if 0
/* For x11r5 session management */
static gchar **restart_argv;
@@ -259,7 +262,7 @@
MAINWIN_GENERAL_STOPFADE, MAINWIN_GENERAL_BACK5SEC,
MAINWIN_GENERAL_FWD5SEC, MAINWIN_GENERAL_START, MAINWIN_GENERAL_BACK10,
MAINWIN_GENERAL_FWD10, MAINWIN_GENERAL_JTT, MAINWIN_GENERAL_JTF,
- MAINWIN_GENERAL_EXIT
+ MAINWIN_GENERAL_EXIT, MAINWIN_GENERAL_SETAB, MAINWIN_GENERAL_CLEARAB
};
void mainwin_general_menu_callback(gpointer cb_data, guint action, GtkWidget * w);
@@ -294,6 +297,9 @@
{N_("/Playback/-"), NULL, NULL, 0, ""},
{N_("/Playback/Jump to Time"), "J", mainwin_general_menu_callback, MAINWIN_GENERAL_JTT, ""},
{N_("/Playback/Jump to File"), "J", mainwin_general_menu_callback, MAINWIN_GENERAL_JTF, ""},
+ {N_("/Playback/-"), NULL, NULL, 0, ""},
+{N_("/Playback/Set A-B"), "A", mainwin_general_menu_callback, MAINWIN_GENERAL_SETAB, ""},
+{N_("/Playback/Clear A-B"), "S", mainwin_general_menu_callback, MAINWIN_GENERAL_CLEARAB, ""},
{N_("/Visualization"), NULL, NULL, 0, ""},
{N_("/-"), NULL, NULL, 0, ""},
{N_("/Exit"), NULL, mainwin_general_menu_callback, MAINWIN_GENERAL_EXIT, ""}
@@ -1931,6 +1937,8 @@
void mainwin_play_pushed(void)
{
+if (-1!=ab_position_a)
+input_seek(ab_position_a/1000);
if (get_input_paused())
{
input_pause();
@@ -2447,7 +2455,26 @@
break;
case MAINWIN_GENERAL_EXIT:
mainwin_quit_cb();
- break;
+ break;
+case MAINWIN_GENERAL_SETAB:
+if (playlist_get_current_length() != -1)
+if (-1==ab_position_a) {
+ ab_position_a = input_get_time();
+ ab_position_b = -1;
+ } else if (-1==ab_position_b) {
+int time=input_get_time();
+if (time>ab_position_a) ab_position_b=time;
+ } else {
+ ab_position_a = input_get_time();
+ ab_position_b = -1;
+ }
+break;
+case MAINWIN_GENERAL_CLEARAB:
+if (playlist_get_current_length() != -1) {
+ab_position_a = -1;
+ab_position_b = -1;
+}
+break;
}
}
@@ -2756,6 +2783,7 @@
textbox_set_xfont(mainwin_info, cfg.mainwin_use_xfont, cfg.mainwin_font);
mainwin_rate_text = create_textbox(&mainwin_wlist, mainwin_bg, mainwin_gc, 111, 43, 15, 0, SKIN_TEXT);
mainwin_freq_text = create_textbox(&mai
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > > > So..., what do you propose? Either there is a tooltip, or you will not > > > accept the patch? > > > > I made a request, which was argumented. You haven't begun to > > discuss the validity of the point, did you? > > And I tried to explain there's no where to put the tooltip. I also have tried Ah. Then I didn't get that. When you talked about keystrokes, I suspected you didn't notice the presence of AB in the menu, where I think the tooltip belong. Now according to Levi, menus don't support tooltips, which I wasn't sure about. > to explain why one would need this feature. I guess we at least could This is understood, don't worry :). > information about this in the documentation, maybe in the AUTHORS, FAQ, NEWS > and README files? Also in the about.c file? If no tooltip is possible, I'd suggest at least a README.MDK holding all mandrake specific stuff? -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
tisdagen den 18 november 2003 17.47 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > Yes but I don't need an explanation for me, I know what AB is > > > about. I'm of course talking for users. > > > > So..., what do you propose? Either there is a tooltip, or you will not > > accept the patch? > > I made a request, which was argumented. You haven't begun to > discuss the validity of the point, did you? And I tried to explain there's no where to put the tooltip. I also have tried to explain why one would need this feature. I guess we at least could information about this in the documentation, maybe in the AUTHORS, FAQ, NEWS and README files? Also in the about.c file? [...] > I suspect you really need a break. No, I just need to keep off the keyboard when intoxicated...
Re: [Cooker] xmms-1.2.7-26mdk
On Tue Nov 18 17:44 +0100, Guillaume Cottenceau wrote:
> The following looks like a menu entry:
>
> +{N_("/Playback/Set A-B"), "A", mainwin_general_menu_callback,
> MAINWIN_GENERAL_SETAB, ""},
>
> I assumed this was tooltip'able, while I'm not sure of that, of
> course.
I don't think GTK+'s tooltips can be used for menus. I've definitely
never seen a GTK+ menu with tooltips.
--
Levi Ramsey
[EMAIL PROTECTED] [EMAIL PROTECTED]
Fate is just the weight of circumstances...
Currently playing: George Carlin - - The Hair Place
Linux 2.4.22-8mdk
12:07:00 up 21:14, 7 users, load average: 0.20, 0.15, 0.12
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > > Yes but I don't need an explanation for me, I know what AB is > > about. I'm of course talking for users. > > So..., what do you propose? Either there is a tooltip, or you will not accept > the patch? I made a request, which was argumented. You haven't begun to discuss the validity of the point, did you? > Come on man, give me a break... ? > You can demand a pretty ab button for all skins, and all of the C/C++ code you > may have, as much as you like, I won't give you one, sorry... Sorry too.. > PS. What about the zillions of undocumented Mandrake "features"? Who will make > silly tooltips for those? Or better, try _DOCUMENT_ them? I suspect you really need a break. -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
<[EMAIL PROTECTED]> writes:
> > Yes but I don't need an explanation for me, I know what AB is
> > about. I'm of course talking for users.
>
> Gc, I am afraid people try to get you to understand that there is no
> button to press. So no place for a tooltip to appear. There is no mouse
The following looks like a menu entry:
+{N_("/Playback/Set A-B"), "A", mainwin_general_menu_callback,
MAINWIN_GENERAL_SETAB, ""},
I assumed this was tooltip'able, while I'm not sure of that, of
course.
> pointer above an action widget. You just press A with the keyboard and the
> status window of xmms displays A. It doesn't make much sense to add a
> tooltip if you would go and over above the A (I even think it very hard to do that
> at all since given the way the status window works) since it it not meant
--
Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
måndagen den 17 november 2003 20.12 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > måndagen den 17 november 2003 13.11 skrev Guillaume Cottenceau: > > > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > > "Also, I think it should have a tooltip explaining what it is, as > > > > > it's rather obscure to "normal" people. Would you consider adding > > > > > the tooltip?" > > > > > > > > Where should this tooltip be located? There is no visual stuff until > > > > you press > > > > > > Well, erhm, a tooltip is a widget that appears automatically when > > > you don't move for 2 seconds on a (typically, action) widget. > > > Thus it should appear when one leave mouse pointer on the AB > > > stuff, I guess. > > > > I tried to explain that this is simply not the case, did you check the > > link > > There is no tooltip, yes, and I suggest to add one :). > > > below? > > Yes but I don't need an explanation for me, I know what AB is > about. I'm of course talking for users. So..., what do you propose? Either there is a tooltip, or you will not accept the patch? Come on man, give me a break... You can demand a pretty ab button for all skins, and all of the C/C++ code you may have, as much as you like, I won't give you one, sorry... PS. What about the zillions of undocumented Mandrake "features"? Who will make silly tooltips for those? Or better, try _DOCUMENT_ them? Chears.
Re: [Cooker] xmms-1.2.7-26mdk
On 17 Nov 2003, Guillaume Cottenceau wrote: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > måndagen den 17 november 2003 13.11 skrev Guillaume Cottenceau: > > > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > > "Also, I think it should have a tooltip explaining what it is, as > > > > > it's rather obscure to "normal" people. Would you consider adding > > > > > the tooltip?" > > > > > > > > Where should this tooltip be located? There is no visual stuff until you > > > > press > > > > > > Well, erhm, a tooltip is a widget that appears automatically when > > > you don't move for 2 seconds on a (typically, action) widget. > > > Thus it should appear when one leave mouse pointer on the AB > > > stuff, I guess. > > > > I tried to explain that this is simply not the case, did you check the link > > There is no tooltip, yes, and I suggest to add one :). > > > below? > > Yes but I don't need an explanation for me, I know what AB is > about. I'm of course talking for users. > > Gc, I am afraid people try to get you to understand that there is no button to press. So no place for a tooltip to appear. There is no mouse pointer above an action widget. You just press A with the keyboard and the status window of xmms displays A. It doesn't make much sense to add a tooltip if you would go and over above the A (I even think it very hard to do that at all since given the way the status window works) since it it not meant to be clicked on. d.
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > måndagen den 17 november 2003 13.11 skrev Guillaume Cottenceau: > > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > "Also, I think it should have a tooltip explaining what it is, as > > > > it's rather obscure to "normal" people. Would you consider adding > > > > the tooltip?" > > > > > > Where should this tooltip be located? There is no visual stuff until you > > > press > > > > Well, erhm, a tooltip is a widget that appears automatically when > > you don't move for 2 seconds on a (typically, action) widget. > > Thus it should appear when one leave mouse pointer on the AB > > stuff, I guess. > > I tried to explain that this is simply not the case, did you check the link There is no tooltip, yes, and I suggest to add one :). > below? Yes but I don't need an explanation for me, I know what AB is about. I'm of course talking for users. -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
måndagen den 17 november 2003 13.11 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > "Also, I think it should have a tooltip explaining what it is, as > > > it's rather obscure to "normal" people. Would you consider adding > > > the tooltip?" > > > > Where should this tooltip be located? There is no visual stuff until you > > press > > Well, erhm, a tooltip is a widget that appears automatically when > you don't move for 2 seconds on a (typically, action) widget. > Thus it should appear when one leave mouse pointer on the AB > stuff, I guess. I tried to explain that this is simply not the case, did you check the link below? > > "A". I spent around 10 minutes fixing a simple web page that shows this > > in action, a picture says more than a thousand words. Please check here: > > > > http://www.deserve-it.com/Cooker/xmms-1_2_7-26mdk.html > > > > Download packages for MDK9.2 here: > > > > http://www.deserve-it.com/9.2/
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > > "Also, I think it should have a tooltip explaining what it is, as > > it's rather obscure to "normal" people. Would you consider adding > > the tooltip?" > > Where should this tooltip be located? There is no visual stuff until you press Well, erhm, a tooltip is a widget that appears automatically when you don't move for 2 seconds on a (typically, action) widget. Thus it should appear when one leave mouse pointer on the AB stuff, I guess. > "A". I spent around 10 minutes fixing a simple web page that shows this in > action, a picture says more than a thousand words. Please check here: > > http://www.deserve-it.com/Cooker/xmms-1_2_7-26mdk.html > > Download packages for MDK9.2 here: > > http://www.deserve-it.com/9.2/ -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
fredagen den 14 november 2003 16.10 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > > Also, I think it should have a tooltip explaining what it is, as > > > > > it's rather obscure to "normal" people. Would you consider adding > > > > > the tooltip? > > > > > > > > I could probably do it, but remember I'm no coder... Could I > > > > get some help? > > > > > > Any taker? > > > > I just noticed this is mentioned in the menu, isn't that enough: > > > > Right click -> Playback -> Set A-B A > > Right click -> Playback -> Clear A-B S > > > > ? > > "Also, I think it should have a tooltip explaining what it is, as > it's rather obscure to "normal" people. Would you consider adding > the tooltip?" Where should this tooltip be located? There is no visual stuff until you press "A". I spent around 10 minutes fixing a simple web page that shows this in action, a picture says more than a thousand words. Please check here: http://www.deserve-it.com/Cooker/xmms-1_2_7-26mdk.html Download packages for MDK9.2 here: http://www.deserve-it.com/9.2/
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > > > > Also, I think it should have a tooltip explaining what it is, as > > > > it's rather obscure to "normal" people. Would you consider adding > > > > the tooltip? > > > > > > I could probably do it, but remember I'm no coder... Could I > > > get some help? > > > > Any taker? > > I just noticed this is mentioned in the menu, isn't that enough: > > Right click -> Playback -> Set A-B A > Right click -> Playback -> Clear A-B S > > ? "Also, I think it should have a tooltip explaining what it is, as it's rather obscure to "normal" people. Would you consider adding the tooltip?" -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
torsdagen den 13 november 2003 15.02 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > > How does it behave when you don't have the necessary hardware? I > > > guess it's just available through A and S keystrokes? > > > > You need at least a standard sound card. > > > > "The idea is simple: anytime during play, you press the "A" key > > (marks A point), the music keeps playing, when you press the "A" key > > again (marks B point), it loops endlessly between the two marked > > points, until the "S" key is pressed (clear), or a new A point is > > marked. Morover, whenever a A-B range is defined, the "play" > > button/menu jumps straight to the A position." > > Ok. > > > > Also, I think it should have a tooltip explaining what it is, as > > > it's rather obscure to "normal" people. Would you consider adding > > > the tooltip? > > > > I could probably do it, but remember I'm no coder... Could I > > get some help? > > Any taker? I just noticed this is mentioned in the menu, isn't that enough: Right click -> Playback -> Set A-B A Right click -> Playback -> Clear A-B S ?
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > > How does it behave when you don't have the necessary hardware? I > > guess it's just available through A and S keystrokes? > > You need at least a standard sound card. > > "The idea is simple: anytime during play, you press the "A" key > (marks A point), the music keeps playing, when you press the "A" key > again (marks B point), it loops endlessly between the two marked > points, until the "S" key is pressed (clear), or a new A point is > marked. Morover, whenever a A-B range is defined, the "play" > button/menu jumps straight to the A position." Ok. > > Also, I think it should have a tooltip explaining what it is, as > > it's rather obscure to "normal" people. Would you consider adding > > the tooltip? > > I could probably do it, but remember I'm no coder... Could I > get some help? Any taker? -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
Re: [Cooker] xmms-1.2.7-26mdk
onsdagen den 12 november 2003 18.48 skrev Guillaume Cottenceau: > Oden Eriksson <[EMAIL PROTECTED]> writes: > > Hi. > > > > Here's background info: > > > > I'm very picky when it comes to functionality, and I love features that > > some people maybe even never heard about, or knew existed. One of these > > features is the "A-B" button on my remote control for my Technics SL-P470 > > (audio cd player). As a musician having to figure out song lyrics and > > train guitar solos for the next cover song that we will play live, the > > A-B feature is extremly crucial. I have asked the authors of winamp and > > xmms numerous times about this feature, for at least 4(?) years, well > > since winamp 1.7.3... Guess what? No responce... > > > > The good news is that a guy named "Rodrigo Martins de Matos Ventura" made > > a patch for xmms. I rediffed this patch for the mandrake package and it > > works like a charm! This is so cool! I love it! Now I can use the PC as a > > training device for learning songs and stuff! Awesome! > > How does it behave when you don't have the necessary hardware? I > guess it's just available through A and S keystrokes? You need at least a standard sound card. "The idea is simple: anytime during play, you press the "A" key (marks A point), the music keeps playing, when you press the "A" key again (marks B point), it loops endlessly between the two marked points, until the "S" key is pressed (clear), or a new A point is marked. Morover, whenever a A-B range is defined, the "play" button/menu jumps straight to the A position." > Also, I think it should have a tooltip explaining what it is, as > it's rather obscure to "normal" people. Would you consider adding > the tooltip? I could probably do it, but remember I'm no coder... Could I get some help? > > I guess a lot of fellows (Austin?) would appreciate this patch if they > > only knew about it, and realized the benefits of it. My patches are > > applied to this mail. > > > > To learn more about it, please read this mail: > > > > http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html > > > > (2002-January, duh!) > > XMMS staff never answered I guess? > > > I made packages for Mandrake Linux 9.2, check here: > > > > http://www.deserve-it.com/9.2/ > > > > > > Chears. > > > > > > --- xmms/main.c 2002-02-27 15:30:28.0 +0100 > > +++ xmms/main.c.oden2003-11-12 15:23:36.0 +0100 > > Patch is rather small, nice :).
Re: [Cooker] xmms-1.2.7-26mdk
Oden Eriksson <[EMAIL PROTECTED]> writes: > Hi. > > Here's background info: > > I'm very picky when it comes to functionality, and I love features that some > people maybe even never heard about, or knew existed. One of these features > is the "A-B" button on my remote control for my Technics SL-P470 (audio cd > player). As a musician having to figure out song lyrics and train guitar > solos for the next cover song that we will play live, the A-B feature is > extremly crucial. I have asked the authors of winamp and xmms numerous times > about this feature, for at least 4(?) years, well since winamp 1.7.3... Guess > what? No responce... > > The good news is that a guy named "Rodrigo Martins de Matos Ventura" made a > patch for xmms. I rediffed this patch for the mandrake package and it works > like a charm! This is so cool! I love it! Now I can use the PC as a training > device for learning songs and stuff! Awesome! How does it behave when you don't have the necessary hardware? I guess it's just available through A and S keystrokes? Also, I think it should have a tooltip explaining what it is, as it's rather obscure to "normal" people. Would you consider adding the tooltip? > I guess a lot of fellows (Austin?) would appreciate this patch if they only > knew about it, and realized the benefits of it. My patches are applied to > this mail. > > To learn more about it, please read this mail: > > http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html > > (2002-January, duh!) XMMS staff never answered I guess? > I made packages for Mandrake Linux 9.2, check here: > > http://www.deserve-it.com/9.2/ > > > Chears. > > > --- xmms/main.c 2002-02-27 15:30:28.0 +0100 > +++ xmms/main.c.oden 2003-11-12 15:23:36.0 +0100 Patch is rather small, nice :). -- Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/
[Cooker] xmms-1.2.7-26mdk
Hi.
Here's background info:
I'm very picky when it comes to functionality, and I love features that some
people maybe even never heard about, or knew existed. One of these features
is the "A-B" button on my remote control for my Technics SL-P470 (audio cd
player). As a musician having to figure out song lyrics and train guitar
solos for the next cover song that we will play live, the A-B feature is
extremly crucial. I have asked the authors of winamp and xmms numerous times
about this feature, for at least 4(?) years, well since winamp 1.7.3... Guess
what? No responce...
The good news is that a guy named "Rodrigo Martins de Matos Ventura" made a
patch for xmms. I rediffed this patch for the mandrake package and it works
like a charm! This is so cool! I love it! Now I can use the PC as a training
device for learning songs and stuff! Awesome!
I guess a lot of fellows (Austin?) would appreciate this patch if they only
knew about it, and realized the benefits of it. My patches are applied to
this mail.
To learn more about it, please read this mail:
http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html
(2002-January, duh!)
I made packages for Mandrake Linux 9.2, check here:
http://www.deserve-it.com/9.2/
Chears.
--- xmms.spec 2003-08-29 21:43:00.0 +0200
+++ xmms.spec.oden 2003-11-12 15:34:00.0 +0100
@@ -13,7 +13,7 @@
Name: xmms
Summary: The Sound player with the WinAmp GUI
Version: 1.2.7
-Release: 25mdk
+Release: 26mdk
License: GPL
Group: Sound
URL: http://www.xmms.org/
@@ -53,6 +53,10 @@
Patch50: xmms-1.2.5-3dse-11.patch.bz2
Patch51: xmms-3dse-niqueluisarace.patch.bz2
+# rediffed from this mail:
+# http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html
+Patch60: xmms-1.2.7-AB-repeat.diff.bz2
+
Packager: Guillaume Cottenceau <[EMAIL PROTECTED]>
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
BuildRequires: libglib-devel libgtk+-devel libxml-devel libvorbis-devel libogg-devel
@@ -169,6 +173,9 @@
%endif
%patch51 -p1
+# rediffed from this mail:
+# http://lists.xmms.org/pipermail/xmms-devel/2002-January/002282.html
+%patch60 -p0
%build
autoconf # (gc) patched configure.in
@@ -382,6 +389,9 @@
%endif
%changelog
+* Wed Nov 12 2003 Oden Eriksson <[EMAIL PROTECTED]> 1.2.7-26mdk
+- added P60
+
* Fri Aug 29 2003 Pablo Saratxaga <[EMAIL PROTECTED]> 1.2.7-25mdk
- included new translations
@@ -798,3 +808,4 @@
* Fri Apr 09 1999 Lyle Kempler <[EMAIL PROTECTED]>
- initial version
+
--- xmms/main.c 2002-02-27 15:30:28.0 +0100
+++ xmms/main.c.oden 2003-11-12 15:23:36.0 +0100
@@ -56,8 +56,8 @@
SButton *mainwin_srew, *mainwin_splay, *mainwin_spause, *mainwin_sstop,
*mainwin_sfwd, *mainwin_seject, *mainwin_about;
TButton *mainwin_shuffle, *mainwin_repeat, *mainwin_eq, *mainwin_pl;
-TextBox *mainwin_info, *mainwin_rate_text, *mainwin_freq_text, *mainwin_stime_min,
- *mainwin_stime_sec;
+TextBox *mainwin_info, *mainwin_rate_text, *mainwin_freq_text, *mainwin_ab_text,
+ *mainwin_stime_min,*mainwin_stime_sec;
MenuRow *mainwin_menurow;
HSlider *mainwin_volume, *mainwin_balance, *mainwin_position, *mainwin_sposition = NULL;
MonoStereo *mainwin_monostereo;
@@ -80,6 +80,9 @@
static gchar *mainwin_title_text = NULL;
static gboolean mainwin_info_text_locked = FALSE;
+static int ab_position_a = -1;
+static int ab_position_b = -1;
+
#if 0
/* For x11r5 session management */
static gchar **restart_argv;
@@ -259,7 +262,7 @@
MAINWIN_GENERAL_STOPFADE, MAINWIN_GENERAL_BACK5SEC,
MAINWIN_GENERAL_FWD5SEC, MAINWIN_GENERAL_START, MAINWIN_GENERAL_BACK10,
MAINWIN_GENERAL_FWD10, MAINWIN_GENERAL_JTT, MAINWIN_GENERAL_JTF,
- MAINWIN_GENERAL_EXIT
+ MAINWIN_GENERAL_EXIT, MAINWIN_GENERAL_SETAB, MAINWIN_GENERAL_CLEARAB
};
void mainwin_general_menu_callback(gpointer cb_data, guint action, GtkWidget * w);
@@ -294,6 +297,9 @@
{N_("/Playback/-"), NULL, NULL, 0, ""},
{N_("/Playback/Jump to Time"), "J", mainwin_general_menu_callback, MAINWIN_GENERAL_JTT, ""},
{N_("/Playback/Jump to File"), "J", mainwin_general_menu_callback, MAINWIN_GENERAL_JTF, ""},
+ {N_("/Playback/-"), NULL, NULL, 0, ""},
+{N_("/Playback/Set A-B"), "A", mainwin_general_menu_callback, MAINWIN_GENERAL_SETAB, ""},
+{N_("/Playback/Clear A-B"), "S", mainwin_general_menu_callback, MAINWIN_GENERAL_CLEARAB, ""},
{N_("/Visualization"), NULL, NULL, 0, ""},
{N_("/-"), NULL, NULL, 0, ""},
{N_("/Exit"), NULL, mainwin_general_menu_callback, MAINWIN_GENERAL_EXIT, ""}
@@ -1931,6 +1937,8 @@
void mainwin_play_pushed(void)
{
+if (-1!=ab_position_a)
+input_seek(ab_position_a/1000);
if (get_input_paused())
{
input_pause();
@@ -2447,7 +2455,26 @@
break;
case MAINWIN_GENERAL_EXIT:
mainwin_quit_cb();
- break;
+ break;
+case MAINWIN_GENERAL_SETAB:
+if (playlist_get_current_length() != -1)
+if (-1==ab_position_a) {
+ ab_positio
