Re: [Cooker] Re: [CHRPM] userdrake-0.92-1mdk

2003-06-24 Thread Daouda LO 
Per Øyvind Karlsen <[EMAIL PROTECTED]> writes:

> On Monday 23 June 2003 17:30, Daouda LO wrote:
> >  %prep
> > -%setup -q
> > +rm -rf %{buildroot}
> ^^^
> > +%setup -q
> > +   
> >  %build
> > -%configure
> > -%make
> > -
> > -%install
> > -rm -rf $RPM_BUILD_ROOT
> ^
> 
> that's wrong, you should never touch buildroot in neither %prep nor %build, 
> and you should rm -rf buildroot before anything else in %install...

You're right. It is fixed in cvs. Next build will correct the 'typo'.

Re: [Cooker] Re: [CHRPM] userdrake-0.92-1mdk

2003-06-23 Thread Michael Scherer 
On Monday 23 June 2003 19:27, Per Øyvind Karlsen wrote:
> On Monday 23 June 2003 19:10, Per Øyvind Karlsen wrote:
> > flepied, I hope you'll add this soon
>
> to rpmlint that is

wouldn't it be cleaner to add it automaticaly to the right place with 
rpm-helper, ie, do the rm before  %install ?
This way, people would no more use rm $BUILDROOT in the spec file, and 
so, they would not misplace it.

-- 

Mickaël Scherer

Re: [Cooker] Re: [CHRPM] userdrake-0.92-1mdk

2003-06-23 Thread Per Øyvind Karlsen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Monday 23 June 2003 19:10, Per Øyvind Karlsen wrote:
> flepied, I hope you'll add this soon
to rpmlint that is
- -- 
Regards,
Per Øyvind Karlsen
Sintrax Solutions
http://www.sintrax.net - +47 41681061
- 
GPG Key: http://sintrax.net/~hawkeye/key.asc
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+9zhzv8F7V9JOSuURAsHlAJ9n1Q1y7KoYnGJuDq5yUuvv4ZWm3QCgkn0j
JmLLFBqxBDlCiU5TLv9EYIg=
=rX8H
-END PGP SIGNATURE-