hg: jdk8/tl/jdk: 7196533: TimeZone.getDefault() slow due to synchronization bottleneck
Changeset: fecba6a8b78e Author:coffeys Date: 2012-10-09 12:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java
hg: jdk8/tl: 7173494: some jdk tests are not run in test/Makefile
Changeset: 4bde5640fb36 Author:alanb Date: 2012-10-09 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4bde5640fb36 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile
hg: jdk8/tl/jdk: 7173494: some jdk tests are not run in test/Makefile
Changeset: 3b79177ebfef Author:alanb Date: 2012-10-09 13:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b79177ebfef 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC
Changeset: 036c55976cef Author:lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java
Re: JAXP RFR: 8000172 : 2 SAX features does not work properly
Look OK Joe On Oct 9, 2012, at 12:31 AM, Joe Wang wrote: This is an issue found while I was working with SQE to expand test coverage. For a non-validating parser, when load-external-dtd is false, entity references are skipped. However, the skippedEntity() event was not reported. The problem was due to missing infoset augmentations when document handler's startGeneralEntity/endGeneralEntity were called. The fix therefore is simply add the arguments. webrev: http://cr.openjdk.java.net/~joehw/jdk8/8000172/webrev/ Please review. Thanks, Joe Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: JAXP RFR: 8000172 : 2 SAX features does not work properly
Thanks Lance! On 10/9/2012 7:55 AM, Lance Andersen - Oracle wrote: Look OK Joe On Oct 9, 2012, at 12:31 AM, Joe Wang wrote: This is an issue found while I was working with SQE to expand test coverage. For a non-validating parser, when load-external-dtd is false, entity references are skipped. However, the skippedEntity() event was not reported. The problem was due to missing infoset augmentations when document handler's startGeneralEntity/endGeneralEntity were called. The fix therefore is simply add the arguments. webrev: http://cr.openjdk.java.net/~joehw/jdk8/8000172/webrev/ http://cr.openjdk.java.net/%7Ejoehw/jdk8/8000172/webrev/ Please review. Thanks, Joe http://oracle.com/us/design/oracle-email-sig-198324.gif http://oracle.com/us/design/oracle-email-sig-198324.gifLance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com mailto:lance.ander...@oracle.com
hg: jdk8/tl/jdk: 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances
Changeset: c725ce4bbf12 Author:naoto Date: 2012-10-09 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c725ce4bbf12 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/DateFormatSymbolsProviderImpl.java
Review Request: 7186817 - Remove Windows 95/98/ME Support
Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/ http://cr.openjdk.java.net/%7Edxu/7186817/webrev/ The main focus of this clean-up is in IO area. And I also cleaned java/lang/ProcessImpl_md.c and java/util/TimeZone_md.c in this transaction. Thanks, -Dan
RFR : 7196086 : update copyright years for files in corba repository (JDK 8)
steve.si...@oracle.com has contributed the following patch which I'd like to push to jdk8 TL. It's the correction of copyright years in corba repo. Need a reviewer. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7196086.jdk8/ http://cr.openjdk.java.net/%7Ecoffeys/webrev.7196086.jdk8/ regards, Sean.
hg: jdk8/tl/jdk: 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed
Changeset: 71de5e31d497 Author:coffeys Date: 2012-10-09 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Reviewed-by: alanb, chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/SocketGrowth.java
Re: RFR : 7196086 : update copyright years for files in corba repository (JDK 8)
looks fine Sean Best Lance On Oct 9, 2012, at 2:38 PM, Seán Coffey wrote: steve.si...@oracle.com has contributed the following patch which I'd like to push to jdk8 TL. It's the correction of copyright years in corba repo. Need a reviewer. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7196086.jdk8/ http://cr.openjdk.java.net/%7Ecoffeys/webrev.7196086.jdk8/ regards, Sean. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/corba: 7196086: update copyright years for files in corba repository (JDK 8)
Changeset: 679e8ad9874f Author:coffeys Date: 2012-10-09 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f 7196086: update copyright years for files in corba repository (JDK 8) Reviewed-by: lancea ! make/common/Defs-bsd.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Defs-bsd.gmk ! make/common/shared/Defs-utils.gmk ! make/tools/src/build/tools/stripproperties/StripPropertiesCorba.java ! make/tools/strip_properties/Makefile
Re: Review Request: 7186817 - Remove Windows 95/98/ME Support
On 09/10/2012 18:46, Dan Xu wrote: Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/ http://cr.openjdk.java.net/%7Edxu/7186817/webrev/ The main focus of this clean-up is in IO area. And I also cleaned java/lang/ProcessImpl_md.c and java/util/TimeZone_md.c in this transaction. Thanks, -Dan This is great clean-up. I haven't gone through it all yet but one question - are there any changes to the code that moved from Win32FileSystem to WinNTFileSystem? I'm just wondering whether there is anything that needs a closer look. -Alan
Re: Review Request: 7186817 - Remove Windows 95/98/ME Support
Hi,
I did not look into the details, but the hint about performance on String.toLower in
WindowsNTFileSystem catched my attention. Here is a very fast converter, which may be enough for
calculating the hash:
// Private ASCII-only optimized version
public static final String toUpper(final String s) {
boolean allUpper = true;
char[] ca = null;
for (int i=0; is.length(); i++) {
int c = s.charAt(i);
if (c = 'a' c = 'z') {
if (allUpper) {
ca = s.toCharArray();
allUpper = false;
}
ca[i] -= '\u0020';
}
}
return allUpper ? s : new String(ca);
}
It also avoids instantiation of new objects, if there is nothing to change.
Note: the equivalent toLower algorithm statistically would be little slower on latin characters, but
maybe faster on wide spreaded Unicode characters.
-Ulf
Am 09.10.2012 19:46, schrieb Dan Xu:
Hi folks,
Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev
has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/
http://cr.openjdk.java.net/%7Edxu/7186817/webrev/
The main focus of this clean-up is in IO area. And I also cleaned java/lang/ProcessImpl_md.c and
java/util/TimeZone_md.c in this transaction.
Thanks,
-Dan
Re: RFR: 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol]
On Mon, Oct 8, 2012 at 2:24 PM, Rob McKenna rob.mcke...@oracle.com wrote: Thanks Martin, Updated webrev at: http://cr.openjdk.java.net/~robm/7152183/webrev.03/ The latest webrev looks correct to me - thanks! I'd also make a couple of pedantic cosmetic changes: 1969 Object deferred = null; A good place to use a blank final final Object deferred; +Field useCountField; Merge the declaration down to the initialization.
Re: Review Request: 7186817 - Remove Windows 95/98/ME Support
On 10/09/2012 12:30 PM, Alan Bateman wrote: On 09/10/2012 18:46, Dan Xu wrote: Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/ http://cr.openjdk.java.net/%7Edxu/7186817/webrev/ The main focus of this clean-up is in IO area. And I also cleaned java/lang/ProcessImpl_md.c and java/util/TimeZone_md.c in this transaction. Thanks, -Dan This is great clean-up. I haven't gone through it all yet but one question - are there any changes to the code that moved from Win32FileSystem to WinNTFileSystem? I'm just wondering whether there is anything that needs a closer look. -Alan Thanks, Alan. There are no code changes when moving them from Win32FileSystem to WinNTFileSystem. -Dan
Re: Review Request: 7186817 - Remove Windows 95/98/ME Support
Hi Ulf,
I think it is better to focus on the clean-up for my current
transaction. The performance improvement of toUpper() method can be
another topic for String class.
Thanks,
-Dan
On 10/09/2012 12:31 PM, Ulf Zibis wrote:
Hi,
I did not look into the details, but the hint about performance on
String.toLower in WindowsNTFileSystem catched my attention. Here is a
very fast converter, which may be enough for calculating the hash:
// Private ASCII-only optimized version
public static final String toUpper(final String s) {
boolean allUpper = true;
char[] ca = null;
for (int i=0; is.length(); i++) {
int c = s.charAt(i);
if (c = 'a' c = 'z') {
if (allUpper) {
ca = s.toCharArray();
allUpper = false;
}
ca[i] -= '\u0020';
}
}
return allUpper ? s : new String(ca);
}
It also avoids instantiation of new objects, if there is nothing to
change.
Note: the equivalent toLower algorithm statistically would be little
slower on latin characters, but maybe faster on wide spreaded Unicode
characters.
-Ulf
Am 09.10.2012 19:46, schrieb Dan Xu:
Hi folks,
Please help review the code change for CR7186817 to remove Windows
95/98/ME support. The webrev has been uploaded to
http://cr.openjdk.java.net/~dxu/7186817/webrev/
http://cr.openjdk.java.net/%7Edxu/7186817/webrev/
The main focus of this clean-up is in IO area. And I also cleaned
java/lang/ProcessImpl_md.c and java/util/TimeZone_md.c in this
transaction.
Thanks,
-Dan
hg: jdk8/tl/jaxp: 8000172: 2 SAX features does not work properly
Changeset: 53a2a4893c8f Author:joehw Date: 2012-10-09 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/53a2a4893c8f 8000172: 2 SAX features does not work properly Summary: When external dtd is not loaded, skippedEntity event should be reported for entity references. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java
Re: Review Request: 7186817 - Remove Windows 95/98/ME Support
Thanks Zhong, you are correct.
So we additionally can save again 1 variable and 2 lines.
-Ulf
Am 09.10.2012 23:08, schrieb Zhong Yu:
Ulf, since
allUpper == ca==null
we don't need allUpper...
On Tue, Oct 9, 2012 at 2:31 PM, Ulf Zibis ulf.zi...@cosoco.de wrote:
Hi,
I did not look into the details, but the hint about performance on
String.toLower in WindowsNTFileSystem catched my attention. Here is a very
fast converter, which may be enough for calculating the hash:
// Private ASCII-only optimized version
public static final String toUpper(final String s) {
boolean allUpper = true;
char[] ca = null;
for (int i=0; is.length(); i++) {
int c = s.charAt(i);
if (c = 'a' c = 'z') {
if (allUpper) {
ca = s.toCharArray();
allUpper = false;
}
ca[i] -= '\u0020';
}
}
return allUpper ? s : new String(ca);
}
It also avoids instantiation of new objects, if there is nothing to change.
Note: the equivalent toLower algorithm statistically would be little slower
on latin characters, but maybe faster on wide spreaded Unicode characters.
-Ulf
Am 09.10.2012 19:46, schrieb Dan Xu:
Hi folks,
Please help review the code change for CR7186817 to remove Windows
95/98/ME support. The webrev has been uploaded to
http://cr.openjdk.java.net/~dxu/7186817/webrev/
http://cr.openjdk.java.net/%7Edxu/7186817/webrev/
The main focus of this clean-up is in IO area. And I also cleaned
java/lang/ProcessImpl_md.c and java/util/TimeZone_md.c in this transaction.
Thanks,
-Dan
hg: jdk8/tl/langtools: 8000663: clean up langtools imports
Changeset: c75be5bc5283 Author:jjg Date: 2012-10-09 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c75be5bc5283 8000663: clean up langtools imports Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java !
