hg: jdk8/tl/langtools: 8001714: add missing tests for 7199925
Changeset: 64fce9f95b1d Author:jjg Date: 2012-10-26 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64fce9f95b1d 8001714: add missing tests for 7199925 Reviewed-by: darcy + test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java + test/tools/javac/annotations/repeatingAnnotations/SeparateCompile.java
Re: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012
Thanks David,
java.sun.com... D'oh. Updated and pushed. The meat will come shortly!
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779
-Chris.
On 10/26/2012 03:06 AM, David Holmes wrote:
Hi Chris,
You can count me as a reviewer anyway. :)
A couple of observations:
--- old/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:15 2012
+++ new/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:14 2012
@@ -79,11 +79,9 @@
/**
* Constructs an ExecutionException with the specified
cause.
- * The detail message is set to:
- *
- * (cause == null ? null : cause.toString())
- * (which typically contains the class and detail message of
- * cause).
+ * The detail message is set to {@code (cause == null ? null :
+ * cause.toString())} (which typically contains the class and
+ * detail message of cause).
The last cause should be replaced by {@Code cause}.
There are a couple of places that refer to JLS (eg package-info,
Locks.java)
+ * http://java.sun.com/docs/books/jls/";> The Java Language
+ * Specification, Third Edition (17.4 Memory Model):
which should, I believe, be updated to:
http://docs.oracle.com/javase/specs/jls/se7/html/index.html
Thanks,
David
On 26/10/2012 12:13 AM, Chris Hegarty wrote:
In preparation to a re-sync of the java.util.concurrent classes with
Doug's CVS, I've extracted most of the minor/small changes. This will
reduce the noise when reviewing the remainder of the implementation
changes. More specifically,
Cleanup:
javadoc style/consistency
javadoc example code style
imports
whitespace
uniform serialization method javadoc
typos
Minor/small impl changes:
remove redundant null checks
throw NPE when more efficient
rework timeouts, lasttime -> deadline
STPE, make drainTo methods more robust when add throws
To be clear, I'm not requested a review here. These are Doug's changes
are I am already a reviewer, but please feel free ( be warned, nothing
interesting here! )
http://cr.openjdk.java.net/~chegar/8001575/webrev.00/webrev/
-Chris.
hg: jdk8/tl/jdk: 8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012
Changeset: 3fc5457cf779 Author:dl Date: 2012-10-26 21:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779 8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012 Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/BrokenBarrierException.java ! src/share/classes/java/util/concurrent/CompletionService.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/CountDownLatch.java ! src/share/classes/java/util/concurrent/CyclicBarrier.java ! src/share/classes/java/util/concurrent/Delayed.java ! src/share/classes/java/util/concurrent/ExecutionException.java ! src/share/classes/java/util/concurrent/Executor.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/RecursiveAction.java ! src/share/classes/java/util/concurrent/RejectedExecutionException.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/Semaphore.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/ThreadFactory.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/package-info.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! src/share/classes/java/util/concurrent/locks/Lock.java ! src/share/classes/java/util/concurrent/locks/LockSupport.java ! src/share/classes/java/util/concurrent/locks/ReentrantLock.java ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! src/share/classes/java/util/concurrent/package-info.java
hg: jdk8/tl/langtools: 8001219: Clean up use of URLs in javadoc Extern class
Changeset: 217c265158fe Author:jjg Date: 2012-10-26 13:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/217c265158fe 8001219: Clean up use of URLs in javadoc Extern class Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java
Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code
Looks good to me. You also fixed the new build to include java.io.FileSystem - that's good. Mandy On 10/25/2012 2:26 PM, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the change, the native codes for windows and unix platforms are removed. Instead, corresponding Java codes are added for each platform. Thanks! -Dan
hg: jdk8/tl/jdk: 4239752: FileSystem should be a platform-specific class to avoid native code
Changeset: 0b52c87c39da Author:dxu Date: 2012-10-26 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b52c87c39da 4239752: FileSystem should be a platform-specific class to avoid native code Reviewed-by: alanb, dholmes, erikj, jgish ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/FILES_java.gmk ! make/java/java/mapfile-vers ! makefiles/CompileJavaClasses.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileSystem.java + src/solaris/classes/java/io/DefaultFileSystem.java - src/solaris/native/java/io/FileSystem_md.c + src/windows/classes/java/io/DefaultFileSystem.java - src/windows/native/java/io/FileSystem_md.c
Re: Review Request - JDK-4239752: FileSystem should be a platform-specific class to avoid native code
On 25/10/2012 22:26, Dan Xu wrote: Hi, Please review the code change to avoid native codes when creating the FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/. In the change, the native codes for windows and unix platforms are removed. Instead, corresponding Java codes are added for each platform. Thanks! -Dan Thanks for taking this one, the changes looks good to me, and a good follow-up to 7186817 [1]. Also thank you for spending the time to make sure that it builds with both the old and the new build system. I'll push it for you today. -Alan. [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2be39b27e1c
