Re: Review request for 8001536 updated
Here is revised webrev taking into account Remi's suggestions http://cr.openjdk.java.net/~lancea/8001536/webrev.01/ Best, Lance On Oct 30, 2012, at 2:05 PM, Remi Forax wrote: On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote: Hi, This is a request for review of http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds read/writeObject as well as clone methods to SerialXLob classes. All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a bug in the test that the TCK team is aware of and will address. JDBC Unit tests all pass . Hi Lance. In SerialBlob and in SerialClob test (obj == null) is not necessary in equals, null instanceof X is always false. in hashCode, Objects.hash() allocate an array to pass arguments to Arrays.hashCode() and box primitive values to Object. while this method is really convenient to use, each calls will allocate an array and box the two values, the overhead seems to high here. This code should be equivalent: return ((31 +Arrays.hashCode(buf)) * 31 +len) * 31 + origLen; in clone, sb should not be initialized to null and the catch should be: throw new InternalError(e), this is the standard code you can see in clone. in readObject, the test (buf.length != len) can be done before decoding the blob. in writeObject, you set blob twice, which is weird, also I think that if blob is not Serializable, the code should throw an exception, so you should not use instanceof and let s.writeFields() to throw NotSerializable exception. cheers, Rémi Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/jaxws: 2 new changesets
Changeset: d265b9b4c0f5 Author:katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d265b9b4c0f5 Added tag jdk8-b61 for changeset 97e5e74e2a34 ! .hgtags Changeset: c27ea8d489e8 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags
hg: jdk8/tl: 6 new changesets
Changeset: 8343ccdd63f1 Author:katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8343ccdd63f1 Added tag jdk8-b61 for changeset 20ff117b5090 ! .hgtags Changeset: c12e759ac4e8 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simo...@gmail.com ! README-builds.html + make/scripts/fixpath.pl ! make/scripts/vsvars.sh Changeset: 8a3fe0ae06a8 Author:katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8a3fe0ae06a8 Merge Changeset: 4e984be114bd Author:katleman Date: 2012-10-25 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4e984be114bd Added tag jdk8-b62 for changeset 8a3fe0ae06a8 ! .hgtags Changeset: 744e165aaf33 Author:lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/744e165aaf33 Merge Changeset: ce212cd7ea69 Author:lana Date: 2012-10-25 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ce212cd7ea69 Merge
hg: jdk8/tl/jaxp: 4 new changesets
Changeset: 5d0fa0108d02 Author:katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5d0fa0108d02 Added tag jdk8-b61 for changeset 6b1db0b41d2f ! .hgtags Changeset: a96e34e038f5 Author:katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags Changeset: 23e1d537224b Author:lana Date: 2012-10-23 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/23e1d537224b Merge Changeset: fc589819b335 Author:lana Date: 2012-10-25 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/fc589819b335 Merge
hg: jdk8/tl/jdk: 49 new changesets
Changeset: 1ae6420126af Author:katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ae6420126af Added tag jdk8-b61 for changeset 61ddb3fd000a ! .hgtags Changeset: 61af38b8d4ff Author:twisti Date: 2012-10-19 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61af38b8d4ff 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: jrose ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/PrivateInvokeTest.java Changeset: 7a7e49acadec Author:kamg Date: 2012-10-22 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7e49acadec 8001225: Disable jdk regression test java/lang/System/Versions.java until jdk's classfile version code is updated Summary: Exclude java/lang/System/Versions.java test Reviewed-by: sspitsyn, coleenp ! test/ProblemList.txt Changeset: a0a2b186ae28 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simo...@gmail.com ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh ! make/tools/freetypecheck/Makefile + make/tools/msys_build_scripts/dospath.sh + make/tools/msys_build_scripts/dospath.vbs Changeset: 50b8b17449d2 Author:katleman Date: 2012-10-24 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50b8b17449d2 Merge Changeset: 65d2c6726487 Author:katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65d2c6726487 Added tag jdk8-b62 for changeset 50b8b17449d2 ! .hgtags Changeset: 117eed515e42 Author:bae Date: 2012-10-23 13:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/117eed515e42 7051394: NullPointerException when running regression tests LoadProfileTest by using openjdk-7-b144 Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: aeb96dec1c6b Author:lana Date: 2012-10-23 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aeb96dec1c6b Merge Changeset: 93e2669f1ac2 Author:leonidr Date: 2012-10-09 18:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93e2669f1ac2 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Reviewed-by: anthony ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 527f8eeb8e8d Author:leonidr Date: 2012-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/527f8eeb8e8d 7124321: [macosx] TrayIcon MouseListener is never triggered Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CTrayIcon.java ! src/macosx/native/sun/awt/CTrayIcon.h ! src/macosx/native/sun/awt/CTrayIcon.m Changeset: d4d0327e36e2 Author:kshefov Date: 2012-10-12 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4d0327e36e2 7184326: TEST_BUG: java/awt/Frame/7024749/bug7024749.java has a typo Reviewed-by: anthony ! test/java/awt/Frame/7024749/bug7024749.java Changeset: 34d502d14a61 Author:lana Date: 2012-10-12 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34d502d14a61 Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: f42d178f0452 Author:anthony Date: 2012-10-16 20:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f42d178f0452 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Summary: Throw AWTError instead of InternalError if the DISPLAY is bad Reviewed-by: anthony, serb Contributed-by: Mikhail Cherkasov mikhail.cherka...@oracle.com ! src/solaris/native/sun/awt/awt_GraphicsEnv.c + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 47cdc463b4b0 Author:kizune Date: 2012-10-17 14:32 +0400 URL:
hg: jdk8/tl/langtools: 8001664: refactor javadoc to use abstraction to handle files
Changeset: b980e8e6aabf Author:jjg Date: 2012-10-31 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b980e8e6aabf 8001664: refactor javadoc to use abstraction to handle files Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourcePath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testDocFileDir/TestDocFileDir.java
Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK
Hi Kumar, So after this jdk8 builds will have to use current langtools javac in order to work? The corresponding changes to the new build system will be needed as well. David On 1/11/2012 3:43 AM, Kumar Srinivasan wrote: Hello, Please review changes to rev up the default -source and -target for jdk compilation, thus producing v52.0 class files. Bug is here: https://jbs.oracle.com/bugs/browse/JDK-8001191 Webrev is here: http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ Note: this webrev is generated against the master repository but changes will be pushed via tl after the tl-master sync is completed. Thanks Kumar
Re: RFR: 7050936: (pack200) Support version 52.0 class files
Hi Kumar, On 1/11/2012 4:15 AM, Kumar Srinivasan wrote: Please review change which allows pack200 to recognize the class file v52.0. Looks fine, but I'm curious - if constants.h was never updated for 51.0 are those values even being used? David Bug is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7050936 Webrev is here: http://cr.openjdk.java.net/~ksrini/7050936/webrev.0/ Thanks Kumar
Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK
Hi Jon, On 1/11/2012 12:09 PM, Jonathan Gibbons wrote: David, For a long time now, the JDK 8 langtools repo has accepted -source 8 and -target 8, so this should not affect which version of langtools you need to use. Of course, you do need to make sure that these options are not used with the bootstrap javac, which will typically be from JDK 7. That wasn't quite my query/concern - I wasn't very clear. If someone is doing a partial build, ie JDK repo only, they will now have to use a JDK8 boot JDK (or point to suitable langtools import?) - correct? (Where a full build would use the current langtools to build the rest of the JDK.) Just trying to understand if there may be places (JPRT?) where we've so far been able to use a JDK7 boot JDK but will no longer be able to. Thanks, David -- Jon On 10/31/2012 06:38 PM, David Holmes wrote: Hi Kumar, So after this jdk8 builds will have to use current langtools javac in order to work? The corresponding changes to the new build system will be needed as well. David On 1/11/2012 3:43 AM, Kumar Srinivasan wrote: Hello, Please review changes to rev up the default -source and -target for jdk compilation, thus producing v52.0 class files. Bug is here: https://jbs.oracle.com/bugs/browse/JDK-8001191 Webrev is here: http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ Note: this webrev is generated against the master repository but changes will be pushed via tl after the tl-master sync is completed. Thanks Kumar
XS RFR: 7198815 Add the minimal VM as known in jvm.cfg
http://cr.openjdk.java.net/~dholmes/7198815/webrev/ The minimal VM has just reached jdk8/jdk8/hotspot. This change makes it easy for anyone building the minimal VM to actually select it at runtime. Only 32-bit linux platforms are targeted. This will be pushed via the TL repo. Thanks, David
