Re: RFR v6 - 8027634: Support @argfiles for java command-line tool
> On Aug 21, 2015, at 3:46 PM, Henry Jen wrote: > > v7 is up, changes are > > - Add formfeed character(\u000c) as while space character > - Support escape \f for formfeed character in quote > - Update java help output to include @ and -Xdisable-@files > > http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v7/webrev/ The diff you sent in another mail is useful for just reviewing the delta change. That looks fine. launcher.properties @ following -splash seems a little awk but it's consistent with javac -help and that’s okay. Thanks Mandy
Where is Tristan
I will be OOO from Aug 24th to Sept 7th. I will be checking Email intermittently but I won't be online. Drop me a mail if you need something from me. Tristan
Re: RFR 8073056: Repeating annotations throws java.security.AccessControlException with a SecurityManager
Belatedly, the
http://cr.openjdk.java.net/~jfranck/8073056/webrev.02/
webrev looks fine other than a missing space in a line of
AnnotationSuport.java:
208 }catch (Throwable t) { // from
InvocationHandler::invoke
Thanks,
-Joe
On 3/28/2015 3:24 AM, Joel Borggrén-Franck wrote:
Hi,
On 27 Feb 2015, at 11:06, Peter Levart wrote:
On 02/27/2015 10:27 AM, Joel Borggrén-Franck wrote:
On 26 feb 2015, at 22:35, Peter Levart
wrote:
On 02/26/2015 10:27 PM, Peter Levart wrote:
The m.setAccessible(true) for the methods is needed to access methods of
non-public annotations, right? This call could be moved to AnnotationType
constructor as there it will be performed only once per Method object.
...which will have the added benefit in that it will guarantee that only one
MethodAccessor object per Method will ever be constructed instead of two…
I don’t see this. setAccessible sets override in AccessibleObject, I don’t see
a new MethodAccessor being generated here.
My fault! I was mistakenly thinking of Field objects in the context of
setAccessible(boolean). If you use a Field object in two modes it will create
and retain two different FieldAccessors (because they are different
implementations in case field is final).
But I agree with you, and setting it as accessible in the AnnotationType
constructor should arguably be more secure since then we know it isn’t shared
since we just got our copy fresh from getDeclaredMethods().
That's a good point from maintainability perspective, yes, if someone some time decides
to "optimize" the AnnotationType. I think it would be nice if AnnotationType
documents that members() method returns Method objects that are pre-conditioned with
setAccessible(true) and that users should not change this flag.
I don’t want to do this in AnnotationType without a bigger overhaul that may be
slightly incompatible and therefor should be 9 only. I do want to backport this
fix to 8 however, so here is an alternative solution that should be safe and
correct at the cost of extra allocation in the path for custom implementations
of annotations (that should be rare).
New webrev:
http://cr.openjdk.java.net/~jfranck/8073056/webrev.02/
cheers
/Joel
Re: RFR v6 - 8027634: Support @argfiles for java command-line tool
v7 is up, changes are - Add formfeed character(\u000c) as while space character - Support escape \f for formfeed character in quote - Update java help output to include @ and -Xdisable-@files http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v7/webrev/ Cheers, Henry > On Aug 18, 2015, at 11:00 AM, Mandy Chung wrote: > > > > On 08/17/2015 09:15 PM, Henry Jen wrote: >> v6 is available at >> >> http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v6/webrev/ > > Thanks for the update. Looks fine. > > Mandy
Re: RFR 8133939: javadoc clarification for java.sql.Date.toLocalDate()
Looks good, Lance.
Best,
Joe
On 8/21/2015 5:48 AM, Lance Andersen wrote:
Hi,
Here is a minor javadoc update for java.sql.Date.toLocalDate(). The ccc has
been approved.
Best
Lance
hg diff Date.java
diff -r 562b349a85da src/java.sql/share/classes/java/sql/Date.java
--- a/src/java.sql/share/classes/java/sql/Date.java Tue Aug 18 20:30:15
2015 -0700
+++ b/src/java.sql/share/classes/java/sql/Date.java Wed Aug 19 10:03:58
2015 -0400
@@ -295,11 +295,8 @@
}
/**
- * Converts this {@code Date} object to a {@code LocalDate}
- *
- * The conversion creates a {@code LocalDate} that represents the same
- * date value as this {@code Date} in local time zone
- *
+ * Creates a {@code LocalDate} instance using the year, month and day
+ * from this {@code Date} object.
* @return a {@code LocalDate} object representing the same date value
*
* @since 1.8
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
RFR 8133939: javadoc clarification for java.sql.Date.toLocalDate()
Hi,
Here is a minor javadoc update for java.sql.Date.toLocalDate(). The ccc has
been approved.
Best
Lance
hg diff Date.java
diff -r 562b349a85da src/java.sql/share/classes/java/sql/Date.java
--- a/src/java.sql/share/classes/java/sql/Date.java Tue Aug 18 20:30:15
2015 -0700
+++ b/src/java.sql/share/classes/java/sql/Date.java Wed Aug 19 10:03:58
2015 -0400
@@ -295,11 +295,8 @@
}
/**
- * Converts this {@code Date} object to a {@code LocalDate}
- *
- * The conversion creates a {@code LocalDate} that represents the same
- * date value as this {@code Date} in local time zone
- *
+ * Creates a {@code LocalDate} instance using the year, month and day
+ * from this {@code Date} object.
* @return a {@code LocalDate} object representing the same date value
*
* @since 1.8
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
RFR 8133939: javadoc clarification for java.sql.Date.toLocalDate()
Hi,
Here is a minor javadoc update for java.sql.Date.toLocalDate(). The ccc has
been approved.
Best
Lance
hg diff Date.java
diff -r 562b349a85da src/java.sql/share/classes/java/sql/Date.java
--- a/src/java.sql/share/classes/java/sql/Date.java Tue Aug 18 20:30:15
2015 -0700
+++ b/src/java.sql/share/classes/java/sql/Date.java Wed Aug 19 10:03:58
2015 -0400
@@ -295,11 +295,8 @@
}
/**
- * Converts this {@code Date} object to a {@code LocalDate}
- *
- * The conversion creates a {@code LocalDate} that represents the same
- * date value as this {@code Date} in local time zone
- *
+ * Creates a {@code LocalDate} instance using the year, month and day
+ * from this {@code Date} object.
* @return a {@code LocalDate} object representing the same date value
*
* @since 1.8
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader
Hi Alan, yes, I know the error/exception handling is really bad here - it isn't anywhere defined properly. In addition, although the code in JAX-B / JAX-WS / SAAJ was most probably "developed" using cut&paste, it isn't very consistent. I tried to improve it a little bit, but I am not sure how much may I change the behavior because of backwards compatibility. I would prefer fail fast if configuration is wrong, but may I? Maybe Georgiy (added) could advise on that? Anyway even if we don't change it, there should be added some logging. Thanks Miran On 20/08/15 19:18, Alan Bateman wrote: On 19/08/2015 16:37, Miroslav Kos wrote: Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.01/ It's about migrating to standard java.util.ServiceLoader. This part of service discovery was implemented previously "own" way. There are some changes in javadoc and implementation has been refactored in order to use same code as is in JAX-B and SAAJ. I skimmed through this and it mostly looks okay. One thing that probably should be re-examined is the catch Exception in fromJDKProperties as an exception accessing or parsing jaxws.properties will be difficult to diagnose with the code as it is. -Alan
