RE: RFR: 8184693: (opt) add Optional.isEmpty
I missed that Remi. Thanks for pointing it out. Will address those and get back. Regards Vivek -Original Message- From: Remi Forax [mailto:fo...@univ-mlv.fr] Sent: Saturday, April 14, 2018 2:58 PM To: Vivek Theeyarath Cc: core-libs-dev Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty Hi Vivek, OptionalInt, OptionalLong and OptionalDouble should be changed too. Rémi - Mail original - > De: "Vivek Theeyarath" > À: "core-libs-dev" > Envoyé: Samedi 14 Avril 2018 08:22:50 > Objet: RFR: 8184693: (opt) add Optional.isEmpty > Hi All, > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8184693 > > Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/ > > > > The related jtreg test was run and the test passed . > > > > Regards > > Vivek
Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek, the parenthesis around the lambdas in Basic.java are unnecessary Predicate isPositiveNumber = (x -> x > 0); vs Predicate isPositiveNumber = x -> x > 0; the same remark for isNegativeNumber. cheers, Rémi - Mail original - > De: "Vivek Theeyarath" > À: "core-libs-dev" > Envoyé: Samedi 14 Avril 2018 08:22:50 > Objet: RFR: 8184693: (opt) add Optional.isEmpty > Hi All, > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8184693 > > Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/ > > > > The related jtreg test was run and the test passed . > > > > Regards > > Vivek
Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek, OptionalInt, OptionalLong and OptionalDouble should be changed too. Rémi - Mail original - > De: "Vivek Theeyarath" > À: "core-libs-dev" > Envoyé: Samedi 14 Avril 2018 08:22:50 > Objet: RFR: 8184693: (opt) add Optional.isEmpty > Hi All, > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8184693 > > Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/ > > > > The related jtreg test was run and the test passed . > > > > Regards > > Vivek