Re: RFR: 8285838: DST not applying properly with zone id offset set with TZ env variable
On Wed, 11 May 2022 18:00:31 GMT, Gaurav Chaudhari wrote: > This fix ensures that when a lookup for a custom TZ code fails, and an > attempt is made to find the GMT offset in order to get the current time, > Daylight savings rules are applied correctly. Hi, please send me an e-mail at dalibor.to...@oracle.com, so that I can mark your account as verified. - PR: https://git.openjdk.java.net/jdk/pull/8661
Re: RFR: 8286163: micro-optimize Instant.plusSeconds
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote: > Provide micro-benchmark for comparison Hi, please send an e-Mail to dalibor.to...@oracle.com so that I can mark your account as verified. - PR: https://git.openjdk.java.net/jdk/pull/8542
Re: RFR: 8285440: Typo in Collections.addAll method javadoc
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Hi, please (re)submit a completed OCA at OCA.opensource.oracle.com. - PR: https://git.openjdk.java.net/jdk/pull/6942
Re: RFR: 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException
On Thu, 25 Mar 2021 08:19:24 GMT, Fabian Meumertzheim wrote: > Adds missing @throws declarations for ArithmeticException to the public > function > java.math.BigDecimal#stripTrailingZeros > as well as the private helper functions > java.math.BigDecimal#createAndStripZerosToMatchScale(long, int, long) > java.math.BigDecimal#createAndStripZerosToMatchScale(BigInteger, int, long) > > stripTrailingZeros calls one of the two helper functions, both of which > can repeatedly decrease the scale by 1 until it underflows. If it does, > the call to checkScale will result in an ArithmeticException (overflow). Hi, please send me an e-mail at dalibor.to...@oracle.com so that I can verify your account. - PR: https://git.openjdk.java.net/jdk/pull/3189
Re: Garbage Free Check
Hi Ralph,
I've added an apache-log4j-interest label to the issue.
cheers,
dalibor topic
On 14.04.2021 19:00, Ralph Goers wrote:
I don’t have an account in the bug tracking system. Could someone possibly
update the issue noted below to indicate that Apache Log4j 2 would also like
that enhancement?
Thanks,
Ralph
On Apr 5, 2021, at 1:26 PM, Roger Riggs wrote:
Hi,
Java does not have a data type with enough resolution to hold a full nanosecond
value.
Hence the implementation of Instant holding seconds and nanos.
There is an long dormant enhancement request to return micro-seconds as a long.
8196003 <https://bugs.openjdk.java.net/browse/JDK-8196003> java.time Instant
and Duration methods for microseconds
That might be useful if the application gets enough resolution from
microseconds.
There might be some clever interpolation between System.currentTimeMillis()
and adjusting with System.nanoTime().
Though it would likely not be exactly synchronized with the values from Instant.
Regards, Roger
On 4/5/21 3:56 PM, Brian Goetz wrote:
Project Valhalla will allow Instant to be migrated to a primitive class, which
would address your problem.
On 4/2/2021 7:47 PM, Ralph Goers wrote:
Log4j 2 supports the notion of a PreciseClock - one that can be initialized to
something more precise than a millisecond. At the same time it also supports
running with no heap allocations in certain circumstances. I am in the process
of moving our master branch to require Java 11 as the minimum. In doing so I am
encountering unit test errors while verifying that logging is garbage free.
They all occur allocating an Instant.
The code we have simply does
public void init(MutableInstant mutableInstant) {
Instant instant = java.time.Clock.systemUTC().instant();
mutableInstant.initFromEpochSecond(instant.getEpochSecond(), instant.getNano());
}
In our previous tests we had thought the allocation was being eliminated due to
escape analysis since the data is being extracted from the Instant and not
passed along. However, after upgrading the Google test library and the JDK
version it appears that is not the case.
Ideally we would really like something like
public void init(MutableInstant mutableInstant) {
java.time.Clock.systemUTC().initInstant(mutableInstant);
}
where Mutable instant would implement an interface that has the two set
methods.The method would execute the same logic that is in the instant() method
but instead of creating a new Instant it would call the set methods for the
provided object.
This would allow us to either have the MutableInstants in ThreadLocals or some
other mechanism to ensure they are thread safe and have no heap allocations. As
it stands now I see no way to gain access to the higher precision clock without
memory allocation.
Do you know of another way to do this? Am I missing something?
Ralph
--
<http://www.oracle.com> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 , Mobile: +491737185961
, Video: dalibor.to...@oracle.com
Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann
Re: 8214761: Bug in parallel Kahan summation implementation
Hi Anirvan, You can contact contact Oracle’s open-source administrators at opensource_ww_...@oracle.com, who run the OCA app. We don't use the github usernames from the OCA app for OpenJDK pull requests, so you should not be running into issues with that for contributions to OpenJDK. If you do, please let me know off-list which pull request is involved. cheers, dalibor topic On 03.04.2021 22:11, Anirvan Sarkar wrote: Hi Pavel, I think I have the same issue as Chris. The new OCA contributors list [1] is incorrectly linking the user names to GitHub as compared to the old contributors list [2]. It seems the new OCA contributors list is assuming that the GitHub username of past contributors is the same as the username of the project, when they had signed the OCA in the past. When I had signed OCA a few years back for the OpenJFX project, I had provided my username as *anirvan.sarkar*. This was my username on java.net / javafx-jira.kenai.com (the old JIRA for JavaFX project). But my GitHub username is *AnirvanSarkar*, not *anirvan.sarkar* which user does not exist on GitHub. [1] : https://oca.opensource.oracle.com/?ojr=contrib-list [2] : https://oca.opensource.oracle.com/?ojr=old-contrib-list On Sun, 4 Apr 2021 at 03:35, Pavel Rappo wrote: Hey Chris, I don't know exactly what triggers removal of the "oca" and "oca-verify" labels. The only OCA entry for Chris Dennis I could find [1] had a different GitHub username. Did you mistype it or it belongs to another person? Mind you, that person's GitHub page is 404. -Pavel [1] https://oca.opensource.oracle.com/?ojr=contrib-list On 3 Apr 2021, at 16:12, Chris Dennis wrote: A gentle prod. Am I misunderstanding procedure here? From: Chris Dennis Date: Monday, March 22, 2021 at 2:28 PM To: core-libs-dev Subject: 8214761: Bug in parallel Kahan summation implementation I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting on OCA signatory status to be confirmed. Did something get lost in the shuffle or do I just need to be more patient. Thanks, Chris -- <http://www.oracle.com> Dalibor Topic Consulting Product Manager Phone: +494089091214 , Mobile: +491737185961 , Video: dalibor.to...@oracle.com Oracle Global Services Germany GmbH Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRB 246209 Geschäftsführer: Ralf Herrmann
Re: Class-Path (in jar file) semantics different between Java 11 and 13 (on Windows)?
On 18.11.2019 16:56, Jaikiran Pai wrote: Quarkus is a relatively new project and furthermore this specific code is very new too (a few months old I think). So I think this never got covered as part of the outreach efforts. Yeah, Quarkus is not on the OpenJDK Quality Outreach list yet. I've just pinged Emmanuel Bernard about adding it there, so we'll see if that'll change. ;) cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Consulting Product Manager Phone: +494089091214 | Mobile: +491737185961 | Video: dalibor.to...@oracle.com Oracle Global Services Germany GmbH Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRB 246209 Geschäftsführer: Ralf Herrmann <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: PipedInputStream improvement
Hi Ilya, If you are contributing on behalf of your organization, then a person authorized to sign document on behalf of your organization (usually a VP or higher) must sign the OCA, indicating his or her title, for the organization. If you intend to (also) contribute changes individually, i.e. not on behalf of your organization, you need to sign a separate OCA as well as an individual. Please consult the OCA FAQ for details: http://www.oracle.com/technetwork/oca-faq-405384.pdf As described on http://openjdk.java.net/contribute/ If you haven't yet signed the Oracle Contributor Agreement (OCA) then please do so, scan it and e-mail the result to oracle-ca_us(at)oracle.com. Please make sure to specify OpenJDK as the project you'd like to contribute to so that we can process and store your OCA. cheers, dalibor topic On 29.10.2018 20:33, Ilya Gazman wrote: Hey guys, I created a more efficient version of java.io.PipedStream. I would like to have a conversation with you about my implementation and how we can test and benched marked it and eventually maybe even submit it for the next Java release. My name is Ilya Gazman, I work at DoubleVerify, and I did this implementation as part of our work on our core systems. Please guide me through the process of what should I do to receive proper feedback and what are the next steps. Best, Ilya -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Core Type Compilation Issues
On 06.08.2018 20:21, mr rupplin wrote: Three problems that I run into when running the 'make jdk' after minor work on the System.java class for JNI and custom JDK: java/lang/memory/GroupListener.java:111: Can we get explanations for each of these? No. There is no java.lang.memory in OpenJDK. So it looks as if you are not using OpenJDK, you're using something else. Ask whoever gave you what you're using for support. We can't help you fix it. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Getting a live view of environment variables (Gradle and JDK 9)
On 12.10.2017 16:23, Kirk Pepperdine wrote: Hi, On Oct 12, 2017, at 2:54 PM, Mario Torre <neugens.limasoftw...@gmail.com> wrote: 2017-10-12 11:58 GMT+02:00 Cédric Champeau <cedric.champ...@gmail.com>: 1. an API in 18.3 which would let us refresh the environment variables, even if inherently unsafe (we can take the risk, if the Javadocs explains that if you're really unlucky calling such a method could kill your VM). Being a public API we would expose everyone to this risk, and the API should be supported on all platforms maybe forever. I know other people have different opinion here, but this seems to be high risk, high impact to be worth. As I have stated in post postings, this is behavior is unexpected and IMHO shouldn’t be supported. Yeah, it smells a bit like stopThread to me, which may have seemed like an interesting idea at the time, but created a lot of issues down the road, as discussed in https://docs.oracle.com/javase/9/docs/api/java/lang/doc-files/threadPrimitiveDeprecation.html A 'setenv' might not be as simple as it sounds conceptually. For example, it might necessitate thinking through what kind of security permission would be required to govern its use. In addition, having such functionality exposed by default could be a bit like a conveniently placed loaded gun for an attacker attempting to bring a system down - one man's 'unlucky call bringing down your VM' is another man's 'lucky shot'. That's not necessarily a hypothetical concern, as similar designs have had their share of interesting issues in the past. For example: "Cupsd invokes CGI applications for certain requests, and the 'SetEnv' directive allows us to set arbitrary environment variables for these CGI processes." from https://googleprojectzero.blogspot.de/2015/06/owning-internet-printing-case-study-in.html cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Set the effective user ID of the Java process.
Sounds like https://bugs.openjdk.java.net/browse/JDK-5032600 . cheers, dalibor topic On 11.09.2017 14:31, Dmitrii Kashin wrote: I'd like to add to the conversation that this thread was started because of the argue here[1] (russian). The main point of the argue was dropping privileges from root to some user after the program performed all the needed actions (f.e. when it started listening port < 1024). We've found an example in commons-daemon code[2] how to drop privileges in MS Windows systems. It seems a new Access Token is created for some unprivileged user, and then spawns a new process with this token. I suppose it makes some sense to say about it here: it would be very useful to have a possibility to drop privileges to some user. Please consider it as a user request. [1] https://www.opennet.ru/opennews/art.shtml?num=47170#29 [2] https://github.com/apache/commons-daemon/blob/6702852984689bc6507690113949b478dba157ef/src/native/windows/src/rprocess.c#L481 bruno ais <brunoa...@gmail.com> writes: Any idea how it can be done on Windows? Or better yet; is there a cross-platform thing or equivalence of that feature? If not, then that can easily be the reason. On Mon, Sep 11, 2017 at 9:29 AM, DoWhile ForEach <dowhilefore...@gmail.com> wrote: Hello. Please explain someone why the Java API has not yet implemented a method that allows you to set the effective user ID of the Java process. To accomplish this simple task, you have to make some workarounds. A striking example of such workarounds is jsvc tool from the Apache commons-daemon project for Tomcat server: https://github.com/apache/commons-daemon/blob/6702852984689b c6507690113949b478dba157ef/src/native/unix/native/jsvc-unix.c#L163 -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Any known issues posting to core-libs-dev?
Hi Andrew, I'm not yet aware of any ongoing problems posting to lists at this time. Could you please send an e-mail to ops@openjdk detailing the issue, along with the e-mail headers? Thanks! cheers, dalibor topic On 25.08.2017 11:10, Andrew Leonard wrote: Hi, are there any known issues with posting to core-libs-dev at the moment? I've got a couple of colleagues who are newly registered subscribers who have posted but their messages have not got through even after waiting several days...? Thanks Andrew Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: jdk9 vs. jdk8 : TimeZone getDisplayName(Locale.GERMAN) for TZ=MET
On 31.05.2017 17:11, Baesken, Matthias wrote:
I wonder why the display names for timezone MET changed ( I observed this on
Linux and Solaris) when I compare
jdk8 to jdk9 .
The test is very small, it just outputs for Locale.GERMAN the display name.
With jdk8 we get a translated german timezone name, but not with jdk9 (this is
a bit strange because the jdk9 rsource file
src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_de.java
still contains the translation).
Is this intentional or a bug ?
Hi Matthias,
it might be a side effect of http://openjdk.java.net/jeps/252 .
cheers,
dalibor topic
Best regards, Matthias
TimeZoneTest.java
import java.util.TimeZone;
import java.util.Locale;
public class TimeZoneTest {
public static void main(String[] args)
{
TimeZone tz = TimeZone.getDefault();
// now test for german
String dng = tz.getDisplayName(Locale.GERMAN);
System.out.println("timezone display name for Locale.GERMAN " + dng);
}
}
for environment variable TZ=MET (export TZ=MET) we get :
../output-jdk8/images/j2sdk-image/bin/java TimeZoneTest
timezone display name for Locale.GERMAN Zentraleuropäische Zeit
../output-jdk9/images/jdk/bin/java TimeZoneTest
timezone display name for Locale.GERMAN Middle Europe Time
--
<http://www.oracle.com> Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961>
ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
Re: Proposal: javax.naming.spi.NamingManager.clearInitialContextFactoryBuilder()
On 18.05.2017 00:20, Andrew Guibert wrote: Hi Alan, I've checked within IBM and it appears we do not have any OpenJDK committers. Still trying to chase down if we have anyone in IBM who can drive this commit. Do you know of anyone? Hi Andrew, you can find a list of JDK 10 Committers at http://openjdk.java.net/census#jdk10 . You can cross reference it with the list at http://db.openjdk.java.net/people to lookup their organizations, if any. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Getting a live view of environment variables (Gradle and JDK 9)
On 17.05.2017 00:53, Kirk Pepperdine wrote:
println System.getenv('MY_VAR')
doesn't print "foo" after doing:
MY_VAR=foo gradle printVar
I disagree, this would be totally expected behavior. The daemon and this
process would run in different shells and I am unaware of any daemon process
that auto-magically reconfigures it’s self to adapt to any other arbitrary
shell’s changed environment variables. In fact, IMHO, this seems like a
fundamentally flawed way for the deamon process to behave. I believe the client
communicating with the deamon that should be providing information to the
daemon.
It might open a grab bag of exciting behavior depending on what, if any,
filtering is done on the type and content of environment variables being
set.
The $PATH to /tmp/.dr0pp3r/.h3ll/ is paved with good intentions.
cheers,
dalibor topic
--
<http://www.oracle.com> Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961>
ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
Re: Getting a live view of environment variables (Gradle and JDK 9)
Thanks for the explanation, David. That doesn't sound much more risky than what we already do today in getenv. Cheers, Dalibor -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214<tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment > On 15. May 2017, at 07:14, David Holmes <david.hol...@oracle.com> wrote: > > Re-sending to core-libs-dev > >> On 13/05/2017 5:56 PM, David Holmes wrote: >> Hi Dalibor, >> >>> On 12/05/2017 11:28 PM, dalibor topic wrote: >>>> On 11.05.2017 18:29, Cédric Champeau wrote: >>>> >>>> >>>>Unfortunately, they are not safely mutable in multi-threaded >>>>programs on many operating system/libc combinations. >>>> >>>> But the problem is less about mutating, that it is about reading: the VM >>>> returns wrong values at some point, because it _assumes_ that the >>>> environment variables are not mutated. >>> >>> Right. Assuming that another thread could be simultaneously writing to >>> the same data structure holding environment variables (char **), reading >>> itself becomes problematic at such points in time, as you might read a >>> temporarily corrupted data structure. >>> >>> I guess the question underneath is if there is a safe point in time when >>> reading the data could be preformed and no concurrent write from JNI >>> code corrupting the data when it's partially read is possible. >> >> I'm afraid no such safe point guarantee exists at all - even for the >> initial reading of the process environment on the first call to System >> getenv(). There could always potentially be some JNI, or other native >> in-process code, mutating the environ char** at the same time as we >> first read it in the JVM. >> >> But we're not trying to protect against random concurrent updates in the >> current scenario, things are more structured: >> - request comes in with data that says to update certain env vars >> - JNI code updates the env vars >> - the daemon's java code (currently) causes the System.getenv map to be >> updated >> - the "client" code is executed and reads the env var and sees the right >> value >> >> There would have to be a caveat on System.getenv(true) if we went that >> path, that it is up to the user to ensure it is called in as safe a >> manner as possible having regard to any concurrent updates in their >> application code and how the environment is managed on a given platform. >> >> Cheers, >> David >> - >> >>> cheers, >>> dalibor topic
Re: Getting a live view of environment variables (Gradle and JDK 9)
On 11.05.2017 18:29, Cédric Champeau wrote: Unfortunately, they are not safely mutable in multi-threaded programs on many operating system/libc combinations. But the problem is less about mutating, that it is about reading: the VM returns wrong values at some point, because it _assumes_ that the environment variables are not mutated. Right. Assuming that another thread could be simultaneously writing to the same data structure holding environment variables (char **), reading itself becomes problematic at such points in time, as you might read a temporarily corrupted data structure. I guess the question underneath is if there is a safe point in time when reading the data could be preformed and no concurrent write from JNI code corrupting the data when it's partially read is possible. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Getting a live view of environment variables (Gradle and JDK 9)
On 11.05.2017 09:02, Cédric Champeau wrote: Thanks for the answers, folks, but I think they are kind of missing the point. The fact is that environment variables *are* mutable. Unfortunately, they are not safely mutable in multi-threaded programs on many operating system/libc combinations. Consider a situation in which one thread calls a not multi-thread safe setenv() with a long enough piece of data to stuff into an environment variable that it takes more then an instant, while another thread simultaneously calls a not multi-thread safe getenv() and reads the unfinished, corrupted data, potentially reading beyond boundaries and crashing the application. In such an environment, the safest thing to do is to not update environment variables at all. Such environments are very common, unfortunately (Linux/glibc is a rather popular one). Unfortunately, you might not really be able to stop JNI code from calling setenv() or an equivalent (or just messing with char ** environ directly for fun and profit) at any given point in time so you might not be sure that the environment is safe to read at any given point in time, either, except at startup time before anyone has had a chance to mess with the environment in the first place. So the one safe thing one can do is what Java already does. Going beyond in a safe and portable fashion in the JDK itself might be quite tricky and require a bit of thought, because environment variables are quite a bit of mess to deal with - see http://www.club.cc.cmu.edu/~cmccabe/blog_the_setenv_fiasco.html for a nice read. And that's without even starting to think about the security surface of such functionality. For a start, consider the various ways environment variables can go wrong elaborated in https://www.dwheeler.com/secure-programs/Secure-Programs-HOWTO.html#ENVIRONMENT-VARIABLES . So while it may seem that we're missing the point, and you may very well be right, I would naively suspect that providing functionality to read/modify/update environment variables in a way that doesn't cause problems down the road might not be quite as trivial as it might seem. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Accessing module internals from bytecode rewriting agent
On 05.05.2017 08:39, Jeremy Manson wrote: Mostly, I'm telling you all because I think it makes an interesting case study - a large Java installation and the issues it faces trying to roll out JDK 9. Indeed - thank you for providing valuable insight into your concerns and experiences. If other installations do the kinds of things that we do, the path to a JDK 9 without lots of add-exports and kill switch options is likely to be slow and laborious for them. We're comparatively well situated to do it - we have our own JDK build and a staffed team to do / help with the migration, and are likely to roll it out to everyone with the kill switch turned on by default so that our awful hacks can stay put until we finish fixing them. I think part of responsibly relying on awful hacks leveraging unsupported behavior is to budget for their removal/rewrite as the assumptions behind them get invalidated over time. Sometimes, it might be well known where the awful hacks are buried, in particular with one's own code. Other times, in particular with third party code, it might not be quite as obvious. That's where the jdeps & jdeprscan tools come in to help get a sense of the scope & intensity of such problems at compile time. The kill switch complements that at runtime. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: IBM RSA-II "virtual drive" feature does not work with OpenJDK
Hi Martin, we don't provide OpenJDK binaries in Linux distributions. I'd suggest reporting it to the provider of your binaries directly (Debian in this case), as we don't provide a browser plugin implementation, either. Alternatively, you may want to give the distro-pkg-dev mailing list a try, where the developers of the IcedTea-Web plugin and/or Debian packages may be found. cheers, dalibor topic On 08.05.2017 13:00, Martin T wrote: Hi, first of all, I hope that this is a correct mailing list. I have an IBM server with Remote Supervisor Adapter II out-of-band card which provides a remote console function using an Java applet. It works fine with Java version 1.7.0_121 provided by openjdk-7-jre-headless package under Debian and IcedTea-Web plugin version 1.5.3 except one can not use "virtual drive" function: http://i.imgur.com/qDqlFPR.png However, this "virtual drive" feature works fine under Windows(IE 7.0.5730.13, Java SE 1.6.0.05): http://i.imgur.com/a8H7lXn.jpg If I start my browser(Firefox 45.9.0) from the terminal and launch the applet, then it logs following error: java.lang.UnsatisfiedLinkError: VirtualDrive.PassThroughCommand.GetSupportedDevices()LVirtualDrive/SupportedDevices; at VirtualDrive.PassThroughCommand.GetSupportedDevices(Native Method) at com.ibm.asm.remotedisk.RemoteDisk.buildDriveList(Unknown Source) at com.ibm.asm.remotedisk.RemoteDisk.start(Unknown Source) at sun.applet.AppletPanel.run(AppletPanel.java:476) at sun.applet.AppletViewerPanelAccess.run(AppletViewerPanelAccess.java:90) at java.lang.Thread.run(Thread.java:745) I also tried with OpenJDK version 1.8.0_121, but the error message was almost exactly the same: java.lang.UnsatisfiedLinkError: VirtualDrive.PassThroughCommand.GetSupportedDevices()LVirtualDrive/SupportedDevices; at VirtualDrive.PassThroughCommand.GetSupportedDevices(Native Method) at com.ibm.asm.remotedisk.RemoteDisk.buildDriveList(Unknown Source) at com.ibm.asm.remotedisk.RemoteDisk.start(Unknown Source) at sun.applet.AppletPanel.run(AppletPanel.java:476) at sun.applet.AppletViewerPanelAccess.run(AppletViewerPanelAccess.java:84) at java.lang.Thread.run(Thread.java:745) Is this feature not supported by OpenJDK? Please let me know if I can provide any additional information for troubleshooting. thanks, Martin -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Accessing module internals from bytecode rewriting agent
On 02.05.2017 18:46, Jeremy Manson wrote: People are using Xbootclasspath for a variety of things. It's worth keeping in mind when using such options that "Non-standard options are general purpose options that are specific to the Java HotSpot Virtual Machine, so they are not guaranteed to be supported by all JVM implementations, and are subject to change. These options start with -X." http://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html#BABHDABI cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: AppCDS in OpenJDK?
To provide a more general answer: No commercial features are available in OpenJDK. cheers, dalibor topic -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: Optional.isEmpty()
On 24.04.2017 10:26, Andrew Dinn wrote: Ah, bike-shedding! Personally, I much prefer isAbsent() to isNotPresent(), presence and absence being a historically well-sanctioned English language pairing. [n.b. I'll grant that my preference for C18th literature over Comp Sci argot might have swayed my judgement in this matter so I'll leave it to others to sanction or reject that suggestion via a conformantly aligned, textually rendered act of pollification (i.e. go on, post yer +/-1 follow-ups)] If we're going with fine aged literature references for naming things, then isBarren() might signify appealing, yet slightly terrifying existential emptiness. [0] [1] cheers, dalibor topic [0] 'The Draculas were, says Arminius, a great and noble race, though now and again were scions who were held by their coevals to have had dealings with the Evil One. They learned his secrets in the Scholomance, amongst the mountains over Lake Hermanstadt, where the devil claims the tenth scholar as his due. In the records are such words as ‘stregoica’—witch, ‘ordog,’ and ‘pokol’—Satan and hell; and in one manuscript this very Dracula is spoken of as ‘wampyr,’ which we all understand too well. There have been from the loins of this very one great men and good women, and their graves make sacred the earth where alone this foulness can dwell. For it is not the least of its terrors that this evil thing is rooted deep in all good; in soil barren of holy memories it cannot rest.”' [1] "I desired that I might pass my life on that barren rock, wearily, it is true, but uninterrupted by any sudden shock of misery. If I returned, it was to be sacrificed or to see those whom I most loved die under the grasp of a daemon whom I had myself created." -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: On what issues could I help clean up for JDK 9
Community-wide 'starter issues' are a better idea in theory, then they are in practice. Typically the theory behind them is to mark some low priority issues for someone else to fix. But in practice, not all low priority fixes are welcome at all times. See http://mail.openjdk.java.net/pipermail/adoption-discuss/2016-August/001422.html for a longer explanation why that's the case. In practice, it's a better idea to focus new contributors' attention not on what they can do for the large projects with schedules, processes and all that good, complicated stuff that enables releases to happen, like JDK 9 or JDK 8 Updates, but on what they can do in the projects that are in a more exploratory phase, such as Valhalla. Beside exploration of new ideas being more fun for new contributors, they are also often eager for the kind of feedback on the new ideas and designs, that comes from playing with the new toys and often enough, breaking them in interesting ways. cheers, dalibor topic On 02.12.2016 13:53, Patrick Reinhart wrote: What was the outcome of that discussion? I seem to miss that one. My question comes from the past presentation I gave about contributing to the OpenJDK. And one of the main things was not only to do some local hacking but instead try to solve some small issues, that else would not be fixed because of other more important things. -Patrick Am 02.12.2016 um 11:45 schrieb Martijn Verburg <martijnverb...@gmail.com>: There's no JBS query that I know of (I think in the distant past we discussed adding a low hanging fruit 'Duke' tag?). Cheers, Martijn -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: [PATCH] Implement a noop clear() for Collections#EMPTY_LIST
Thanks, Naufal - I'll take a look and let you & Paul know when it's processed. cheers, dalibor topic On 23.05.2016 12:53, Mohamed Naufal wrote: Hi Paul, I've already sent a signed copy of the OCA to oracle-ca...@oracle.com. Thanks, Naufal On 23 May 2016 at 16:13, Paul Sandoz <paul.san...@oracle.com> wrote: Hi Naufal, Thanks for looking at this. For us to accept your patch (no matter how small) you need to become a contributor, which requires that you agree to the Oracle Contributor Agreement (OCA), see: http://openjdk.java.net/contribute/ Thanks, Paul. On 22 May 2016, at 12:10, Mohamed Naufal <naufa...@gmail.com> wrote: Hi, A call to clear() on Collections#EMPTY_LIST is currently redirected to AbstractList#clear(), which performs a bunch of checks and creates a ListItr object, all of which is unnecessary for an EmptyList. PFA a patch that implements a noop clear() for EmptyList. Thanks, Naufal -- <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
Re: [7u-dev] Request for Approval and Review: 8017212: File.createTempFile requires unnecessary read permission
Approved pending a positive review. On 15.08.2014 17:41, Ivan Gerasimov wrote: Hello! I'd like to ask an approval to backport 8017212 into 7u-dev. The patch does not apply cleanly, however the required modifications are quite small. Nevertheless, I will need a peer review for this. The webrev for jdk7: http://cr.openjdk.java.net/~igerasim/8017212/0/webrev/ The difference, compared to jdk8 is: src/share/classes/java/io/File.java -- curly bracket at the end of the line test/java/io/File/createTempFile/SpecialTempFile.java -- there were conflicts due to backport of 8025128, so the test was just copied verbatim from the latest jdk8u. Bug: https://bugs.openjdk.java.net/browse/JDK-8017212 Jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/10d2a4b1e576 Jdk8 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018354.html The change was tested with jprt on all supported platforms. All the io tests, including added and updated, passed. Sincerely yours, Ivan -- http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: [7u backport] RFR: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations
Looks fine to me as well. cheers, dalibor topic On 3/3/14 1:21 PM, dmeetry degrave wrote: Hi all, I would like to ask someone with a reviewer status in jdk7u project to look at these changes. thanks, dmeetry On 02/27/2014 05:44 PM, Joel Borggren-Franck wrote: Hi, I looked at webrev.1. Looks good. cheers /Joel On 2014-02-25, dmeetry degrave wrote: Thanks for looking at this, Peter! On 02/24/2014 04:42 PM, Peter Levart wrote: Hi Dmeetry, On 02/22/2014 01:22 PM, dmeetry degrave wrote: Hi all, I would like to ask for a review of combined back port for 7u-dev/7u80. The main goal is to have a fix for 7122142 in jdk7, it also integrates the changes from 8005232, 7185456, 8022721 https://bugs.openjdk.java.net/browse/JDK-7122142 https://bugs.openjdk.java.net/browse/JDK-8005232 https://bugs.openjdk.java.net/browse/JDK-7185456 https://bugs.openjdk.java.net/browse/JDK-8022721 Original jdk8 changes: 7122142: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4ce6502eac0 8005232: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1109bfff4e92 7185456: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae03282ba501 8022721: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2281a7f79738 back port: http://cr.openjdk.java.net/~dmeetry/7122142.8005232.7185456.8022721/webrev.0/ Patches can't be applied cleanly, hence it was a manual back port, though the final result is equivalent to applying the patches in chronological order (8005232, 7185456, 7122142, 8022721) and applying all the relevant rejected parts It's good to see those patches being back-ported to 7u. By browsing the webrev, I don't see any obvious difference between the original patches and the backport. there shouldn't be any! Do you happen to remember in what part of code there were rejects so that you had to manually apply the changes? there were conflicts due to small difference between 7 and 8 (copyrights, white spaces, @SuppressWarnings, Class?,...). I copied all rejected parts and original patches here: http://cr.openjdk.java.net/~dmeetry/7122142.8005232.7185456.8022721/webrev.1/rej/ (with one exception, AnnotationTypeRuntimeAssumptionTest.java test was not included due to jdk8 API). Ah, It's the Class.getDeclaredAnnotation(Class) that's new in JDK8. Here's the changed test that only uses the JDK7 API so you can include this test too: http://cr.openjdk.java.net/~plevart/jdk7u/7122142/AnnotationTypeRuntimeAssumptionTest.java Thanks! http://cr.openjdk.java.net/~dmeetry/7122142.8005232.7185456.8022721/webrev.1/ (just with the new test added). thanks, dmeetry All tests in test/java/lang/annotation passed. thanks, dmeetry Regards, Peter -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs
On 11/27/13 1:04 PM, Alan Bateman wrote: On 26/11/2013 23:59, Mandy Chung wrote: This is a simple patch that adds a new jdeps -jdkinternals option to make it easier for developers to find dependencies on the JDK internal APIs: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8029216/webrev.00/ This looks good (and I can't think of a better name for the option). Do you think this needs a test as otherwise this option will not be exercised? -jdkinternals doesn't necessarily imply that using the JDK internal APIs is dangerous. Maybe calling it -warn would be better, and offer a path forward to in the future warn about other objectionable dependency constructs (circles, etc.). cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Debug builds
On 10/8/13 8:17 PM, cowwoc wrote: Alex clarified the difference between FULL_DEBUG_SYMBOLS and DEBUG_CLASSFILES below (thank you!) Based upon this, I am asking Oracle to ship DEBUG_CLASSFILES=true as part of the public JDK. Can someone from Oracle please comment on this? Not an OpenJDK issue - forums.oracle.com may be a better place for that. cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Classes on the stack trace
On 7/30/13 2:01 PM, Jörn Huxhorn wrote: See http://code.ohloh.net/search?s=Reflection.getCallerClass for a rough estimate about the impact of this change. Eh, no. Try http://code.ohloh.net/search?s=%22Reflection.getCallerClass%28%22pp=0fl=Javaff=1mp=1ml=1me=1md=1filterChecked=true instead. cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Classes on the stack trace
On 8/1/13 3:58 PM, Nick Williams wrote: On Aug 1, 2013, at 8:01 AM, Dalibor Topic wrote: On 7/30/13 2:01 PM, Jörn Huxhorn wrote: See http://code.ohloh.net/search?s=Reflection.getCallerClass for a rough estimate about the impact of this change. Eh, no. Try http://code.ohloh.net/search?s=%22Reflection.getCallerClass%28%22pp=0fl=Javaff=1mp=1ml=1me=1md=1filterChecked=true instead. I think the number is probably somewhere in between these two (I'm not sure where). Dalibor's filter appears to exclude uses via reflection (Class.forName(sun.reflect.Reflection), c.getMethod(getCallerClass)). Yep. Searching for the names individually gives a slightly higher number (and covers reflection use as mentioned above): http://code.ohloh.net/search?s=%22Reflection%22%20%22getCallerClass%22%20%22sun.reflect%22pp=0fl=Javaff=1mp=0ml=1me=1md=1filterChecked=true cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Codereview request for 7183053: Optimize DoubleByte charset for String.getBytes()/new String(byte[])
On 7/13/12 9:22 PM, Ulf Zibis wrote: Am 13.07.2012 14:19, schrieb Alan Bateman: Ulf - you've got several patches to the double byte charsets and I wonder if you have cycles to try Sherman's patch with jdk8 to see if there is any more to be gained? First, most of those patches have been closed from official side, don't really understand why: https://bugs.openjdk.java.net/buglist.cgi?query_format=advancedshort_desc_type=allwordssubstrshort_desc=long_desc_type=substringlong_desc=bug_file_loc_type=allwordssubstrbug_file_loc=status_whiteboard_type=allwordssubstrstatus_whiteboard=emailassigned_to1=1emailtype1=substringemail1=emailassigned_to2=1emailreporter2=1emailqa_contact2=1emailcc2=1emailtype2=substringemail2=ulf.zibisbugidtype=includebug_id=chfieldfrom=chfieldto=Nowchfieldvalue=cmdtype=doitorder=Importancefield0-0-0=nooptype0-0-0=noopvalue0-0-0= Tim is going through then issues in Bugzilla and closing the already fixed ones, and migrating the rest over to bug.sun.com in preparation for the the JIRA migration, afaik. I'm in a kind of vacation from OpenJDK development. One reason is the missing appreciation from official side. All attempts to at least have an account on http://cr.openjdk.java.net/, for easier publishing webrevs, have ended in *no answer* regardless my activity: See [Who Sent It?] on: http://markmail.org/search/+list:net.java.openjdk.core-libs-dev If this patch is eventually headed for JDK 7 Updates, I could grant you an Author role there, if you wish. cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Principal Product Manager Phone: +494089091214 tel:+494089091214 | Mobile: +491737185961 tel:+491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: StrictMath performance improvement not ported to Math?
On 11/18/11 3:29 PM, Martin Desruisseaux wrote: Hello all On December 1, 2010, darcy committed You probably know this already, but I just wanted to point out that one can use the census page as a handy decoder ring for committer names: http://openjdk.java.net/census#darcy cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Who is on Dedoxx?
On 11/8/11 7:40 PM, Ulf Zibis wrote: Can one explain me what BOF stands for? https://secure.wikimedia.org/wikipedia/en/wiki/Birds_of_a_Feather_%28computing%29 cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Request for review Remove private cause in jdk exceptions
On 8/26/11 12:59 PM, Sebastian Sickelmann wrote: Am 26.08.2011 08:32, schrieb Peter Jones: Public fields like RemoteException.detail, ill-advised as they may have been, cannot be removed (would break binary compatibility). Sorry for that. It was more a reflex (remove evil public fields) than a real problem with this. Breaking this would breaking binary compatibility but can this be a real show-stopper for not fixing this? Breaking binary compatibility is bad, bad, really, really bad. cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Request for review Remove private cause in jdk exceptions
On 8/26/11 1:15 PM, Sebastian Sickelmann wrote: Thanks for reviewing/supporting on my CRs. (Does CR mean Change Request???) Yes. See http://wikis.sun.com/display/OpenJdkBuilds/JDK+Glossary+of+Terms cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: JAXP 1.4.5 in JDK7
On 5/9/11 8:17 PM, Joe Wang wrote: Steve, Alan, The kenai team has just fixed the issue for jaxp.java.net. The pages are now updated properly. Thank you very much for the fast update, Joe! cheers, dalibor topic Thanks, Joe On 5/9/2011 4:27 AM, Alan Bateman wrote: Steve Poole wrote: Sorry - I wasn't clear. I know 1.4.5 is in the build now but it is a development release. If you go here: http://jaxp.java.net/ you'll see that the latest formal release mentioned is 1.4.4. Is JDK7 going to ship with a development release of JAXP or will 1.4.5 get formally released before JDK7 FCS? I've cc'ed Joe Wang from the JAXP project and I'm sure he can help (and maybe suggest the mailing list to use for JAXP related issues). -Alan -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: How can I get all emails from this mailing list
On 3/2/11 9:55 AM, Charles Lee wrote: Is there any place, which is like http://markmail.org/, holding all the mailing from openjdk mailing list? http://markmail.org/search/?q=list%3Anet.java.openjdk cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | | | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle
On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API and implementation are supplied by the upstream JAXP developers in the GlassFish JAXP project, i.e. http://jaxp.java.net/ . The source code repository is at http://java.net/projects/jaxp-sources/sources/svn/show cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | | | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle
On 4/7/11 3:49 PM, Dr Andrew John Hughes wrote: On 07/04/2011, Dalibor Topic dalibor.to...@oracle.com wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API and implementation are supplied by the upstream JAXP developers in the GlassFish JAXP project, i.e. http://jaxp.java.net/ . The source code repository is at http://java.net/projects/jaxp-sources/sources/svn/show http://java.net/projects/jaxp-sources/sources/svn/show/tags shows no tags in the last six months. What does this tarball correspond to? Good point. CC:ing Joe. cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | | | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()
On 12/22/10 12:19 PM, Neil Richards wrote: On 22 December 2010 09:38, David Holmes david.hol...@oracle.com wrote: Hi Neil, Any chance you can generate webrevs as mentioned in: http://openjdk.java.net/guide/changePlanning.html Hi David, From the documentation, I don't believe I can do so yet. Hi Neil, As a workaround, if you fetch the webrev script from http://blogs.sun.com/jcc/resource/webrev and run it on your hg tree, it will generate a webrev.zip file, along with a webrev, which you can send to this list as an attachment until you get an account on cr.openjdk. For an introduction to webrev, please see http://blogs.sun.com/jcc/entry/webrev_for_openjdk_a_code cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | | | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: b120 changelog empty?
implementation 4328728e04096991528 Support making Throwable.suppressedExceptions immutable a7ea58fa3e9a6985719 Alike methods in interfaces (Inheritance and Overriding) 1dd813a529cf6999635 Multicatch: crash while compiling simple code with a multicatch parameter cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | | | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle http://www.oracle.com/commitment Oracle is committed to developing practices and products that help protect the environment
Re: How to contribute - webrev question
Ulf Zibis wrote: Much thanks, Martin, to rub my eyes. I'm successive with Cygwin to run awk scripts on Windows, but there is no library for ksh (Kern Shell) :-( There is pdksh, fwiw: http://cygwin.com/packages/pdksh/pdksh-5.2.14-3 but it may or may not work. It may be worth a try, of course. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: Spec update for Class#getDeclaredMethods()
Rémi Forax wrote: Florian Weimer a écrit : I suggest to replace: | The elements [methods] in the array returned are not sorted and are | not in any particular order. with: | If the class is a compiled Java class, the elements in the array are | sorted according to the order of declaration in the source code. | Otherwise, the elements are not in any particular order. There is a growing amount of code which relies on predictable method order, so backwards compatibility concerns implicitly dictate the ordering. The proposed change makes this explicit. The other reflection methods should be updated in a similar fashion This sentences was conscientiously added between 1.1 and 1.2 and I know a small VM that returns the method using the vtable ordering for getMethod. Your suggestion implies that potentially all VM implementors should change some parts of their VM data structures. Doesn't seem realistic, isn't it. Unless the order of method declarations in the source code must be preserved in the class file (I don't think that's the case), I don't think it would really be possible for JVM implementors to do that due to the lack of the ability to determine at runtime from the class file alone the 'original' permutation of the elements that corresponds to the one in the source code in general. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: Reg : How to contribute
Ganesan Pugalendhi wrote: Hi I have more then 6+ years of working experience in java (Java ME (3 Years) and Java SE and EE (3 + yrs)), I have implemented RTP/RTCP stack in j2me, designed and implemented Canvas based UI frame work for J2ME clients and Architected many Java EE projects. I like to contribute to JDK7 but i don't know how. Can any one help me. A good start is the OpenJDK developer guide - see http://openjdk.java.net/guide/ to learn how the project works. A good way to understand how to start contributing patches is http://openjdk.java.net/contribute/ cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: Reg : How to contribute
Neal, Are you interested in improving the developer guide? cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: Reg : How to contribute
Ulf Zibis wrote: I think, it would be good idea to make the webrev tool available for external contributors too. It's the perfect tool for discussion on changesets. Hi Ulf, The webrev tool is available at http://blogs.sun.com/jcc/resource/webrev cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: Reg : How to contribute
Ulf Zibis wrote: but what to do with this script to make it work for me? I'm not sure I understand the question correctly - webrev is a shell script that uses ksh, so you could mark it as executable and run it using ksh, for example. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Dalibor Topic wrote: Dalibor Topic wrote: Hi core libraries developers, I met Alan Bateman last evening, and we thought that we should have another OpenJDK Core Libraries Forum this week, so (drumroll) it's time again on Friday, for the OpenJDK Forum Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Subject: Core libraries round table Hi everyone, a recording of the call in the Ogg Vorbis format is available at http://mediacast.sun.com/users/robilad/media/openjdk-forum-3.ogg/details For the Ogg-player-less would-be-listeners, there is an mp3 version generated from the ogg file at http://mediacast.sun.com/users/robilad/media/openjdk-forum-3.mp3/details cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Dalibor Topic wrote: Hi core libraries developers, I met Alan Bateman last evening, and we thought that we should have another OpenJDK Core Libraries Forum this week, so (drumroll) it's time again on Friday, for the OpenJDK Forum Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Subject: Core libraries round table Hi everyone, a recording of the call in the Ogg Vorbis format is available at http://mediacast.sun.com/users/robilad/media/openjdk-forum-3.ogg/details Other formats are coming later tonight. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Andrew John Hughes wrote: 2009/5/28 Gary Benson gben...@redhat.com: Dalibor Topic wrote: Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Is that 1600 GMT or 1600 BST (ie 1500 GMT)? Cheers, Gary -- http://gbenson.net/ Dalibor, it's looks like you copied and pasted the wrong line again... ;) If it's 5pm in Germany, only 1600 BST makes any sense. Right, it should be http://www.timeanddate.com/worldclock/meetingdetails.html?year=2009month=5day=29hour=3min=0sec=0p1=224p2=136p3=37 cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Andrew John Hughes wrote: 2009/5/28 Gary Benson gben...@redhat.com: Dalibor Topic wrote: Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Is that 1600 GMT or 1600 BST (ie 1500 GMT)? Cheers, Gary -- http://gbenson.net/ Dalibor, it's looks like you copied and pasted the wrong line again... ;) If it's 5pm in Germany, only 1600 BST makes any sense. Thanks for catching it, it's 1600 BST according to http://www.timeanddate.com/worldclock/meetingdetails.html?year=2009month=5day=29hour=15min=0sec=0p1=224p2=136p3=37 cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Dalibor Topic wrote: Andrew John Hughes wrote: 2009/5/28 Gary Benson gben...@redhat.com: Dalibor Topic wrote: Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Is that 1600 GMT or 1600 BST (ie 1500 GMT)? Cheers, Gary -- http://gbenson.net/ Dalibor, it's looks like you copied and pasted the wrong line again... ;) If it's 5pm in Germany, only 1600 BST makes any sense. Right, it should be http://www.timeanddate.com/worldclock/meetingdetails.html?year=2009month=5day=29hour=3min=0sec=0p1=224p2=136p3=37 Heh, almost - it's actually http://www.timeanddate.com/worldclock/meetingdetails.html?year=2009month=5day=29hour=15min=0sec=0p1=224p2=136p3=37 (clearly I should just let a script do this rather then posting after midnight myself) cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
Update: OpenJDK Forum: Core Libraries Round Table
Since conference calls may be a somewhat new experience to some of us, here are a couple ground rules: * Please identify yourself by name and location when speaking. At least in theory, we could have more then one Dalibor on the call, for example, and for those of us not familiar with each Dalibor's voice, having a way to pick them apart is useful. * Please address individuals by name when speaking. That helps keep the discussion flowing, without causing confusion who a particular question, remark or idea is addressed to. * Please speak clearly and avoid side conversations and background noise. We'll use the #openjdk IRC channel on irc.oftc.net for side conversations. If you are not familiar with IRC clients, you can run the corresponding web start application at http://openjdk.java.net/irc/ . * Keeping the noise down When you're not speaking, please mute your own line by pressing *6 on your telephone keypad. To unmute press *6 again. * On Sun campus in Santa Clara? Please join Dalibor and Alan in conference room Abba Zabba in building 22. See hear you soon, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
OpenJDK Forum: Core Libraries Round Table
Hi core libraries developers, I met Alan Bateman last evening, and we thought that we should have another OpenJDK Core Libraries Forum this week, so (drumroll) it's time again on Friday, for the OpenJDK Forum Date/Time: Friday May 29th, 8 AM Pacific, 1600 GMT, 5 PM Germany Subject: Core libraries round table Call Host: Dalibor Topic Expected Participants: * members of disc...@openjdk and core-libs-...@openjdk mailing lists interested in hearing what everyone else is working on in the core libraries area. Synopsis: The agenda would be just go around the table and get everyone to speak on what they are working on in the core libraries area in OpenJDK in light of the finished M3 and the upcoming M4, and the JavaOne conference just around the corner next week. We will then switch to open discussion mode to hear people's questions, concerns, and suggestions on the subject matter. The call will be recorded, and the recording will be made available after the call - in a free format, of course! Dial in numbers: Passcode: 5817876 Speed dial extension for developers inside Sun: x44414 Country Toll Numbers Freephone/Toll Free Number ARGENTINA 0800-777-0463 AUSTRALIA ADELAIDE: 61-8-8121-4868 1-800-249-288 AUSTRALIA BRISBANE: 61-7-3102-0970 1-800-249-288 AUSTRALIA CANBERRA: 61-2-6100-1970 1-800-249-288 AUSTRALIA MELBOURNE: 61-3-9010-7739 1-800-249-288 AUSTRALIA PERTH: 61-8-9467-5249 1-800-249-288 AUSTRALIA SYDNEY:61-2-8205-8125 1-800-249-288 AUSTRIA43-1-92-86-506 0800-005-029 BELGIUM32-1-150-03140800-4-8680 BRAZIL 0800-7610674 CHILE 1230-020-2867 CHINA* 86-400-810-4766 10800-712-1433 10800-120-1433 COLOMBIA01800-9-156430 CZECH REPUBLIC 420-2-25-98-56-54800-700-173 DENMARK45-7014-0280 8088-6132 ESTONIA 800-011-1089 FINLAND Land Line: 106-33-146 0-800-1-10100 FINLAND Mobile:09-106-33-1460-800-1-10100 FRANCE LYON: 33-4-26-69-12-81 080-563-9647 FRANCE MARSEILLE: 33-4-86-06-00-81 080-563-9647 FRANCE PARIS: 33-1-70-70-74-20 080-563-9647 GERMANY49-69--2566 0800-000-3441 GREECE 30-80-1-100-0683 00800-12-6973 HONG KONG 852-2286-5731800-930-705 HUNGARY 06-800-18013 INDIA 000-800-852-1266 INDONESIA 001-803-011-3787 IRELAND353-1-247-5253 1800-932-145 ISRAEL 1-80-9214916 ITALY 39-02-3600-3642 800-986-570 JAPAN OSAKA: 81-6-7739-4769 0034-800-400828 JAPAN TOKYO: 81-3-5539-5189 0034-800-400828 LATVIA 8000-3025 LUXEMBOURG 352-27-000-1360 MALAYSIA1-800-80-2812 MEXICO 001-866-627-0574 NETHERLANDS31-20-718-8533 0800-020-1392 NEW ZEALAND64-9-970-47690800-449-823 NORWAY 47-21-59-00-59 800-15414 PANAMA 011-001-800-5072129 PERU0800-53733 PHILIPPINES63-2-858-3715 POLAND 00-800-1212021 PORTUGAL8008-14061 RUSSIA 8-10-8002-9683011 SINGAPORE 65-6883-9228 800-120-4662 SLOVAK REPUBLIC421-2-322-422-21 SOUTH AFRICA080-09-80416 SOUTH KOREA82-2-6744-1081 00798-14800-6860 SPAIN 34-91-414-62-98
Re: OpenJDK Forum: Core Libraries Round Table
Ulf Zibis wrote: Am 14.04.2009 13:52, Max (Weijun) Wang schrieb: To ease your acquaintance with them, comments are added: Alan Bateman: the NIO2 guy Chris Hegarty: the SCTP guy Vincent Ryan: the ECC guy Michael McMahon: the HTTP server guy Xueming (Sherman) Shen: the corelib guy (sorry I forget what he said in the conf) Ulf Ziebis: I don't know who this is. Sorry. Correction: Ulf Zibis: the charset-enhanced guy https://java-nio-charset-enhanced.dev.java.net/ Doug Lea: the concurrency guy Andrew Haley: the RedHat guy Josh Bloch: the sort guy Dalibor Topic: the ambassador Mark Reinhold: the chief Thanks, everyone, I added most of the links to http://robilad.livejournal.com/46797.html , and I'll add a pointer to the minutes, once they are available. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
Re: Update: OpenJDK Forum: Core Libraries Round Table
Dalibor Topic wrote: Please join Mark Reinhold in conference room Firewall in building 22. In Mars Bars, actually. cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Tom Hawtin wrote: Dalibor Topic wrote: A recording of the call is available on http://mediacast.sun.com/users/robilad/media/openjdk6-core-libs.ogg Any chance of getting that in a mainstream format? Windows doesn't understand it. Rhythmbox under VirtualBox freezes. I'll generate an mp3 in a few minutes, once I've figured out how to do it. Audacity has this great 'export to Ogg Vorbis' feature that just works. ;) cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
Re: OpenJDK Forum: Core Libraries Round Table
Tom Hawtin wrote: Dalibor Topic wrote: A recording of the call is available on http://mediacast.sun.com/users/robilad/media/openjdk6-core-libs.ogg Any chance of getting that in a mainstream format? Windows doesn't understand it. Rhythmbox under VirtualBox freezes. http://mediacast.sun.com/users/robilad/media/openjdk-core-libraries-roundup.mp3 cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
OpenJDK Forum: Core Libraries Round Table
Hi core libraries developers, I'd like to carry on doing these, as the last one we did for contributing into OpenJDK 6 was fun and productive, so per Alan Bateman's suggestion, it's time again tomorrow, on Thursday, for the OpenJDK Forum Date/Time: Thursday Apr. 9th, 8 AM Pacific, 1600 GMT, 5 PM Germany Subject: Core libraries round table Call Host: Dalibor Topic Expected Participants: * members of disc...@openjdk and core-libs-...@openjdk mailing lists interested in hearing what everyone else is working on in the core libraries area. Synopsis: The agenda would be just go around the table and get everyone to speak on what they are working on in the core libraries area in OpenJDK. We will then switch to open discussion mode to hear people's questions, concerns, and suggestions on the subject matter. The call will be recorded, and the recording will be made available after the call - in a free format, of course! Dial in numbers: Passcode: 5817876 Speed dial extension for developers inside Sun: x44414 Country Toll Numbers Freephone/Toll Free Number ARGENTINA 0800-777-0463 AUSTRALIA ADELAIDE: 61-8-8121-4868 1-800-249-288 AUSTRALIA BRISBANE: 61-7-3102-0970 1-800-249-288 AUSTRALIA CANBERRA: 61-2-6100-1970 1-800-249-288 AUSTRALIA MELBOURNE: 61-3-9010-7739 1-800-249-288 AUSTRALIA PERTH: 61-8-9467-5249 1-800-249-288 AUSTRALIA SYDNEY:61-2-8205-8125 1-800-249-288 AUSTRIA43-1-92-86-506 0800-005-029 BELGIUM32-1-150-03140800-4-8680 BRAZIL 0800-7610674 CHILE 1230-020-2867 CHINA* 86-400-810-4766 10800-712-1433 10800-120-1433 COLOMBIA01800-9-156430 CZECH REPUBLIC 420-2-25-98-56-54800-700-173 DENMARK45-7014-0280 8088-6132 ESTONIA 800-011-1089 FINLAND Land Line: 106-33-146 0-800-1-10100 FINLAND Mobile:09-106-33-1460-800-1-10100 FRANCE LYON: 33-4-26-69-12-81 080-563-9647 FRANCE MARSEILLE: 33-4-86-06-00-81 080-563-9647 FRANCE PARIS: 33-1-70-70-74-20 080-563-9647 GERMANY49-69--2566 0800-000-3441 GREECE 30-80-1-100-0683 00800-12-6973 HONG KONG 852-2286-5731800-930-705 HUNGARY 06-800-18013 INDIA 000-800-852-1266 INDONESIA 001-803-011-3787 IRELAND353-1-247-5253 1800-932-145 ISRAEL 1-80-9214916 ITALY 39-02-3600-3642 800-986-570 JAPAN OSAKA: 81-6-7739-4769 0034-800-400828 JAPAN TOKYO: 81-3-5539-5189 0034-800-400828 LATVIA 8000-3025 LUXEMBOURG 352-27-000-1360 MALAYSIA1-800-80-2812 MEXICO 001-866-627-0574 NETHERLANDS31-20-718-8533 0800-020-1392 NEW ZEALAND64-9-970-47690800-449-823 NORWAY 47-21-59-00-59 800-15414 PANAMA 011-001-800-5072129 PERU0800-53733 PHILIPPINES63-2-858-3715 POLAND 00-800-1212021 PORTUGAL8008-14061 RUSSIA 8-10-8002-9683011 SINGAPORE 65-6883-9228 800-120-4662 SLOVAK REPUBLIC421-2-322-422-21 SOUTH AFRICA080-09-80416 SOUTH KOREA82-2-6744-1081 00798-14800-6860 SPAIN 34-91-414-62-98 800-099-810 SWEDEN 46-8-505-78-524
Re: [PATCH 1/1] Get rid of synchronization in java.util.logging.LogRecord constructor
David M. Lloyd wrote: On 03/12/2009 05:41 PM, Mark Reinhold wrote: You might want to have a look at the new contribution process [1]. Using that will increase the probability that someone will evaluate your patch sooner rather than later. - Mark [1] http://openjdk.java.net/contribute Consider my post to be step 2 of that process. The patch itself is probably the most succinct way of expressing the proposed change (it only took a minute or two to write in any case). That's understandable, but it's a lot easier to find interesting patches to review in a bug tracker, then to search for them among mailing list threads. In other words, if you, say, look at this thread so far in your mail reader, you'd have a hard time figuring out whether someone has reviewed your change or not, without spending the time reading the thread. Since more people end up reading each e-mail then people end up writing each e-mail, it's useful to optimize processes towards avoiding having to read a lot of e-mail in order to figure out simple things. So, please do add your patch to the bug tracker so that it doesn't get lost, and so that others don't have to spend time reading threads full of polite requests to please add your patch to the bug tracker. ;) Anyone have comments on the change? It seems that the change would break serialization, by changing the type of a serialized field (in both classes) away from a primitive one. See http://java.sun.com/javase/6/docs/platform/serialization/spec/version.html for details. Such comments are, obviously, better preserved in a bug tracker, then in a mailing list thread, but you knew I'd say that, right? ;) cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
Re: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour
David Holmes - Sun Microsystems wrote: In C, the result of an overflowing add of two signed integers is undefined. Strewth! That's a surprise to me. I always thought that C defined integer arithmetic to always wrap. Only for unsigned operands (from 6.2.5 - Types): A computation involving unsigned operands can never overflow, because a result that cannot be represented by the resulting unsigned integer type is reduced modulo the number that is one greater than the largest value modulo reduced that can be represented by the resulting type. see p. 496 in the The New C Standard: An Economic and Cultural Commentary for more details then most people care. ;) cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55http://openjdk.java.net D-20097 Hamburg mailto:dalibor.to...@sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht München: HRB 161028 Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer Vorsitzender des Aufsichtsrates: Martin Häring
