Re: Request for review: 8006757: Refactor Socket and File I/O tracing

[Edvard Wendelin]

Approved, given that Alan reviewed it on the core-libs alias.

/Edvard

On Jan 24, 2013, at 2:37 PM, Claes Redestad  wrote:

> Hi all,
> 
> this is a refactoring of the I/O trace instrumentation that's going into JDK
> 7u14. The fix is only applicable to jdk7 since the corresponding code does 
> not yet
> exist in jdk8.
> 
> Bug: 8006757: Refactor Socket and File I/O tracing
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006757
> 
> Description: By moving all parameters to the xxEnd-methods in IoTrace, we can 
> defer
> evaluation/object allocations until we know events will be written, which may 
> reduce
> the overhead of enabling these events.
> 
> Webrev:
> http://cr.openjdk.java.net/~sla/clredest/8006757/
> 
> Thanks!
> 
> /Claes
> 

Re: [7u8] Request for approval: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

[Edvard Wendelin]

Sorry for the delay. Approved.

Cheers,
Edvard

Ps. Please start new threads instead of replying to an old approval 
request.


On 08/28/2012 02:22 AM, Kurchi Hazra wrote:


This is a request for approval to backport the fix for 7160252 from 8 
to 7u8.


Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160252
Webrev:http://cr.openjdk.java.net/~khazra/7160252/7u8/webrev.00/

This had been reviewed by Alan Bateman and Chris Hegarty. [1]

This fix has been pushed into jdk8 [2].

Thanks,
Kurchi

[1]http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010823.html 


[2]http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9461aeff91f

Re: [7u6] Request for approval: 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion

[Edvard Wendelin]

Approved.

On 05/02/2012 09:10 PM, Kurchi Hazra wrote:


Requesting approval to commit fix for CR 7118100.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7118100
Webrev: http://cr.openjdk.java.net/~khazra/7118100/webrev.01/

This had been reviewed by Alan Bateman. [1]

This fix has been pushed into jdk8 [2]

Thanks,
Kurchi

[1] 
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/003081.html

[2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/108a02a57b75

Re: Request for Review(XS): 7156963 Incorrect copyright header in java/io/SerialCallbackContext

[Edvard Wendelin]

Correct! Thanks for pointing that out. Don't know how it ended up 
getting one extra space on each line.


Updated webrev on http://cr.openjdk.java.net/~ewendeli/7156963/webrev.02/

Thanks,
Edvard

On 06/05/2012 02:25 AM, Weijun Wang wrote:

It seems the whole copyright header is one-char shifted to right.

-Max

On 06/05/2012 02:38 AM, Joe Darcy wrote:

Looks fine,

-Joe

On 6/4/2012 7:01 AM, Edvard Wendelin wrote:

Please review. In addition to fixing the copyright I also fixed the
incorrect indentation of the rest of the file (which is kind of hard
to tell from the webrev).

Bug: 7156963

CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963
Synopsis: Incorrect copyright header in java/io/SerialCallbackContext

Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/

Testing: Verified that the JDK compiles properly.

Thanks,
Edvard

Request for Review(XS): 7156963 Incorrect copyright header in java/io/SerialCallbackContext

[Edvard Wendelin]

Please review. In addition to fixing the copyright  I also fixed the incorrect 
indentation of the rest of the file (which is kind of hard to tell from the 
webrev).

Bug: 7156963

CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963
Synopsis: Incorrect copyright header in java/io/SerialCallbackContext

Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/

Testing: Verified that the JDK compiles properly. 

Thanks,
Edvard

Re: [7u6] Request for approval: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows

[Edvard Wendelin]

Approved!

On May 29, 2012, at 10:35 PM, Kurchi Hazra wrote:

> 
> Requesting approval to commit fix for CR 7170169.
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169
> Webrev: http://cr.openjdk.java.net/~khazra/7170169/7u6/webrev.00/
> 
> This had been reviewed by darcy, dholmes, alanb, chegar. [1]
> 
> This fix has been pushed into jdk8 [2]
> 
> Thanks,
> Kurchi
> 
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-May/010233.html
> [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918
> 
>