Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v6]
On Thu, 9 Jun 2022 01:03:47 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 44 additional commits since > the last revision: > > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Update symbols for JDK 19 b25. > - Merge branch 'master' into JDK-8284858 > - Adjust deprecated options test. > - Merge branch 'master' into JDK-8284858 > - Update deprecated options test. > - Merge branch 'master' into JDK-8284858 > - ... and 34 more: > https://git.openjdk.java.net/jdk/compare/705cfa36...1b29a17c Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8236
Re: RFR: 8288068: Javadoc contains spurious reference to CLinker
On Wed, 8 Jun 2022 21:07:13 GMT, Maurizio Cimadamore wrote: > This simple patch fixes a bunch of references to "CLinker" and replaces them > with "Linker", following the API name changes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9094
Re: CFV: new Core Libraries Group member: Roger Riggs
Vote: yes Iris
Re: CVF: new Core Libraries Group member: Naoto Sato
Vote yes Iris From: core-libs-dev on behalf of Stuart Marks Sent: Monday, June 6, 2022 5:52 PM To: core-libs-dev Subject: CVF: new Core Libraries Group member: Naoto Sato I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2]. Naoto Sato has been on the Core Libraries team for over a decade and has contributed hundreds of changes to the JDK project [3]. His most significant recent contribution is JEP 400: UTF-8 by Default [4]. Naoto is also lead of the Internationalization Group [5] and a Reviewer on the JDK project. Votes are due by June 20, 2022, 23:59 PDT. Only current members of the Core Libraries Group [6] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list, as described here [7]. Results are determined by lazy consensus [8]. s'marks [1] https://openjdk.java.net/census#naoto [2] https://openjdk.java.net/groups/core-libs/ [3] https://github.com/openjdk/jdk/search?q=author-name%3Anaoto&type=commits [4] https://openjdk.java.net/jeps/400 [5] https://openjdk.java.net/groups/i18n/ [6] https://openjdk.java.net/census#core-libs [7] https://openjdk.java.net/groups/#member-vote [8] https://openjdk.java.net/bylaws#lazy-consensus
Re: RFR: 8287541: Files.writeString fails to throw IOException for charset "windows-1252"
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote: > The code path calls `String.getBytesNoRepl()`, but it blindly replaces > unmappable characters with replacements if the encoder is an `ArrayEncoder`. > Changed only to do so if `doReplace` is `true` in > `String.encodeWithEncoder()`. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9019
Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v5]
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 40 additional commits since > the last revision: > > - Update symbols for JDK 19 b25. > - Merge branch 'master' into JDK-8284858 > - Adjust deprecated options test. > - Merge branch 'master' into JDK-8284858 > - Update deprecated options test. > - Merge branch 'master' into JDK-8284858 > - Respond to review feedback. > - Update symbol information for JDK 19 b24. > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - ... and 30 more: > https://git.openjdk.java.net/jdk/compare/5a6d202d...e495a579 Changes still look good. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8236
Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v3]
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 36 additional commits since > the last revision: > > - Update deprecated options test. > - Merge branch 'master' into JDK-8284858 > - Respond to review feedback. > - Update symbol information for JDK 19 b24. > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Merge branch 'master' into JDK-8284858 > - Update symbol information for JDK 19 b23. > - ... and 26 more: > https://git.openjdk.java.net/jdk/compare/d01d01b5...eedd36bd Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8236
Re: RFR: 8287340: Refactor old code using StringTokenizer in locale related code
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote: > Refactoring some old code in locale providers. The test case data have also > been modified due to: > - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not > handle the case for `no-NO-NY`. > - `Locale.toLanguageTag()` won't handle legacy Java locales, e.g., `ja_JP_JP` > and falls back, so comparing locales using language tags does not work for > those locales. Changed to compare with `Locale.toString()` instead. Very nice code moderization. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8960
Re: RFR: 8287440: Typo in package-info.java of java.util.random
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe wrote: > The change is trivial, but I'll need help from someone to create a JBS issue > & sponsor this PR. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8766
Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8236
Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8236
Re: RFR: 8284209: Replace remaining usages of 'a the' in source code
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8771
Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8768
Re: RFR: 8284213: Replace usages of 'a the' in xml
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8769
Re: RFR: 8286858: Remove dead code in sun.reflect.misc.MethodUtil
On Sun, 15 May 2022 12:47:10 GMT, Andrey Turbanov wrote: > They are unused and leftover since JDK 7. It's good to remove them. Nice clean up. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8715
Re: RFR: JDK-8286615: Small refactor to SerializedLambda
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote: > Noticed by inspection during a CSR review, small refactoring to use a > message-cause exception constructor when one is available. > > Will update the copyright before a push. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8670
Re: RFR: JDK-8286604: Update InputStream and OutputStream to use @implSpec
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote: > While doing a CSR review of another issue, I noticed some cases in > InputStream and OutputStream what would benefit from being upgraded to > implSpec and related javadoc tags. > > The "A subclass must provide an implementation of this method." statements on > several abstract methods don't add much value, but I chose to leave them in > for this request. > > Please also review the corresponding CSR: > https://bugs.openjdk.java.net/browse/JDK-8286605 Associated CSR also reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8663
Re: RFR: JDK-8286347: incorrect use of `{@link}`
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8584
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v7]
On Wed, 4 May 2022 23:10:06 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties, for an initial release of a specification. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 >> >> I'll update copyright years before an integration. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 12 additional commits since > the last revision: > > - Respond to mbreinhold review feedback. > - Merge branch 'master' into JDK-8285497 > - Update wording to address review feedback. > - Merge branch 'master' into JDK-8285497 > - Change punctuation from review feedback. > - Respond to review feedback; make sequence of values explicit. > - Respond to review feedback. > - Respond to review feedback. > - Respond to CSR feedback. > - Merge branch 'master' into JDK-8285497 > - ... and 2 more: > https://git.openjdk.java.net/jdk/compare/460bf5de...7b7720cf Associated CSR also reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: 8286154: Fix 3rd party notices in test files
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote: > Trivial fix to 3rd party copyright notices. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8558
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v6]
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties, for an initial release of a specification. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 >> >> I'll update copyright years before an integration. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 10 additional commits since > the last revision: > > - Update wording to address review feedback. > - Merge branch 'master' into JDK-8285497 > - Change punctuation from review feedback. > - Respond to review feedback; make sequence of values explicit. > - Respond to review feedback. > - Respond to review feedback. > - Respond to CSR feedback. > - Merge branch 'master' into JDK-8285497 > - Update comment in template. > - JDK-8285497: Add system property for Java SE specification maintenance > version Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285977: Add links to IEEE 754 specification
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote: > Please review the addition of @-see links from classes that mention the IEEE > 754 floating-point standard to an IEEE page about the standard. The URL in > the initial version of the PR is the top search result on the IEEE home page > for "754 standard". > > Another candidate page to use is > > https://ieeexplore.ieee.org/servlet/opac?punumber=8766227 > > which is (apparently) a stable citation page for the standard. > > These links may be upgraded to the the forthcoming @-spec facility in the > future. ( JDK-6251738). Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8511
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v5]
On Fri, 29 Apr 2022 01:20:17 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties, for an initial release of a specification.
>>
>> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>>
>> I'll update copyright years before an integration.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change punctuation from review feedback.
Is there intent to backport this to the RI for JSR 337 MR 4?
src/java.base/share/classes/java/lang/System.java line 743:
> 741: * have the value {@code "1"}; after a second maintenance
> 742: * release, this property will have the value {@code "2"},
> 743: * and so on.
There should be no requirement that values be allocated sequentially. In other
words, if JCP MR does not require an RI, then it should not be surprising
if there is no JDK build with maintenance version . As an example, JSR 337
MR 1 and MR 2 both used the same RI. If this system property had existed
during development of MR 1, it would return "1". Since no RI was submitted for
MR 2, a build returning "2" should never exist. MR 3 did update the RI, so it
would return "3".
src/java.base/share/classes/java/lang/VersionProps.java.template line 113:
> 111: props.put("java.specification.version", VERSION_SPECIFICATION);
> 112:
> 113: // Uncomment next props.put call after the first maintenance
> release for a
Is "after" correct? I think this value should be set to the target MR at the
beginning of RI development for the release, similar to what is done for other
version identification system properties.
-
Changes requested by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285614: Fix typo in java.lang.Float
On Mon, 25 Apr 2022 22:22:29 GMT, Joe Darcy wrote: > Fix typo introduced in JDK-8261123. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8390
Re: RFR: 8284922: Fix some doc-comment issues on methods with package access in JDK API
On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo wrote: > People rarely include JDK elements with package access in a javadoc run. That > is why bugs in those elements' doc comments tend to remain unnoticed. > > There are many more bugs in the doc comments of the JDK elements with the > package access than are addressed by this PR; I only included the simplest > ones. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8267
Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers [v2]
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote: >> Added the test case, and eliminated the immediate hashmap value, replaced >> with the ordinal number of `Character.UnicodeScript.UNKNOWN`. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed a typo Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8253
Re: RFR: 8284856: Add a test case for checking UnicodeScript entity numbers
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote: > Added the test case, and eliminated the immediate hashmap value, replaced > with the ordinal number of `Character.UnicodeScript.UNKNOWN`. Nice catch in the review for 8186958. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8253
Re: RFR: 8284893: Fix typos in java.base
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `src/java.base` directory, and accepted those > changes where it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > The majority of fixes are in comments. A handful is in strings, one in a > local variable name, and a couple in parameter declarations. > > Annoyingly, there are several instances of "childs" (instead of "children") > in the source code, but they were not local and I dared not change them. > Someone braver than me might take a stab at it, perhaps.. Looks good. I usually like GitHub's colorful diffs, but this is one of those rare cases where looking at the single webrev-generated diff file is so much easier. About the only thing that could improve it would be to reduce the context (i.e. "diff -C"). - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8250
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8265315: Support for CLDR version 41 [v2]
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote: >> This is to upgrade the CLDR data from version 39 to version 41 which was >> released yesterday. The vast majority of the changes are basically replacing >> the CLDR data, along with tools/testcase alignments. Here is the link to >> CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41 > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 22 commits: > > - Merge branch 'master' into cldr+ > - Merge branch 'master' into cldr+ > - CLDR v41 final > - CLDR v41 beta2 > - Merge branch 'master' into cldr+ > - CLDR v41 alpha4 > - Merge branch 'master' into cldr+ > - Update copyright year to 2022 > - CLDR release v40 > - Merge branch 'master' into cldr > - ... and 12 more: > https://git.openjdk.java.net/jdk/compare/a8c87526...9ef22a6d Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8150
Re: RFR: 8284567: Collapse identical catch branches in java.base
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote: > Let's take advantage of Java 7 language feature - "Catching Multiple > Exception Types". > It simplifies code. Reduces duplication. > Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try' > statement Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8081
Re: RFR: 8265315: Support for CLDR version 41
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's release notes: https://cldr.unicode.org/index/downloads/cldr-41 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8150
Re: RFR: 8283698: Refactor Locale constructors used in src/test
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `Locale.US`. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8130
Re: RFR: 8283842: TestZoneTextPrinterParser.test_roundTripAtOverlap fails: DateTimeParseException
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote: > Fixes test failures caused by depending on the default locale. Specifying > explicit `Locale.US` will do. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8045
Re: RFR: 8283889: Fix typo in package-info.java
On Tue, 29 Mar 2022 18:23:31 GMT, Lance Andersen wrote: > Hi all, > > Please review this trivial fix which addresses a typo in > src/java.sql/share/classes/java/sql/package-info.java > > make docs is clean and I am also running mach5 tier1 as an extra sanity check > so there are no surprises when the patch is pushed > > Best > Lance Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8020
Re: RFR: 8283846: Remove unused jdk.internal.reflect.SignatureIterator
On Tue, 29 Mar 2022 09:15:01 GMT, Andrey Turbanov wrote: > It was no longer used due to JDK-4479184 long ago. Nice clean-up. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8013
Re: RFR: JDK-8283668: Update IllegalFormatException to use sealed classes
On Fri, 25 Mar 2022 04:17:57 GMT, Joe Darcy wrote: > Working down the list of candidates to be sealed, this time > IllegalFormatException. > > Please also review the companion CSR: > https://bugs.openjdk.java.net/browse/JDK-8283669 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7950
Re: RFR: 8283465: Character.UnicodeBlock.NUM_ENTITIES is out of date [v2]
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote: >> Fixing the out-of-date number of entries in >> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been >> renamed and now repurposed just to examine whether the `NUM_ENTITIES` >> correctly has the `map.size()` value. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Comment adjusted per review suggestion Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7909
Re: RFR: 8283465: Character.UnicodeBlock.NUM_ENTITIES is out of date
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote: > Fixing the out-of-date number of entries in > `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been > renamed and now repurposed just to examine whether the `NUM_ENTITIES` > correctly has the `map.size()` value. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7909
Re: RFR: 8283426: Fix 'exeption' typo
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated type `exeption` Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7879
Re: RFR: 8283277: ISO 4217 Amendment 171 Update
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE > redenomination (removing 3 zeros). Its effective date is 4/1, but I went > ahead as JDK19 won't be released by 4/1. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7857
Re: RFR: JDK-8283274: Improve @jvms usage in java.base
On Wed, 16 Mar 2022 16:57:12 GMT, Joe Darcy wrote: > As was done for JLS references under JDK-8283234, now the analogous update > for JVMS references. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7844
Re: RFR: JDK-8283234: Improve @jls usage in java.base
On Wed, 16 Mar 2022 03:03:23 GMT, Joe Darcy wrote: > Checking the java.bases sources revealed a number of other instances where > conceptual links into the JLS (or JVMS) could be upgraded to actual links. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7834
Re: RFR: JDK-8283230: Improve @jls usage in ElementType
On Wed, 16 Mar 2022 00:33:57 GMT, Joe Darcy wrote: > Improve some semantic links into JLS with actual links. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7831
Re: RFR: JDK-8283124: Add constant for tau to Math and StrictMath [v2]
On Mon, 14 Mar 2022 23:21:26 GMT, Joe Darcy wrote: >> Add a constant for tau, 2*pi, to Math and StrictMath. Since 2*pi is a very >> common value in mathematical formulas, it is helpful to give it a distinct >> constant. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8283136 > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Set value with 2.0 * PI. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7813
Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new Skara bot jcheck option similar to what is already in place for trailing whitespace? - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7268
Re: RFR: 8282583: Update BCEL md to include the copyright notice [v2]
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote: >> Update BCEL md to include the copyright notice. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > remove the section that's no longer in the notice file Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7681
Re: RFR: 8282583: Update BCEL md to include the copyright notice
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote: > Update BCEL md to include the copyright notice. Confirm 2020, not 2022. Otherwise, looks good. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7681
Re: RFR: 8282131: java.time.ZoneId should be a sealed abstract class
On Fri, 25 Feb 2022 19:02:55 GMT, Naoto Sato wrote: > Refactoring `java.time.ZoneId` class to be a sealed class. A CSR has also > been drafted. Associated CSR also reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7625
Re: RFR: 8282190: Typo in javadoc of java.time.format.DateTimeFormatter#getDecimalStyle
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change to the javadoc of > `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in > https://bugs.openjdk.java.net/browse/JDK-8282190? Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7556
Re: RFR: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java
On Thu, 17 Feb 2022 18:02:20 GMT, Ian Graves wrote: > Adding a missing period per this doc bug. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7521
Re: RFR: JDK-8281082: Improve javadoc references to JOSS
On Tue, 1 Feb 2022 21:11:39 GMT, Joe Darcy wrote: > The references to JOSS, the Java Object Serialization Specification, are not > done consistently in the API javadoc. This should be improved. > > I'll update copyright years before pushing. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7315
Re: RFR: JDK-8280534: Enable compile-time doclint reference checking [v2]
On Fri, 28 Jan 2022 02:15:59 GMT, Joe Darcy wrote:
>> The changes in this PR on top of the out-for-review changes in
>> https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint
>> checking to be enabled in all JDK modules.
>>
>> Typically, a @SuppressWarnings("doclint:refernce") annotation is added to
>> declaration with javadoc blocks that have already had distinguished
>> cross-module links added (JDK-8280492).
>>
>> One exception is in src/java.base/share/classes/java/net/package-info.java
>> where the cross-module link was (for now) removed. Currently the
>> SuppressWarnings annotation type is not declared to allow its annotations to
>> be applied to package declarations. I'll look into amending that, but in the
>> mean time, I think it is beneficial for the JDK build, and the base module
>> in particular, to have compile-time doclint protections turned on.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains four additional commits since
> the last revision:
>
> - Use capabilities of JDK-8280744.
> - Merge branch 'master' into JDK-8280534
> - Cover java.base.
> - JDK-8280534: Enable compile-time doclint reference checking
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7237
Re: RFR: JDK-8280744: Allow SuppressWarnings to be used in package declarations [v4]
On Thu, 27 Jan 2022 23:27:54 GMT, Joe Darcy wrote: >> The SuppressWarnings annotation type is declared have multiple targets, >> including modules; however, "package" is left off of its target list. As >> package-info file are another kind of declaration where a compiler could >> give warnings, allowing SuppressWarnings in that case is reasonable. Wanting >> SuppressWarnings in package-info file came up while working on doclint >> warnings (JDK-8280534). >> >> Please also review the companion CSR: >> https://bugs.openjdk.java.net/browse/JDK-8280745 >> >> While the SuppressWarnings annotation does have a JLS section (9.6.4.5. >> @SuppressWarnings), the section doesn't mention the target list therefore >> doesn't appear to need to be updated. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Respond to review feedback. > - Merge branch 'master' into JDK-8280744 > - Respond to CSR feedback. > - Respond to review feedback. > - JDK-8280745: Allow SuppressWarnings to be used in package declarations The current spec changes correspond to the approved CSR. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7239
Re: RFR: JDK-8279242: Reflection newInstance() error message when constructor has no access modifiers could use improvement [v4]
On Tue, 25 Jan 2022 18:25:14 GMT, Joe Darcy wrote: >> Making the exception message friendlier to users. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7208
Re: RFR: JDK-8279242: Reflection newInstance() error message when constructor has no access modifiers could use improvement [v2]
On Tue, 25 Jan 2022 05:25:12 GMT, Joe Darcy wrote: >> Making the exception message friendlier to users. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7208
Re: RFR: 8280531: Remove unused DeferredCloseInputStream
On Tue, 18 Jan 2022 20:51:06 GMT, Andrey Turbanov wrote: > Class DeferredCloseInputStream is unused since removing of Solaris support > https://github.com/openjdk/jdk/blob/9fe4b69c1a1120e1d761730495c3cfac8f179d13/src/java.base/unix/classes/java/lang/ProcessImpl.java#L80-L81 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7135
Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: [jdk18] RFR: JDK-8279179: Update nroff pages in JDK 18 before RC
On Fri, 21 Jan 2022 18:37:50 GMT, Jonathan Gibbons wrote: > Please review this semi-automated update to the nroff man pages from the > upstream repo. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/112
Re: RFR: 8280470: Confusing instanceof check in HijrahChronology.range
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote: > Parameter `ChronoField field` is checked by `if (field instanceof > ChronoField)`. Such check is confusing, because only one case, when this > could be `false` is when `field == null`. > But if condition is not satisfied we will get immediate NullPointerException > anyway in `return field.range();`. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7118
Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6974
Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug [v2]
On Thu, 16 Dec 2021 18:41:32 GMT, Naoto Sato wrote: >> This is a doc fix to `StringTokenizer`, where the original spec does not >> account for the delimiter's length in the case of a supplementary character. >> Corresponding CSR has been drafted: >> https://bugs.openjdk.java.net/browse/JDK-8278814 > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects CSR comments. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6836
Re: RFR: 8278587: StringTokenizer(String, String, boolean) documentation bug
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote: > This is a doc fix to `StringTokenizer`, where the original spec does not > account for the delimiter's length in the case of a supplementary character. > Corresponding CSR has been drafted: > https://bugs.openjdk.java.net/browse/JDK-8278814 Corresponding CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6836
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6713
Re: RFR: 8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc
On Wed, 1 Dec 2021 13:49:42 GMT, Maurizio Cimadamore wrote: > There are some truncated statements in > MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in > the `@throws` for `IndexOutOfBoundsException`. Trivial fix for an apparent cut-and-paste error. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6635
Re: RFR: 8277986: Typo in javadoc of java.util.zip.ZipEntry#setTime
On Tue, 30 Nov 2021 14:28:05 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes a typo in the javadoc > of `java.util.zip.ZipEntry.setTime()` method? Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6615
Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]
On Mon, 29 Nov 2021 18:38:35 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.java.net/browse/JDK-8277512 >> >> JDK-8277514: Add source 19 and target 19 to javac >> https://bugs.openjdk.java.net/browse/JDK-8277514 >> >> Clean local tier 1 test runs for langtools, jdk, and hotspot. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol information for JDK 18 b25. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6493
Re: RFR: 8277322: Document that setting an invalid property `jdk.serialFilter` disables deserialization
On Mon, 22 Nov 2021 19:57:25 GMT, Roger Riggs wrote: > The effects of an invalid `jdk.serialFilter` property are not completely > documented. If the value of the system property jdk.serialFilter is invalid, > deserialization should not be possible and it should be clear in the > specification. > > Specify an implementation specific exception is thrown in the case where > deserialization is invoked after reporting the invalid jdk.serialFilter. Associated CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6508
Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]
On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >> https://bugs.openjdk.java.net/browse/JDK-8277512 >> >> JDK-8277514: Add source 19 and target 19 to javac >> https://bugs.openjdk.java.net/browse/JDK-8277514 >> >> Clean local tier 1 test runs for langtools, jdk, and hotspot. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6493
Re: RFR: 8276141: XPathFactory set/getProperty method [v10]
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote: >> Add setProperty/getProperty methods to the XPath API so that properties can >> be supported in the future. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update as commented Associated CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6215
Re: RFR: 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote: > The `jdk.internal.ValueBased` annotation was incorrectly applied to > subclasses of java.util.AbstractMap. > [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html) > requires that supertypes have no instance fields; AbstractMap has instance > fields keySet and values. > > Remove the internal @ValueBased annotation for subclasses of AbstractMap > including: > AbstractImmutableMap, Map1, and MapN. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6480
Re: RFR: 8274333: Redundant null comparison after Pattern.split
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote: > In couple of classes, result part of arrays of Pattern.split is compared with > `null`. Pattern.split (and hence String.split) never returns `null` in array > elements. Such comparisons are redundant. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5708
Re: RFR: 8275386: Change nested classes in jdk.jlink to static nested classes
On Sun, 17 Oct 2021 21:06:44 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5983
Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v8]
On Wed, 17 Nov 2021 17:48:39 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Removed changes to Util.java as it is not needed. > Eliminated premature jnuEncoding initializaiton in > jni_util.c::InitializeEncoding() Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6282
Re: RFR: 8277048: Tiny improvements to the specification text for java.util.Properties.load
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote: > Please review this simple two-hunk fix to the documentation comment of > java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a > suggestion. I believe it reads better since the plurality is more idiomatic; > native English speakers should correct me if I'm wrong. The second hunk picks > up what was overlooked in JDK-8274075 > (https://git.openjdk.java.net/jdk/pull/5610). Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6367
Re: RFR: 8276186: Require getAvailableLocales() methods to include Locale.ROOT [v2]
On Wed, 10 Nov 2021 19:05:17 GMT, Naoto Sato wrote: >> This fix is to require to include `Locale.ROOT` in the returned arrays/set >> from `getAvailableLocales()` methods in various locale-sensitive classes. >> The implementation has been including `Locale.ROOT` since its inception, it >> is simply a doc clarification (+ a test case verifying it). Corresponding >> CSR has also been drafted: https://bugs.openjdk.java.net/browse/JDK-8276249 > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Using @code tag for `Set`. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6258
Re: RFR: 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for years <= 1893
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote: > Simple doc clarification where the `toString()` output only conforms to ISO > 8601 if the seconds in the offset are zero. CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6321
Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v2]
On Tue, 9 Nov 2021 19:38:01 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Emit a warning on unsupported jnu encoding Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6282
Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote: > Please review the subject fix. In light of JEP400, Java runtime can/should > start in UTF-8 charset if the underlying native encoding is not supported. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6282
Re: RFR: JDK-8276650: GenGraphs does not produce deterministic output
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung wrote: > The dot graph should print the edges in alphatical order. A simple fix to > sort the edges before printing them. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6266
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276348: Use blessed modifier order in java.base
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place > in JDK-8136583 in 2015 [^2]. That change affected 1780 lines spanning 453 > files. Since then modifiers have become a bit lose, and it makes sense to > re-bless (using the JDK-8136583 terminology) them. > > This change was produced by running the below command followed by updating > the copyright years on the affected files where necessary: > > $ sh ./bin/blessed-modifier-order.sh src/java.base > > The resulting change is much smaller than that of 2015: 39 lines spanning 21 > files. > > [^1]: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-November/082987.html > (or https://github.com/openjdk/jdk/pull/6191#pullrequestreview-79465) > [^2]: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6213
Re: RFR: 8276188: Clarify "default charset" descriptions in String class
On Mon, 1 Nov 2021 18:31:17 GMT, Naoto Sato wrote: > This is a leftover document fix to `String` class for the JEP 400. > Corresponding CSR has also been drafted: > https://bugs.openjdk.java.net/browse/JDK-8276238 Diffs align with the corresponding CSR, which I have also reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6198
Re: RFR: JDK-8276236: Table headers missing in Formatter api docs
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote: > Adds table headers to all tables in Formatter api docs. I inferred the header > "Unicode" for the columns that contained unicode > codepoints. > > Formatter api docs: > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6195
Re: RFR: 8276234: Trivially clean up locale-related code [v2]
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote: >> Please review this PR. A comprehensive test job has been scheduled; I'll >> notify this thread once that job has completed. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Use the blessed modifiers order Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6191
Re: RFR: 8275766: (tz) Update Timezone Data to 2021e
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote: > Please review the integration of tzdata2021e (including tzdata2021d) to the > JDK. > The fix has passed all relevant JTREG regression tests and JCK tests. > > 8275754: (tz) Update Timezone Data to 2021d > 8275849: TestZoneInfo310.java fails with tzdata2021e Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6144
Re: RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote: > Trivial clean-up. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6110
Re: RFR: JDK-8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote: > Another serialization warnings cleanup; this time in java.rmi. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6055
Re: RFR: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote: > Removing a problem-listed test case, which has little value in itself. > Confirmed it did succeed on all platforms before the removal. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5996
Re: RFR: 8275145: file.encoding system property has an incorrect value on Windows
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote: > Fixing a regression in which `file.encoding` was initialized by > `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS > platforms. tier1-3 tests passed on all platforms. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5953
Re: RFR: 8275197: Remove unused fields in ThaiBuddhistChronology
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote: > Remove 3 unused HashMap's. > Reported here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html > I did the similar PR to treetenbp and it was merged > https://github.com/ThreeTen/threetenbp/pull/155 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5917
Re: RFR: JDK-8275249: Suppress warnings on non-serializable array component types in jdk.jlink
On Wed, 13 Oct 2021 21:08:41 GMT, Joe Darcy wrote: > After a refinement to the checks under development in #5709, the new checks > examine array types of serial fields and warn if the underlying component > type is not serializable. Per the JLS, all array types are serializable, but > if the base component is not serializable, the serialization process can > throw an exception. > > From "Java Object Serialization Specification: 2 - Object Output Classes": > > "If the object is an array, writeObject is called recursively to write the > ObjectStreamClass of the array. The handle for the array is assigned. It is > followed by the length of the array. Each element of the array is then > written to the stream, after which writeObject returns." > > The jdk.jlink module has one instance of this coding pattern that needs > suppression to compile successfully under the future warning. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5936
Re: RFR: 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException
On Wed, 13 Oct 2021 17:43:29 GMT, Lance Andersen wrote: > Hi all, > > Please review the fix to address a javadoc issue for the Deflater::deflate > methods that were added as part of JDK-6341887 that could throw a > ReadOnlyBufferException. > > The` @throws ` clause for `ReadOnlyBufferException` was inadvertently > omitted from the javadoc for these new methods. > > A CSR, JDK-8275164, has also been created for this issue. > > Best > Lance Associated CSR also Reviewed. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5931
Re: RFR: 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi
On Thu, 7 Oct 2021 18:00:33 GMT, Andrey Turbanov wrote: > Pass cause exception as constructor parameter is shorter and easier to read. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5854
Re: RFR: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote: > While working on tzdata2021c update, I noticed there is a dead code in > `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for > `endOfDay` for certain cases. These are no longer needed as JDK's code is > already capable of dealing with transitions beyond the end of the day. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5857
Re: RFR: 8274407: (tz) Update Timezone Data to 2021c
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5832
Re: RFR: 8274658: ISO 4217 Amendment 170 Update
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790
Re: RFR: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml
On Wed, 29 Sep 2021 17:56:49 GMT, Andrey Turbanov wrote: > StringBuffer is a legacy synchronized class. There are more modern > alternatives which perform better: > 1. Plain String concatenation should be preferred > 2. StringBuilder is a direct replacement to StringBuffer which generally have > better performance > > Similar cleanups: > 1. [JDK-8264029](https://bugs.openjdk.java.net/browse/JDK-8264029) java.base > 2. [JDK-8264428](https://bugs.openjdk.java.net/browse/JDK-8264428) > java.desktop > 3. [JDK-8264484](https://bugs.openjdk.java.net/browse/JDK-8264484) > jdk.hotspot.agent Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5759
