Re: RFR: JDK-8266797: Fix for 8266610 breaks the build on macos

2021-05-10 Thread Jayathirth D V 
On Mon, 10 May 2021 11:21:34 GMT, Vyom Tewari  wrote:

>>> Hi Vyom,
>>> 
>>> That fixes the include file problem but as this was obviously not tested on 
>>> non-Linux have you checked that the rest of the fix for 8266610 works okay 
>>> on non-Linux?
>>> 
>>> Thanks,
>>> David
>> 
>> Hi David,
>> 
>> Original fix  was intended to  Linux specific. Current  Fix  will not impact 
>> other platforms. 
>> 
>> There is existing test (java/nio/channels/FileChannel/BlockDeviceSize.java) 
>> which test the new code but currently it is silently passing without running 
>> the test. This test requires root access.
>> 
>> Please see the bug( https://bugs.openjdk.java.net/browse/JDK-8150539) 
>> 
>> Thanks,
>> Vyom
>
>> @vyommani how are you going to test this?
> 
> I tested locally at my Linux environment. we have a test 
> "java/nio/channels/FileChannel/BlockDeviceSize.java" but  it requires root 
> privileged , i ran this as well as a root.  Please  have a look into 
> this(https://bugs.openjdk.java.net/browse/JDK-8150539).

@vyommani You can start tier1 CI build to make sure build passes with this fix.

-

PR: https://git.openjdk.java.net/jdk/pull/3943

Re: RFR: JDK-8266797: Fix for 8266610 breaks the build on macos

2021-05-10 Thread Jayathirth D V 
On Mon, 10 May 2021 06:34:36 GMT, Vyom Tewari  wrote:

> this change will  include  the below headers files to Linux only. 
> #include 
> #include 

Marked as reviewed by jdv (Reviewer).

In internal CI with fix tier 1 builds are running fine.

-

PR: https://git.openjdk.java.net/jdk/pull/3943

Re: RFR: 8255043: Incorrectly styled copyright text

2020-10-20 Thread Jayathirth D V 
On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov  wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
> * Copyright (c)

Marked as reviewed by jdv (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/759