Integrated: 8260356: (tz) Upgrade time-zone data to tzdata2021a
On Tue, 2 Feb 2021 17:22:18 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review integrating tzdata2021a to JDK. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8260356 > > The fix has passed the regression and JCK tests. More information can be > viewed at - > https://mm.icann.org/pipermail/tz-announce/2021-January/65.html > > Thanks, > Kiran This pull request has now been integrated. Changeset: d9aefa36 Author:Kiran Sidhartha Ravikumar URL: https://git.openjdk.java.net/jdk/commit/d9aefa36 Stats: 12 lines in 3 files changed: 6 ins; 0 del; 6 mod 8260356: (tz) Upgrade time-zone data to tzdata2021a Reviewed-by: naoto - PR: https://git.openjdk.java.net/jdk/pull/2359
RFR: 8260356: (tz) Upgrade time-zone data to tzdata2021a
Hi Guys, Please review integrating tzdata2021a to JDK. JBS: https://bugs.openjdk.java.net/browse/JDK-8260356 The fix has passed the regression and JCK tests. More information can be viewed at - https://mm.icann.org/pipermail/tz-announce/2021-January/65.html Thanks, Kiran - Commit messages: - 8260356: (tz) Upgrade time-zone data to tzdata2021a Changes: https://git.openjdk.java.net/jdk/pull/2359/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2359=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260356 Stats: 12 lines in 3 files changed: 6 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/2359.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2359/head:pull/2359 PR: https://git.openjdk.java.net/jdk/pull/2359
Integrated: 8259048: (tz) Upgrade time-zone data to tzdata2020f
On Mon, 4 Jan 2021 18:11:05 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Updating the summary as tzdata2020f is available and includes tzdata2020e > changes also. > > Please review the integration of tzdata2020f to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-December/64.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8259048 > > tzdata2020e - Most of the changes are about correcting past timestamps and > Australia/Currie timezone is removed. > tzdata2020f - No changes to the data since 2020e. > > Regression Tests pass along with JCK. > > Please let me know if the changes are good to push. > > Thanks, > Kiran This pull request has now been integrated. Changeset: fe84ecd5 Author:Kiran Sidhartha Ravikumar URL: https://git.openjdk.java.net/jdk/commit/fe84ecd5 Stats: 729 lines in 10 files changed: 578 ins; 19 del; 132 mod 8259048: (tz) Upgrade time-zone data to tzdata2020f Reviewed-by: naoto, erikj - PR: https://git.openjdk.java.net/jdk/pull/1937
Re: RFR: 8259048: (tz) Upgrade time-zone data to tzdata2020f [v2]
On Mon, 4 Jan 2021 18:40:06 GMT, Naoto Sato wrote: > Looks good. > IIUC, 2020f is already out, and the 2020e-2020f diff does not seem to include > any data change. Would you change this PR to incorporate 2020f? Hi @naotoj , I have updated the VERSION and PR title to incorporate tzdata2020f, please let me know if the changes are good to push. - PR: https://git.openjdk.java.net/jdk/pull/1937
Re: RFR: 8259048: (tz) Upgrade time-zone data to tzdata2020f [v2]
> Hi Guys, > > Please review the integration of tzdata2020e to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-December/63.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8258878 > > Most of the changes are about correcting past timestamps and Australia/Currie > timezone is removed. > > Regression Tests pass along with JCK. > > Please let me know if the changes are good to push. > > Thanks, > Kiran Kiran Sidhartha Ravikumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8258878: (tz) Upgrade time-zone data to tzdata2020e - Merge remote-tracking branch 'origin/master' into JDK-8258878 - 8258878: (tz) Upgrade time-zone data to tzdata2020e - Changes: - all: https://git.openjdk.java.net/jdk/pull/1937/files - new: https://git.openjdk.java.net/jdk/pull/1937/files/a89ac891..4e18e930 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1937=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1937=00-01 Stats: 46333 lines in 1566 files changed: 19748 ins; 13335 del; 13250 mod Patch: https://git.openjdk.java.net/jdk/pull/1937.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1937/head:pull/1937 PR: https://git.openjdk.java.net/jdk/pull/1937
Integrated: 8255226: (tz) Upgrade time-zone data to tzdata2020d
On Mon, 2 Nov 2020 16:29:07 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020d to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/62.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 > > TestZoneInfo310.java test failure is addressed along with it. The last rule > affects "Asia/Gaza" and "Asia/Hebron" and therefore excluded from the test. > > Regression Tests pass along with JCK. > > Please let me know if the changes are good to push. > > Thanks, > Kiran This pull request has now been integrated. Changeset: b65ff60a Author:Kiran Sidhartha Ravikumar Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/b65ff60a Stats: 61 lines in 4 files changed: 38 ins; 2 del; 21 mod 8255226: (tz) Upgrade time-zone data to tzdata2020d Reviewed-by: naoto - PR: https://git.openjdk.java.net/jdk/pull/1012
Re: RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d [v3]
> Hi Guys, > > Please review the integration of tzdata2020d to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/62.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 > > TestZoneInfo310.java test failure is addressed along with it. The last rule > affects "Asia/Gaza" and "Asia/Hebron" and therefore excluded from the test. > > Regression Tests pass along with JCK. > > Please let me know if the changes are good to push. > > Thanks, > Kiran Kiran Sidhartha Ravikumar has updated the pull request incrementally with one additional commit since the last revision: 8255226: Fixing whitespaces - Changes: - all: https://git.openjdk.java.net/jdk/pull/1012/files - new: https://git.openjdk.java.net/jdk/pull/1012/files/8782181c..e4a565e2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1012=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1012=01-02 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/1012.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1012/head:pull/1012 PR: https://git.openjdk.java.net/jdk/pull/1012
Re: RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d [v2]
On Tue, 3 Nov 2020 00:21:16 GMT, Naoto Sato wrote: >> Thanks for getting back Naoto, I believe this is a long-standing issue - >> https://bugs.openjdk.java.net/browse/JDK-8227293. >> >> Looking back at the integration of tzdata2019a/tzdata2019b, the same issue >> was addressed by updating the source code - >> https://hg.openjdk.java.net/jdk/jdk/rev/79036e5e744b#l13.1. >> >> Here is some history to the issue - >> https://mail.openjdk.java.net/pipermail/i18n-dev/2019-July/002887.html >> >> Please let me know your thoughts > > Should we then remove the hack in the ZoneInfoFile.java that excludes > Gaza/Hebron instead? I had made changes to the ZoneInfoFile.java to avoid applying the logic present to Gaza/Hebron. Regression tests executed successfully. - PR: https://git.openjdk.java.net/jdk/pull/1012
Re: RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d [v2]
> Hi Guys, > > Please review the integration of tzdata2020d to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/62.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 > > TestZoneInfo310.java test failure is addressed along with it. The last rule > affects "Asia/Gaza" and "Asia/Hebron" and therefore excluded from the test. > > Regression Tests pass along with JCK. > > Please let me know if the changes are good to push. > > Thanks, > Kiran Kiran Sidhartha Ravikumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into JDK-8255226 - 8255226: Updating ZoneInfoFile.java logic to avoid certain zones - 8255226: (tz) Upgrade time-zone data to tzdata2020d - Changes: - all: https://git.openjdk.java.net/jdk/pull/1012/files - new: https://git.openjdk.java.net/jdk/pull/1012/files/e859af83..8782181c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1012=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1012=00-01 Stats: 2120 lines in 83 files changed: 1178 ins; 580 del; 362 mod Patch: https://git.openjdk.java.net/jdk/pull/1012.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1012/head:pull/1012 PR: https://git.openjdk.java.net/jdk/pull/1012
Re: RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d
On Mon, 2 Nov 2020 18:14:47 GMT, Naoto Sato wrote: >> It's probably these last rule what is causing the issue >> >> Rule Palestine 2020max - Mar Sat>=24 0:001:00 >> S >> Rule Palestine 2020max - Oct Sat>=24 1:000 >> - >> >> The failure seen is >> >> ** >> Asia/Gaza : Asia/Gaza >> - >> SimpleTimeZone (NG) >> >> stz=java.util.SimpleTimeZone[id=Asia/Gaza,offset=720,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=7,startTime=0,startTimeMode=0,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=7,endTime=360,endTimeMode=0] >> >> stz0=java.util.SimpleTimeZone[id=Asia/Gaza,offset=720,dstSavings=360,useDaylight=true,startYear=0,startMode=3,startMonth=2,startDay=24,startDayOfWeek=7,startTime=0,startTimeMode=0,endMode=3,endMonth=9,endDay=24,endDayOfWeek=7,endTime=360,endTimeMode=0] > > My question is why it is failing. Have you figured it? The existing > exceptions are either negative DST or last rule beyond 2037, which javazic > cannot handle. The changes introduced with 2020d does not meet either of > them. Unless we know why it is failing, we cannot be sure we can exclude it. Thanks for getting back Naoto, I believe this is a long-standing issue - https://bugs.openjdk.java.net/browse/JDK-8227293. Looking back at the integration of tzdata2019a/tzdata2019b, the same issue was addressed by updating the source code - https://hg.openjdk.java.net/jdk/jdk/rev/79036e5e744b#l13.1. Here is some history to the issue - https://mail.openjdk.java.net/pipermail/i18n-dev/2019-July/002887.html Please let me know your thoughts - PR: https://git.openjdk.java.net/jdk/pull/1012
Re: RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d
On Mon, 2 Nov 2020 17:10:34 GMT, Naoto Sato wrote:
>> Hi Guys,
>>
>> Please review the integration of tzdata2020d to JDK.
>>
>> Details regarding the change can be viewed at -
>> https://mm.icann.org/pipermail/tz-announce/2020-October/62.html
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8255226
>>
>> TestZoneInfo310.java test failure is addressed along with it. The last rule
>> affects "Asia/Gaza" and "Asia/Hebron" and therefore excluded from the test.
>>
>> Regression Tests pass along with JCK.
>>
>> Please let me know if the changes are good to push.
>>
>> Thanks,
>> Kiran
>
> test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 201:
>
>> 199: zid.equals("Iran") || // last rule mismatch
>> 200: zid.equals("Asia/Gaza") || // last rule mismatch
>> 201: zid.equals("Asia/Hebron")) { // last rule mismatch
>
> Can you explain why these zones are failing? The criteria for excluding
> failing tests here is that the zone has negative dst and last rules beyond
> 2037, and I don't think those newly excluded zones suffice those.
It's probably these last rule what is causing the issue
Rule Palestine 2020max - Mar Sat>=24 0:001:00S
Rule Palestine 2020max - Oct Sat>=24 1:000 -
The failure seen is
**
Asia/Gaza : Asia/Gaza
-
SimpleTimeZone (NG)
stz=java.util.SimpleTimeZone[id=Asia/Gaza,offset=720,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=7,startTime=0,startTimeMode=0,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=7,endTime=360,endTimeMode=0]
stz0=java.util.SimpleTimeZone[id=Asia/Gaza,offset=720,dstSavings=360,useDaylight=true,startYear=0,startMode=3,startMonth=2,startDay=24,startDayOfWeek=7,startTime=0,startTimeMode=0,endMode=3,endMonth=9,endDay=24,endDayOfWeek=7,endTime=360,endTimeMode=0]
-
PR: https://git.openjdk.java.net/jdk/pull/1012
RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d
Hi Guys, Please review the integration of tzdata2020d to JDK. Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-October/62.html Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 TestZoneInfo310.java test failure is addressed along with it. The last rule affects "Asia/Gaza" and "Asia/Hebron" and therefore excluded from the test. Regression Tests pass along with JCK. Please let me know if the changes are good to push. Thanks, Kiran - Commit messages: - 8255226: (tz) Upgrade time-zone data to tzdata2020d Changes: https://git.openjdk.java.net/jdk/pull/1012/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1012=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255226 Stats: 54 lines in 4 files changed: 34 ins; 2 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/1012.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1012/head:pull/1012 PR: https://git.openjdk.java.net/jdk/pull/1012
Integrated: 8254982: (tz) Upgrade time-zone data to tzdata2020c
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 > > Along with it, there is a test fix for > https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test > fails for the mentioned zones expecting "PST" but JDK has Zone names for > "MST" for JRE locale provider. Since the purpose of the test is to get any > GMT-08:00 time zone, I have excluded those zones from the test. > > Please let me know if the changes are good to push. > > Thanks, > Kiran This pull request has now been integrated. Changeset: 55a0cad8 Author:Kiran Sidhartha Ravikumar Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/55a0cad8 Stats: 33 lines in 4 files changed: 30 ins; 0 del; 3 mod 8254982: (tz) Upgrade time-zone data to tzdata2020c Reviewed-by: erikj, naoto - PR: https://git.openjdk.java.net/jdk/pull/747
Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]
> Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 > > Along with it, there is a test fix for > https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test > fails for the mentioned zones expecting "PST" but JDK has Zone names for > "MST" for JRE locale provider. Since the > purpose of the test is to get any GMT-08:00 time zone, I have excluded those > zones from the test. Please let me know > if the changes are good to push. > Thanks, > Kiran Kiran Sidhartha Ravikumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8254982: Adding comments for removal of zones in BasicDateTime.java - Merge remote-tracking branch 'origin/master' into JDK-8254982 - 8254982: (tz) Upgrade time-zone data to tzdata2020c - Changes: - all: https://git.openjdk.java.net/jdk/pull/747/files - new: https://git.openjdk.java.net/jdk/pull/747/files/7bd51537..7434663a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=747=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=747=00-01 Stats: 26902 lines in 293 files changed: 17268 ins; 8054 del; 1580 mod Patch: https://git.openjdk.java.net/jdk/pull/747.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/747/head:pull/747 PR: https://git.openjdk.java.net/jdk/pull/747
Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]
On Mon, 19 Oct 2020 19:38:57 GMT, Naoto Sato wrote:
>> Kiran Sidhartha Ravikumar has updated the pull request with a new target
>> base due to a merge or a rebase. The
>> incremental webrev excludes the unrelated changes brought in by the
>> merge/rebase. The pull request contains three
>> additional commits since the last revision:
>> - 8254982: Adding comments for removal of zones in BasicDateTime.java
>> - Merge remote-tracking branch 'origin/master' into JDK-8254982
>> - 8254982: (tz) Upgrade time-zone data to tzdata2020c
>
> test/jdk/java/util/Formatter/BasicDateTime.java line 1695:
>
>> 1693: list.remove("America/Dawson");
>> 1694: list.remove("America/WhiteHorse");
>> 1695: list.remove("Canada/Yukon");
>
> I'd explicitly mention why these time zones are removed from the test.
Thanks, Naoto, I have added the information.
-
PR: https://git.openjdk.java.net/jdk/pull/747
RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c
Hi Guys, Please review the integration of tzdata2020c to JDK. Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-October/60.html Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 Along with it, there is a test fix for https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test fails for the mentioned zones expecting "PST" but JDK has Zone names for "MST" for JRE locale provider. Since the purpose of the test is to get any GMT-08:00 time zone, I have excluded those zones from the test. Please let me know if the changes are good to push. Thanks, Kiran - Commit messages: - 8254982: (tz) Upgrade time-zone data to tzdata2020c Changes: https://git.openjdk.java.net/jdk/pull/747/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=747=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254982 Stats: 30 lines in 4 files changed: 27 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/747.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/747/head:pull/747 PR: https://git.openjdk.java.net/jdk/pull/747
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Tue, 13 Oct 2020 18:43:18 GMT, Andrew John Hughes wrote: >> Thanks for the review everyone, I have added a release note to the bug. I >> will integrate the changes > > Looks like we both reached the same patch for this one independently :) > systemv was removed from tzdata some time ago and wasn't even being read by > the JDK as far as I could see. Its contents > are duplicated in jdk11_backward anyway. Good to see both it and pacificnew > being removed. In the unlikely event the > removal of Pacific_New is problematic, it could be added to jdk11_backward as > well, but it seems very unlikely. Thanks for the comment, Andrew. I agree - PR: https://git.openjdk.java.net/jdk/pull/602
Integrated: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
On Mon, 12 Oct 2020 19:36:52 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the fix to remove jdk.internal.ref.SoftCleanable and > WeakCleanable classes as there is no visible usage > of them in JDK. Currently, only PhantomCleanable is used. > More information can be viewed at > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/067997.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251861 > > Thanks, > Kiran This pull request has now been integrated. Changeset: ba24f963 Author:Kiran Sidhartha Ravikumar Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/ba24f963 Stats: 635 lines in 4 files changed: 0 ins; 633 del; 2 mod 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable Reviewed-by: mchung, rriggs - PR: https://git.openjdk.java.net/jdk/pull/616
Re: RFR: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
On Tue, 13 Oct 2020 16:39:51 GMT, Roger Riggs wrote: >> Hi Guys, >> >> Please review the fix to remove jdk.internal.ref.SoftCleanable and >> WeakCleanable classes as there is no visible usage >> of them in JDK. Currently, only PhantomCleanable is used. >> More information can be viewed at >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/067997.html >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8251861 >> >> Thanks, >> Kiran > > Marked as reviewed by rriggs (Reviewer). Thanks guys - PR: https://git.openjdk.java.net/jdk/pull/616
